| kata-dev-irc-bot | <xu> Thanks @claire, this is the etherpad for the arch committee conference today: https://etherpad.openstack.org/p/katacontainers-2018-architecture-committee-mtgs | 00:40 |
|---|---|---|
| *** devimc has joined #kata-dev | 00:59 | |
| *** sameo has quit IRC | 01:12 | |
| *** liujiong has joined #kata-dev | 01:38 | |
| *** bergwolf has quit IRC | 01:41 | |
| *** bergwolf has joined #kata-dev | 01:41 | |
| *** devimc has quit IRC | 01:51 | |
| *** sjas has joined #kata-dev | 01:52 | |
| *** sjas_ has quit IRC | 01:55 | |
| kata-dev-irc-bot | <xu> The note for the meeting of this week has been updated in the etherpad. And participants could suggest agenda of next meeting on it as well. | 02:18 |
| *** aledbf_ has joined #kata-dev | 04:00 | |
| *** aledbf_ has quit IRC | 04:01 | |
| *** diga has joined #kata-dev | 04:11 | |
| *** coolsvap has joined #kata-dev | 04:15 | |
| *** diga has quit IRC | 06:05 | |
| *** jodh has joined #kata-dev | 07:29 | |
| *** jodh has quit IRC | 07:29 | |
| *** jodh has joined #kata-dev | 07:29 | |
| *** sameo has joined #kata-dev | 08:25 | |
| *** cdent has joined #kata-dev | 08:52 | |
| *** gwhaley has joined #kata-dev | 09:13 | |
| *** liujiong has quit IRC | 10:17 | |
| *** nshaikh has joined #kata-dev | 10:34 | |
| *** diga has joined #kata-dev | 10:36 | |
| kata-dev-irc-bot | <samuel.ortiz> @laijs Hey. Could you please have a look at https://github.com/kata-containers/shim/pull/26 ? | 11:02 |
| kata-dev-irc-bot | <samuel.ortiz> or @bergwolf ^ | 11:04 |
| *** diga has quit IRC | 11:37 | |
| kata-dev-irc-bot | <bergwolf> @samuel.ortiz the change looks good but codecov still complains. do we merge it nevertheless? | 11:50 |
| *** gwhaley has quit IRC | 12:05 | |
| kata-dev-irc-bot | <samuel.ortiz> @bergwolf I'd say so, yes. | 12:52 |
| *** gwhaley has joined #kata-dev | 13:07 | |
| *** dims has quit IRC | 13:22 | |
| *** dims has joined #kata-dev | 13:25 | |
| *** fuentess has joined #kata-dev | 13:25 | |
| *** devimc has joined #kata-dev | 13:41 | |
| *** ssathaye has quit IRC | 13:55 | |
| *** ssathaye has joined #kata-dev | 13:55 | |
| *** sboeuf has joined #kata-dev | 15:18 | |
| *** sameo has quit IRC | 15:50 | |
| *** coolsvap has quit IRC | 15:55 | |
| *** test123_ has joined #kata-dev | 16:35 | |
| *** test123_ has quit IRC | 16:35 | |
| *** jodh has quit IRC | 16:38 | |
| *** rcw has joined #kata-dev | 16:40 | |
| smcginnis | Anyone know why this is being rejected saying I need Signed-off-by when it is in the commit message? https://github.com/kata-containers/www.katacontainers.io/pull/42 | 16:57 |
| smcginnis | Known issue? | 16:57 |
| gwhaley | smcginnis: not an issue I know of - just to check (as it is hard to tell from the github GUI) - is the signoff in the message from the same id used to submit the commit - iirc, we may have seen pullapprove reject that before | 17:02 |
| gwhaley | I'd cc jodh, but I don't see him on at the moment | 17:02 |
| gwhaley | let me see if I can grab that PR locally to have a look... | 17:02 |
| smcginnis | gwhaley: Ah, bingo. I used my gmail in the commit, but this machines git config has my work email set. | 17:03 |
| gwhaley | yeah, smcginnis, I suspect that is the problem :-) | 17:04 |
| smcginnis | gwhaley: Rookie mistake. Thanks! | 17:04 |
| gwhaley | not really your problem - would have been nice if the pullapprove web page had tell you why it bounced it ;-) | 17:04 |
| smcginnis | Yeah... it could probably use a little more detail in there. ;) | 17:04 |
| gwhaley | if you feel motivated - go open them an Issue ;-) We have done that before on a couple of niggly things, and they sometimes do add feature requests... | 17:05 |
| smcginnis | Sure, I might be able to take a look at that a little later. | 17:06 |
| smcginnis | Do we have a trigger to rerun that check? I've updated the message with the right email, but doesn't look like that kicked off a recheck for the failing check. | 17:07 |
| *** nshaikh2 has joined #kata-dev | 17:10 | |
| gwhaley | smcginnis: you re-pushed from your local repo to github (git push -f origin <my branch>) - yes - normally a re-push causes it to re-evaluate | 17:11 |
| *** eernst has joined #kata-dev | 17:12 | |
| smcginnis | Yeah, still fails, so that must not have actually been the issue. Hmm.. | 17:12 |
| *** nshaikh has quit IRC | 17:15 | |
| eernst | smcginnis: the commits still have @gmail? | 17:15 |
| eernst | --amend needed? | 17:16 |
| smcginnis | eernst: No, I amended and the current one has my work huawei.com address. | 17:16 |
| eernst | squash needed then? | 17:16 |
| eernst | I see 3 commits on the PR | 17:16 |
| eernst | The a281c51 still has gmail | 17:16 |
| smcginnis | eernst: I may have messed something up there. I pushed the wrong one, amended the commit, then push -f the update. | 17:17 |
| eernst | AFAICT you need to squash/ rebase? | 17:17 |
| smcginnis | That looks different than how I would have expected it to look though. | 17:17 |
| eernst | me too :) | 17:18 |
| eernst | I think if you squash /fixup the two add ones, and get rid of the merge commit it shoudl be good. | 17:18 |
| eernst | *should* | 17:18 |
| smcginnis | Sheesh, that was way more difficult than it should have been. :) | 17:28 |
| eernst | the PR looks much better now. | 17:28 |
| eernst | i imagine the tooling should be happy with it, we'll see. | 17:28 |
| kata-dev-irc-bot | <eric.ernst> @xu -- what's the status for ipv6 support in runv? | 17:46 |
| *** sameo has joined #kata-dev | 18:08 | |
| *** cdent has quit IRC | 18:55 | |
| *** rcwoolley_ has joined #kata-dev | 19:15 | |
| *** rcw has quit IRC | 19:18 | |
| *** rwoolley__ has joined #kata-dev | 19:41 | |
| *** rcwoolley_ has quit IRC | 19:44 | |
| *** eernst has quit IRC | 20:17 | |
| *** Jeffrey4l has quit IRC | 20:25 | |
| *** Jeffrey4l has joined #kata-dev | 20:25 | |
| *** gwhaley has quit IRC | 20:33 | |
| *** devimc has quit IRC | 21:35 | |
| *** rwoolley__ has quit IRC | 22:03 | |
| *** sameo has quit IRC | 22:12 | |
| *** sameo has joined #kata-dev | 22:15 | |
| *** PagliaccisCloud has quit IRC | 22:55 | |
| *** PagliaccisCloud has joined #kata-dev | 22:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!