| *** zerocoolback has joined #kata-dev | 00:17 | |
| *** jgriffit1 is now known as jgriffith | 01:06 | |
| kata-dev-irc-bot | <laijs> hello @sebastien.boeuf | 01:18 |
|---|---|---|
| kata-dev-irc-bot | <sebastien.boeuf> hey @laijs, sorry I gotta go, but I'll ping you later when I'll be back | 01:21 |
| kata-dev-irc-bot | <laijs> It’s my fault | 01:21 |
| *** sjas_ has joined #kata-dev | 05:09 | |
| *** sjas has quit IRC | 05:11 | |
| kata-dev-irc-bot | <sebastien.boeuf> @laijs @bergwolf hey guys ! | 06:47 |
| kata-dev-irc-bot | <bergwolf> hi @sebastien.boeuf | 06:48 |
| kata-dev-irc-bot | <sebastien.boeuf> so about https://github.com/kata-containers/agent/pull/133 I am reading your comments | 06:48 |
| kata-dev-irc-bot | <sebastien.boeuf> and I am thinking we should maybe split Storage into 2 different structures Storage and Device | 06:49 |
| kata-dev-irc-bot | <sebastien.boeuf> I am just saying this because we are trying to make everything working with Storage but it does not really fit well for all cases we're trying to handle here | 06:49 |
| kata-dev-irc-bot | <sebastien.boeuf> WDYT ? | 06:49 |
| kata-dev-irc-bot | <bergwolf> I do agree! I even suggested to separate them even before Christmas ;) see: https://github.com/kata-containers/agent/issues/52#issuecomment-351451802 | 06:53 |
| kata-dev-irc-bot | <sebastien.boeuf> @bergwolf glad to see we think the same way, I had missed your comment | 06:55 |
| kata-dev-irc-bot | <sebastien.boeuf> I will comment on my PR to get some feedback from others, and I'll update accordingly | 06:56 |
| kata-dev-irc-bot | <bergwolf> cool | 06:56 |
| kata-dev-irc-bot | <sebastien.boeuf> @bergwolf you're globally okay with the PR, right ? It's the naming convention using Storage that you don't like, right ? | 06:56 |
| kata-dev-irc-bot | <bergwolf> yes, generally I'm OK with it. I hope we can rename `Mountpoint` to something else though because it can be more than mountpoint now. | 06:57 |
| kata-dev-irc-bot | <bergwolf> and the behaviour needs to be documented | 06:58 |
| kata-dev-irc-bot | <sebastien.boeuf> maybe a dumb question, but does `Mountpoint` need to be renamed if we have the Device structure ? | 06:59 |
| kata-dev-irc-bot | <bergwolf> no need to rename then since I assume if we have struct device, storage is not involved | 07:00 |
| kata-dev-irc-bot | <sebastien.boeuf> exactly, Storage would not be used in this case | 07:00 |
| kata-dev-irc-bot | <bergwolf> I think we can dedicate `Device` for passthrough, can `Stroage` is involved only when the device needs to be mounted by the agent | 07:00 |
| kata-dev-irc-bot | <sebastien.boeuf> yes that sounds good to me for now. We'll adjust later if we think we need to | 07:01 |
| kata-dev-irc-bot | <bergwolf> yup | 07:02 |
| kata-dev-irc-bot | <sebastien.boeuf> @bergwolf I am going to bed, but please check internally with @laijs if he's okay with that too. I want to make sure everybody's okay with this | 07:03 |
| kata-dev-irc-bot | <bergwolf> ok, I'll ask him to comment | 07:03 |
| kata-dev-irc-bot | <sebastien.boeuf> thx, ttyl ! | 07:06 |
| *** jodh has joined #kata-dev | 07:06 | |
| *** jodh has quit IRC | 07:06 | |
| *** jodh has joined #kata-dev | 07:06 | |
| kata-dev-irc-bot | <bergwolf> ttyl~ | 07:08 |
| *** gwhaley has joined #kata-dev | 09:00 | |
| *** cdent has joined #kata-dev | 09:04 | |
| kata-dev-irc-bot | <laijs> I’m ok with it. thanks | 09:34 |
| *** eocardon has quit IRC | 09:51 | |
| *** eocardon has joined #kata-dev | 09:55 | |
| *** coolsvap has joined #kata-dev | 09:56 | |
| *** zerocoolback has quit IRC | 10:21 | |
| *** zerocoolback has joined #kata-dev | 11:51 | |
| *** zerocoolback has quit IRC | 11:56 | |
| *** zerocoolback has joined #kata-dev | 11:57 | |
| *** gwhaley has quit IRC | 12:09 | |
| *** coolsvap has quit IRC | 12:15 | |
| *** cdent has quit IRC | 12:28 | |
| *** gwhaley has joined #kata-dev | 12:58 | |
| *** cdent has joined #kata-dev | 13:45 | |
| *** devimc has joined #kata-dev | 13:58 | |
| *** devimc has quit IRC | 14:04 | |
| *** devimc has joined #kata-dev | 14:11 | |
| *** cdent has quit IRC | 15:14 | |
| *** eernst has joined #kata-dev | 15:40 | |
| *** cdent has joined #kata-dev | 15:52 | |
| *** zerocoolback has quit IRC | 16:10 | |
| *** zerocoolback has joined #kata-dev | 16:11 | |
| *** zerocoolback has quit IRC | 16:16 | |
| *** cdent has quit IRC | 16:25 | |
| *** zerocoolback has joined #kata-dev | 16:31 | |
| *** zerocoolback has quit IRC | 16:33 | |
| *** zerocoolback has joined #kata-dev | 16:33 | |
| *** zerocoolback has quit IRC | 16:38 | |
| *** mcastelino has joined #kata-dev | 17:28 | |
| *** gwhaley has quit IRC | 17:31 | |
| *** jodh has quit IRC | 18:00 | |
| *** gwhaley has joined #kata-dev | 18:11 | |
| *** fuentess has quit IRC | 18:59 | |
| *** fuentess has joined #kata-dev | 18:59 | |
| *** rcw has joined #kata-dev | 19:26 | |
| *** gwhaley has quit IRC | 20:35 | |
| *** eernst has quit IRC | 20:47 | |
| *** eernst has joined #kata-dev | 21:17 | |
| *** rcw has quit IRC | 21:59 | |
| *** devimc has quit IRC | 22:04 | |
| *** eernst has quit IRC | 22:27 | |
| *** eernst has joined #kata-dev | 22:37 | |
| *** eernst has quit IRC | 23:02 | |
| *** eernst has joined #kata-dev | 23:02 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!