*** mestery has quit IRC | 00:39 | |
*** mestery has joined #kata-dev | 00:40 | |
*** dlw has joined #kata-dev | 02:34 | |
*** zerocoolback has joined #kata-dev | 04:05 | |
*** sjas_ has joined #kata-dev | 04:23 | |
*** sjas has quit IRC | 04:26 | |
*** jodh has joined #kata-dev | 06:58 | |
*** jodh has quit IRC | 06:58 | |
*** jodh has joined #kata-dev | 06:58 | |
*** dims has quit IRC | 07:57 | |
*** dims has joined #kata-dev | 07:57 | |
*** davidgiluk has joined #kata-dev | 08:02 | |
*** gwhaley has joined #kata-dev | 08:07 | |
*** sameo has joined #kata-dev | 08:13 | |
*** marcov has quit IRC | 08:23 | |
*** marcov has joined #kata-dev | 08:30 | |
*** marcov has quit IRC | 10:35 | |
*** marcov has joined #kata-dev | 10:35 | |
*** marcov has quit IRC | 10:38 | |
*** marcov has joined #kata-dev | 10:38 | |
*** dlw has quit IRC | 11:44 | |
*** sgordon has joined #kata-dev | 12:42 | |
*** devimc has joined #kata-dev | 12:47 | |
*** fuentess has joined #kata-dev | 13:16 | |
*** changcheng has quit IRC | 13:57 | |
*** changcheng has joined #kata-dev | 14:00 | |
*** dklyle has joined #kata-dev | 14:01 | |
*** sjas_ is now known as sjas | 14:11 | |
*** dklyle has quit IRC | 14:13 | |
*** liwwu88 has joined #kata-dev | 14:16 | |
*** liwwu88 has quit IRC | 14:40 | |
*** annabelleB_ has joined #kata-dev | 14:43 | |
*** annabelleB has joined #kata-dev | 14:52 | |
kata-irc-bot | <eric.ernst> Heads up I’ll be flying during arch committee today. | 15:00 |
---|---|---|
kata-irc-bot | <eric.ernst> Only update I have is that we should have a target date for 1.3 | 15:00 |
*** dklyle has joined #kata-dev | 15:26 | |
*** annabelleB has quit IRC | 16:05 | |
kata-irc-bot | <eric.ernst> @bergwolf what was the final re refactoring? My zoom dropped | 16:05 |
kata-irc-bot | <eric.ernst> Separate out refactoring (first) then rebase this pr? Sorry. | 16:06 |
*** sameo has quit IRC | 16:07 | |
kata-irc-bot | <raravena80> that was the initial prop, but we ran out of time, and continue the discussion here or the ML and into next week. | 16:09 |
*** zerocoolback has quit IRC | 16:10 | |
gwhaley | I think it was do refactor now, and then re-assess (next week) how it looks | 16:11 |
*** annabelleB has joined #kata-dev | 16:11 | |
kata-irc-bot | <sebastien.boeuf> that's my understanding too ^ | 16:13 |
*** zerocoolback has joined #kata-dev | 16:13 | |
kata-irc-bot | <xu> @eric.ernst we will take a look on the command line side and file the refactor issue firstly. let’s see how big the change set is. | 16:19 |
kata-irc-bot | <eric.ernst> Cool. | 16:20 |
*** zerocoolback has quit IRC | 16:21 | |
kata-irc-bot | <xu> for us, we don’t see big different from refactor first or merge v2shim first right now. but if there are too many debates on the refactor…. is this possible? | 16:21 |
*** zerocoolback has joined #kata-dev | 16:23 | |
*** zerocoolback has quit IRC | 16:25 | |
*** zerocool_ has joined #kata-dev | 16:25 | |
*** zerocoolback has joined #kata-dev | 16:26 | |
*** zerocool_ has quit IRC | 16:26 | |
kata-irc-bot | <sebastien.boeuf> @jonolson quick question, is there any way to make a clear separation of some structure definition for the agent grpc definition. I am asking because the use case I have in mind is to be able to import only a few structure definitions (Interface and Route), without pulling the whole grpc definition. This is needed from a new binary (netmon) and if I pull everything, the binary size jumps from 4Mib to 11Mib.... | 16:30 |
*** eernst has joined #kata-dev | 16:33 | |
kata-irc-bot | <jonolson> Sadly, no — protobuf imports are at the proto file level — which really _should_ be fine if you don’t use the other definitions, except Go isn’t smart enough to GC them (the C++ linker is, which is how we get away with this) — where this matters (e.g., mobile) the only option I know of is to make a new proto that covers the subset you’re interested in and construct it explicitly | 16:33 |
kata-irc-bot | <jonolson> There may be some public tools for carving up/subsetting an existing definition — I’m not sure on that front — it _is_ safe to do, though, assuming the author of the original proto obeys the rules of never changing field numbers or unsafely changing types | 16:34 |
kata-irc-bot | <jonolson> (in which case you can get away with parsing the “big” proto as the subset version and ignoring unknown fields) | 16:35 |
kata-irc-bot | <sebastien.boeuf> thanks for the answer @jonolson! Following question on that, don't you think a simpler solution might be to define those generic structures in their own go package and then, both `netmon` and `agent/protocols/grpc` would import them ? | 16:48 |
kata-irc-bot | <jonolson> If that’s an option, yes, definitely | 16:49 |
kata-irc-bot | <sebastien.boeuf> well, I could see how the runtime of Kata could define those structures, as they might be reused by the entire Kata environment, and not only by the agent grpc protocol | 16:50 |
*** eernst has quit IRC | 16:51 | |
*** annabelleB_ has quit IRC | 16:52 | |
kata-irc-bot | <james.o.hunt> Congratulations @eric.ernst, @jonolson and @zhangwei555!! :) | 16:55 |
kata-irc-bot | <james.o.hunt> Beers are on you it seems ;P | 16:55 |
*** dklyle has quit IRC | 16:55 | |
kata-irc-bot | <xu> congrat | 16:56 |
kata-irc-bot | <jonolson> Always happy to buy a round for anyone who treks all the way to Seattle :slightly_smiling_face: | 16:56 |
kata-irc-bot | <james.o.hunt> I'll have to settle for attempting to grow longer arms for now I'm afraid :slightly_smiling_face: | 16:58 |
*** dklyle has joined #kata-dev | 16:59 | |
kata-irc-bot | <xu> congrats to the winners, I have merged https://github.com/kata-containers/community/pull/61 | 17:01 |
kata-irc-bot | <xu> Thanks @anne, have a good day guys. I may go to bed now :,) | 17:02 |
kata-irc-bot | <jonolson> and I may finally head into the office :P | 17:02 |
kata-irc-bot | <eric.ernst> And I’ll continue sitting on tarmac :) | 17:03 |
kata-irc-bot | <eric.ernst> Thanks y’all! | 17:03 |
kata-irc-bot | <anne> congrats all! and thank you to @kata and @tallclair for getting the project kicked off for the first six months! | 17:04 |
kata-irc-bot | <james.o.hunt> @anne - I'm about to eod but note that we also need to update the list of members on https://github.com/kata-containers/community/blob/master/README.md#architecture-committee (yes, duplication! :) | 17:04 |
kata-irc-bot | <anne> @james.o.hunt yup--i'll freshen up tea and submit an update. We love duplication! ;) | 17:05 |
kata-irc-bot | Action: james.o.hunt screams silently! | 17:05 |
kata-irc-bot | <james.o.hunt> Thanks @anne! :) | 17:05 |
kata-irc-bot | <anne> I'll make sure to dedicate the commit message: "To James Hunt, and his love of duplication." | 17:06 |
gwhaley | now, if we can duplicate anne and james....... | 17:06 |
* gwhaley signs off - l8r | 17:06 | |
*** annabelleB has quit IRC | 17:06 | |
*** gwhaley has quit IRC | 17:06 | |
*** jodh has quit IRC | 17:09 | |
*** zerocoolback has quit IRC | 17:16 | |
*** annabelleB has joined #kata-dev | 17:18 | |
*** sameo has joined #kata-dev | 17:23 | |
*** eernst has joined #kata-dev | 17:43 | |
*** eernst has quit IRC | 17:56 | |
*** annabelleB has quit IRC | 17:56 | |
*** eernst has joined #kata-dev | 18:03 | |
*** annabelleB has joined #kata-dev | 18:04 | |
*** dklyle has quit IRC | 18:05 | |
*** dklyle has joined #kata-dev | 18:06 | |
*** eernst has quit IRC | 18:11 | |
*** dklyle has quit IRC | 18:13 | |
*** annabelleB has quit IRC | 18:15 | |
*** annabelleB has joined #kata-dev | 18:19 | |
*** annabelleB has quit IRC | 18:19 | |
*** eernst has joined #kata-dev | 18:34 | |
*** eernst has quit IRC | 18:45 | |
*** davidgiluk has quit IRC | 19:06 | |
*** annabelleB has joined #kata-dev | 19:37 | |
*** dklyle has joined #kata-dev | 19:38 | |
*** eernst has joined #kata-dev | 20:14 | |
*** marcov has quit IRC | 20:29 | |
*** annabelleB has quit IRC | 20:51 | |
*** dklyle has quit IRC | 20:52 | |
*** annabelleB has joined #kata-dev | 20:59 | |
*** eernst has quit IRC | 21:07 | |
*** eernst has joined #kata-dev | 21:09 | |
*** eernst has quit IRC | 21:34 | |
*** eernst has joined #kata-dev | 21:34 | |
*** devimc has quit IRC | 21:38 | |
*** eernst_ has joined #kata-dev | 21:39 | |
*** eernst has quit IRC | 21:39 | |
*** eernst_ has quit IRC | 21:54 | |
*** eernst has joined #kata-dev | 21:55 | |
*** dklyle has joined #kata-dev | 21:55 | |
*** eernst has quit IRC | 21:55 | |
*** eernst has joined #kata-dev | 21:56 | |
*** eernst has quit IRC | 22:05 | |
*** annabelleB has quit IRC | 22:16 | |
*** annabelleB has joined #kata-dev | 22:22 | |
*** dklyle has quit IRC | 22:37 | |
*** dklyle has joined #kata-dev | 22:54 | |
*** annabelleB has quit IRC | 22:55 | |
*** dklyle has quit IRC | 23:22 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!