| *** devimc has quit IRC | 00:39 | |
| *** kailun has joined #kata-dev | 01:46 | |
| kata-irc-bot | <zhangwei555> @archana.m.shinde Around? Can you take a look at https://github.com/kata-containers/runtime/pull/874#issuecomment-434549586 ? I need some help from you | 01:57 |
|---|---|---|
| *** eernst has joined #kata-dev | 03:01 | |
| *** eernst has quit IRC | 03:08 | |
| kata-irc-bot | <eric.ernst> hey @zhangwei555 | 03:32 |
| kata-irc-bot | <zhangwei555> @eric.ernst Hey :) | 03:32 |
| kata-irc-bot | <eric.ernst> i looked at it with archana briefly earlier. I don't think we need all those structs/fields for endpoints. | 03:32 |
| kata-irc-bot | <zhangwei555> I agree with you, but you know, it has so many fields related to many types of endpoints, so I'm not sure how many parts should I keep in new persist format | 03:33 |
| kata-irc-bot | <zhangwei555> That's why I need to ask for some help from you | 03:33 |
| kata-irc-bot | <eric.ernst> yeah, makes sense. We're looking at it. | 03:33 |
| kata-irc-bot | <eric.ernst> For now you're just copying what is in vc, right? | 03:34 |
| kata-irc-bot | <eric.ernst> if the container is already running much of it isn't necessary afaiu. | 03:34 |
| kata-irc-bot | <zhangwei555> Copy, reorganize and rename | 03:34 |
| kata-irc-bot | <zhangwei555> Also I see the `/var/lib/kata-containers/sbs/<sandbox>/config.json` has lots of duplicate fileds with `/var/run/vc/sbs/xxx/xxx` | 03:35 |
| kata-irc-bot | <eric.ernst> Yeah. i think we have a few things to do here. | 03:36 |
| kata-irc-bot | <eric.ernst> 1) minimal fields for #874 | 03:37 |
| kata-irc-bot | <eric.ernst> 2) merge that package. | 03:37 |
| kata-irc-bot | <eric.ernst> 3) rework vc to use those data structures for what we store to disk | 03:37 |
| kata-irc-bot | <zhangwei555> Yes, exactly | 03:37 |
| kata-irc-bot | <zhangwei555> I'm also writing some demo codes to show how 3) works like later | 03:38 |
| kata-irc-bot | <zhangwei555> > How do you see the project using the version field? I wonder if most of the presence/unexpected fields can be handled by marshalling of the json itself? Regarding your last question in comment: It's for some breaking change. e.g. v1: ``` BlockIndex int ``` Then we find that int isn't right , we actually need is a map, then v2: ``` BlockIndex int // legacy BlockIndexMap map[int]bool ``` And new handling code should be : ``` | 03:43 |
| kata-irc-bot | if v1 { // this container is created by old runtime, go to legacy handling logic // handle BlockIndex } else if v2 { // moder runtime, handling modern fields // handle BlockIndexMap } ``` | 03:43 |
| kata-irc-bot | <eric.ernst> got it. | 03:45 |
| kata-irc-bot | <eric.ernst> ah, i need to send email asking about when to schedule architecture committee going forward. | 03:45 |
| kata-irc-bot | <eric.ernst> you have input, wei? | 03:46 |
| kata-irc-bot | <zhangwei555> This pr could be my input :slightly_smiling_face: | 03:46 |
| kata-irc-bot | <zhangwei555> I guess next AC meeting would be canceled? Because most of you are in Berlin? | 03:47 |
| kata-irc-bot | <zhangwei555> Oh, I misread the conference time, it's not next week. | 03:50 |
| *** david-lyle has joined #kata-dev | 04:08 | |
| *** dklyle has quit IRC | 04:09 | |
| *** coolsvap has joined #kata-dev | 07:55 | |
| *** jodh has joined #kata-dev | 08:00 | |
| *** marcov has joined #kata-dev | 08:17 | |
| *** gwhaley has joined #kata-dev | 09:01 | |
| *** davidgiluk has joined #kata-dev | 09:04 | |
| *** lpetrut has joined #kata-dev | 11:32 | |
| *** gwhaley has quit IRC | 12:05 | |
| *** lpetrut has quit IRC | 12:13 | |
| *** gwhaley has joined #kata-dev | 13:22 | |
| *** lpetrut has joined #kata-dev | 13:42 | |
| *** lpetrut has quit IRC | 14:26 | |
| *** lpetrut has joined #kata-dev | 14:30 | |
| *** lpetrut has quit IRC | 14:37 | |
| *** coolsvap has quit IRC | 14:54 | |
| *** shrasool has joined #kata-dev | 15:58 | |
| *** jodh has quit IRC | 16:32 | |
| *** shrasool has quit IRC | 16:33 | |
| *** stackedsax has quit IRC | 16:49 | |
| *** shrasool has joined #kata-dev | 17:28 | |
| *** marcov has quit IRC | 18:05 | |
| *** gwhaley has quit IRC | 18:18 | |
| *** shrasool has quit IRC | 18:27 | |
| *** shrasool has joined #kata-dev | 18:42 | |
| *** shrasool has quit IRC | 19:27 | |
| *** shrasool has joined #kata-dev | 19:32 | |
| *** lpetrut has joined #kata-dev | 19:34 | |
| *** shrasool has quit IRC | 19:41 | |
| kata-irc-bot | Action: eric.ernst starts to open runtime issue to track adding support for k8s static config of cpu-manager | 20:11 |
| *** lpetrut has quit IRC | 20:35 | |
| *** davidgiluk has quit IRC | 20:51 | |
| *** shrasool has joined #kata-dev | 21:23 | |
| *** kailun has quit IRC | 21:34 | |
| *** shrasool has quit IRC | 22:24 | |
| *** shrasool has joined #kata-dev | 22:27 | |
| *** shrasool has quit IRC | 22:28 | |
| *** shrasool has joined #kata-dev | 23:19 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!