| kata-irc-bot | <archana.m.shinde> @xwlpt https://github.com/kata-containers/runtime/blob/master/virtcontainers/qemu.go#L661 | 00:21 |
|---|---|---|
| kata-irc-bot | <archana.m.shinde> qmp command is sent to do that | 00:21 |
| kata-irc-bot | <archana.m.shinde> @eric.ernst Take a look https://github.com/kata-containers/agent/pull/509 | 00:21 |
| kata-irc-bot | <archana.m.shinde> and https://github.com/kata-containers/agent/pull/510 | 00:22 |
| kata-irc-bot | <xwlpt> @archana.m.shinde Thanks, but I mean sandbox stop inside Delete() https://github.com/kata-containers/runtime/blob/master/virtcontainers/sandbox.go#L706 | 00:22 |
| kata-irc-bot | <archana.m.shinde> I have tested the changes as well, so you can merge them @eric.ernst | 00:22 |
| kata-irc-bot | <xwlpt> I didn’t see sandbox stop inside Delete() | 00:22 |
| kata-irc-bot | <eric.ernst> Thx Archana | 00:26 |
| kata-irc-bot | <xwlpt> I am running k8s test cases with kata runtime. I found that sometime, the qemu process still exists after pod delete. From the log, I can see vm start log, then it received a Delete request. (There is no VM stop log). | 00:27 |
| kata-irc-bot | <archana.m.shinde> @xwlpt whats your k8s setup like? are you using shimv2? | 00:36 |
| kata-irc-bot | <xwlpt> My test cluster with 1 master node and 2 minion node, I am using shimv2 | 00:37 |
| kata-irc-bot | <xwlpt> and kata 1.6 | 00:37 |
| kata-irc-bot | <archana.m.shinde> @fupan should be able to help you with that ^ | 00:39 |
| kata-irc-bot | <xwlpt> @archana.m.shinde thanks | 01:02 |
| *** igordc has quit IRC | 01:29 | |
| *** auk has joined #kata-dev | 02:58 | |
| *** auk has quit IRC | 03:04 | |
| *** eernst has joined #kata-dev | 03:45 | |
| *** igordc has joined #kata-dev | 04:18 | |
| *** eernst has quit IRC | 05:04 | |
| *** tmhoang has joined #kata-dev | 05:19 | |
| *** auk has joined #kata-dev | 05:46 | |
| *** sgarzare has joined #kata-dev | 06:37 | |
| *** sgarzare has quit IRC | 06:45 | |
| *** sgarzare has joined #kata-dev | 06:47 | |
| *** auk has quit IRC | 07:13 | |
| *** auk has joined #kata-dev | 07:14 | |
| *** auk has quit IRC | 07:19 | |
| *** auk has joined #kata-dev | 07:19 | |
| *** auk has quit IRC | 07:36 | |
| *** sameo has joined #kata-dev | 07:49 | |
| *** igordc has quit IRC | 08:04 | |
| *** davidgiluk has joined #kata-dev | 08:06 | |
| *** tmhoang_ has joined #kata-dev | 10:28 | |
| *** tmhoang_ has joined #kata-dev | 10:28 | |
| *** tmhoang__ has joined #kata-dev | 10:29 | |
| *** tmhoang has quit IRC | 10:29 | |
| *** tmhoang__ is now known as tmhoang | 10:30 | |
| *** tmhoang_ has quit IRC | 10:33 | |
| *** devimc has joined #kata-dev | 13:12 | |
| *** dklyle has quit IRC | 13:30 | |
| *** dklyle has joined #kata-dev | 13:31 | |
| *** fuentess has joined #kata-dev | 13:39 | |
| *** igordc has joined #kata-dev | 14:01 | |
| *** dklyle has quit IRC | 14:15 | |
| *** eernst has joined #kata-dev | 14:28 | |
| *** dklyle has joined #kata-dev | 14:41 | |
| kata-irc-bot | <eric.ernst> any travis lovers out there? Trying to figure out why its rejecting me for a file I didn't modify (SPDX license for a Makefile) | 14:59 |
| kata-irc-bot | <eric.ernst> see https://github.com/kata-containers/agent/pull/513, https://travis-ci.org/kata-containers/runtime/jobs/515237940 | 14:59 |
| kata-irc-bot | <eric.ernst> @salvador.fuentes - I'm wondering -- is there a branch specific work around for license header checks? | 15:01 |
| kata-irc-bot | <eric.ernst> I only see this on the stable branches (again, for a file which isn't being touched?) | 15:02 |
| *** devimc has quit IRC | 15:10 | |
| *** devimc has joined #kata-dev | 15:10 | |
| *** eernst has quit IRC | 15:28 | |
| *** tmhoang_ has joined #kata-dev | 15:53 | |
| *** tmhoang has quit IRC | 15:55 | |
| *** tmhoang__ has joined #kata-dev | 15:55 | |
| *** tmhoang__ is now known as tmhoang | 15:57 | |
| *** tmhoang_ has quit IRC | 15:59 | |
| *** sgarzare has quit IRC | 16:24 | |
| kata-irc-bot | <gmmaharaj> @eric.ernst what is the error youare getting? seems like travis and the CI has passed. | 16:47 |
| kata-irc-bot | <gmmaharaj> nvm.. foiund what you are seeing. | 17:00 |
| kata-irc-bot | <xwlpt> @fupan Thanks for this. But it is reasonable to do Delete() without Stop() | 17:07 |
| *** igordc has quit IRC | 18:14 | |
| *** igordc has joined #kata-dev | 18:50 | |
| *** davidgiluk has quit IRC | 19:06 | |
| *** sameo has quit IRC | 19:43 | |
| *** tmhoang has quit IRC | 19:52 | |
| *** igordc has quit IRC | 20:18 | |
| kata-irc-bot | <raravena80> @eric.ernst looks like the header `SPDX-License-Identifier: Apache-2.0` is not in the `stable-1.5` branch, I believe the branch you are trying to merge to (and you branched off from). I suppose you need to add to file in your PR(?) | 20:45 |
| *** igordc has joined #kata-dev | 20:59 | |
| kata-irc-bot | <xwlpt> @fupan I see the stop behavior before Cleanup, thanks | 21:11 |
| *** devimc has quit IRC | 22:05 | |
| *** fuentess has quit IRC | 22:41 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!