Wednesday, 2019-07-10

« Tuesday, 2019-07-09 Index Thursday, 2019-07-11 »
*** altlogbot_1 has joined #kata-dev00:28
*** altlogbot_1 has quit IRC00:37
*** altlogbot_3 has joined #kata-dev01:06
*** khyr0n has quit IRC01:09
*** khyr0n has joined #kata-dev01:11
*** altlogbot_3 has quit IRC01:15
*** khyr0n has quit IRC01:22
*** altlogbot_0 has joined #kata-dev02:18
*** irclogbot_3 has joined #kata-dev02:18
*** altlogbot_0 has quit IRC02:25
*** irclogbot_3 has quit IRC02:26
*** jugs has quit IRC02:48
*** jugs has joined #kata-dev02:49
*** khyr0n has joined #kata-dev03:13
*** dklyle has quit IRC03:19
*** irclogbot_0 has joined #kata-dev04:06
*** irclogbot_0 has quit IRC04:12
*** altlogbot_2 has joined #kata-dev04:12
*** altlogbot_2 has quit IRC04:17
*** altlogbot_1 has joined #kata-dev05:02
*** irclogbot_0 has joined #kata-dev05:06
*** altlogbot_1 has quit IRC05:21
*** irclogbot_0 has quit IRC05:22
*** sameo has joined #kata-dev05:33
*** pcaruana has joined #kata-dev05:37
*** khyr0n has quit IRC05:46
*** tmhoang has quit IRC06:19
*** pcaruana has quit IRC06:20
*** sameo has quit IRC06:42
*** altlogbot_1 has joined #kata-dev07:02
*** jodh has joined #kata-dev07:03
*** altlogbot_1 has quit IRC07:08
*** sgarzare has joined #kata-dev07:28
*** irclogbot_3 has joined #kata-dev07:38
*** irclogbot_3 has quit IRC07:44
*** sameo has joined #kata-dev07:53
*** pcaruana has joined #kata-dev07:54
*** gwhaley has joined #kata-dev08:02
*** davidgiluk has joined #kata-dev08:03
*** irclogbot_2 has joined #kata-dev08:56
*** irclogbot_2 has quit IRC09:01
kata-irc-bot<gmmaharaj> @james.o.hunt for https://github.com/kata-containers/tests/pull/1795, all i am doing is making sure our vendored code matches what we changed in our Gopkg.* files.09:06
kata-irc-bot<gmmaharaj> which ever person touching Gopkg.* should do, but wasn't enforced.09:06
kata-irc-bot<gmmaharaj> does `dep ensure` automatically move the tree of each of our vendored code to the latest?09:06
*** altlogbot_3 has joined #kata-dev09:10
kata-irc-bot<gmmaharaj> and is there a reason we have these many nested Gopkg.* files09:10
kata-irc-bot<gmmaharaj> ?09:10
kata-irc-bot<graham.whaley> I suspect nested gopkg files are in the cmd folder? each of those is a separate golang program, so has their own vendoring...09:12
kata-irc-bot<gmmaharaj> ``` ganeshma@ganeshma-lab3 <> tests % find . -name "Gopkg.*" ./kata-webhook/Gopkg.lock ./kata-webhook/Gopkg.toml ./kata-webhook/vendor/github.com/json-iterator/go/Gopkg.lock ./kata-webhook/vendor/github.com/json-iterator/go/Gopkg.toml ./kata-webhook/vendor/github.com/modern-go/reflect2/Gopkg.lock ./kata-webhook/vendor/github.com/modern-go/reflect2/Gopkg.toml ./Gopkg.lock ./Gopkg.toml ./cmd/checkmetrics/Gopkg.lock09:12
kata-irc-bot./cmd/checkmetrics/Gopkg.toml ./cmd/checkcommits/Gopkg.lock ./cmd/checkcommits/Gopkg.toml ./cmd/checkcommits/vendor/github.com/stretchr/testify/Gopkg.lock ./cmd/checkcommits/vendor/github.com/stretchr/testify/Gopkg.toml ./cmd/log-parser/Gopkg.lock ./cmd/log-parser/Gopkg.toml ./cmd/check-markdown/Gopkg.lock ./cmd/check-markdown/Gopkg.toml ```09:12
kata-irc-bot<gmmaharaj> more than just one. :(09:12
kata-irc-bot<graham.whaley> yes - each sub folder under cmd is a separate self contained program, so needs its own vendoring...09:13
kata-irc-bot<gmmaharaj> running dep ensure on the top level is bound to cause such havoc i guess.. cause it now thinks it controls all the code lying underneath.09:13
kata-irc-bot<graham.whaley> that, I'm not sure about - I thought it would just control the vendor subdir... from the top level dir09:14
*** altlogbot_3 has quit IRC09:14
kata-irc-bot<gmmaharaj> @graham.whaley can we not compile each of the subfolder as their own programs using top level vendoring?09:14
kata-irc-bot<graham.whaley> or more accurately, the vendor subdir of the gopkg files you run it on iyswim.09:14
kata-irc-bot<graham.whaley> gmmaha - I would say nope - each subprogram will want its own (sub)set of vendored packages.09:15
kata-irc-bot<graham.whaley> I'm no expert here though -best wait for input from @james.o.hunt and maybe others...09:15
kata-irc-bot<gmmaharaj> if they have to be such, then we need to ignore the top level Gopkg.* files and somehow run `dep check && dep ensure` on each of the folders with a Gopkg file09:16
kata-irc-bot<gmmaharaj> my change does not help and i think i need to drop this one as well.. https://github.com/kata-containers/runtime/pull/1868/commits/9a346d6817d2d5ab5bdffa790feb2756d9f7f53709:17
kata-irc-bot<gmmaharaj> i think it's best i drop that commit for now until we figure out how we are doing vendoring for all our repos.09:17
kata-irc-bot<gmmaharaj> WDYT @graham.whaley?09:18
kata-irc-bot<graham.whaley> I think .... you need input from folks who understand dep and our use and nesting of cmds more ;) heh09:19
kata-irc-bot<graham.whaley> I guess there are two questions:09:19
kata-irc-bot<gmmaharaj> that is 100% true. while i wait for that, i shold not tag that along with the other issue that i am trying to solve.09:19
kata-irc-bot<gmmaharaj> let me drop that commit for now.09:19
kata-irc-bot<graham.whaley> 1) should we CI dep check all the gopkg files, if they change.... yes, I think we should...09:19
kata-irc-bot<graham.whaley> 2) does a dep check at the top level mistakenly include all the sub vendor and gopkg files in the cmd subdirs? I dunno - it should not imo - so, let us know on that one09:20
kata-irc-bot<gmmaharaj> yes to 1) for sure.09:20
kata-irc-bot<gmmaharaj> yeah, not too clear about 2). will wait to get more info and hunt more before i do a top level re-vendoring of code.09:21
*** altlogbot_0 has joined #kata-dev09:24
*** altlogbot_0 has quit IRC09:28
*** altlogbot_1 has joined #kata-dev09:28
*** altlogbot_1 has quit IRC09:34
kata-irc-bot<james.o.hunt> @gmmaharaj - the "sub-vendoring" for files below `cmd/` was required afaik since `dep` won't allow you to re-use the top-level vendoring (or atleast it didn't when we added the sub-vendoring).09:35
kata-irc-bot<james.o.hunt> I'm tempted to say, let's wait until we can switch to `go mod`. We can then jettison all this horrid `dep` cruft.09:36
*** irclogbot_3 has joined #kata-dev09:36
kata-irc-bot<gmmaharaj> i won't mind that at all..09:36
kata-irc-bot<gmmaharaj> well, whichever is easy.09:36
kata-irc-bot<gmmaharaj> seems like go mod is probably the way to go. but not sure how much effort that is.. and that seems to be true even for the current scenario where we are not doing dep ensure on all packages.09:37
kata-irc-bot<james.o.hunt> I think we're waiting for go1.13 before we can switch and that looks close: https://github.com/golang/go/milestone/8309:37
kata-irc-bot<gmmaharaj> you mean go 1.13 being the minimum version we will support?09:38
*** irclogbot_3 has quit IRC09:40
*** altlogbot_2 has joined #kata-dev09:44
kata-irc-bot<james.o.hunt> I guess that would (have to be) true yes: https://github.com/kata-containers/kata-containers/issues/42. Since we prolly don't want to mandate that even when 1.13 is out, I guess we'll have to determine how much work it's going to be to fix the `dep` mess. A good topic for the AC meeting maybe?09:45
kata-irc-bot<gmmaharaj> yes sir.09:46
kata-irc-bot<gmmaharaj> next week's meeting.09:46
kata-irc-bot<gmmaharaj> let me add that to the list right now.09:46
kata-irc-botAction: gmmaharaj wonders where the agenda place is.09:46
*** tmhoang has joined #kata-dev09:47
gwhaley@gmmaharaj: https://etherpad.openstack.org/p/katacontainers-2019-architecture-committee-mtgs09:48
kata-irc-bot<gmmaharaj> l just realized that i will be in air for the next AC meeting.09:50
*** altlogbot_2 has quit IRC09:50
kata-irc-bot<graham.whaley> heh, excuses....09:50
kata-irc-bot<gmmaharaj> haha09:50
kata-irc-bot<gmmaharaj> i can try to dial into the call 20,000ft above the north pole. connection might be a bit choppy..09:50
kata-irc-bot<gmmaharaj> alright, i am going offline for a bit.. will be back online later.10:13
kata-irc-bot<gmmaharaj> have a good rest of the day and enjoy wimbledon.10:13
*** irclogbot_1 has joined #kata-dev10:22
*** irclogbot_1 has quit IRC10:26
*** gwhaley has quit IRC11:29
*** gwhaley has joined #kata-dev12:47
*** devimc has joined #kata-dev12:50
*** irclogbot_3 has joined #kata-dev13:04
*** irclogbot_3 has quit IRC13:08
*** altlogbot_3 has joined #kata-dev13:10
*** altlogbot_3 has quit IRC13:16
*** irclogbot_0 has joined #kata-dev13:16
*** irclogbot_0 has quit IRC13:22
*** altlogbot_3 has joined #kata-dev13:34
*** altlogbot_3 has quit IRC13:36
*** devimc has quit IRC13:51
*** devimc has joined #kata-dev13:51
*** dklyle has joined #kata-dev14:04
*** sameo has quit IRC14:27
*** dklyle has quit IRC14:30
*** altlogbot_1 has joined #kata-dev14:38
*** dklyle has joined #kata-dev14:38
*** altlogbot_1 has quit IRC14:42
*** altlogbot_0 has joined #kata-dev14:50
*** altlogbot_0 has quit IRC14:56
*** altlogbot_3 has joined #kata-dev15:06
*** dklyle has quit IRC15:09
*** altlogbot_3 has quit IRC15:12
*** irclogbot_0 has joined #kata-dev15:18
*** irclogbot_0 has quit IRC15:22
*** altlogbot_3 has joined #kata-dev15:30
*** altlogbot_3 has quit IRC15:34
*** irclogbot_3 has joined #kata-dev15:38
*** irclogbot_3 has quit IRC15:42
*** altlogbot_2 has joined #kata-dev15:44
*** altlogbot_2 has quit IRC15:48
*** altlogbot_0 has joined #kata-dev15:54
*** altlogbot_0 has quit IRC15:58
*** sgarzare has quit IRC16:04
*** sameo has joined #kata-dev16:24
*** altlogbot_1 has joined #kata-dev16:34
*** altlogbot_1 has quit IRC16:36
*** altlogbot_1 has joined #kata-dev16:48
*** altlogbot_1 has quit IRC16:54
*** gwhaley has quit IRC16:59
*** jodh has quit IRC17:17
*** irclogbot_0 has joined #kata-dev18:04
*** irclogbot_0 has quit IRC18:08
*** sameo has quit IRC18:26
*** tmhoang has quit IRC18:39
*** altlogbot_0 has joined #kata-dev19:00
*** altlogbot_0 has quit IRC19:04
*** davidgiluk has quit IRC19:12
*** irclogbot_1 has joined #kata-dev19:19
*** irclogbot_1 has quit IRC19:22
*** altlogbot_3 has joined #kata-dev20:27
*** altlogbot_3 has quit IRC20:32
*** pcaruana has quit IRC20:48
*** dklyle has joined #kata-dev20:55
*** altlogbot_3 has joined #kata-dev21:03
*** altlogbot_3 has quit IRC21:08
*** altlogbot_2 has joined #kata-dev21:17
*** altlogbot_2 has quit IRC21:22
*** dklyle has quit IRC21:29
*** devimc has quit IRC21:41
*** tmhoang has joined #kata-dev21:44
*** irclogbot_3 has joined #kata-dev21:47
*** irclogbot_3 has quit IRC21:52
*** altlogbot_0 has joined #kata-dev23:03
*** tmhoang has quit IRC23:05
*** altlogbot_0 has quit IRC23:08
*** altlogbot_0 has joined #kata-dev23:13
*** altlogbot_0 has quit IRC23:18
*** altlogbot_1 has joined #kata-dev23:19
*** altlogbot_1 has quit IRC23:24
*** altlogbot_1 has joined #kata-dev23:25
*** altlogbot_1 has quit IRC23:30
« Tuesday, 2019-07-09 Index Thursday, 2019-07-11 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!