| *** fuentess has quit IRC | 00:05 | |
| *** igordc has quit IRC | 01:13 | |
| *** auk has joined #kata-dev | 02:16 | |
| *** pcaruana has joined #kata-dev | 06:32 | |
| *** auk has quit IRC | 06:50 | |
| *** pohly has joined #kata-dev | 06:52 | |
| *** sgarzare has joined #kata-dev | 08:09 | |
| *** jodh has joined #kata-dev | 08:15 | |
| *** sameo has joined #kata-dev | 08:15 | |
| *** sgarzare has quit IRC | 08:22 | |
| *** sgarzare has joined #kata-dev | 08:32 | |
| *** davidgiluk has joined #kata-dev | 08:56 | |
| *** gwhaley has joined #kata-dev | 09:03 | |
| *** sgarzare has quit IRC | 10:02 | |
| *** sgarzare has joined #kata-dev | 10:04 | |
| *** sameo has quit IRC | 10:42 | |
| *** sameo has joined #kata-dev | 10:42 | |
| *** lpetrut has joined #kata-dev | 10:52 | |
| *** gwhaley has quit IRC | 12:02 | |
| *** gwhaley has joined #kata-dev | 13:10 | |
| *** devimc has joined #kata-dev | 13:13 | |
| *** fuentess has joined #kata-dev | 13:19 | |
| *** jodh has quit IRC | 14:38 | |
| *** jodh_ has joined #kata-dev | 14:39 | |
| *** canyounot has joined #kata-dev | 14:45 | |
| *** jodh_ has quit IRC | 15:02 | |
| *** jodh has joined #kata-dev | 15:03 | |
| kata-irc-bot3 | <jose.carlos.venegas.m> @johan.kuijpers mornoon | 15:53 |
|---|---|---|
| kata-irc-bot3 | <jose.carlos.venegas.m> a heads up, we are sending today a PR to move the HTTP client - the PR removes a few things just in case you want to hold a bit on unit test as some functions will be gone | 15:55 |
| *** jodh has quit IRC | 16:04 | |
| *** sgarzare has quit IRC | 16:35 | |
| *** sameo has quit IRC | 16:51 | |
| kata-irc-bot3 | <eric.ernst> I’m excited to sit down and review the PR! | 17:19 |
| *** igordc has joined #kata-dev | 17:20 | |
| *** sameo has joined #kata-dev | 17:54 | |
| *** sameo has quit IRC | 18:28 | |
| *** lpetrut has quit IRC | 19:08 | |
| *** davidgiluk has quit IRC | 20:16 | |
| *** gwhaley has quit IRC | 20:34 | |
| *** igordc has quit IRC | 21:33 | |
| *** canyounot has quit IRC | 21:39 | |
| *** igordc has joined #kata-dev | 21:39 | |
| *** pohly has quit IRC | 21:58 | |
| *** devimc has quit IRC | 22:05 | |
| *** pcaruana has quit IRC | 22:16 | |
| kata-irc-bot3 | <jose.carlos.venegas.m> @eric.ernst thaks for to the first review - let me go for some tea an will fix answer questions | 22:26 |
| kata-irc-bot3 | <eric.ernst> yw. | 22:35 |
| kata-irc-bot3 | <eric.ernst> Did ya'll test w/ volumes yet? | 22:35 |
| kata-irc-bot3 | <eric.ernst> In FC we ran into issues where devices were defined/added before we had the VMM up (ie, after createSandbox, before startSandbox) | 22:36 |
| kata-irc-bot3 | <jose.carlos.venegas.m> you mean hotplug a disk ? | 22:46 |
| kata-irc-bot3 | <jose.carlos.venegas.m> it is not supported, but it is using virtiofsd so not a problem | 22:47 |
| kata-irc-bot3 | <eric.ernst> Well | 22:52 |
| kata-irc-bot3 | <eric.ernst> In Firecacker, we would start the VMM first | 22:52 |
| kata-irc-bot3 | <eric.ernst> and then we'd start adding devices to it. | 22:52 |
| kata-irc-bot3 | <eric.ernst> including kernel, rootfs, volumes, etc. | 22:52 |
| kata-irc-bot3 | <jose.carlos.venegas.m> oh I see | 22:52 |
| kata-irc-bot3 | <eric.ernst> This isn't relaly the case, it seems, in CLH. | 22:52 |
| kata-irc-bot3 | <eric.ernst> I need to look @ API closer. | 22:52 |
| kata-irc-bot3 | <jose.carlos.venegas.m> we could start the VM still at createSandbox | 22:53 |
| kata-irc-bot3 | <eric.ernst> I see this vmconfig struct which is updated. | 22:53 |
| kata-irc-bot3 | <jose.carlos.venegas.m> I am not sure if is going to save time , we need tracing to see what could be reorganized agaree | 22:53 |
| kata-irc-bot3 | <eric.ernst> Nah, I think we start the VMM an dthen the VM in startsandobx, even for FRC. | 22:54 |
| kata-irc-bot3 | <eric.ernst> for FC* | 22:54 |
| kata-irc-bot3 | <jose.carlos.venegas.m> the trick I remember that is used for FC is about volumes the VM for cases like K8s but in this case with the virtiofs is not needed that trick | 22:55 |
| kata-irc-bot3 | <eric.ernst> CLH API is differnet, but maybe nice. | 22:56 |
| kata-irc-bot3 | <eric.ernst> In FC, you configure each piece of VM one at a time. | 22:56 |
| kata-irc-bot3 | <eric.ernst> ie, rootfs | 22:56 |
| kata-irc-bot3 | <eric.ernst> kernel, etc. | 22:56 |
| kata-irc-bot3 | <eric.ernst> In CLH, we create a VMConfig | 22:57 |
| kata-irc-bot3 | <eric.ernst> and use that call CreateVM | 22:57 |
| kata-irc-bot3 | <eric.ernst> and then do start VM | 22:57 |
| kata-irc-bot3 | <eric.ernst> this is reasonable, I guess. | 22:57 |
| kata-irc-bot3 | <eric.ernst> anyway, this looks pretty good -- i will hold off on more comments for now. Nice work and thanks. | 23:06 |
| kata-irc-bot3 | <jose.carlos.venegas.m> Thanks - I am fixing the comments you left - trying to get the CI working | 23:07 |
| *** eernst has joined #kata-dev | 23:44 | |
| *** eernst has quit IRC | 23:48 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!