| *** igordc has joined #kata-dev | 02:46 | |
| *** igordc has quit IRC | 02:52 | |
| *** igordc has joined #kata-dev | 02:52 | |
| *** igordc has quit IRC | 02:57 | |
| *** sameo has joined #kata-dev | 05:25 | |
| *** dklyle has quit IRC | 06:26 | |
| *** jodh has joined #kata-dev | 06:59 | |
| *** sgarzare has joined #kata-dev | 07:26 | |
| *** amorenoz has quit IRC | 07:52 | |
| *** amorenoz has joined #kata-dev | 08:49 | |
| *** hashar has joined #kata-dev | 11:43 | |
| *** devimc has joined #kata-dev | 11:52 | |
| kata-irc-bot | <fidencio> @salvador.fuentes, as we still don't have the PR tagging the release, I'd like to have https://github.com/kata-containers/runtime/pull/2624 merged before we tag. | 12:02 |
|---|---|---|
| kata-irc-bot | <fidencio> most likely I'll be able to have it merged in one CI run, but just to le you know | 12:02 |
| kata-irc-bot | <salvador.fuentes> @fidencio ok, sure | 12:45 |
| fidencio | devimc: may I just push abologna's PR? | 13:01 |
| fidencio | devimc: and buenos dias! :-) | 13:01 |
| devimc | fidencio: Hey, buenas tardes! | 13:03 |
| devimc | fidencio: go for it, let's merge it | 13:03 |
| fidencio | devimc: done, thanks! | 13:04 |
| fidencio | @salvador.fuentes, PR is in, so nothing else from my side blocking you! | 13:04 |
| kata-irc-bot | <salvador.fuentes> thanks fidencio, just waiting CI from 1.9 backport on runtime and then we can proceed with the release | 13:06 |
| fidencio | devimc: do you wanna have the vfio changes merged for the -rc0? | 13:24 |
| fidencio | devimc: maybe that's worth it ... | 13:24 |
| devimc | fidencio: yes | 13:27 |
| devimc | but I need review :( | 13:27 |
| fidencio | devimc: I can review, you won't get a test, tho :-/ | 13:27 |
| devimc | fidencio: https://github.com/kata-containers/runtime/issues/2605#issuecomment-613120645 | 13:28 |
| devimc | he tested it, so I think it's fine | 13:28 |
| devimc | xD | 13:28 |
| devimc | fidencio: btw ignore jenkins-ubuntu-16-04-vfio | 13:30 |
| devimc | I have renamed it to jenkins-ubuntu-18-04-vfio | 13:30 |
| fidencio | devimc: btw, we faced an issue that if you can give me a pointer to the code, that would be good ... seems that if specifying "cpus: n", on a pod definition, this is not reflecting on how many vcpus are actually being allocated | 13:45 |
| fidencio | devimc: I'll open a bug for that, but I also would like to test this myself and with shimv2 (this was tested using shimv1) | 13:46 |
| devimc | fidencio: run --cpus N ? | 13:46 |
| devimc | ohhh wait "pod definition" ? | 13:47 |
| *** crobinso has joined #kata-dev | 13:47 | |
| devimc | I don't follow, what's that? podman specific? | 13:47 |
| fidencio | devimc: seems to be k8s specific actually | 13:48 |
| devimc | :S | 13:49 |
| devimc | fidencio: so, the actual number of vcpus is not honored? | 13:50 |
| devimc | `nproc` shows always 1 | 13:50 |
| devimc | maybe not a bug? https://github.com/kata-containers/documentation/blob/master/design/vcpu-handling.md | 13:51 |
| fidencio | devimc: so, having something like https://paste.centos.org/view/64a337a0 seems always to show as 1 | 13:52 |
| devimc | okay, that could be a bug | 13:53 |
| *** dklyle has joined #kata-dev | 13:55 | |
| fidencio | In any case, do you have a pointer of where to look for such things? Again, I'll report it as soon as I have a cluster where I can do some tests (which is not that easy) | 13:55 |
| devimc | fidencio: https://github.com/kata-containers/runtime/blob/master/virtcontainers/sandbox.go#L1785 | 13:57 |
| devimc | fidencio: https://github.com/kata-containers/runtime/blob/master/virtcontainers/container.go#L1231 | 13:59 |
| devimc | fidencio: quota and period are converted to vcpus | 13:59 |
| fidencio | devimc: cool, that gives me enough info to start digging into it, thanks! | 14:00 |
| devimc | fidencio: yw | 14:00 |
| fidencio | devimc: btw, there's still a "it's -> is" conversion to be done in the commit message. Anyways, I've approved the PR | 14:01 |
| fidencio | devimc: can you sync with @salvador.fuentes in order to also have it in for Today's release? | 14:01 |
| devimc | fidencio: sure thing | 14:04 |
| devimc | let me fix it | 14:04 |
| fidencio | cool, thanks! | 14:04 |
| devimc | fidencio: jfyi I couldn't reproduce it | 14:31 |
| devimc | k8s 1.16.3 | 14:31 |
| devimc | fidencio: I don't have 5 vcpus - so this is my yaml https://paste.centos.org/view/39074808 | 14:34 |
| fidencio | and it just worked without any issue | 14:35 |
| fidencio | cool, good to know. I'll dig into this later Today / next week | 14:35 |
| *** devimc has quit IRC | 15:24 | |
| *** devimc has joined #kata-dev | 15:25 | |
| devimc | fidencio: https://github.com/kata-containers/runtime/pull/2606 won't land in this release, cri CI is not happy ;-( | 16:31 |
| kata-irc-bot | <fidencio> Okay, we can have this as part of the official release | 16:31 |
| *** sgarzare has quit IRC | 16:37 | |
| devimc | fidencio: I hope so, I will debug it :) | 16:39 |
| *** igordc has joined #kata-dev | 17:04 | |
| *** jodh has quit IRC | 17:04 | |
| *** igordc has quit IRC | 17:09 | |
| *** hashar has quit IRC | 17:18 | |
| *** sameo has quit IRC | 21:14 | |
| *** hashar has joined #kata-dev | 21:20 | |
| *** devimc has quit IRC | 21:23 | |
| *** hashar has quit IRC | 21:46 | |
| *** crobinso has quit IRC | 22:04 | |
| *** igordc has joined #kata-dev | 23:08 | |
| *** igordc has quit IRC | 23:27 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!