kata-irc-bot | <bergwolf> musl shouldn’t be any issue for fedora/rh. we are building inside docker containers and do not rely on any host distro libraries. | 01:50 |
---|---|---|
*** openstack has joined #kata-dev | 04:20 | |
*** ChanServ sets mode: +o openstack | 04:20 | |
*** jodh has joined #kata-dev | 06:34 | |
*** sameo_ has joined #kata-dev | 06:41 | |
*** sgarzare has joined #kata-dev | 07:25 | |
*** ailan has joined #kata-dev | 07:31 | |
*** openstack has joined #kata-dev | 07:47 | |
*** ChanServ sets mode: +o openstack | 07:47 | |
*** davidgiluk has joined #kata-dev | 08:03 | |
*** gwhaley has joined #kata-dev | 08:08 | |
kata-irc-bot | <fidencio> @bergwolf it is actually a blocker, mainly for RHEL. If we go down the path to use kata, we must ensure we build it ourselves. Any distro, even more the enterprises one, won't never ever ship something someone else built inside a containers, using something not supported by the distro | 09:03 |
kata-irc-bot | <bergwolf> In that case, is there a docker image for RHEL? | 09:08 |
kata-irc-bot | <fidencio> there's, it's called UBI (https://developers.redhat.com/blog/2020/03/24/red-hat-universal-base-images-for-docker-users/) and it has pretty much the same content as you have on RHEL itself. So, no musl there. | 09:09 |
kata-irc-bot | <bergwolf> I see. I don’t think musl is a hard requirement for the rust agent. Have you tried to build it w/o musl? | 09:12 |
kata-irc-bot | <fidencio> I didn't yet, but that's something we (as Red Hat people) should try and report the issues we face. | 09:13 |
kata-irc-bot | <bergwolf> `LIBC = musl` is the only line that needs to be changed. | 09:14 |
kata-irc-bot | <fidencio> Having the issue raised by @jose.carlos.venegas.m was the first step ... | 09:14 |
kata-irc-bot | <bergwolf> you might just export LIBC = gnu | 09:14 |
kata-irc-bot | <fidencio> now it comes back to us to try to build and check whether there's some issue or not, and then report that | 09:14 |
kata-irc-bot | <fidencio> @bergwolf, does this make sense? | 09:14 |
kata-irc-bot | <bergwolf> sure, go ahead and rock! | 09:15 |
kata-irc-bot | <fidencio> perfect! It won't happen that soon, though, as we're still figuring out other points on our side with higher-prio, but that's on our radar for soon-enough :slightly_smiling_face: | 09:15 |
kata-irc-bot | <bergwolf> This would do it. You can make it an makefile option: ```diff --git a/src/agent/Makefile b/src/agent/Makefile index 7e25b3c7..3666c652 100644 --- a/src/agent/Makefile +++ b/src/agent/Makefile @@ -26,7 +26,7 @@ export VERSION_COMMIT := $(if $(COMMIT),$(VERSION)-$(COMMIT),$(VERSION)) BUILD_TYPE = release ARCH = $(shell uname -m) -LIBC = musl +LIBC = gnu TRIPLE = $(ARCH)-unknown-linux-$(LIBC) TARGET_PATH = | 09:24 |
kata-irc-bot | target/$(TRIPLE)/$(BUILD_TYPE)/$(TARGET)``` | 09:24 |
kata-irc-bot | <bergwolf> I just tried and it works | 09:25 |
kata-irc-bot | <fidencio> It builds or it works? :slightly_smiling_face: | 09:25 |
kata-irc-bot | <fidencio> In any case, I'll propose a patch to have LIBC configurable, using musl as the default one | 09:26 |
kata-irc-bot | <fidencio> and make sure it at least builds on our side | 09:26 |
kata-irc-bot | <fidencio> @bergwolf can you point me to the official rust agent repo? | 09:37 |
gwhaley | @fidencio - I think that lives in the '2.0' kata-containers repo: https://github.com/kata-containers/kata-containers/tree/master/src/agent | 09:39 |
gwhaley | cc @jodh to confirm | 09:39 |
fidencio | it does, indeed! | 09:40 |
fidencio | gwhaley: @bergwolf, thanks! | 09:44 |
*** dklyle has quit IRC | 09:45 | |
kata-irc-bot | <fidencio> We'll have to update this: https://github.com/kata-containers/kata-containers/blob/master/src/agent/README.md | 09:49 |
kata-irc-bot | <bergwolf> it builds ;) | 09:58 |
*** pcaruana has quit IRC | 10:31 | |
*** pcaruana has joined #kata-dev | 10:50 | |
*** pcaruana has quit IRC | 10:57 | |
*** pcaruana has joined #kata-dev | 11:02 | |
*** gwhaley has quit IRC | 11:02 | |
*** gwhaley has joined #kata-dev | 12:09 | |
*** hashar has joined #kata-dev | 12:11 | |
*** devimc has joined #kata-dev | 12:22 | |
*** ailan has quit IRC | 12:55 | |
*** vgoyal has joined #kata-dev | 13:01 | |
*** ailan has joined #kata-dev | 13:30 | |
*** ailan has quit IRC | 14:09 | |
*** ailan_ has joined #kata-dev | 14:09 | |
*** devimc has quit IRC | 14:22 | |
*** devimc has joined #kata-dev | 14:27 | |
*** dklyle has joined #kata-dev | 14:48 | |
*** ailan__ has joined #kata-dev | 14:52 | |
*** ailan_ has quit IRC | 14:55 | |
*** hashar has quit IRC | 15:08 | |
kata-irc-bot | <wmoschet> Hi folks, do we have somewhere the built rpms from kata-containers master? | 15:09 |
kata-irc-bot | <fidencio> I don't think so. | 15:11 |
devimc | https://build.opensuse.org/project/show/home:katacontainers:releases:x86_64:master | 15:11 |
devimc | @wmoschet wmoschet | 15:12 |
kata-irc-bot | <fidencio> That's for the releases. We don't build anything based on master (per each accepted PR) | 15:13 |
kata-irc-bot | <wmoschet> yes, I meant based on master. anyway, thanks @julio.montes | 15:14 |
kata-irc-bot | <fidencio> @julio.montes, giving you some context ... Wainer is looking in possible ways to hook up OpenShift CI with kata PRs | 15:26 |
kata-irc-bot | <fidencio> seems that generating RPMs for each commit, and then somehow installing the generated RPM to OpenShift seems to be one of the ways to go | 15:27 |
kata-irc-bot | <wmoschet> yes, but let's think for now I want to test the master branch just after a merge. I need to generate all the rpms so that I can inject them in the image openshift CI uses to build the cluster nodes | 15:29 |
kata-irc-bot | <fidencio> so, if an RPM is actually needed, we could have the RPM generated as an artifact and stored on github itself | 15:31 |
devimc | @fidencio @wmoschet I'd prefer to have nightly jobs for kata components , for example http://jenkins.katacontainers.io/job/kernel-nightly-x86_64/ | 15:31 |
devimc | it's easier than the rpm generation | 15:31 |
kata-irc-bot | <wmoschet> I know that packaging provides scripts for building rpms on OBS | 15:31 |
kata-irc-bot | <wmoschet> @julio.montes so far my understand is that I really need rpms...because they should be installed in a rpm-ostree, which is how I can possible update the nodes in a openshift cluster | 15:32 |
devimc | @wmoschet OBS is a good open-free service, but imo it's not reliable, sometimes it's down or saturated | 15:33 |
kata-irc-bot | <wmoschet> hmmm | 15:33 |
kata-irc-bot | <wmoschet> good to know | 15:33 |
kata-irc-bot | <fidencio> Maybe a copr repo? There are ways to easily trigger copr builds | 15:37 |
kata-irc-bot | <wmoschet> Need to think.... suppose I merge something on runtime repo, then I merged another on osbuilder. I want to test this new change to osbuilder, using a nightly build of runtime won't be exactly the version I need (I need the master). | 15:40 |
kata-irc-bot | <wmoschet> So technically if I want to test a merge on master on any repo, I should build the rpms from master on all other repos. Unless I am missing something :slightly_smiling_face: | 15:41 |
kata-irc-bot | <fidencio> Consider we use copr, we can do copr builds for each PR if that's what you need | 15:42 |
kata-irc-bot | <wmoschet> I need to investigate that possibility | 15:43 |
kata-irc-bot | <fidencio> Because the problem becomes having the RPMs for the different projects, altogether, to be used ... from latest master ... right? | 15:44 |
kata-irc-bot | <wmoschet> exactly | 15:45 |
kata-irc-bot | <fidencio> Ok, let me think as well, let me think | 15:47 |
kata-irc-bot | <wmoschet> Let's suppose I don't need rpms... but rather I need to install everything in a given folder (e.g. /tmp/local_install). Is there any existing script that helps me with that? | 15:57 |
kata-irc-bot | <fidencio> Yesterday I learned about https://github.com/kata-containers/packaging/tree/master/kata-deploy#docker-quick-start | 16:03 |
kata-irc-bot | <fidencio> that may have something that helps us | 16:04 |
kata-irc-bot | <fidencio> another way would be to just generate a binary as an artifact and consume the binary to use on OpenShift Ci | 16:04 |
*** sgarzare has quit IRC | 16:17 | |
fidencio | devimc: *if* we need, I guess it's fine to the project's binary as an artifact for the CI, right? | 16:21 |
devimc | fidencio: what you mean? | 16:24 |
fidencio | devimc: let's say openshift ci would need to use the latest runtime / agent / osbuilder code | 16:26 |
fidencio | devimc: would be okay to have a post merge job running that would generate the binaries needed and store it on github, so we don't have to rebuild all the n projects everytime? | 16:27 |
devimc | fidencio: github? I don't think so, I'd place it in jenkins like an artifact | 16:28 |
fidencio | devimc: hmmm. jenkins may work as well. I'm not that familiar with github, but I know gitlab would allow me to do that | 16:29 |
gwhaley | iirc, somebody reported a few weeks back that they could not move the kata static package (aka, kata-deploy binaries) to a different path - it seemed to fail. I don't know if/what there are any hard wired paths - but, just something to look out for. | 16:48 |
*** jodh has quit IRC | 17:01 | |
*** gwhaley has quit IRC | 17:12 | |
*** irclogbot_3 has quit IRC | 17:20 | |
*** irclogbot_0 has joined #kata-dev | 17:22 | |
kata-irc-bot | <wmoschet> The openshift CI has a robot that will get notified as soon as you merge the PR, I don't know how it can be in sync with a Jenkins job so that it would halt until the jenkins finishes the build of the artifacts | 17:39 |
kata-irc-bot | <wmoschet> But it is another possibility to explore | 17:39 |
*** devimc has quit IRC | 17:52 | |
*** hashar has joined #kata-dev | 17:58 | |
*** devimc has joined #kata-dev | 18:23 | |
kata-irc-bot | <fidencio> Yeah, I'd say for now we better have the knowledge about all the possibilities :-) | 18:38 |
kata-irc-bot | <fidencio> https://gitlab.cee.redhat.com/kata-containers/kata-utils/blob/jfreiman/cloud/containers/kata-installer/Dockerfile | 19:04 |
*** davidgiluk has quit IRC | 19:17 | |
kata-irc-bot | <fidencio> @salvador.fuentes @jose.carlos.venegas.m, so in your CI, you built your QEMU version or you just use the nightly static build? | 19:26 |
kata-irc-bot | <jose.carlos.venegas.m> @fidencio we pin to one version https://github.com/kata-containers/runtime/blob/master/versions.yaml#L92 | 19:28 |
kata-irc-bot | <jose.carlos.venegas.m> tag: “v4.1.1” at this moment | 19:28 |
kata-irc-bot | <fidencio> and build it on every PR? | 19:29 |
kata-irc-bot | <jose.carlos.venegas.m> yeah, If that value is modified the CI is going to build it | 19:29 |
kata-irc-bot | <jose.carlos.venegas.m> we have a way to cache a build | 19:29 |
kata-irc-bot | <jose.carlos.venegas.m> of some assets like qemu | 19:29 |
kata-irc-bot | <jose.carlos.venegas.m> so if is merged, we cache that new build | 19:30 |
kata-irc-bot | <jose.carlos.venegas.m> http://jenkins.katacontainers.io/job/qemu-nightly-x86_64/lastBuild/ | 19:30 |
kata-irc-bot | <jose.carlos.venegas.m> so nightly means our latest build | 19:31 |
kata-irc-bot | <fidencio> Yeah, the static one! | 19:31 |
kata-irc-bot | <jose.carlos.venegas.m> not the latest from qemu | 19:31 |
kata-irc-bot | <fidencio> and the reason for using the static one, I guess, is just to avoid dealing with the needed dependencies? | 19:31 |
kata-irc-bot | <jose.carlos.venegas.m> yeah, to share the same build across all the distros in the CI | 19:32 |
kata-irc-bot | <jose.carlos.venegas.m> for OBS distros we still do dynamic linked build | 19:32 |
kata-irc-bot | <jose.carlos.venegas.m> but kata-deploy and CI uses static build of qemu | 19:33 |
kata-irc-bot | <fidencio> Cool, perfect, that was my impression but thanks for confirming that! | 19:33 |
kata-irc-bot | <jose.carlos.venegas.m> yeah :slightly_smiling_face:, no problem ! | 19:33 |
*** sameo_ has quit IRC | 20:15 | |
*** hashar has quit IRC | 20:49 | |
*** devimc has quit IRC | 21:08 | |
*** ailan__ has quit IRC | 22:45 | |
*** vgoyal has quit IRC | 23:02 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!