kata-irc-bot1 | <archana.m.shinde> @eric.ernst Take a look at this : https://github.com/kata-containers/kata-containers/pull/442 | 01:41 |
---|---|---|
kata-irc-bot1 | <archana.m.shinde> I am pinning to a particular version of actions, similarly applied the change for open PRs as well | 01:41 |
*** bpradipt has joined #kata-dev | 02:51 | |
kata-irc-bot1 | <eric.ernst> K | 03:39 |
*** pcaruana has quit IRC | 04:17 | |
*** pcaruana has joined #kata-dev | 04:17 | |
*** amorenoz has joined #kata-dev | 06:16 | |
*** amorenoz has quit IRC | 06:20 | |
*** amorenoz has joined #kata-dev | 06:20 | |
*** amorenoz has joined #kata-dev | 06:21 | |
*** amorenoz has quit IRC | 06:25 | |
*** amorenoz has joined #kata-dev | 06:25 | |
*** fgiudici has joined #kata-dev | 07:12 | |
kata-irc-bot1 | <fidencio> Done! | 07:18 |
*** snir_ has quit IRC | 07:35 | |
*** snir_ has joined #kata-dev | 07:35 | |
*** davidgiluk has joined #kata-dev | 08:06 | |
*** sgarzare has joined #kata-dev | 08:08 | |
kata-irc-bot1 | <thierry> Just checked and removed the Zuul SoB/WIP checks from the "required" list for repo/branches that still have them. You might have to backport those actions to all branches | 08:10 |
kata-irc-bot1 | <fidencio> @thierry, thanks a lot for taking care of this! | 08:11 |
kata-irc-bot1 | <thierry> I'll soon remove the integration so that Zuul stops running those checks on new PRs | 08:12 |
kata-irc-bot1 | <thierry> Just doublechecking a few things first | 08:12 |
*** sgarzare has quit IRC | 08:22 | |
*** sgarzare has joined #kata-dev | 08:22 | |
kata-irc-bot1 | <thierry> @archana.m.shinde: looks like you will have to backport adding actions to all branches, most notably kata-containers:2.0-dev | 08:26 |
*** sgarzare has quit IRC | 09:30 | |
*** sgarzare has joined #kata-dev | 09:31 | |
*** afrosi has joined #kata-dev | 10:07 | |
*** afrosi has quit IRC | 10:14 | |
*** afrosi has joined #kata-dev | 11:03 | |
*** afrosi has quit IRC | 12:02 | |
*** devimc has joined #kata-dev | 13:50 | |
*** sgarzare has quit IRC | 13:56 | |
*** sgarzare has joined #kata-dev | 14:01 | |
*** devimc has quit IRC | 14:44 | |
*** devimc has joined #kata-dev | 14:45 | |
*** sgarzare_ has joined #kata-dev | 15:10 | |
*** sgarzare has quit IRC | 15:13 | |
kata-irc-bot1 | <archana.m.shinde> @thierry: ohh I thought just adding the checks under branch protection rules would suffice : https://github.com/kata-containers/kata-containers/settings/branches | 15:17 |
kata-irc-bot1 | <archana.m.shinde> let me see, I'll backport those | 15:17 |
kata-irc-bot1 | <thierry> @archana.m.shinde: I agree that would have been convenient :) It's confusing because the "recently-seen" tests list (the one you can choose required tests from) shows master tests and not tests from current branch | 15:19 |
kata-irc-bot1 | <thierry> so you can actually put yourself in a corner mandating a test that will never run | 15:20 |
kata-irc-bot1 | <archana.m.shinde> I see, not good! | 15:21 |
kata-irc-bot1 | <archana.m.shinde> thanks for letting me know @thierry, I'll start working on backporting those changes | 15:21 |
kata-irc-bot1 | <thierry> np! Once enabled it seems to work pretty well (as in: triggers and reports fast) | 15:22 |
kata-irc-bot1 | <archana.m.shinde> yes its pretty quick | 15:22 |
kata-irc-bot1 | <fidencio> @archana.m.shinde, this is a good example of when exception rules would be good | 15:27 |
kata-irc-bot1 | <fidencio> would be nice to just have those patches pushed to all branches, without having to deal with create an issue, submit a PR, get 2 approvals ... | 15:28 |
fidencio | devimc: @amshinde: how easy is to have the link for the CI commands automatically added to the PRs? :-) | 15:32 |
devimc | fidencio: I think the kata-bot can do it | 15:33 |
devimc | .github/auto-comment.yml | 15:34 |
devimc | fidencio: for example https://github.com/kata-containers/runtime/blob/master/.github/auto-comment.yml | 15:34 |
kata-irc-bot1 | <archana.m.shinde> yup, something that could be taken care of by auto-bot | 15:35 |
fidencio | cool, thanks! | 15:35 |
fidencio | would be nice to have the results of the CI with some text explaining how to rerun the tests, if needed | 15:36 |
fidencio | I always suffer to find the links with the commands that I need | 15:37 |
kata-irc-bot1 | <archana.m.shinde> agree | 15:38 |
kata-irc-bot1 | <archana.m.shinde> Its been on todo list for a list | 15:38 |
kata-irc-bot1 | <archana.m.shinde> would be useful indeed | 15:38 |
*** sgarzare_ has quit IRC | 16:01 | |
davidgiluk | archana.m.shinde: So are we all good now with the new qemu and kernel set? | 16:26 |
*** ailan has quit IRC | 17:24 | |
*** fgiudici has quit IRC | 17:33 | |
*** devimc has quit IRC | 17:49 | |
*** bpradipt has quit IRC | 18:35 | |
*** devimc has joined #kata-dev | 18:54 | |
*** davidgiluk has quit IRC | 19:12 | |
kata-irc-bot1 | <eric.ernst> can anyone help with getting this merged? https://github.com/kata-containers/documentation/pull/693 | 20:51 |
kata-irc-bot1 | <eric.ernst> @archana.m.shinde can we bypass the SoB/WIP checks if that tooling is in-progress/changing over still? | 20:52 |
kata-irc-bot1 | <archana.m.shinde> @eric.ernst I closed and reoponed the PR for the checks to run, since they were added after your PR was raised | 21:04 |
kata-irc-bot1 | <archana.m.shinde> they have run now | 21:04 |
kata-irc-bot1 | <eric.ernst> ok. Should we do the same for my thread model PR ? :slightly_smiling_face: | 21:04 |
*** devimc has quit IRC | 21:52 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!