| kata-irc-bot | <eric.ernst> I'm working on moving changes from 1.x to 2.0 which include vendor updates. | 00:06 |
|---|---|---|
| kata-irc-bot | <eric.ernst> Is there documentation on our usage/process for adding new vendored code, now that we droppe dep? I would always use this guide before: https://github.com/kata-containers/community/blob/7047db10842da04ae8988d4985e532a467230a79/VENDORING.md | 00:08 |
| kata-irc-bot | <eric.ernst> @jose.carlos.venegas.m @bergwolf @archana.m.shinde you know? | 00:08 |
| kata-irc-bot | <eric.ernst> I think my main issue was I was attempting to pull in a package from k8s.io/kubernetes which is painful. The package is very standalone; I think I'll end up just adding the utility functions I need to ./src/runtime/pkg | 01:14 |
| kata-irc-bot | <bergwolf> `go mod vendor` and `go mod tidy` ? | 02:25 |
| kata-irc-bot | <eric.ernst> Yeah, that generally works, but I guess trying to vendor in anything from k8s.io/kubernetes is quite challenging. | 03:44 |
| kata-irc-bot | <dgibson> I don't think I did ever fix it | 04:33 |
| kata-irc-bot | <dgibson> @bergwolf hello | 04:34 |
| kata-irc-bot | <bergwolf> hi | 04:34 |
| kata-irc-bot | <dgibson> I'm afraid I posted a competing PR for Kata2 issue #703 | 04:35 |
| kata-irc-bot | <dgibson> it's arguably not as nice as yours, but is closer to what is in Kata1, so will make my life easier for future forward ports | 04:35 |
| kata-irc-bot | <dgibson> sorry for the duplicated effort, I should have posted my drafts earlier | 04:35 |
| kata-irc-bot | <bergwolf> cool. Let me take a look. If it works well, let’s merge yours instead. I was a bit worried that the issue will block 2.0 release so I rushed out a simple version yesterday. | 04:36 |
| kata-irc-bot | <dgibson> fair enough | 04:36 |
| kata-irc-bot | <eric.ernst> Hey Bergwolf -- cpusets/cgroups for 2.0 :thread: | 04:37 |
| kata-irc-bot | <dgibson> I got rather sidetracked on the way to doing the forward port | 04:37 |
| kata-irc-bot | <eric.ernst> TAL @ https://github.com/kata-containers/kata-containers/pull/933 please | 04:37 |
| kata-irc-bot | <dgibson> @bergwolf from your timezone on slack, I'm guessing you're based in China? | 04:37 |
| kata-irc-bot | <eric.ernst> Finally got around to forward porting these. Basically, I'm testing with 2.0 now, so quickly seeing some gaps. Hopefully this is the last of it . | 04:38 |
| kata-irc-bot | <eric.ernst> Sorry to be so tardy on getting these fowrard ported. I consider much of it as bug fixes, since there was 'some' cpuset support that wasn't ideal, and we weren't respecting kubernetes static CPU policies correctly. | 04:38 |
| kata-irc-bot | <eric.ernst> 2.0 default settings -- looking for input! :thread: | 04:39 |
| kata-irc-bot | <eric.ernst> why is 9pfs still the default for kata-qemu configuration? Do we want this? I think virtio-fs w / out DAX makes more sense? | 04:39 |
| kata-irc-bot | <bergwolf> yup | 04:40 |
| kata-irc-bot | <dgibson> good to know | 04:40 |
| kata-irc-bot | <eric.ernst> Similarly, I am okay with keeping the logic behind a flag, but I really think sandboxCgroupOnly=true should be the default. | 04:40 |
| kata-irc-bot | <dgibson> I'm in Australia, so my hours line up much better with you than with the people in the US or Europe | 04:40 |
| kata-irc-bot | <bergwolf> wow, wonderful! | 04:40 |
| kata-irc-bot | <bergwolf> let’s push it in for 2.0 | 04:40 |
| kata-irc-bot | <eric.ernst> Once it lands, I can 'backport' to stable-2.0.0 | 04:42 |
| kata-irc-bot | <bergwolf> +1 on `sandboxCgroupOnly=true` . As for defaulting to virtiofs, I’m not sure if we should do it at the last week of releasing 2.0 | 04:42 |
| kata-irc-bot | <bergwolf> Need a lot of tests to make sure virtiofs is as stable as 9p on 2.0 IMHO | 04:42 |
| kata-irc-bot | <eric.ernst> In case you missed it while on your much deserved vacation, I created that branch for the rc1 release. It was about the same as 2.0-dev, minus SGX. | 04:42 |
| kata-irc-bot | <eric.ernst> I think its there when DAX is disabled (default to cache=0 would be required) | 04:43 |
| kata-irc-bot | <eric.ernst> We've been talking about getting rid of 9pfs for about 3 years now; I'd hate to have it the default still in 2.0 | 04:43 |
| kata-irc-bot | <bergwolf> yup, I noticed that. I have a `prepare-release` branch in my repo to hold all the backports that I have for stable-2.0.0. It syncs daily with latest dev-2.0 | 04:44 |
| kata-irc-bot | <bergwolf> https://github.com/bergwolf/kata-containers/tree/prepare-release | 04:44 |
| kata-irc-bot | <eric.ernst> cool. hopefully it lines up okay w/ stable-2.0.0 | 04:45 |
| kata-irc-bot | <eric.ernst> what's the date for release? | 04:45 |
| kata-irc-bot | <bergwolf> It is based off stable-2.0.0, cherry-picking all the commits increamentally. | 04:46 |
| kata-irc-bot | <bergwolf> This Friday,:) | 04:46 |
| kata-irc-bot | <bergwolf> At least before Oct 19-23, which is the openinfra summit | 04:47 |
| kata-irc-bot | <bergwolf> Great, we can talk more ;) | 04:48 |
| kata-irc-bot | <eric.ernst> OK, let's talk during the A.C on this. | 04:50 |
| *** sameo has joined #kata-dev | 05:18 | |
| *** dklyle has quit IRC | 06:43 | |
| *** jodh has joined #kata-dev | 06:53 | |
| *** fgiudici has joined #kata-dev | 07:01 | |
| *** amorenoz has joined #kata-dev | 07:02 | |
| *** snir has joined #kata-dev | 07:13 | |
| *** davidgiluk has joined #kata-dev | 08:01 | |
| *** sgarzare has joined #kata-dev | 09:42 | |
| *** fgiudici has quit IRC | 11:22 | |
| *** snir has quit IRC | 13:28 | |
| *** fuentess has joined #kata-dev | 13:33 | |
| *** crobinso has joined #kata-dev | 13:34 | |
| *** dklyle has joined #kata-dev | 14:12 | |
| *** snir has joined #kata-dev | 14:34 | |
| kata-irc-bot | <archana.m.shinde> Will have to skip today's AC meeting | 15:03 |
| kata-irc-bot | <gabriela.cervantes.te> we can't connect to the meeting | 15:04 |
| kata-irc-bot | <bergwolf> Any one can start the zoom meeting? | 15:04 |
| kata-irc-bot | <gabriela.cervantes.te> it says wait for the host | 15:04 |
| kata-irc-bot | <fidencio> I'm trying to connect but I'm having a hard time to start it :slightly_smiling_face: | 15:04 |
| kata-irc-bot | <gabriela.cervantes.te> no | 15:04 |
| kata-irc-bot | <raravena80> @sunny can the Arch Committee members have access to host the meeting in the future? Thx. | 15:07 |
| davidgiluk | wasnt there a message saying it was a different call link | 15:13 |
| kata-irc-bot | <sunny> unfortunately with the new zoom feature, I can’t set anyone as host before the meeting. The new process should be one of the AC members claim as host using the new link but it looks like that failed this morning | 15:40 |
| kata-irc-bot | <sunny> Let me ask our zoom guy today about this and do some digging. If not, I’ll just have to log in quickly in the future and set someone as a host then log out to another zoom meeting | 15:41 |
| kata-irc-bot | <fidencio> @eric.ernst, I'll go ahead and do the two PRs related to virtiofsd, okay? | 16:11 |
| kata-irc-bot | <eric.ernst> which were the two? Enable default and _ ? | 16:17 |
| kata-irc-bot | <eric.ernst> ie, updating the Makefile? | 16:17 |
| kata-irc-bot | <eric.ernst> see https://github.com/kata-containers/kata-containers/pull/936 | 16:18 |
| *** fuentess has quit IRC | 16:22 | |
| kata-irc-bot | <fidencio> @eric.ernst, backporting the QEMU patch mentioned by Dave and passing `--thread-pool-size=1` to virtiofsd | 16:27 |
| kata-irc-bot | <eric.ernst> ACK | 16:27 |
| kata-irc-bot | <eric.ernst> thanks @fidencio | 16:27 |
| *** fuentess has joined #kata-dev | 16:43 | |
| *** jodh has quit IRC | 16:59 | |
| *** sgarzare has quit IRC | 17:17 | |
| kata-irc-bot | <eric.ernst> can someone TAL @ https://github.com/kata-containers/runtime/pull/2988? | 18:07 |
| kata-irc-bot | <eric.ernst> addressed feedback: should be good to go now | 18:07 |
| kata-irc-bot | <eric.ernst> @jose.carlos.venegas.m @archana.m.shinde @chen.bo PTAL? | 18:08 |
| kata-irc-bot | <eric.ernst> @salvador.fuentes @gabriela.cervantes.te I took a quick look @ popular docker images test | 18:08 |
| kata-irc-bot | <eric.ernst> I think just moving to containerd CLI should be most straight forward. | 18:08 |
| kata-irc-bot | <eric.ernst> I put an initial PR here: https://github.com/kata-containers/tests/pull/2952 | 18:09 |
| kata-irc-bot | <eric.ernst> I'm having a bit of network issues locally so can't easily run the whole suite, and I *think* that we'll want to update the RUNTIME settings appropriately. Any chance either of you can help add to this in order to make sure containerd-shim-kata*-v2 is utilized? | 18:09 |
| kata-irc-bot | <chen.bo> @eric.ernst Added my ack. It is mostly educating me one more new thins for kata/k8s. :slightly_smiling_face: I wonder why we needed this limit on mini-memory at the first place? | 18:17 |
| kata-irc-bot | <eric.ernst> This was just to make sure users didn't update the default to 1 MiB and get confused when the VMM wasn't able to actually boot. | 18:20 |
| kata-irc-bot | <eric.ernst> But, in reality, I think its better to leave it up to end user rather than try to figure out across the board what the right limit is. | 18:20 |
| kata-irc-bot | <chen.bo> ok. I see. Thanks for the explanation. | 18:21 |
| kata-irc-bot | <eric.ernst> In our case, booting a basic workload eats on the order of ~120-160MB. We should allow setting the baseline memory needed by the VMM at those kinds of levels, rather than artificially saying "must be >=256MB" | 18:21 |
| kata-irc-bot | <chen.bo> Right. Makes sense. | 18:21 |
| kata-irc-bot | <chen.bo> BTW, you may want to update the description of the PR itself, where you have `lower to 8MB` instead of remove the check completely. @eric.ernst | 18:22 |
| kata-irc-bot | <eric.ernst> ah, the commit message was updated. | 18:23 |
| kata-irc-bot | <eric.ernst> let me put that in pr header too | 18:23 |
| kata-irc-bot | <chen.bo> Yes. :slightly_smiling_face: | 18:23 |
| kata-irc-bot | <fidencio> I also can help you here, Eric | 18:24 |
| kata-irc-bot | <eric.ernst> Thanks for the review as well, Carlos :slightly_smiling_face: | 18:24 |
| kata-irc-bot | <jose.carlos.venegas.m> just ack, we may want to add a test with podoverhead | 18:24 |
| kata-irc-bot | <chen.bo> Ready to be landed. :) | 18:24 |
| kata-irc-bot | <eric.ernst> I was able to manually run a couple of them. | 18:25 |
| kata-irc-bot | <fidencio> Let the tests run, I'm playing with some stuff now but I'll take a look as soon as they end | 18:26 |
| kata-irc-bot | <eric.ernst> @jose.carlos.venegas.m yeah I think @salvador.fuentes is looking at updating to 1.18 for the CI. fingers crossed that goes well so we can just update the runteimClass one. | 18:26 |
| kata-irc-bot | <salvador.fuentes> @eric.ernst you'll need to enable those tests in one of these CI jobs: https://github.com/kata-containers/tests/blob/2.0-dev/.ci/run.sh#L19 | 18:26 |
| kata-irc-bot | <salvador.fuentes> thanks btw :slightly_smiling_face: | 18:27 |
| kata-irc-bot | <eric.ernst> yw. Looking @ Makefile -- do we even have popular images test today? | 18:35 |
| kata-irc-bot | <eric.ernst> running/ | 18:35 |
| kata-irc-bot | <salvador.fuentes> not for every PR, there is a nightly job doing the work | 18:36 |
| kata-irc-bot | <salvador.fuentes> I think it is because it takes a lot of time | 18:36 |
| kata-irc-bot | <eric.ernst> Got it. Where's that configured? | 18:36 |
| kata-irc-bot | <eric.ernst> I'm fine w/ it being nightly, but i want to be able to trigger it manually if feasible to test... | 18:37 |
| kata-irc-bot | <salvador.fuentes> ok, we can add a new CI_JOB in that case | 18:37 |
| kata-irc-bot | <salvador.fuentes> and then, we configure it in the jenkins job itself | 18:37 |
| kata-irc-bot | <salvador.fuentes> this is the job that tests master branch: http://jenkins.katacontainers.io/job/kata-containers-tests-ubuntu-18-04-master-ksm-pentest-popular-images/ | 18:39 |
| kata-irc-bot | <eric.ernst> ACK. Any chance you can help facilitate the job creation while we work on testing the bats? | 18:50 |
| kata-irc-bot | <eric.ernst> s / you/ anyone | 18:50 |
| *** davidgiluk has quit IRC | 19:10 | |
| kata-irc-bot | <salvador.fuentes> I can do that | 19:16 |
| kata-irc-bot | <salvador.fuentes> @eric.ernst I created: http://jenkins.katacontainers.io/job/kata-containers-2.0-popular-images/, after your PR is merged, we can give a first try | 19:28 |
| kata-irc-bot | <eric.ernst> I’m not sure if all these are tested / passing today in 1.x. Guess we can see... | 19:30 |
| kata-irc-bot | <salvador.fuentes> I can see in the latest run that they are | 19:31 |
| kata-irc-bot | <eric.ernst> I see that they all pass, yeah. Bonita seemed to have issue for me. | 19:32 |
| kata-irc-bot | <eric.ernst> I'm not sure what the formal url is for the container image that's being tested in docker case. | 19:32 |
| kata-irc-bot | <eric.ernst> perhaps it is different than docker.io/library/bonita:latest | 19:32 |
| *** sameo has quit IRC | 21:04 | |
| *** amorenoz has quit IRC | 21:49 | |
| *** amorenoz has joined #kata-dev | 21:50 | |
| *** auk has joined #kata-dev | 22:06 | |
| *** fuentess has quit IRC | 22:08 | |
| *** fuentess1 has joined #kata-dev | 22:08 | |
| *** fuentess1 has quit IRC | 22:20 | |
| *** sameo has joined #kata-dev | 22:23 | |
| *** sameo has quit IRC | 22:50 | |
| *** auk has quit IRC | 23:43 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!