| *** fuentess has quit IRC | 01:43 | |
| *** fgiudici has joined #kata-dev | 07:27 | |
| *** dklyle has quit IRC | 07:37 | |
| kata-irc-bot | <fidencio> @bergwolf, @fupan, @liubin0329, may I bother you guys with some help on https://github.com/kata-containers/kata-containers/issues/1080#issuecomment-722596355 ? Doesn't have to be now, but please, add that to your backlog. | 07:37 |
|---|---|---|
| *** jodh has joined #kata-dev | 07:46 | |
| *** jodh has quit IRC | 07:56 | |
| *** sgarzare has joined #kata-dev | 08:04 | |
| *** auk_ has quit IRC | 08:24 | |
| *** sameo has joined #kata-dev | 08:26 | |
| *** jodh has joined #kata-dev | 08:47 | |
| *** snir has quit IRC | 08:50 | |
| *** snir has joined #kata-dev | 08:50 | |
| *** davidgiluk has joined #kata-dev | 09:04 | |
| *** th0din has quit IRC | 10:08 | |
| *** th0din has joined #kata-dev | 10:15 | |
| *** th0din has quit IRC | 10:16 | |
| *** th0din has joined #kata-dev | 10:21 | |
| *** devimc has joined #kata-dev | 12:36 | |
| kata-irc-bot | <liubin0329> I suspect https://github.com/cri-o/cri-o/blob/v1.18.4/internal/oci/runtime_vm.go#L407 this line is the reason, is it convenient to you to delete these lines (including https://github.com/cri-o/cri-o/blob/v1.18.4/internal/oci/runtime_vm.go#L351-L355 ) and try again? | 14:34 |
| kata-irc-bot | <liubin0329> My test VM has crashed | 14:37 |
| kata-irc-bot | <fidencio> Sorry for the long time it took me to reply, I was in a meeting! | 14:49 |
| kata-irc-bot | <fidencio> I'll give it a try soon, thanks @liubin0329! | 14:49 |
| kata-irc-bot | <liubin0329> Hope a good news :slightly_smiling_face: | 14:53 |
| kata-irc-bot | <fidencio> From a quick test, it seems to work, indeed! We have two possible ways to follow from here. 1. I do more tests, submit the patch, add your Signed-off-by to give you the credit you deserve; 2. You submit the patch, I'll keep doing more tests and we hold merging the patches till I check some other cases; What's your preference? | 15:02 |
| kata-irc-bot | <fidencio> @liubin0329: ^ :slightly_smiling_face: | 15:04 |
| kata-irc-bot | <liubin0329> I prefer 1, but Signed-off-by to you. I only checked the source, But I thinks test is most important. | 15:06 |
| kata-irc-bot | <fidencio> I'll Sign off, but I'd like to also add your Sign off, if you're okay with that. | 15:07 |
| kata-irc-bot | <fidencio> I'll ensure it works for master, 1.19. 1.18, and 1.17 | 15:07 |
| kata-irc-bot | <liubin0329> OKļ¼thanks | 15:07 |
| kata-irc-bot | <fidencio> Also disable the test on kata for now, and take care of updating everything when 1.18.5 is out | 15:07 |
| kata-irc-bot | <fidencio> @liubin0329, thanks a lot for the help, *really appreciated*! Now, please, take a rest and enjoy your weekend! | 15:08 |
| kata-irc-bot | <liubin0329> Have a nice weekend. | 15:09 |
| kata-irc-bot | <liubin0329> And I think we need a stress test also, for example `for i in {1..100}; do sleep 3 ; kubectl cp file.txt test-env:/tmp; done;` | 15:11 |
| kata-irc-bot | <liubin0329> And I think we need a stress test also, for example `for i in {1..100}; do sleep 3 ; kubectl cp file.txt test-env:/tmp; done;` | 15:12 |
| kata-irc-bot | <liubin0329> And cover all case with `kubectl exec` with its `-i` and `-t` options | 15:12 |
| kata-irc-bot | <liubin0329> And cover all case with `kubectl exec` with its `-i` and `-t` options | 15:12 |
| kata-irc-bot | <liubin0329> https://github.com/kata-containers/tests/pull/2766/files | 15:13 |
| kata-irc-bot | <fidencio> Alright, I'm in the middle for a loop of your first suggestion here! | 15:15 |
| kata-irc-bot | <fidencio> Will make sure to cover all the cases with `-i` and `-t` as well | 15:16 |
| *** sameo has quit IRC | 15:16 | |
| *** sameo has joined #kata-dev | 15:17 | |
| *** devimc has quit IRC | 15:37 | |
| *** devimc has joined #kata-dev | 15:37 | |
| *** dklyle has joined #kata-dev | 15:55 | |
| *** fuentess has joined #kata-dev | 16:50 | |
| *** jodh has quit IRC | 18:08 | |
| *** sgarzare has quit IRC | 18:17 | |
| *** fgiudici has quit IRC | 18:37 | |
| *** sameo has quit IRC | 19:09 | |
| *** sameo has joined #kata-dev | 19:22 | |
| *** auk has joined #kata-dev | 19:35 | |
| *** davidgiluk has quit IRC | 20:01 | |
| *** pcaruana has quit IRC | 21:34 | |
| *** devimc has quit IRC | 22:14 | |
| *** fuentess has quit IRC | 22:50 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!