| *** tmhoang has quit IRC | 04:42 | |
| *** tmhoang has joined #kata-dev | 04:42 | |
| *** snir_ has quit IRC | 05:14 | |
| *** snir_ has joined #kata-dev | 05:15 | |
| *** jodh has joined #kata-dev | 07:45 | |
| *** pmores has joined #kata-dev | 07:47 | |
| *** fgiudici has joined #kata-dev | 07:51 | |
| *** sgarzare has joined #kata-dev | 08:19 | |
| *** sameo has joined #kata-dev | 08:55 | |
| *** davidgiluk has joined #kata-dev | 09:02 | |
| *** auk has joined #kata-dev | 09:02 | |
| *** auk has quit IRC | 09:03 | |
| *** dklyle has quit IRC | 10:01 | |
| *** jodh has quit IRC | 11:08 | |
| *** jodh has joined #kata-dev | 11:10 | |
| *** devimc has joined #kata-dev | 13:00 | |
| *** pmores has quit IRC | 13:32 | |
| *** pmores has joined #kata-dev | 14:30 | |
| *** fuentess has joined #kata-dev | 14:33 | |
| *** sgarzare_ has joined #kata-dev | 14:35 | |
| *** sgarzare_ has quit IRC | 14:35 | |
| *** sgarzare has quit IRC | 14:35 | |
| *** devimc has quit IRC | 14:43 | |
| *** devimc has joined #kata-dev | 14:43 | |
| *** pcaruana has quit IRC | 15:03 | |
| *** pcaruana has joined #kata-dev | 15:12 | |
| *** sgarzare has joined #kata-dev | 15:20 | |
| *** crobinso has joined #kata-dev | 15:22 | |
| *** dklyle has joined #kata-dev | 15:47 | |
| *** jodh has quit IRC | 17:00 | |
| kata-irc-bot | <eric.ernst> devimc you around? | 17:28 |
|---|---|---|
| devimc | Hi @eric.ernst | 17:39 |
| kata-irc-bot | <eric.ernst> I was going to git blame you around the blockVolume handling, but I see it wasn't your fault. | 17:44 |
| kata-irc-bot | <eric.ernst> i'm probably going to refactor some of those functions -- its kind of a mess right now. Will then update the unit tests as well. | 17:45 |
| kata-irc-bot | <eric.ernst> Will def want your review on it. | 17:45 |
| *** jodh has joined #kata-dev | 17:47 | |
| devimc | oks | 17:48 |
| *** sgarzare has quit IRC | 17:59 | |
| *** fgiudici has quit IRC | 18:01 | |
| *** jodh has quit IRC | 18:04 | |
| kata-irc-bot | <eric.ernst> devimc know any e2e tests for vhost-user-blk? | 18:35 |
| kata-irc-bot | <eric.ernst> I know it was added by a TME /FAE from Intel initially. I don't see any integration tests, just a unit test that I don't fully trust. | 18:36 |
| devimc | @eric.ernst nop, just the posix test | 19:10 |
| kata-irc-bot | <eric.ernst> ok. | 19:21 |
| kata-irc-bot | <eric.ernst> its pretty self contained -- I'll make sure the existing unit test still works. | 19:21 |
| *** pmores has quit IRC | 19:51 | |
| kata-irc-bot | <eric.ernst> devimc: heads up | 20:06 |
| kata-irc-bot | <eric.ernst> https://github.com/kata-containers/runtime/pull/3115/files?file-filters%5B%5D=.go&file-filters%5B%5D=No+extension | 20:06 |
| devimc | @eric.ernst lgtm | 20:11 |
| devimc | waiting for the CI | 20:11 |
| *** davidgiluk has quit IRC | 20:12 | |
| *** davidgiluk has joined #kata-dev | 20:26 | |
| *** davidgiluk has quit IRC | 20:35 | |
| *** crobinso has quit IRC | 21:25 | |
| *** devimc has quit IRC | 22:05 | |
| kata-irc-bot | <fidencio> @pavlenko.maksym, hey / ping. I'm facing an issue that you may help me to figure out what's the best way out of it. :thread: | 22:57 |
| kata-irc-bot | <fidencio> CRI-O is failing to get metrics from the pods because when unmarshalling the response from Kata Containers CRI-O doesn't know what to do with the following type: "io.containerd.cgroups.v1.Metrics". What's the best way to solve this? Just registering the type would be enough or is there something else expected? | 22:57 |
| kata-irc-bot | <pavlenko.maksym> RegisterType might help, worth to try | 22:59 |
| kata-irc-bot | <fidencio> It looks weird to have to manually register that, doesn't it? | 22:59 |
| kata-irc-bot | <pavlenko.maksym> (don’t know much about crio), but ideally it should register it since it uses it | 23:06 |
| kata-irc-bot | <fidencio> containerd/cgroups seems to be vendored already, which brings in the metrics.proto file. I thought (naively) that it would be enough to have it registered. | 23:10 |
| kata-irc-bot | <fidencio> or maybe I'm missing something else. Anyways, thanks for the help, I'll take some rest and get back to it Tomorrow. | 23:11 |
| *** fuentess has quit IRC | 23:39 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!