| *** dklyle has quit IRC | 06:16 | |
| *** jodh has joined #kata-dev | 06:36 | |
| *** fgiudici has joined #kata-dev | 06:50 | |
| *** fuentess has joined #kata-dev | 12:49 | |
| kata-irc-bot | <fidencio> @eric.ernst, going through the document and dropping some suggestions here | 13:19 |
|---|---|---|
| kata-irc-bot | <fidencio> > "In the non-watchable scenario, updates to the mount continue to be propagated to the container workload, but these updates will not trigger an inotify event." Please, make it clear that this is already the current scenario. The way it's written it sounds like a drawback would be introduced by the work, rather than "in this case, everything will continue as it's Today" | 13:20 |
| kata-irc-bot | <fidencio> > the `kata-agent` will poll the mount presented from the host through ... I guess a very basic question will be ... how often will kata poll? And also having it configurable is fine. I'd say that those polls being in a window of "a few minutes" would have no impact at all and could be a good enough situation. But I guess for what you need, you may end up polling every few seconds? | 13:23 |
| kata-irc-bot | <fidencio> Anyways, what you have is solid and promising! Thanks for working on that. | 13:30 |
| *** devimc has joined #kata-dev | 13:35 | |
| kata-irc-bot | <fidencio> I took a quick look at the code, there's nothing that negatively caught my attention, but I'll dive into that properly once you tell me you want a formal code review there. | 13:40 |
| *** dklyle has joined #kata-dev | 14:46 | |
| kata-irc-bot | <eric.ernst> thanks @fidencio | 15:18 |
| kata-irc-bot | <eric.ernst> A few more changes, a couple more unit tests and I should have a PR ready. | 15:18 |
| kata-irc-bot | <fidencio> I like how you're splitting the work with Maxym :slightly_smiling_face: | 15:19 |
| *** khyr0n has quit IRC | 15:32 | |
| *** khyr0n has joined #kata-dev | 15:33 | |
| *** jodh has quit IRC | 17:02 | |
| *** fgiudici has quit IRC | 18:01 | |
| kata-irc-bot | <eric.ernst> We're having fun. :slightly_smiling_face: | 18:54 |
| *** devimc has quit IRC | 21:56 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!