| kata-irc-bot | <fidencio> @jakob.naucke, you've expanded the script to toggle the sandbox_cgroup_only option, and I'd like to know what's your take on parameters that would either be commented out or present there, rather than switching a default by a different one. | 13:41 |
|---|---|---|
| kata-irc-bot | <fidencio> I'm tending to just `sed` the script and be happy about that, but I would like to double check whether you had plans for expanding the set_kata_config.sh | 13:42 |
| kata-irc-bot | <jakob.naucke> No, no plans for expanding that script. However, I don't quite understand what you mean by > parameters that would either be commented out or present there, rather than switching a default by a different one While we're at it, I should say that I have some remorse about whether I over-engineered `set_kata_config.sh`, given I could have used three lines of `crudini`, given how many times we just use `crudini`, given how many times we | 15:13 |
| kata-irc-bot | just use `sed`... | 15:13 |
| kata-irc-bot | <fidencio> I was thinking about a case like https://github.com/kata-containers/tests/pull/3803/files#diff-7b436cb5923ba7f66ccf2e140b342330400dcb1d6776d03444564dc34c5379f1R102 | 15:15 |
| kata-irc-bot | <jakob.naucke> Hmm. One beautiful thing about `crudini` is that it has an understanding of sections, which isn't really possible with `sed`. But I think `crudini` isn't built for commented fields, which we do use in Kata. It's debatable whether it's better to do this in a script, or just `sed` like you are currently doing. You could expand the script if you want to. | 15:21 |
| kata-irc-bot | <dan.middleton> looks like y’all use github actions. if I come across jenkins files are those detritus? and is it helpful if I remove them? | 21:59 |
| kata-irc-bot | <eric.ernst> Hey Dan. Both are utilized | 22:54 |
| kata-irc-bot | <eric.ernst> So, when in doubt, don’t remove :) | 22:56 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!