| kata-irc-bot | <simon.kaegi> hmm... let me try some variations but I believe this was for the case where `optional: true` was specified but the configmap/secret was not present | 03:50 |
|---|---|---|
| kata-irc-bot | <simon.kaegi> oh interesting... this fails also if the configmap or secret is present "but" it's empty | 04:14 |
| kata-irc-bot | <eric.ernst> Interesting. Can you reproduce on 2.1 Kata? | 05:00 |
| kata-irc-bot | <eric.ernst> I’m wondering if this may be dealing w watchable mount handling that was introduced in the 2.2 release timeframe. | 05:01 |
| kata-irc-bot | <archana.m.shinde> +1 for going with useradd rather than updating files manually | 05:55 |
| kata-irc-bot | <christophe> Interested in getting feedback on the "pod API" https://github.com/kata-containers/kata-containers/issues/2637 | 06:13 |
| kata-irc-bot | <simon.kaegi> yep seems to be a 2.2 problem - 2.1 worked. | 15:19 |
| kata-irc-bot | <fidencio> @eric.ernst, do you take it over from here? :slightly_smiling_face: | 15:29 |
| kata-irc-bot | <eric.ernst> ugh. | 17:02 |
| kata-irc-bot | <eric.ernst> yeah, let me TAL right away. | 17:02 |
| kata-irc-bot | <eric.ernst> Looks like the path must not be created until the first copy is carried out. | 17:22 |
| kata-irc-bot | <feng.wang> @eric.ernst @fidencio can you two please approve the PR if there is no more feedback? | 18:16 |
| kata-irc-bot | <eric.ernst> @fidencio you had some outstanding comments? https://github.com/kata-containers/kata-containers/pull/2432/files#r705706048 | 18:23 |
| kata-irc-bot | <feng.wang> I have added a defer block in line 309. Let me if that addressed the concern. @fidencio @eric.ernst | 18:24 |
| kata-irc-bot | <eric.ernst> Left 2 more nits for questions that I think were unresolved. | 18:26 |
| kata-irc-bot | <eric.ernst> The defer on that line looks good — just want to give fabiano a chance to resolve the query | 18:27 |
| kata-irc-bot | <feng.wang> Thanks. I’ll look into them. | 18:28 |
| kata-irc-bot | <fidencio> If CI is green, I'm fine merging it. :slightly_smiling_face: | 19:26 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!