| kata-irc-bot | <samuel.ortiz> Hey @jakob.naucke | 09:06 |
|---|---|---|
| kata-irc-bot | <samuel.ortiz> I see the s390x CI failing, with: | 09:07 |
| kata-irc-bot | <samuel.ortiz> ```kata-check_s390x_test.go:59:16: fieldalignment: struct with 24 pointer bytes could be 16 (govet) type testData struct { ^``` | 09:07 |
| kata-irc-bot | <samuel.ortiz> Which, afaik, is new… | 09:07 |
| kata-irc-bot | <samuel.ortiz> The ARM CI is failing as well, with another nitpicker. | 09:08 |
| kata-irc-bot | <jakob.naucke> Yes, we enthusiastically added !x86 static checks without noticing that in testing, they were only run upon the tests repo in https://github.com/kata-containers/tests/pull/4027. https://github.com/kata-containers/kata-containers/pull/2774 fixes what you're referring to here, but there are more issues that I am currently looking at. Sorry, was out sick yesterday. | 09:10 |
| kata-irc-bot | <samuel.ortiz> Oh no worries. I hope you’re feeling better today. | 09:11 |
| kata-irc-bot | <samuel.ortiz> I pinged you to check if you had a fix already or if I should start looking at it. | 09:11 |
| kata-irc-bot | <samuel.ortiz> Ah, I see, you’re looking at the next issue then… | 09:13 |
| kata-irc-bot | <samuel.ortiz> @jakob.naucke @james.o.hunt @bergwolf Could one of you please look at https://github.com/kata-containers/kata-containers/pull/2769 ? | 09:18 |
| kata-irc-bot | <gkurz> @samuel.ortiz Hi ! I had a question you haven't answered yet : https://github.com/kata-containers/kata-containers/pull/2769/files/a44cde7e8dda2bd501ceff8226e18178366c9f5e#diff-c60c57e960a9b[…]db8feab8c65dd14e09c ... maybe not a big deal, I'm still learning :slightly_smiling_face: | 10:32 |
| kata-irc-bot | <samuel.ortiz> @gkurz Hey! Sorry, I do not see your question :S | 10:34 |
| kata-irc-bot | <samuel.ortiz> @gkurz Sorry if I’m just missing it… | 10:36 |
| kata-irc-bot | <gkurz> weird... it's about the version bump in src/runtime/go.sum ... your change adds two lines but only removes one | 10:36 |
| kata-irc-bot | <samuel.ortiz> @gkurz I swear I don’t see any comment/question there. | 10:37 |
| kata-irc-bot | <samuel.ortiz> Anyhow, this was generated by `go mod` …I don’t think I want to manually mess with it? | 10:38 |
| kata-irc-bot | <gkurz> @samuel.ortiz oh... I didn't know that was auto-generated... and I don't know why github won't you show my question either :S | 10:40 |
| kata-irc-bot | <samuel.ortiz> Super weird. Sorry to ask, but did you actually bush the “comment” button? It may be pending on your local github view? | 10:41 |
| kata-irc-bot | <jakob.naucke> Could it be that the comment was made on a commit that had already been force-pushed over at the time of commenting? In that case, comments do not show up on the PR AFAIK. | 10:45 |
| kata-irc-bot | <gkurz> I remember I had pressed the green "start a review" button last time | 10:47 |
| kata-irc-bot | <gkurz> this time I've just pressed "add single comment" | 10:47 |
| kata-irc-bot | <jakob.naucke> @gkurz we can see your comment now | 10:48 |
| kata-irc-bot | <samuel.ortiz> When you do “start a review”, you need to finish it for the comments to show up. | 10:48 |
| kata-irc-bot | <samuel.ortiz> We can see them, yes. Thanks @gkurz | 10:48 |
| kata-irc-bot | <gkurz> ha ha that was it then ! | 10:48 |
| kata-irc-bot | <jakob.naucke> @gkurz ah that was it. Yes, when you "start a review", the comments are marked as "pending", and you have to finish it. This functionality exists to have fewer notifications and to have multiple related comments be published at the same time. | 10:50 |
| kata-irc-bot | <gkurz> @jakob.naucke ok I get it. I guess this only makes sense when you have a lot to say on the PR, hence the review wording :slightly_smiling_face: | 10:52 |
| kata-irc-bot | <samuel.ortiz> @gkurz Or when you start a review and you’re not sure how much you’re going to say :slightly_smiling_face: | 10:53 |
| kata-irc-bot | <bergwolf> Folks, please note that today's AC meeting is canceled. Enjoy your day and let's meet next week! | 14:34 |
| kata-irc-bot | <eric.ernst> Hey ya’ll — anyone use macvtap these days? | 17:43 |
| kata-irc-bot | <eric.ernst> @simon.kaegi @feng.wang @efoster @bergwolf | 17:43 |
| kata-irc-bot | <feng.wang> We don’t. | 17:44 |
| kata-irc-bot | <eric.ernst> tc-filter has been default for a while. We’re looking at some refactoring around networking to clean things up, but the macvtap is certainly a lot more complex. | 17:44 |
| kata-irc-bot | <simon.kaegi> Not me but I'd have to ask for our iaas | 17:45 |
| kata-irc-bot | <eric.ernst> @crowther @christophe ^ | 17:46 |
| kata-irc-bot | <simon.kaegi> @pradipta.banerjee ^^ | 17:48 |
| kata-irc-bot | <eric.ernst> Thanks Jacob. OK. I’ll open an RFC issue for dropping macvtap | 18:03 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!