| kata-irc-bot | <fidencio> @ssheribe, morning! > Having a library as Kir is working on would be great Agree, but it's a long term thing (as in, not going to happen this year). > We don't really use libcontainer with this PR (i mean, we may use some string manipulation functions... as it's not a core utility I'd ignore it, can also be removed) Ack. I don't think it's worth removing it / reimplementing something. And thanks for clarifying that only some | 06:28 |
|---|---|---|
| kata-irc-bot | utilities are used from libcontainers. > AFAICT libcontainer also wouldn't work for kata + systemd's cgroups driver, since runc v1.0.0-rc90/v1.0.0-rc1 (we bumped to 1.0.1) it's broken for the kata use case, unfortunately we missed that due to missing tests and hidden webhook failure What's broken exactly with libcontainers? Have you checked that 1.0.2 is also broken? We can influence in the release of 1.0.3 in case we need patches from there. | 06:28 |
| kata-irc-bot | By the way, the libcontainers discussion is about how we'll go in the short-term future, *NOT* to replace the fixes you and Greg are working on for now. | 06:28 |
| kata-irc-bot | <ssheribe> @fidencio morning, so AFAIU, the issue with libcontianer cgroups is that it's intended to set them for containers, we are using it also to set cgroups for the shim itself. It seems to me the issue is that there's a requirement (with systemd cgroups) to freeze the process before setting cgroups, as we are setting cgroups on the same process we are running on (instead of a container), it get stuck / freezes itself. • There are comments | 06:46 |
| kata-irc-bot | the runc code why it's needed, i didn't get it through • It doesn't seems to be done with all cgroups libraries, I'm not sure why (i suppose it requires only for container processes) • libcontainer used to operate differently until b810da149008f1d7d07f481970d40c0d035958af , hence, it used to work until then | 06:46 |
| kata-irc-bot | <fidencio> Ack, I'll go through the commit sooner than later. I'll also open an issue on kata-containers side and loop everyone here, plus Kir, plus Mrunal, and we can concentrate all the discussions (and action items) there Thanks for the pointer, Snir. | 07:15 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!