| kata-irc-bot | <dgibson> Anyone know what policy/norms there are about Rust version usage | 05:55 |
|---|---|---|
| kata-irc-bot | <dgibson> I have a draft PR which is fine on the 1.54 Rust that's used on most of the CI, but not on the 1.47.0 that's used for ARM and s390x | 05:56 |
| kata-irc-bot | <eric.ernst> Is there a reason these are on older version? I'd rather see them move forward. | 06:11 |
| kata-irc-bot | <fidencio> I am always worried that some downstreams may hit some issues later on by using a too old version of rust on their own | 07:42 |
| kata-irc-bot | <fidencio> But I assume you're checking that inside Red Hat. | 07:42 |
| kata-irc-bot | <jakob.naucke> I'll TAL, I was aware 1.47 was still used in some places, but unaware those were architecture-specific. It's possible we held it back at some point, as Rust 1.50 was pretty much completely borked on s390x. | 09:44 |
| kata-irc-bot | <fidencio> Hey all! I'd appreciate some easy acks on https://github.com/kata-containers/kata-containers/pull/3010 and https://github.com/kata-containers/tests/pull/4178 Those are for 2.3.0-rc1 release, which fix the issues we had when releasing 2.3.0-rc0. | 18:03 |
| kata-irc-bot | <fidencio> @wmoschet, I am adding an action to make sure `cargo audit` is happy with our rust code | 18:27 |
| kata-irc-bot | <fidencio> That was discussed during the KVM Forum, IIRC, with Andreea | 18:27 |
| kata-irc-bot | <fidencio> And I think you even opened an issue upstream | 18:27 |
| kata-irc-bot | <fidencio> I will CC you there for a review as soon as I have it | 18:27 |
| kata-irc-bot | <wmoschet> cool. yeah, add me as reviewer. Recently I played with gh actions so it is fresh on my mind (in a few weeks I will be like: "what's actions about?") | 18:29 |
| kata-irc-bot | <fidencio> Thanks god your memory is way better than mine | 18:29 |
| kata-irc-bot | <wmoschet> lol | 18:29 |
| kata-irc-bot | <fidencio> I usually forget things hours later | 18:29 |
| kata-irc-bot | <jakob.naucke> No. It's because that instance simply still has 1.47.0 installed and our scriptery doesn't update it and on freshly provisioned instances, you wouldn't notice. | 18:55 |
| kata-irc-bot | <jakob.naucke> ah, but it will when you bump the minimum version @dgibson | 18:56 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!