kata-irc-bot | <fidencio> @gkurz, may I bother you for a review on https://github.com/kata-containers/kata-containers/pull/3669 ? | 08:12 |
---|---|---|
kata-irc-bot | <gkurz> Sure ! It is certainly a good idea to use announce_submounts | 08:26 |
kata-irc-bot | <fidencio> @gkurz, then an approval would be very much appreciated. :slightly_smiling_face: | 08:30 |
kata-irc-bot | <samuel.ortiz> Hey @bergwolf! Are you able to reach out to @jimmy488 to get an answer about https://github.com/kata-containers/kata-containers/pull/3110 ? | 14:27 |
kata-irc-bot | <samuel.ortiz> Not sure if he works with you or not, trying my luck :slightly_smiling_face: | 14:27 |
kata-irc-bot | <jakob.naucke> @fidencio @james.o.hunt I don't want to be impolite, but maybe notifications are just not sent after a closed PR: Have you seen my comment on https://github.com/kata-containers/tests/pull/4385#issuecomment-1019991100? | 16:13 |
kata-irc-bot | <fidencio> Not being unpolite at all | 16:14 |
kata-irc-bot | <fidencio> I missed that, genuinely missed that. | 16:14 |
kata-irc-bot | <fidencio> What I think that should happen is: • Break the static-checks CI in several small targets, the static checks script already spports that • Have the force-skip-ci present but only for things that will not leave the CI broken if merged (as in the commit shortlog check) | 16:15 |
kata-irc-bot | <fidencio> While still here, if I didn't reply to something on GitHub in 2 days, maximum, *please*, do exactly what you did here and ping me. | 16:16 |
kata-irc-bot | <jakob.naucke> hmm good call | 16:18 |
kata-irc-bot | <jakob.naucke> Thanks! | 16:18 |
kata-irc-bot | <james.o.hunt> @jakob.naucke - +1 to @fid@fidencio’s comments. And yes, given the amount of mail we both receive, Slack is the only reliable way of contacting us imho :) It's very easy to miss GH pings. | 16:42 |
kata-irc-bot | <jakob.naucke> @james.o.hunt now I want to know though: can you tell whether the email was actually sent or are mails just not sent after close? | 16:43 |
kata-irc-bot | <james.o.hunt> Can't tell you for sure as I've deleted it but I think we should have received it. Having said that, we do occasionally have problems with GH either not sending emails, or having mails blocked, blah. | 16:45 |
kata-irc-bot | <fidencio> I did receive it. | 16:45 |
kata-irc-bot | <jakob.naucke> @fidencio thanks! | 16:48 |
kata-irc-bot | <ssheribe> @wmoschet Hi, Is it possible to login in with serial console to Vagrant VM? cc @samuel.ortiz | 16:50 |
kata-irc-bot | <jakob.naucke> I just realised that we wouldn't run those in Jenkins anyway, they run on GHA. So I think that really just the comment needs an update. | 16:56 |
kata-irc-bot | <fidencio> You run, don't you? | 17:01 |
kata-irc-bot | <fidencio> I am pretty sure you run, otherwise we wouldn't have caught the issues we caught | 17:03 |
kata-irc-bot | <fidencio> But I think you guys run it in a different way on baremetal | 17:03 |
kata-irc-bot | <jakob.naucke> We run `--arch-only` at this point, but we might not have back then | 17:09 |
kata-irc-bot | <jakob.naucke> `--only-arch` it is. It was merged the same day, I'm not sure about the detailed order. | 17:10 |
kata-irc-bot | <wmoschet> hi @ssheribe, I never tried but it should be possible. I don't think it has such as facility out-of-box so likely you will need to add the serial device and configurations manually. Remember that the way Vagrant is setup in our project it will be using libvirt under the hoods | 18:51 |
kata-irc-bot | <fidencio> @wmoschet, does virsh show the vagrant machine? | 19:29 |
kata-irc-bot | <fidencio> If so, `virsh console` should do the trick | 19:29 |
kata-irc-bot | <wmoschet> it does @fidencio | 19:29 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!