| kata-irc-bot | <gkurz> Hi ! Does someone understand what's happening in this static check ? https://github.com/kata-containers/kata-containers/runs/5547471142?check_suite_focus=true#step:11:689 | 09:01 |
|---|---|---|
| kata-irc-bot | <fidencio> Looking at the error: ``` Running checkcommits version 0.0.1 (commit 55a477071dd73bdb188be317a3ef24233b3b87da) Found 1 commit between commit HEAD and branch main ERROR: No "Fixes" found ERROR: checkcommits failed. See the document below for help on formatting commits for the project.``` | 09:03 |
| kata-irc-bot | <gkurz> this is the latest merge commit in the tests repo | 09:04 |
| kata-irc-bot | <gkurz> ```commit 55a477071dd73bdb188be317a3ef24233b3b87da (HEAD -> main, origin/main, origin/HEAD) Merge: c56960746f53 b85668a9d9d3 Author: Julio Montes <julio.montes@intel.com> Date: Mon Mar 14 10:20:09 2022 -0600 Merge pull request #4196 from cmaf/tracing-test-move-ci tracing: Move tracing test to different job``` | 09:04 |
| kata-irc-bot | <fidencio> The merge commit itself doesn't have the "Fixes: " | 09:05 |
| kata-irc-bot | <gkurz> and AFAICS there are no 'Fixes:' tags in merge commits | 09:05 |
| kata-irc-bot | <fidencio> As that's auto-generated when you click the "merge" button | 09:05 |
| kata-irc-bot | <fidencio> Check the commit that was actually merged | 09:05 |
| kata-irc-bot | <fidencio> Anyways, the guy seems to have the "Fixes: " on his commit: ```runtime/virtcontainers: Pass the hugepages resources to agent The hugepages resources claimed by containers should be limited by cgroup in the guest OS. Fixes: kata-containers#3695``` | 09:06 |
| kata-irc-bot | <gkurz> yes, we've guided him to have a proper commit message | 09:06 |
| kata-irc-bot | <fidencio> Let me re-run the test | 09:06 |
| kata-irc-bot | <fidencio> So, the person has to adjust the commit message to: ```Fixes: #3695``` or ```Fixes: github.com/kata-containers/...``` | 09:10 |
| kata-irc-bot | <gkurz> hmmm... ok, this cannot match the Fixes: line in the commit | 09:10 |
| kata-irc-bot | <gkurz> I could have found that... | 09:10 |
| kata-irc-bot | <steven> They also have a mismatch in the DCO check: `0dae697a30aa4f0803406bd8b32b9f85f85debf7 Expected "miao.xia <xia.miao1@zte.com.cn>", but got "Miao Xia <xia.miao1@zte.com.cn>".` if you weren’t aware of that? | 09:11 |
| kata-irc-bot | <gkurz> yes, I've commented on it and provided steps to fix that. | 09:11 |
| kata-irc-bot | <gkurz> @fidencio PTAL at https://github.com/kata-containers/kata-containers/commit/0dae697a30aa4f0803406bd8b32b9f85f85debf7.patch | 09:13 |
| kata-irc-bot | <gkurz> ```Fixes: https://github.com/kata-containers/kata-containers/issues/3695``` | 09:13 |
| kata-irc-bot | <gkurz> this still doesn't match the regex in the script but it is different from what you pasted ^^ | 09:14 |
| kata-irc-bot | <fidencio> Yeah, I sincerely think we should expand the script to accept a link to the issue | 09:16 |
| kata-irc-bot | <fidencio> exactly, please, open an issue for that. | 09:18 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!