| kata-irc-bot | <meng.mobile> Deserve opening an enhancement issue? or just noise to dismiss? @eric.ernst @fidencio | 06:21 |
|---|---|---|
| kata-irc-bot | <fidencio> I'd say it's always worth opening an enhancement request. The hard(est) part is to find someone to work on that considering we have other simpler options to solve the problem. But it's worth opening. | 06:34 |
| kata-irc-bot | <cameron4mcdermott> okay ill get those fixed up and push again. In the meantime do you think the PR will need any backports? | 08:12 |
| kata-irc-bot | <fidencio> It will! :slightly_smiling_face: | 08:32 |
| kata-irc-bot | <fidencio> And I can take care of that | 08:32 |
| kata-irc-bot | <cameron4mcdermott> nice, many thanks | 08:40 |
| kata-irc-bot | <cameron4mcdermott> I see the commit check is still failing at the moment. I think I missed the bit about the line lengths when I was looking through the contributing docs, would you like me to fix that as well? | 08:44 |
| kata-irc-bot | <cameron4mcdermott> ive pushed a new commit that should fix that | 08:58 |
| kata-irc-bot | <fidencio> Thanks, Cameron, very much appreciated. I am opening an issue in our tests repo as we should have an integration test to cover that case. | 09:05 |
| kata-irc-bot | <fidencio> I will open the issue, describe how I, personally, would test that, and if you have time / cycles / willingness to work on that, that would also be very much welcome. | 09:06 |
| kata-irc-bot | <fidencio> Also, bear with us if it takes some time to have it merged / properly debugged, but I think there may be more things wrong with the chronyd service and how we're building the image. I will try to take a look at that, unless @archana.m.shinde has some cycles and beat me on that. | 09:17 |
| kata-irc-bot | <cameron4mcdermott> Okay no problem, all good from my perspective. Feel free to send the issue from the test repo over when its created and I will give it a look over | 09:28 |
| kata-irc-bot | <gong_ys2004> yes，we are using rook ceph as csi, which provides volumes for kata containers. | 15:34 |
| kata-irc-bot | <chelsea.e.mafrica> FYI the was bug resolved in the PR linked to this issue | 16:30 |
| kata-irc-bot | <cameron4mcdermott> @fidencio my apologies, just realised the initial sed I committed did not work, when I tested it I had not cleaned the build cache between the builds I did, one to remember for the future! | 18:28 |
| kata-irc-bot | <fidencio> Thanks, Cameron! | 18:28 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!