| *** jtriley has joined #kolla | 00:07 | |
| *** achanda has quit IRC | 00:16 | |
| *** dims has quit IRC | 00:22 | |
| *** jasonsb_ has quit IRC | 00:29 | |
| *** jasonsb has joined #kolla | 00:30 | |
| *** jasonsb has quit IRC | 00:34 | |
| *** jtriley has quit IRC | 00:59 | |
| *** dims has joined #kolla | 01:00 | |
| *** achanda has joined #kolla | 01:17 | |
| *** britthouser has joined #kolla | 01:17 | |
| *** erkules_ has joined #kolla | 01:20 | |
| *** sdake_ has quit IRC | 01:21 | |
| *** achanda has quit IRC | 01:22 | |
| *** erkules has quit IRC | 01:22 | |
| *** jasonsb has joined #kolla | 01:23 | |
| *** achanda has joined #kolla | 01:58 | |
| *** jtriley has joined #kolla | 02:16 | |
| *** jtriley has quit IRC | 02:21 | |
| *** sdake has joined #kolla | 02:22 | |
| *** dims_ has joined #kolla | 02:35 | |
| *** dims has quit IRC | 02:37 | |
| *** britthouser has quit IRC | 02:51 | |
| *** britthouser has joined #kolla | 02:53 | |
| SamYaple | morning people | 02:54 |
|---|---|---|
| SamYaple | sdake: got the modules already and working | 02:54 |
| sdake | hey samyaple | 02:54 |
| sdake | cool so we are ticking with the modules you wrote then? | 02:54 |
| SamYaple | since there are no other alternatives, yea | 02:55 |
| sdake | well we could ue the modules from osad | 02:55 |
| sdake | but its not lie ka big thing eithe way | 02:55 |
| SamYaple | it isnt merged into the main branch yet | 02:55 |
| SamYaple | probably wont for a week or two | 02:55 |
| sdake | if what you have is working and implemented its a very small part of our codebae | 02:55 |
| sdake | i see | 02:55 |
| sdake | well we can't wait that long | 02:55 |
| SamYaple | pep8 gate needs to ignore ansible modules | 02:55 |
| SamYaple | https://review.openstack.org/#/c/199463/ | 02:56 |
| sdake | that is easy enough | 02:56 |
| sdake | let me switch networks to find example of how its done | 02:57 |
| sdake | nm already on correct network | 02:57 |
| SamYaple | I could clena up most of those errors, but the wildcard import stays. period | 02:57 |
| SamYaple | the rest are ansible style choices | 02:57 |
| SamYaple | im just following most modules style | 02:57 |
| sdake | [flake8] | 02:58 |
| sdake | # H803 skipped on purpose per list discussion. | 02:58 |
| sdake | # E125 is deliberately excluded. See https://github.com/jcrocholl/pep8/issues/126 | 02:58 |
| sdake | # E711 is ignored because it is normal to use "column == None" in sqlalchemy | 02:58 |
| sdake | # The rest of the ignores are TODOs | 02:58 |
| sdake | # New from hacking 0.9: E129, E131, H407, H405, H904 | 02:58 |
| sdake | # E251 Skipped due to https://github.com/jcrocholl/pep8/issues/301 | 02:58 |
| sdake | ignore = E121,E122,E123,E124,E125,E131,E251,H302,H405,H803,H904,E711 | 02:58 |
| sdake | exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools,magnum/common/pythonk8sclient | 02:58 |
| sdake | sorry i guess I shoudl have pasted that | 02:58 |
| sdake | anyway this is from magnum | 02:58 |
| sdake | can you insert a patch in front of the one you have there | 02:58 |
| sdake | that does the exclusion list | 02:58 |
| sdake | you can probably keep the ignore rules out | 02:59 |
| sdake | I'm not sure if flake8 has hit our rep yet - let me check that out | 02:59 |
| SamYaple | going to have to ignore H303 and H403, probably H231 as well | 02:59 |
| SamYaple | Ansible is not even close to working with python 3.x. it doesn't even allow some of the "compatible" syntax | 03:00 |
| sdake | samyaple just ignore the modules entirely samyaple | 03:01 |
| sdake | are they in a specific directory? | 03:01 |
| SamYaple | yea | 03:01 |
| sdake | just add to tox.ini under flake8 the ignore list | 03:01 |
| sdake | sec let me find link | 03:01 |
| *** dims_ has quit IRC | 03:01 | |
| sdake | https://github.com/stackforge/kolla/blob/master/tox.ini#L66 | 03:02 |
| sdake | try adding there | 03:02 |
| sdake | insert a patch in your patch stream | 03:02 |
| sdake | git commit --allow-empty iirc | 03:02 |
| sdake | samyaple make sense? | 03:04 |
| sdake | justi ignore the entire directory | 03:04 |
| openstackgerrit | Sam Yaple proposed stackforge/kolla: Add temporary Ansible keystone modules https://review.openstack.org/199463 | 03:04 |
| sdake | or make pep8 complaint as much as possible | 03:04 |
| SamYaple | well see | 03:04 |
| sdake | please make as a separate commit if you can | 03:05 |
| SamYaple | ill never fisnish this ansible stuff | 03:05 |
| sdake | its coming along :) | 03:06 |
| sdake | what do you mean you will never finish ? :) | 03:06 |
| sdake | we need to get more people working on it | 03:06 |
| SamYaple | not when i have t oagain rebase so ill be 4 rebases in to actually work on nova | 03:06 |
| sdake | so its not just all you | 03:07 |
| SamYaple | we cant until there is a foundation. with 4 reabses deep and a week between reviews its not going to happen | 03:07 |
| SamYaple | not by the end of the month | 03:07 |
| sdake | ok i'll ask harmw to be fast and i'll be fast on the reviews as well | 03:07 |
| sdake | agree reviews have been slow | 03:08 |
| sdake | i have reviews outstanding for 2-3 days | 03:08 |
| openstackgerrit | Sam Yaple proposed stackforge/kolla: Add temporary Ansible keystone modules https://review.openstack.org/199463 | 03:08 |
| SamYaple | let me guess youre going to make me file a bug for this too | 03:09 |
| SamYaple | further delaying things | 03:09 |
| sdake | its been particularlly tough because of hte from source has created a bunch of rebasing | 03:09 |
| sdake | we dont have to have all of the containers running in ansible - i'd be satisified with the core services | 03:10 |
| sdake | in other words, neutron, nova, glance, keystone, db, amqp | 03:10 |
| SamYaple | probably wont happen and work well unless we actually commit. | 03:10 |
| sdake | ya we need to jsut ge tthe patches appoved | 03:10 |
| sdake | so other people can start running with them | 03:10 |
| SamYaple | with this tox.ini in a seperate commit we are probably a week and a half away from nova ansible merging | 03:10 |
| SamYaple | and that is written | 03:10 |
| sdake | speaking of that, I want to get my env setup so I can run these | 03:11 |
| sdake | your syaing putting tox.ini in a separate commit will add 10 days ? | 03:11 |
| SamYaple | now nova requires 4 patches to actually merge :) | 03:11 |
| SamYaple | so yes | 03:11 |
| openstackgerrit | Sam Yaple proposed stackforge/kolla: filter ansible/library from tox.ini https://review.openstack.org/200859 | 03:13 |
| sdake | are all the patches finished for nova? | 03:14 |
| SamYaple | locally. but i have to keep rebasing them | 03:14 |
| openstackgerrit | Sam Yaple proposed stackforge/kolla: Add temporary Ansible keystone modules https://review.openstack.org/199463 | 03:15 |
| sdake | you have to rebase because of the from source work? | 03:15 |
| SamYaple | no i have to rebase because i have (now) 3 pending ansible patches that nova depends on | 03:16 |
| SamYaple | well i suppose one is tox. so 2 pending and then this tox patch | 03:16 |
| sdake | if you keep them in one stream it makes approving them alot easier | 03:16 |
| sdake | otherwise its hard to tell what the deps are | 03:16 |
| sdake | where are theo ther patches? | 03:16 |
| SamYaple | its not. it says it before you scroll down | 03:16 |
| sdake | i dont understand whaty ou mean | 03:18 |
| SamYaple | https://review.openstack.org/#/c/199463/ | 03:18 |
| SamYaple | do you not see the big "DEPENDS ON" | 03:18 |
| SamYaple | ? | 03:18 |
| sdake | ya got it | 03:18 |
| sdake | any others that need reviewing? | 03:24 |
| sdake | that looks good minus a todo comment | 03:24 |
| sdake | but that point isn't a big deal | 03:24 |
| sdake | typically I'd be a little more aggressive on todos, but I am certain these todos will change so they wont get lost | 03:25 |
| SamYaple | https://review.openstack.org/#/c/199406/ | 03:25 |
| SamYaple | https://review.openstack.org/#/c/198520/ not need, but its been sitting for over a week... | 03:26 |
| openstackgerrit | Merged stackforge/kolla: Fixes an issue with AIO and galera clusters https://review.openstack.org/199406 | 03:30 |
| openstackgerrit | Merged stackforge/kolla: Add +x to Magnum's config-internal.sh scripts https://review.openstack.org/200645 | 03:31 |
| openstackgerrit | Merged stackforge/kolla: Add RabbitMQ image for Ubuntu https://review.openstack.org/200183 | 03:34 |
| sdake | samyaple ya people dont like their name attached to security fixes typically | 03:40 |
| SamYaple | yea thats just keep that open | 03:40 |
| SamYaple | better option there | 03:40 |
| sdake | let me ask a security guy to look and review the change - if he gives it thumbs up i'll approve monday | 03:41 |
| sdake | he doesn't work weekends ;) | 03:41 |
| SamYaple | the same one from before? | 03:41 |
| sdake | yup | 03:41 |
| SamYaple | that already has? | 03:41 |
| sdake | he hasn't +1'ed the review? | 03:42 |
| SamYaple | no ye just posted a generic link without looking at the review | 03:42 |
| sdake | yes | 03:42 |
| sdake | i'll ask him out of band to look at the review monday | 03:42 |
| sdake | not super man hard for me to remember everyone's requuests... | 03:43 |
| sdake | i'll end him mail now sec | 03:43 |
| *** sdake_ has joined #kolla | 03:45 | |
| sdake_ | there mail away | 03:46 |
| sdake_ | and i'll ask him via irc on monday as well | 03:46 |
| SamYaple | cool | 03:46 |
| sdake_ | if you could remind me monday it would be appreciated | 03:47 |
| sdake_ | if he hasn't reviewed by the morning | 03:47 |
| SamYaple | sure | 03:48 |
| sdake_ | ta | 03:48 |
| *** sdake has quit IRC | 03:49 | |
| *** sdake_ is now known as sdake | 03:54 | |
| *** jtriley has joined #kolla | 04:17 | |
| *** sdake has quit IRC | 04:19 | |
| *** jtriley has quit IRC | 04:22 | |
| openstackgerrit | Merged stackforge/kolla: Fix Horizon config-internal.sh permissions https://review.openstack.org/200841 | 05:50 |
| *** achanda has quit IRC | 07:17 | |
| *** achanda has joined #kolla | 07:22 | |
| *** achanda has quit IRC | 07:32 | |
| *** jtriley has joined #kolla | 09:19 | |
| *** jtriley has quit IRC | 09:24 | |
| openstackgerrit | Sam Yaple proposed stackforge/kolla: Ansible Nova w/ libvirt support https://review.openstack.org/200881 | 12:44 |
| *** jtriley has joined #kolla | 13:20 | |
| *** jtriley has quit IRC | 13:26 | |
| *** sdake has joined #kolla | 13:55 | |
| *** pbourke has quit IRC | 14:21 | |
| *** pbourke has joined #kolla | 14:22 | |
| *** sdake has quit IRC | 14:51 | |
| *** sdake has joined #kolla | 15:00 | |
| sdake | morning | 15:08 |
| *** achanda has joined #kolla | 17:06 | |
| *** achanda has quit IRC | 18:09 | |
| *** achanda has joined #kolla | 18:46 | |
| harmw | how is this important? https://blueprints.launchpad.net/kolla/+spec/enable-ntp-container | 19:14 |
| harmw | from a kolla perspective | 19:14 |
| harmw | hm | 19:17 |
| harmw | $ cat docker/centos/rdo/openvswitch/ovs-base/config-internal.sh | 19:17 |
| harmw | ../../../../common/openvswitch/ovs-base/config-external.sh | 19:17 |
| harmw | that doesn't look good | 19:17 |
| *** jtriley has joined #kolla | 19:23 | |
| *** jtriley has quit IRC | 19:28 | |
| *** sdake has quit IRC | 20:07 | |
| *** achanda has quit IRC | 20:18 | |
| *** achanda has joined #kolla | 20:18 | |
| *** achanda has quit IRC | 20:19 | |
| *** achanda has joined #kolla | 20:26 | |
| *** achanda has quit IRC | 20:35 | |
| *** sdake has joined #kolla | 21:43 | |
| *** sdake has quit IRC | 21:46 | |
| *** sdake has joined #kolla | 21:51 | |
| *** achanda has joined #kolla | 22:14 | |
| *** jasonsb has quit IRC | 22:32 | |
| *** jasonsb has joined #kolla | 22:32 | |
| *** achanda_ has joined #kolla | 22:36 | |
| *** jasonsb has quit IRC | 22:37 | |
| *** achanda has quit IRC | 22:38 | |
| *** achanda_ has quit IRC | 22:44 | |
| *** achanda has joined #kolla | 23:09 | |
| *** mandre has joined #kolla | 23:40 | |
| *** sdake has quit IRC | 23:56 | |
| *** sdake has joined #kolla | 23:57 | |
| sdake | harmw I am not quite sure but the docs say to install ntp | 23:58 |
| sdake | harmw if a link is wrong can you file a bug for it | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!