*** charlesw has joined #magnetodb | 00:37 | |
*** Viswanath has joined #magnetodb | 02:23 | |
*** miqui has joined #magnetodb | 02:24 | |
*** Viswanath has quit IRC | 02:26 | |
*** vivekd has joined #magnetodb | 02:45 | |
*** charlesw has quit IRC | 02:49 | |
*** charlesw has joined #magnetodb | 02:52 | |
*** charlesw has quit IRC | 04:17 | |
*** charlesw has joined #magnetodb | 04:19 | |
*** rushiagr_away is now known as rushiagr | 04:51 | |
*** miqui has quit IRC | 05:11 | |
*** charlesw has quit IRC | 05:13 | |
*** k4n0 has joined #magnetodb | 05:39 | |
*** ajayaa has joined #magnetodb | 06:40 | |
*** rushiagr is now known as rushiagr_away | 07:11 | |
*** rushiagr_away has quit IRC | 07:49 | |
*** rushiagr has joined #magnetodb | 08:25 | |
*** ajayaa has quit IRC | 08:54 | |
*** keith_newstadt has joined #magnetodb | 08:55 | |
rushiagr | https://review.openstack.org/#/c/132952/ is a simple change | 10:06 |
---|---|---|
rushiagr | can somebody help me with getting this merged? | 10:06 |
rushiagr | thanks in advance :) | 10:06 |
ikhudoshyn | rushiagr: hi, I'll take a look | 10:07 |
rushiagr | ikhudoshyn: thanks | 10:07 |
ikhudoshyn | rushiagr: could you pls describe yr case? I mean why do you want to set it up into another location | 10:10 |
ikhudoshyn | afaik devstack is being set up to /opt/stack all the time, not sure that other locations are supported at all | 10:11 |
rushiagr | ikhudoshyn: let's say I want to run it at a different location | 10:11 |
rushiagr | ikhudoshyn: no. In devstack you can change the destination directory to any location | 10:12 |
ikhudoshyn | if so then it would be nice if mdb integration will use that exact location | 10:12 |
rushiagr | ikhudoshyn: also, in the code, DEST_DIR is /opt/stack/new at all places. I would have loved to change it to /opt/stack, but I didn't do that in this change. I just abstracted out the value in a variable so that it is easy to change | 10:12 |
rushiagr | ikhudoshyn: that will be another change. Here, I'm just making sure that 'that another change' is a simple change | 10:13 |
rushiagr | ikhudoshyn: you know what I mean :) | 10:13 |
ikhudoshyn | i dont really object against having DEST_DIR variable )) | 10:13 |
ikhudoshyn | i'd just prefer these two (current and coming) patches to be a single one | 10:15 |
ikhudoshyn | so others could easily see the reason | 10:15 |
ikhudoshyn | btw did you look at how other incubated projects do it? | 10:16 |
rushiagr | ikhudoshyn: I don't know | 10:18 |
rushiagr | ikhudoshyn: I was having problems changing the path, as I needed to make edits at a lot of places | 10:18 |
rushiagr | ikhudoshyn: I fixed it by abstracting those things out into a variable | 10:18 |
rushiagr | I think this patch is a non-issue, and can be submitted independently of the other | 10:19 |
rushiagr | other=other upcoming patch | 10:19 |
ikhudoshyn | oh, man, sorry, i thought is't a part of devstack integration)) missed that | 10:19 |
ikhudoshyn | so no objections from my side) | 10:20 |
rushiagr | ikhudoshyn: np | 10:20 |
rushiagr | ikhudoshyn: :) | 10:20 |
rushiagr | ikhudoshyn: thanks :) | 10:20 |
ikhudoshyn | +2'd | 10:21 |
rushiagr | ikhudoshyn: awesome. Thanks! | 10:24 |
*** vivekd_ has joined #magnetodb | 10:25 | |
*** vivekd has quit IRC | 10:28 | |
*** vivekd_ is now known as vivekd | 10:28 | |
openstackgerrit | A change was merged to stackforge/magnetodb: Remove hardcoded values https://review.openstack.org/132952 | 11:33 |
*** ajayaa has joined #magnetodb | 11:42 | |
rushiagr | yay! | 11:54 |
*** vivekd has quit IRC | 12:18 | |
*** ajayaa has quit IRC | 13:45 | |
*** keith_newstadt has quit IRC | 14:02 | |
*** rushiagr is now known as rushiagr_away | 14:04 | |
*** charlesw has joined #magnetodb | 14:40 | |
*** rushiagr_away is now known as rushiagr | 14:51 | |
*** jeromatron has joined #magnetodb | 14:51 | |
*** rushiagr is now known as rushiagr_away | 14:52 | |
*** openstackgerrit has quit IRC | 14:55 | |
*** jeromatron has quit IRC | 15:02 | |
*** jeromatron has joined #magnetodb | 15:04 | |
*** rushiagr_away is now known as rushiagr | 15:05 | |
*** jeromatron has quit IRC | 15:22 | |
*** k4n0 has quit IRC | 15:27 | |
*** nunosantos has joined #magnetodb | 15:47 | |
*** jeromatron has joined #magnetodb | 15:54 | |
*** Viswanath has joined #magnetodb | 16:53 | |
*** Viswanath has quit IRC | 16:56 | |
*** openstackgerrit has joined #magnetodb | 17:49 | |
*** jeromatron has quit IRC | 17:58 | |
*** jeromatron has joined #magnetodb | 18:14 | |
*** rushiagr is now known as rushiagr_away | 18:43 | |
*** jeromatron has quit IRC | 18:47 | |
*** jeromatron has joined #magnetodb | 18:48 | |
*** jeromatron has quit IRC | 19:01 | |
*** jeromatron has joined #magnetodb | 19:01 | |
*** jeromatron has quit IRC | 19:29 | |
*** Viswanath has joined #magnetodb | 21:09 | |
*** Viswanath has quit IRC | 21:12 | |
*** charlesw has quit IRC | 21:18 | |
*** jeromatron has joined #magnetodb | 21:27 | |
*** jeromatron has quit IRC | 22:11 | |
*** jeromatron has joined #magnetodb | 22:11 | |
*** charlesw has joined #magnetodb | 22:31 | |
*** rushiagr_away is now known as rushiagr | 22:48 | |
*** miqui has joined #magnetodb | 22:50 | |
*** charlesw has quit IRC | 23:24 | |
*** keith_newstadt has joined #magnetodb | 23:39 | |
*** keith_newstadt has quit IRC | 23:42 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!