| *** gokrokve has joined #murano | 00:54 | |
| *** gokrokve has quit IRC | 01:38 | |
| *** TravT has quit IRC | 01:42 | |
| *** gokrokve has joined #murano | 03:02 | |
| *** gokrokve has quit IRC | 04:17 | |
| *** stan_lagun has joined #murano | 07:42 | |
| *** slagun has quit IRC | 07:46 | |
| openstackgerrit | Sergey Murashov proposed a change to stackforge/murano: Add new deployment tests https://review.openstack.org/97198 | 07:53 |
|---|---|---|
| sergmelikyan | dteselkin, https://blueprints.launchpad.net/murano/+spec/make-dynamicui-more-informative - I have updated your BP a little bit. | 08:12 |
| sergmelikyan | Set URL to google doc as url to full specification | 08:12 |
| dteselkin | sergmelikyan, ok, thanks | 08:17 |
| openstackgerrit | Sergey Kolekonov proposed a change to stackforge/murano: add pid directory deletion in murano setup script https://review.openstack.org/98056 | 08:20 |
| *** skolekonov has joined #murano | 08:20 | |
| openstackgerrit | Anastasia Kuznetsova proposed a change to stackforge/python-muranoclient: Create base set of tests for python-muranoclient https://review.openstack.org/97791 | 08:37 |
| sergmelikyan | tsufiev, can you look at https://review.openstack.org/97776 ? | 08:48 |
| sergmelikyan | I think it is quite straight-forward change, I am writing unit-tests and need this change. | 08:49 |
| sergmelikyan | dteselkin, ativelkov https://review.openstack.org/97776 :) | 08:49 |
| * sergmelikyan shamelessly pinging cores :) | 08:50 | |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Delay quick environment creation until it is really needed https://review.openstack.org/97188 | 09:00 |
| tsufiev | sergmelikyan, looking at it... | 09:06 |
| tsufiev | sergmelikyan, do you know why ruhe calls setUp() explicitly even if it simply calls parent method? | 09:08 |
| sergmelikyan | tsufiev, actually no, maybe some specific of testtools? | 09:14 |
| sergmelikyan | ruhe, ? | 09:14 |
| openstackgerrit | A change was merged to stackforge/murano: Fixes Python 2.6 compatibility in HeatStack class https://review.openstack.org/97930 | 09:16 |
| ruhe | tsufiev: sergmelikyan: yes, testtools enforces that | 09:18 |
| tsufiev | ok, approved | 09:19 |
| tnurlygayanov | one more commit for review https://review.openstack.org/#/c/97913/ | 09:30 |
| openstackgerrit | Sergey Murashov proposed a change to stackforge/murano: Add new deployment tests https://review.openstack.org/97198 | 09:32 |
| openstackgerrit | A change was merged to stackforge/murano: Migrate unit test to testtools https://review.openstack.org/97776 | 09:33 |
| ativelkov | tsufiev: in https://review.openstack.org/#/c/94368 by "normal YAML sequence" you mean the list? | 09:34 |
| tsufiev | ativelkov, yes | 09:34 |
| ativelkov | I see, thanks | 09:35 |
| tsufiev | YAQL uses terms 'sequence' and 'mapping' for Python's 'list' and 'dictionary' | 09:35 |
| tsufiev | ativelkov, also I've added @deprecate_class decorator | 09:36 |
| ruhe | tnurlygayanov: isn't murano-ci jobs supposed to be green here https://review.openstack.org/#/c/96491/ ? | 09:36 |
| ativelkov | tsufiev: having your own "deprecated" looks a little wrong for me | 09:37 |
| tsufiev | ativelkov, is there some common deprecator? | 09:37 |
| *** stanlagun has joined #murano | 09:37 | |
| igormarnat | ruhe: you mean, for Ubuntu? | 09:37 |
| ruhe | igormarnat: yes | 09:37 |
| ativelkov | yup, I am sure I saw one in oslo incubator | 09:37 |
| ativelkov | let me find it | 09:37 |
| tnurlygayanov | ruhe, I will check | 09:38 |
| ativelkov | yup https://github.com/openstack/oslo-incubator/blob/master/openstack/common/versionutils.py#L30 | 09:38 |
| tnurlygayanov | ruhe to fix problems with https://review.openstack.org/#/c/96491 need to merge https://review.openstack.org/#/c/97913/ | 09:39 |
| tnurlygayanov | rruhe the reason of this 'fail' - simultaneously executed automated tests on ubuntu and cent os in the same tenant | 09:40 |
| ruhe | tnurlygayanov: i don't see how deployment tests can affect tests on dashboard | 09:41 |
| tnurlygayanov | ruhe hm... yes, it is incorrect link. so, I will check CI configuration, looks like need to update jobs | 09:43 |
| tnurlygayanov | one more commit for CI https://review.openstack.org/#/c/97735 | 10:03 |
| tnurlygayanov | (for integration tests with deployments) | 10:03 |
| openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: Added DB migrations on Alembic https://review.openstack.org/96471 | 10:08 |
| ruhe | why is the file named murano-engine-with-deployment-tests.sh? we're not testing the engine, we're testing deployment, which includes the api and the engine | 10:10 |
| ruhe | folks, do we really need separate functional tests for the client? | 10:15 |
| ruhe | ... re https://review.openstack.org/#/c/97791/ | 10:16 |
| ruhe | our basic tests aren't stable yet | 10:16 |
| ruhe | deployment tests aren't ready yet | 10:16 |
| ruhe | i think that dashboard and dsvm tests is enough to make sure that python client is ok | 10:17 |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Change the way multiple values for dynamic UI 'type' attr are parsed https://review.openstack.org/94368 | 10:40 |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Change the way multiple values for dynamic UI 'type' attr are parsed https://review.openstack.org/94368 | 10:42 |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Change the way multiple values for dynamic UI 'type' attr are parsed https://review.openstack.org/94368 | 10:42 |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Delay quick environment creation until it is really needed https://review.openstack.org/97188 | 10:58 |
| openstackgerrit | A change was merged to stackforge/murano-dashboard: Move deployment history into environment details https://review.openstack.org/96491 | 11:04 |
| ruhe | after a discussion with tnurlygayanov and akuznetsova we figured out that functional tests might be needed. but we they'll be limited to API calls (it means no deployments) and they should run on OpenStack infrastructure, not on murano-ci | 11:10 |
| *** asalkeld has quit IRC | 11:26 | |
| openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: Added DB migrations on Alembic https://review.openstack.org/96471 | 11:34 |
| *** stanlagun has quit IRC | 11:56 | |
| *** stanlagun has joined #murano | 11:59 | |
| openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: Added DB migrations on Alembic https://review.openstack.org/96471 | 12:08 |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/murano-dashboard: Fix allow method of buttons at the Components page https://review.openstack.org/98090 | 12:18 |
| openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: Added DB migrations on Alembic https://review.openstack.org/96471 | 12:31 |
| openstackgerrit | Timur Nurlygayanov proposed a change to stackforge/murano-deployment: Creates jenkins job for automated tests for Engine https://review.openstack.org/97913 | 12:50 |
| openstackgerrit | Timur Nurlygayanov proposed a change to stackforge/murano-deployment: Creates jenkins job for automated tests for Engine https://review.openstack.org/97913 | 12:51 |
| openstackgerrit | Sergey Murashov proposed a change to stackforge/murano: Add new deployment tests https://review.openstack.org/97198 | 13:11 |
| openstackgerrit | Sergey Murashov proposed a change to stackforge/murano: Add new deployment tests https://review.openstack.org/97198 | 13:14 |
| openstackgerrit | Sergey Murashov proposed a change to stackforge/murano: Add new deployment tests https://review.openstack.org/97198 | 13:18 |
| openstackgerrit | Sergey Murashov proposed a change to stackforge/murano: Add new deployment tests https://review.openstack.org/97198 | 13:27 |
| ativelkov | Folks, I have a sudden idea: what about if we merge the Neutron classes (io.murano.lib.networks.Neutron) into the Core library (io.murano)? | 13:43 |
| ativelkov | It turns out that is is close to impossible to keep core classes (such as Instance) to be completely separated of Neutron specifics | 13:44 |
| ativelkov | Currently Instance ports are created within Neutron lib | 13:45 |
| ativelkov | which causes a lot of problems | 13:45 |
| stanlagun | +2 | 13:45 |
| ativelkov | So I would added port creation into the instance class | 13:47 |
| ativelkov | But this actually introduces a Neutron dependency into the Core. But that is probably OK | 13:47 |
| stanlagun | The fact that you have Neutron in core doesn't mean you have to use Neutron | 13:49 |
| *** TravT has joined #murano | 13:49 | |
| stanlagun | Or at least this statement can become true | 13:49 |
| ativelkov | Well, this will mean that Instance class will be unusable in non-neutron environments | 13:50 |
| ativelkov | There still may be use-cases for Nova-Network topologies | 13:50 |
| stanlagun | Networking can be extended to support nova-networking. This can be an implementation detail in the very same classes | 13:52 |
| ativelkov | That's true | 13:52 |
| ativelkov | So, I'll create a blueprint | 13:52 |
| stanlagun | You just get exceptions on most topologies | 13:52 |
| *** gokrokve has joined #murano | 14:01 | |
| *** sjmc7 has joined #murano | 14:07 | |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Return to the same AppCatalog page from the modal forms https://review.openstack.org/98115 | 14:07 |
| *** drupalmonkey has joined #murano | 14:09 | |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/murano-dashboard: Fix allow method of buttons at the Components page https://review.openstack.org/98090 | 14:17 |
| openstackgerrit | Ryan Peters proposed a change to stackforge/murano-dashboard: Filter available flavors for each service https://review.openstack.org/97904 | 14:18 |
| *** btully has joined #murano | 14:24 | |
| tsufiev | btully, hi! | 14:24 |
| tsufiev | btully, could you please look my comment at https://review.openstack.org/#/c/97582/ ? | 14:25 |
| btully | sure, but can you look at mine first? ;) | 14:25 |
| sjmc7 | :) | 14:25 |
| igormarnat | win-win:) | 14:26 |
| tsufiev | oh, sorry, didn't notice :) | 14:26 |
| btully | hehe no problem :) | 14:26 |
| *** gokrokve has quit IRC | 14:30 | |
| btully | with latest pull of master | 14:31 |
| btully | on catalog index page I see a disabled button "More Apps" at the bottom of the page | 14:31 |
| btully | is this a work in progress? | 14:31 |
| tsufiev | btully, it should already work | 14:34 |
| tsufiev | it is disabled when there are no more pages | 14:34 |
| btully | i only have 3 apps on my local dev environment | 14:35 |
| btully | so it's confusing to see a button that is disabled saying "More Apps" | 14:35 |
| tsufiev | while default limit is 6, so this is ok | 14:35 |
| btully | shouldn't I just not see a button? | 14:35 |
| tsufiev | hm... | 14:35 |
| btully | makes me feel like something is broken | 14:35 |
| btully | i keep clicking as if i will be able to see more apps | 14:36 |
| tsufiev | but that means that after cycling, e.g. 3 pages forward, user sees that 'More Apps' suddenly disappears | 14:36 |
| sjmc7 | what does horizon do in other places? | 14:36 |
| sjmc7 | nova instances, glance images etc | 14:36 |
| tsufiev | sjmc7, horizon uses link, which disappears | 14:37 |
| igormarnat | tsufiev, it seems correct behavior | 14:37 |
| igormarnat | tsufiev, no more apps, no "More apps", right? | 14:37 |
| sjmc7 | not saying horizon is always right, but deviation from the horizon guidelines should be justified | 14:37 |
| tsufiev | igormarnat, sounds reasonable | 14:37 |
| *** skolekonov has quit IRC | 14:37 | |
| tsufiev | ok, it's easy to change | 14:37 |
| tsufiev | btully, i've experimented with tile filling - added more text to description, and raised limit of chars shown in description | 14:39 |
| *** gokrokve has joined #murano | 14:39 | |
| tsufiev | there is always empty space under logo, no matter how many description there is | 14:39 |
| btully | I think I understand. So essentially, that "More Apps" button is the last button of a pagination UI? i.e., a "Next" button? | 14:40 |
| tsufiev | btully, exactly | 14:40 |
| btully | right, so i think if there is no "next" it probably makes sense to make the button disappear rather than just disable, IMHO | 14:41 |
| btully | right, because of the floats, the logo and description need to be certain heights, because we want the tiles to be all the same height. The space below the logo is not a bad thing IMHO as it gives separation and importance to the action buttons (add to env, quick deploy) | 14:42 |
| btully | gokrokve: your thoughts? | 14:43 |
| gokrokve | I tried to delete it once. The whole page was out of align then. It is better to disable elements on the page as div manipulation will be much easier. | 14:44 |
| gokrokve | I bet Timur remembers that issue with last page :-) When you have one or two apps on the last page button tends to align from right side to them rather then stay at the bottom of the page. | 14:45 |
| gokrokve | Space under logo is ok. It help to clearly distinguish main elements on the tile. | 14:46 |
| tsufiev | ok, let's the new tile then :) | 14:49 |
| tsufiev | *approve | 14:50 |
| btully | I think now the "More Apps" button is actually a div below the tiles, so doesn't really affect the tile layout. If it does affect layout in some odd way, perhaps then maybe attach visibility:hidden to the disabled More Apps button | 14:50 |
| btully | i think from a workflow of having many apps, it will become a learned behavior to the user to see the "More Apps" button not being disabled, and as a way to go to the next page of apps | 14:51 |
| btully | but in the edge case of not having many apps, it becomes odd just to see a button you cannot press | 14:52 |
| tsufiev | btully, you've convinced me :) | 14:52 |
| btully | haha sorry, am I "beating a dead horse" | 14:53 |
| btully | ? | 14:53 |
| btully | :) | 14:53 |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Hide 'More Apps' button if there are no more Apps https://review.openstack.org/98131 | 14:54 |
| tsufiev | here it is ^^^^ | 14:55 |
| btully | awesome. i'll review | 14:57 |
| btully | tsufiev: i'm currently reviewing https://review.openstack.org/#/c/98115/ | 14:58 |
| btully | in terms of a test case, should I be on the App Catalog index page to test this? And if so, how would I "create environment"? | 14:59 |
| tsufiev | btully, you need to come to AppCatalog page with Environments list (at Environments page) being empty | 15:00 |
| tsufiev | that way 'Add to Env' first creates a new Env | 15:01 |
| btully | ahh ok, good to know | 15:01 |
| btully | so delete my environments first? | 15:01 |
| tsufiev | yes, if you have nothing valuable there | 15:01 |
| btully | :) | 15:02 |
| btully | tsufiev: so when i do that, and click on an app's "add to env" button, it creates the new environment in the background and stays on the app catalog page, however it doesn't add the app to the env | 15:06 |
| tsufiev | that is true, you need to press the button 'Add to Env' again | 15:07 |
| tsufiev | theoretically, it is possible to redirect just to the wizard view right after creating a new env, but redirects may be a bit tricky | 15:08 |
| btully | hmm | 15:10 |
| btully | should we add something to the notification saying that the environment was created | 15:11 |
| * tsufiev looked again in the template... it might be very simple as well... | 15:12 | |
| tsufiev | that is the problem with 'Current Env' selector which is currently hidden | 15:12 |
| btully | right, that will change soon | 15:12 |
| btully | so ideally, if there are no environments created | 15:13 |
| btully | either the the "add to env" button text would change to say "create environment" | 15:13 |
| btully | or we'd have some kind of redirect after the env was created to then show the modal for adding the app | 15:14 |
| btully | or we'd add some text to the green notification popup saying that the user would need to click on "add to env" button again | 15:15 |
| btully | Does "quick deploy" do both the creation of env and adding the app? | 15:16 |
| openstackgerrit | A change was merged to stackforge/murano-dashboard: Updated app tile styling based on feedback https://review.openstack.org/97582 | 15:19 |
| sergmelikyan | btully, should does | 15:19 |
| sergmelikyan | *should do | 15:19 |
| tsufiev | btully, yes, it does | 15:20 |
| btully | so maybe if no env exists, we either hide the add to env button or have it act the same as a quick deploy button? | 15:21 |
| btully | or to contradict my earlier point about disabled butons, the add to env button is disabled ;) | 15:22 |
| tsufiev | btully, i think the best is to change 'Add to Env' -> 'Create Env' in that case | 15:23 |
| tsufiev | redirecting 'Create Env' -> 'Add App' is tricky indeed | 15:23 |
| btully | k | 15:24 |
| btully | does the index page get refreshed (i.e. is there an actual redirect) when the env is created? | 15:24 |
| btully | or will we have to update the button text using JS | 15:24 |
| openstackgerrit | A change was merged to stackforge/murano-dashboard: Handle dynamic forms in a cleaner and a more performance way https://review.openstack.org/94199 | 15:25 |
| ruhe | tnurlygayanov: akuznetsova: can you please take a look at https://review.openstack.org/#/c/97904/ and help to resolve -1 from murano-ci? | 15:29 |
| tnurlygayanov | yes | 15:29 |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Return to the same AppCatalog page from the modal forms https://review.openstack.org/98115 | 15:30 |
| tsufiev | btully, i've changed the 'Add to Env' button label for case with no environments ^^^^ | 15:31 |
| tsufiev | index page is refreshed | 15:31 |
| btully | oops | 15:31 |
| btully | awesome! you can ignore my comment on the code review then ;) | 15:32 |
| tsufiev | ok :) | 15:33 |
| tsufiev | by the way, there is notification in top right corner when an Environment is created | 15:33 |
| ruhe | sjmc7: do you mind if i reassign https://blueprints.launchpad.net/murano/+spec/filter-flavor-for-each-service to Ryan? it seems that he is working on this BP | 15:33 |
| btully | yes | 15:34 |
| sjmc7 | yeah, ruhe, thanks | 15:34 |
| btully | that was the notification i was suggesting we add text to | 15:34 |
| sjmc7 | i'm unable to edit that one | 15:34 |
| ruhe | sjmc7: done | 15:34 |
| btully | works like a charm tsufiev ! :D | 15:35 |
| tsufiev | nice :) | 15:35 |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add API unit tests https://review.openstack.org/98157 | 15:35 |
| ruhe | sjmc7: what milestone should i set for https://blueprints.launchpad.net/murano/+spec/api-unit-test-base ? | 15:43 |
| ruhe | sjmc7: actually you can set it :) | 15:43 |
| *** christop1eraedo has quit IRC | 15:45 | |
| *** christopheraedo has joined #murano | 15:46 | |
| *** gokrokve has quit IRC | 15:49 | |
| *** sergmelikyan has quit IRC | 15:59 | |
| sjmc7 | ruhe - yeah, i'll do it | 16:00 |
| *** stanlagun has quit IRC | 16:00 | |
| btully | Did we ever agree upon a better term for the "Latest Apps" heading on the catalog index page? | 16:03 |
| btully | also, if the apps under "latest apps" are apps that have either been recently deployed or added to an env, does it make sense that the tiles in that section have the action buttons? | 16:05 |
| *** sergmelikyan has joined #murano | 16:05 | |
| ruhe | sjmc7: one more thing about API tests. i suggest not to use DB migrations in these tests. just populate DB from SQLA metadata. There is a problem with them, they don't always work on sqlite. We went through a hell in StoryBoard to make this kind of tests work. | 16:07 |
| sjmc7 | they seem to work ok. the only workaround was for foreign key constraints | 16:08 |
| sjmc7 | so you mean just populate from models.py ? | 16:09 |
| ruhe | right | 16:09 |
| ruhe | one might rise a question - how can we make sure that DB migrations are in sync with what we populate from models.py? there is a patch to oslo-incubator (which is waiting for oslo.db release), which helps to that | 16:10 |
| ruhe | * to test that | 16:11 |
| sjmc7 | yeah, it makes sense to test the migrations separately | 16:11 |
| sjmc7 | ok, i'll make that change | 16:11 |
| ruhe | and i also have test for migrations here https://review.openstack.org/#/c/96471/ | 16:11 |
| sjmc7 | ok. i guess it'll be simpler and faster not to use the migrations each time | 16:12 |
| ruhe | you can take a look how it's done in openstack-infra/storyboard | 16:13 |
| *** sergmelikyan has quit IRC | 16:14 | |
| sjmc7 | ok, will do that | 16:15 |
| *** openstackgerrit has quit IRC | 16:20 | |
| *** openstackgerrit has joined #murano | 16:20 | |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add API unit tests https://review.openstack.org/98157 | 16:28 |
| sjmc7 | done ruhe, thanks | 16:28 |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Fix allow method of buttons at the Components page https://review.openstack.org/98090 | 16:32 |
| ruhe | already? you are ninja | 16:38 |
| sjmc7 | i just close my eyes and hammer at the keyboard | 16:49 |
| *** gokrokve has joined #murano | 17:27 | |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add API unit tests https://review.openstack.org/98157 | 19:07 |
| *** gokrokve_ has joined #murano | 19:26 | |
| *** gokrokve has quit IRC | 19:30 | |
| *** gokrokve_ has quit IRC | 19:38 | |
| *** gokrokve_ has joined #murano | 19:40 | |
| *** gokrokve_ has quit IRC | 19:57 | |
| *** gokrokve has joined #murano | 20:29 | |
| *** drupalmonkey has quit IRC | 20:29 | |
| *** gokrokve has quit IRC | 20:34 | |
| *** drupalmonkey has joined #murano | 20:36 | |
| *** gokrokve has joined #murano | 20:36 | |
| *** gokrokve has quit IRC | 20:47 | |
| *** asalkeld has joined #murano | 20:53 | |
| *** gokrokve has joined #murano | 21:44 | |
| *** drupalmonkey has quit IRC | 22:09 | |
| *** asalkeld is now known as asalkeld_afk | 22:22 | |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add API unit tests https://review.openstack.org/98157 | 22:33 |
| *** asalkeld_afk is now known as asalkeld | 23:05 | |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add API unit tests https://review.openstack.org/98157 | 23:26 |
| *** asalkeld has quit IRC | 23:31 | |
| *** asalkeld has joined #murano | 23:45 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!