| *** gokrokve has quit IRC | 00:08 | |
| *** gokrokve has joined #murano | 00:34 | |
| openstackgerrit | Brian Tully proposed a change to stackforge/murano-dashboard: Implement Horizon UI patterns https://review.openstack.org/99229 | 02:30 |
|---|---|---|
| *** ankurrr has quit IRC | 02:31 | |
| openstackgerrit | Brian Tully proposed a change to stackforge/murano-dashboard: Implement Horizon UI patterns https://review.openstack.org/99229 | 02:34 |
| *** gokrokve has quit IRC | 03:30 | |
| *** gokrokve has joined #murano | 03:42 | |
| *** gokrokve has quit IRC | 03:43 | |
| *** gokrokve has joined #murano | 04:34 | |
| *** gokrokve has quit IRC | 04:42 | |
| *** gokrokve has joined #murano | 05:12 | |
| *** gokrokve_ has joined #murano | 05:15 | |
| *** gokrokve has quit IRC | 05:17 | |
| *** gokrokve_ has quit IRC | 05:55 | |
| tnurlygayanov | sjmc7 hi! :) | 06:26 |
| *** gokrokve has joined #murano | 06:36 | |
| *** gokrokve has quit IRC | 06:41 | |
| *** stanlagun has joined #murano | 06:58 | |
| iyozhikov | :) | 07:12 |
| openstackgerrit | Igor Yozhikov proposed a change to stackforge/murano: Add package-update scripts https://review.openstack.org/98790 | 07:22 |
| *** gokrokve has joined #murano | 07:35 | |
| *** gokrokve_ has joined #murano | 07:37 | |
| *** gokrokve has quit IRC | 07:40 | |
| openstackgerrit | A change was merged to stackforge/murano: Make categories optional parameter https://review.openstack.org/98769 | 07:41 |
| *** gokrokve_ has quit IRC | 07:41 | |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 07:54 |
| openstackgerrit | A change was merged to stackforge/murano-dashboard: Fix allow method of buttons at the Components page https://review.openstack.org/98090 | 07:55 |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 07:59 |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 08:02 |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 08:04 |
| *** melodous has quit IRC | 08:11 | |
| *** gokrokve has joined #murano | 08:36 | |
| *** gokrokve has quit IRC | 08:41 | |
| openstackgerrit | Dmitry Teselkin proposed a change to stackforge/murano: Install python client from repo https://review.openstack.org/98752 | 09:13 |
| openstackgerrit | Dmitry Teselkin proposed a change to stackforge/murano: Install python client from repo https://review.openstack.org/98752 | 09:14 |
| *** gokrokve has joined #murano | 09:36 | |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Add versionutils from oslo to use @deprecated helper https://review.openstack.org/98388 | 09:39 |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Change the way multiple values for dynamic UI 'type' attr are parsed https://review.openstack.org/94368 | 09:39 |
| *** gokrokve has quit IRC | 09:41 | |
| *** gokrokve has joined #murano | 10:36 | |
| *** gokrokve has quit IRC | 10:41 | |
| *** ogelbukh has quit IRC | 11:18 | |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/murano-dashboard: Make categories field optional https://review.openstack.org/98770 | 11:27 |
| openstackgerrit | Anastasia Kuznetsova proposed a change to stackforge/murano-dashboard: Change image title in dashboard tests to avoid problem with parallel execution https://review.openstack.org/99341 | 11:32 |
| *** gokrokve has joined #murano | 11:36 | |
| *** gokrokve has quit IRC | 11:41 | |
| openstackgerrit | A change was merged to stackforge/python-muranoclient: Enable to set updating type for "Update package" https://review.openstack.org/98975 | 11:52 |
| openstackgerrit | A change was merged to stackforge/murano: Add API unit tests https://review.openstack.org/98157 | 11:53 |
| openstackgerrit | A change was merged to stackforge/murano: Fixed endless recursion loop when super() called in base class https://review.openstack.org/98576 | 11:53 |
| openstackgerrit | Anastasia Kuznetsova proposed a change to stackforge/murano-dashboard: Change image title in dashboard tests to avoid problem with parallel execution https://review.openstack.org/99341 | 11:56 |
| openstackgerrit | Anastasia Kuznetsova proposed a change to stackforge/murano-dashboard: Change image title in dashboard tests to avoid problem with parallel execution https://review.openstack.org/99341 | 12:12 |
| ruhe | murano core team, please go through the list of blueprints/bugs and corresponding reviews and make sure that you've cast your vote in gerrit | 12:17 |
| ruhe | https://launchpad.net/murano/+milestone/juno-1 | 12:17 |
| *** ogelbukh has joined #murano | 12:18 | |
| openstackgerrit | A change was merged to stackforge/murano-dashboard: Add the environment name to deploy modal header https://review.openstack.org/98553 | 12:34 |
| *** gokrokve has joined #murano | 12:36 | |
| *** asalkeld has quit IRC | 12:40 | |
| *** gokrokve has quit IRC | 12:41 | |
| tsufiev | guys, it's just the time to finish reviewing https://review.openstack.org/#/c/98115/ and https://review.openstack.org/#/c/99051/ | 12:52 |
| ativelkov | and https://review.openstack.org/#/c/98471/ as well, though it is not targeted for j1, a rview will be appreciated | 12:53 |
| ruhe | ativelkov: so, if it's not targeted, maybe we should postpone it to j2? | 12:56 |
| ruhe | with a promise to review it :) | 12:56 |
| ruhe | stanlagun: what's the real status of https://blueprints.launchpad.net/murano/+spec/muranopl-exception-handling ? | 12:56 |
| stanlagun | it is waiting for code review | 12:56 |
| ruhe | aha! please update status to "needs code review" | 12:57 |
| ruhe | tsufiev: what's the real status of https://blueprints.launchpad.net/murano/+spec/normalize-dashboard-pagination ? | 12:58 |
| tsufiev | ruhe, it is waiting for adding 'Previous' button | 12:58 |
| tsufiev | i plan to do it today, once I finish with UI for actions | 12:58 |
| openstackgerrit | Anastasia Kuznetsova proposed a change to stackforge/murano-dashboard: Change image title in dashboard test https://review.openstack.org/99341 | 12:59 |
| ativelkov | ruhe - yes, it is ok to postpone it. It is actually up to dteselkin and his MS SQL Cluster | 13:00 |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 13:03 |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 13:04 |
| openstackgerrit | A change was merged to stackforge/murano-dashboard: Fix a typo which caused an error during exception branch https://review.openstack.org/99051 | 13:06 |
| *** katyafervent is now known as katyafervent_awa | 13:10 | |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Draft implementation of Actions UI https://review.openstack.org/99360 | 13:16 |
| openstackgerrit | A change was merged to stackforge/murano-dashboard: Return to the same AppCatalog page from the modal forms https://review.openstack.org/98115 | 13:29 |
| *** gokrokve has joined #murano | 13:36 | |
| *** gokrokve has quit IRC | 13:41 | |
| tsufiev | ruhe, it seems that implementing 'Previous Page' button is a bit harder than I initially thought | 14:00 |
| tsufiev | so, it's better left for J2 | 14:00 |
| tsufiev | but I don't know exactly what to do with the blueprint | 14:01 |
| tsufiev | to make a new blueprint especially for 'Previous Page' or move normalize-dashboard-pagination to J2 because its scope has extended | 14:01 |
| tsufiev | what is better? | 14:01 |
| ruhe | tsufiev: that's up to you | 14:02 |
| tsufiev | ok, then i'll extend the scope of existing blueprint | 14:02 |
| *** gokrokve has joined #murano | 14:24 | |
| *** gokrokve_ has joined #murano | 14:25 | |
| *** sjmc7 has joined #murano | 14:28 | |
| *** gokrokve has quit IRC | 14:28 | |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Make categories field optional https://review.openstack.org/98770 | 14:38 |
| *** stanlagun has quit IRC | 15:10 | |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add heat_template_version to network fragments https://review.openstack.org/99145 | 15:12 |
| *** drupalmonkey has joined #murano | 15:14 | |
| sjmc7 | gokrokve_ - https://blueprints.launchpad.net/murano/+spec/support-aps-packages | 15:54 |
| gokrokve_ | sjmc7: Thanks. This is very interesting. | 15:55 |
| gokrokve_ | sjmc7: And a logical continuation from another side: https://blueprints.launchpad.net/murano/+spec/cloudfoundry-api-support | 16:00 |
| gokrokve_ | sjmc7: I think this will move Murano to the next stage :-) | 16:01 |
| gokrokve_ | sjmc7: Do you use CloudFoundry in your cloud? | 16:02 |
| sjmc7 | gokrokve_ - yeah, and having somewhere to put applications is something they've asked about already | 16:05 |
| gokrokve_ | sjmc7: Then you have an answer for them :-) | 16:05 |
| sjmc7 | much in the same way angus did for solum | 16:05 |
| gokrokve_ | It should not require any significant changes as CF API is pretty well abstracted and we can provide mostly all required info out of the box. | 16:06 |
| gokrokve_ | sjmc7: Yes, I want to talk with Angus about that too. | 16:06 |
| gokrokve_ | sjmc7: I plan to prepare a document about integration with different PaaSes. I have a draft for it, actually. | 16:08 |
| sjmc7 | one thing that pops out is that for some of these applications (CF, APS, solum) the engine we have becomes less important than the catalog | 16:08 |
| sjmc7 | gokrokve_ - we'd be interested in taking a look at that. we've got a big investment in CF | 16:09 |
| gokrokve_ | sjmc7: https://docs.google.com/a/mirantis.com/document/d/1VtGrAAKmCNjgIjqYyYAuG0BCaF0la6q6WqsmfQI08aw/edit?usp=sharing here is a link | 16:09 |
| gokrokve_ | It is shared with you | 16:09 |
| gokrokve_ | sjmc7: Yes, and that is why we call Murano catalog, not an engine. | 16:10 |
| sjmc7 | yep | 16:10 |
| sjmc7 | but currently for heat templates we're translating them into something processable by the engine - that may not be the best long term approach | 16:11 |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Fix environment's quick deploy https://review.openstack.org/99428 | 16:40 |
| openstackgerrit | Anastasia Kuznetsova proposed a change to stackforge/murano-dashboard: Implement Horizon UI patterns https://review.openstack.org/99229 | 16:46 |
| *** gokrokve_ has quit IRC | 16:48 | |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Fix environment's quick deploy https://review.openstack.org/99428 | 17:01 |
| sjmc7 | is anyone else having problems deploying packages? | 17:10 |
| sjmc7 | initialize appears not to be getting called on Instance | 17:12 |
| sjmc7 | does it have to be explicitly called? | 17:13 |
| sjmc7 | this was working until recently | 17:13 |
| *** gokrokve has joined #murano | 17:19 | |
| ativelkov | sjmc7: regarding your commit at https://review.openstack.org/#/c/99145: what will happen if the template contains different tenplate version field? | 17:21 |
| sjmc7 | it'll only add one if none exists. but since the neutron elements don't add one, almost always it will default | 17:22 |
| ativelkov | I mean, if the user attempts to push a heat snippet in the old format | 17:23 |
| ativelkov | afaik, heat cannot properly handle situation when a single stack template contains mixed hot and cfn syntaxes. | 17:23 |
| sjmc7 | no, it can't | 17:23 |
| ativelkov | So, if there is an attempt to merge snippets with different template formats, we should throw an exception | 17:24 |
| ativelkov | As we always insert snippets in hot format, then we should not allow any other formats | 17:24 |
| sjmc7 | realistically, it will never be valid to specify a format | 17:24 |
| sjmc7 | right | 17:24 |
| ativelkov | right, so we may allow to specify the format only if it is hot | 17:25 |
| sjmc7 | ok. i'll change it. currently i can't deploy anything | 17:25 |
| ativelkov | "Any customer can have a car painted any color that he wants so long as it is black" | 17:25 |
| ativelkov | Yes, there is some problem merged into the codebase | 17:26 |
| sjmc7 | right. i don't think there's really a reason to allow CFN any more | 17:26 |
| ativelkov | so, I've added a comment there about it | 17:27 |
| sjmc7 | ok. will update in a moment | 17:27 |
| ativelkov | ruhe: should alembic migrations make its way to j1, or it waits till j2? | 17:29 |
| ativelkov | sjmc7: I've modified the commit message in https://review.openstack.org/#/c/98471/ and answered to your question about allowed_address_pairs | 17:30 |
| sjmc7 | thanks | 17:30 |
| ruhe | ativelkov: it depends on reviews. i'd like to see it in j1, but if team doesn't have capacity to give this patch a good review, then we'll have to postpone it to j2 | 17:35 |
| gokrokve | We need this patch to be merged in master. It will enable a huge amount of possible HA solutions on App level. | 17:35 |
| gokrokve | Pacemaker and heartbeat tools use VIP. | 17:35 |
| sjmc7 | approved, ativelkov | 17:35 |
| ativelkov | gokrokve: which patch do you mean? Alembic? | 17:36 |
| ativelkov | thanks sjmc7 | 17:36 |
| gokrokve | https://review.openstack.org/#/c/98471/ | 17:36 |
| ativelkov | gokrokve: ah, got it | 17:36 |
| gokrokve | SharedIP :-) | 17:36 |
| gokrokve | Once we have it we can use pacemaker to provide HA for Linux apps. | 17:37 |
| gokrokve | I mean users will be able to create Ha deployments with using advanced linux tools which use VIP concept. | 17:37 |
| ativelkov | Then we will need to make a pacemaker class | 17:38 |
| ativelkov | Which will make a nice addition to incubator | 17:38 |
| gokrokve | ativelkov: Not necessarily. Pacemaker is just an app component. It still requires config to work properly, so it is better to leave it to app writer. | 17:39 |
| gokrokve | But a good example with pacemaker will definitely help. I have some examples with DRDB and MySQL. | 17:40 |
| gokrokve | By the way actions will enable Stonith and Fencing in pacemaker. It will be a killer feature :-) | 17:42 |
| ativelkov | gokrokve: proper implementation of actions will require tons of work | 17:42 |
| gokrokve | For stonith you just nedd an action kill this machine. No params :-) | 17:42 |
| gokrokve | http://doc.opensuse.org/products/draft/SLE-HA/SLE-ha-guide_sd_draft/cha.ha.fencing.html | 17:43 |
| ativelkov | For example, the action should be called in the very same class as the one which was used to deploy the component. If the package was removed and a new version was uploaded instead, the action should be run from old package | 17:44 |
| ativelkov | This requires us to persist the package id with the type info in object model - and this is a serious change | 17:44 |
| ativelkov | Also it requires soft delete of the packages | 17:44 |
| ativelkov | And so on. Lot's of changes, lot's of work. | 17:45 |
| gokrokve | Put it to known issues. It is ok to have some limitations if users are aware of them. | 17:45 |
| gokrokve | It should not be perfect but it should work for specific cases like the same package the same environment. | 17:45 |
| ativelkov | Yep. I like the limitation "Actions are not implemented yet" ;) | 17:45 |
| ativelkov | The most important is that there is no way to make anonymous calls to API | 17:46 |
| gokrokve | Hey. They are implemented. If you can call an action for app this is a basic functionality. all other is nice to have features. | 17:46 |
| ativelkov | serg's implementation of actions requires the calls to be authenticated with a token, which is impossible to expect from a third-party service | 17:47 |
| gokrokve | ativelkov: As soon as we can call it via Mistral it is ok. Mistral will have a token. | 17:47 |
| ativelkov | it will have a v3 token | 17:48 |
| ativelkov | Murano does not support keystone's v3 yet | 17:48 |
| gokrokve | In third party app like pacemaker we can add a plugin which will obtain token from a keystone. | 17:48 |
| openstackgerrit | A change was merged to stackforge/murano: Install python client from repo https://review.openstack.org/98752 | 17:48 |
| ativelkov | then you will have to provide user's credentials to cloud apps. Sounds like a huuuge security problem | 17:48 |
| ativelkov | I don't say it is impossible | 17:49 |
| gokrokve | Heh. This is balance between functionality and security | 17:49 |
| ativelkov | I just say that we are going to have a release tomorrow | 17:49 |
| gokrokve | as soon as we have basic actions in it, I am happy | 17:50 |
| ativelkov | I am not sure if they land there. ruhe, your opninion? | 17:50 |
| gokrokve | Here is an official example from pacemaker: | 17:50 |
| gokrokve | params nodename=node2 ipaddr=192.168.0.102 \ | 17:50 |
| gokrokve | userid=USERID passwd=PASSW0RD | 17:50 |
| gokrokve | :-) Tell me about security... | 17:51 |
| ativelkov | cool ) | 17:52 |
| gokrokve | STONITH Device: apcmaster - APC MasterSwitch (via telnet) | 17:52 |
| gokrokve | List of valid parameter names for apcmaster STONITH device: | 17:52 |
| gokrokve | ipaddr | 17:52 |
| gokrokve | login | 17:52 |
| gokrokve | password | 17:52 |
| ativelkov | btw, https://review.openstack.org/#/c/98471/ got +2s, no -1s but no "approved" | 17:52 |
| ativelkov | ruhe, slagun, tsufiev, dteselkin - please help! ) | 17:53 |
| gokrokve | Who is a nearest core you can reach? Ping him | 17:53 |
| ativelkov | No cores around | 17:53 |
| ruhe | i'm here | 17:53 |
| ativelkov | no people in office at all | 17:53 |
| gokrokve | We need more cores in US timezone :-) | 17:53 |
| ativelkov | holiday season, everybody a heading suburbs ) | 17:54 |
| gokrokve | land it, please today | 17:55 |
| gokrokve | And think about core team extension. | 17:55 |
| ruhe | ativelkov: done | 17:56 |
| ativelkov | thanks | 17:56 |
| openstackgerrit | Alexander Tivelkov proposed a change to stackforge/murano: Make sys:Resources class use resources belonging to its owner https://review.openstack.org/98837 | 17:57 |
| ruhe | sjmc7: your unit-tests work! on your patch :) https://review.openstack.org/#/c/94657/ | 17:58 |
| sjmc7 | urgh. will take a look in a sec | 17:59 |
| ativelkov | strange, I've just updated the commit message, but gerrit removed all the +1 marks | 17:59 |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add heat_template_version to network fragments https://review.openstack.org/99145 | 18:03 |
| gokrokve | Here is a patch from Christian: https://review.openstack.org/#/c/98368/ | 18:06 |
| gokrokve | We did something like that in solum when keystoneclient was not compatible with python3. This is a valid solution. Core team, please take a look and approve if there is no any other concerns. | 18:07 |
| ruhe | gokrokve: this one doesn't seem to be critical, since it's supposed to fix code running on python3. we can merge it later | 18:11 |
| ruhe | there are major patches waiting for review | 18:11 |
| gokrokve | ok. just do not forget about it | 18:13 |
| gokrokve | by the way we need also test python26 as this is a default python for CentOS | 18:13 |
| ativelkov | gokrokve: we do | 18:15 |
| ativelkov | it is part of our tests | 18:15 |
| gokrokve | Lat week I was not able to install Murano from master on CentOS | 18:16 |
| gokrokve | Sten fixed the issue, though | 18:16 |
| *** btully has joined #murano | 18:23 | |
| ruhe | yes, we have py26 tests and we also have centos jobs on murano-ci, but they were flaky recently | 18:24 |
| btully | ping tsufiev | 18:25 |
| ruhe | btully: he must be commuting now. afaik he wanted to ask you to rebase your patch (https://review.openstack.org/#/c/99428/) on top of his patch (https://review.openstack.org/#/c/99428/) | 18:32 |
| btully | yes i did that | 18:32 |
| btully | thanks ruhe, i also wanted to respond to his questions | 18:33 |
| openstackgerrit | A change was merged to stackforge/murano-dashboard: Fix environment's quick deploy https://review.openstack.org/99428 | 18:36 |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add policy checks to API https://review.openstack.org/94657 | 18:37 |
| sjmc7 | ruhe - fixed the tests | 18:39 |
| sjmc7 | biab, lunch before meeting | 18:39 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Adds REST API endpoint for action execution https://review.openstack.org/99449 | 18:48 |
| ruhe | sjmc7: me and stan will re-approve it once it gets +1 from jenkins | 18:49 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Maintain virtual MuranoPL stack trace https://review.openstack.org/97943 | 18:53 |
| tsufiev | i'm here if you were searching for me | 18:59 |
| ruhe | btully: ^ | 18:59 |
| ruhe | tsufiev: it's your turn to do reviews :) i'll be afk for about an hour or 1.5hrs | 19:01 |
| btully | hey there tsufiev! I was just responding to your comments | 19:02 |
| btully | so it looks like i should remove the ability to add a second env | 19:02 |
| btully | since there is no URL to create and switch to new env | 19:03 |
| btully | as for the blue line of text, i implemented it wrong. Here's what I suppose it should look like: | 19:06 |
| btully | http://content.screencast.com/users/brian.tully/folders/Jing/media/dd878fa6-549d-466b-ac83-0edfadb7bada/00001089.png | 19:06 |
| btully | is that more acceptable? | 19:06 |
| tsufiev | btully, yes, the bigger background seems better | 19:06 |
| tsufiev | frankly speaking, i'm not very good with colors - my first UI in high school was red on green or something like that :) | 19:07 |
| tsufiev | that time my friends told me that i would be better programmer than designer ))) | 19:07 |
| btully | this is the default alert color if we don't want to use the "info" tag | 19:08 |
| btully | http://content.screencast.com/users/brian.tully/folders/Jing/media/2b7b079f-803c-4ee9-8a57-d5b916f85041/00001090.png | 19:08 |
| btully | red on green, eh? Was it Christmas? ;) | 19:08 |
| tsufiev | no, it wasn't Christmas :) | 19:09 |
| btully | gokrokve: any preference between the two screenshots above? | 19:09 |
| gokrokve | What about just white background. I did not see these colors on other pages. | 19:10 |
| btully | they are existing design patterns in horizon | 19:11 |
| gokrokve | Then I am for blue :-) | 19:11 |
| btully | templates/horizon/_messages.html | 19:11 |
| btully | super. thanks! | 19:11 |
| gokrokve | Yellow are usually for warnings. Blue just for any info. | 19:12 |
| tsufiev | i agree on blue | 19:12 |
| btully | yup, which is why i originally chose it | 19:12 |
| gokrokve | Yellow is for warnings :-) | 19:12 |
| btully | k | 19:12 |
| btully | the other option that I recommended was to hide the "recent activity" section if latest_list was 0 | 19:13 |
| * tsufiev launching vbox to see how currently Default Env selector is implemented | 19:14 | |
| btully | do we want to implement that now or add as a blueprint for next release? | 19:14 |
| gokrokve | Last time I tried to hide something on this page led to nasty elements alignment. | 19:15 |
| btully | that won't be a problem | 19:15 |
| gokrokve | So probably it is safe to keep it as it for now. | 19:15 |
| btully | k | 19:15 |
| openstackgerrit | A change was merged to stackforge/murano: Improve method resolution rules for multiple inheritance https://review.openstack.org/98577 | 19:18 |
| openstackgerrit | A change was merged to stackforge/murano: Automatically call MuranoPL initialize/destroy methods https://review.openstack.org/98579 | 19:19 |
| tsufiev | btully, actually there is some possibility to change the default value of Environment drop-down once a new environment has been created | 19:20 |
| btully | oh yeah? how so? | 19:20 |
| tsufiev | for instance, we could use sessions - add newly created environment to the session and the show it in the template | 19:20 |
| tsufiev | but it is indeed more difficult than to hide 'create env' option when there is at least one environment | 19:21 |
| btully | is there an existing implementation of something similar in the codebase I can look at as a guide? | 19:22 |
| tsufiev | it seems to me, that the right place to new environments is the Environments page, so such an option is provided at AppCatalog page only to make 'Add to Env' button functional | 19:22 |
| tsufiev | the same goes for Current Env selector | 19:23 |
| tsufiev | btully, wait a minute, i'm looking through code... | 19:23 |
| btully | so maybe just keep the "Create Environment" button if there are are no existing envs | 19:24 |
| btully | and if there is an env or multiple we don't have the 'create new env' | 19:24 |
| btully | or if we do, instead of modal, we direct to env page? | 19:24 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Adds REST API endpoint for action execution https://review.openstack.org/99449 | 19:28 |
| gokrokve | btully: I think user should always be able to create new environment | 19:28 |
| btully | yup which is what they have now | 19:29 |
| btully | i am not taking away that ability | 19:29 |
| gokrokve | btully: not really. There is a bug so that if you add a second environment this button "Create env" disappears. | 19:29 |
| btully | i simply wanted to add it even if they had existing environments | 19:29 |
| btully | right, the current (as in master) doesn't have that ability either | 19:30 |
| btully | if a user has an env, it just shows the name | 19:30 |
| btully | if they have multiple envs, it shows each name as a switcher | 19:30 |
| gokrokve | +1 to be able to add it at any time | 19:31 |
| btully | i agree | 19:31 |
| btully | but then there's the issue of when it gets created via modal it doesn't automatically switch to new env | 19:31 |
| btully | not sure if we can resolve that in the next hour or two for this release | 19:32 |
| gokrokve | yes, I agree. Modal is always a problem. | 19:32 |
| btully | but i'm willing to try if you guys can guide me through it ;) | 19:32 |
| gokrokve | I don't know how to fix this. Probably Timur knows. | 19:33 |
| openstackgerrit | A change was merged to stackforge/murano: Introduce a SharedIp object for Clustering https://review.openstack.org/98471 | 19:33 |
| tsufiev | btully, it's a bit trickier than i thought | 19:33 |
| btully | isn't it always ;) | 19:33 |
| tsufiev | https://github.com/stackforge/murano-dashboard/blob/master/muranodashboard/templates/catalog/env_switcher.html#L26 - that is how environment is switched | 19:33 |
| btully | right | 19:34 |
| tsufiev | all it does is call to https://github.com/stackforge/murano-dashboard/blob/master/muranodashboard/catalog/views.py#L89 | 19:34 |
| btully | yup | 19:34 |
| btully | the env gets created and it redirects back to the index | 19:34 |
| tsufiev | to simultaneously create new env and switch to it, you have to provide new url and view | 19:34 |
| btully | which then calls function to see if there are envs | 19:34 |
| *** JoelC has joined #murano | 19:35 | |
| tsufiev | what is from my point of view is wasteful | 19:35 |
| * tsufiev don't like when there are too many views for achieving similar tasks | 19:35 | |
| tsufiev | maybe it could be done simpler, but i have no idea how (at least right now) | 19:36 |
| sjmc7 | i'm not butting in, but i'd liketo approach these things from the view of actual use cases rather than throwing ideas out, especially where it's contentious | 19:36 |
| *** loganb has joined #murano | 19:37 | |
| *** ankurrr has joined #murano | 19:38 | |
| gokrokve | We expect to land couple important patches today for initial Actions support. | 19:39 |
| gokrokve | Can everyone spend some time tomorrow and test this new feature manually? | 19:40 |
| tsufiev | sjmc7, so i'd like to use simpler approach for Environment selector for now | 19:40 |
| gokrokve | You will need to create a new method in application definition like: | 19:41 |
| gokrokve | testAction: | 19:41 |
| gokrokve | Usage: Action | 19:41 |
| gokrokve | Body: | 19:41 |
| gokrokve | Return: 2 + 2 | 19:41 |
| gokrokve | Then you need to deploy this app | 19:41 |
| tsufiev | namely, the one which is able to create New Environment only when there are no environments at all. It's actually the old behaviour, but given we have J1 cut tomorrow, that seems fine to me | 19:41 |
| btully | sounds good to me | 19:41 |
| gokrokve | Once app is deployed there will be a tab actions with a links to call actions for particular application | 19:42 |
| btully | otherwise, my current implementation sorta works, just doesn't switch to the newly created env | 19:42 |
| btully | but i agree this is somewhat confusing, so i'm happy to remove the link from the dropdown for 'create new environment' | 19:43 |
| tsufiev | btully, you could create a separate blueprint for that new behaviour | 19:44 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Maintain virtual MuranoPL stack trace https://review.openstack.org/97943 | 19:44 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Adds ability to throw/catch/rethrow exceptions in MuranoPL https://review.openstack.org/98984 | 19:44 |
| btully | right, but not knowing how to implement it seems like trouble | 19:44 |
| tsufiev | moreover, if it won't be approved, you'll save efforts implementing the 100%-working solution :) | 19:44 |
| tsufiev | to me, it always bitter to throw out something that works, but doesn't fit in overall concept/design | 19:45 |
| btully | and like sjmc7 suggested, we should focus more on actual use cases from users vs 'hey i've got a great idea!" ;) | 19:46 |
| tsufiev | i should leave now to debug our initial Actions UI | 19:46 |
| openstackgerrit | Ankur Rishi proposed a change to stackforge/murano: Add optional fields to packages for supplier info https://review.openstack.org/99465 | 19:46 |
| btully | thanks tsufiev gokrokve and sjmc7 | 19:46 |
| * tsufiev won't reply much here for a while | 19:47 | |
| btully | i'll make my revisions and commit in a few | 19:47 |
| tsufiev | btully, np | 19:47 |
| *** loganb has quit IRC | 19:51 | |
| openstackgerrit | Brian Tully proposed a change to stackforge/murano-dashboard: Implement Horizon UI patterns https://review.openstack.org/99229 | 20:00 |
| openstackgerrit | Brian Tully proposed a change to stackforge/murano-dashboard: Implement Horizon UI patterns https://review.openstack.org/99229 | 20:03 |
| tsufiev | btully, could you look through https://review.openstack.org/#/c/99050/ ? | 20:03 |
| btully | sure! | 20:04 |
| tsufiev | the solution I found seems like hack, but I don't know anything else | 20:04 |
| *** loganb has joined #murano | 20:04 | |
| *** stanlagun has joined #murano | 20:04 | |
| btully | tsufiev: can i ask what led to us having to do this? | 20:11 |
| tsufiev | btully, it was the problem ativelkov encountered on Safari browser | 20:11 |
| btully | does tha AppCatalog page take a long time to load for some people? | 20:12 |
| tsufiev | when he was clicking 'Quick Deploy' in AppCatalog before all resources were loaded, he get 'TemplateDoesNotExist' error | 20:12 |
| gokrokve | btully: It may take a while to do initial load while nothing is cached | 20:12 |
| btully | i see | 20:12 |
| tsufiev | but I couldn't reproduce that problem on Chromium | 20:12 |
| btully | ok | 20:12 |
| btully | so if that's the case | 20:13 |
| btully | so for the user that is experiencing this | 20:13 |
| tsufiev | and the Template exception was due to ajax-modal handler not loaded at this stage - so it used the wrong template (without _ for ajax requests) | 20:13 |
| btully | they will then see the page loading try clicking and nothing will respond | 20:14 |
| tsufiev | the second part of explanation is how I understood that, because I don't have exact proofs | 20:14 |
| tsufiev | btully, yes | 20:14 |
| tsufiev | but nothing will happen for a short period of time - until the page finishes loading | 20:15 |
| btully | perhaps the "cover" div that you added should maybe look like the modal loader | 20:15 |
| tsufiev | which is better than 500 error | 20:15 |
| tsufiev | hm... | 20:15 |
| btully | i.e., black background with transparancy and the animated loader | 20:15 |
| btully | which will disappear once page is loaded | 20:15 |
| btully | in the edge case that a user encounters this, it will communicate better | 20:16 |
| btully | otherwise maybe they would think their browser is locked up? | 20:16 |
| tsufiev | i agree that is a better solution | 20:17 |
| btully | let me see how they do that | 20:17 |
| tsufiev | btully, sure | 20:19 |
| loganb | hey everyone, I'm new to Murano and going through the configuration process.. but while trying to run ./setup.sh install, I hit the error 'can't enable "cloud-archive:havana", exiting' | 20:32 |
| loganb | I havn't found a ton online addressing this and was wondering if someone could point me in the right direction to get around this. I tried ./setup.sh install on a VM with devstack installed, and a clean VM | 20:33 |
| ruhe | loganb: hi! you can use devstack scripts from contrib/devstack | 20:33 |
| ruhe | setup.sh is used to install murano-ci system and might require some additional pre-configuration of the host | 20:34 |
| loganb | ah i see. mind me asking where i would find contrib/devstack? | 20:35 |
| ruhe | sure: https://github.com/stackforge/murano/tree/master/contrib/devstack | 20:36 |
| *** katyafervent_awa has quit IRC | 20:39 | |
| *** ativelkov has quit IRC | 20:39 | |
| *** iyozhikov has quit IRC | 20:39 | |
| *** ativelkov has joined #murano | 20:40 | |
| btully | tsufiev: it doesn't look like horizon uses an animated spinner gif but rather some elaborate linechart JS library to render the spinner | 20:41 |
| *** katyafervent_awa has joined #murano | 20:41 | |
| loganb | ruhe: thanks for the quick response and help! | 20:42 |
| ruhe | loganb: you're welcome. feel free to ask again if you'll need any assistance | 20:42 |
| btully | tsufiev: maybe try something like this? http://content.screencast.com/users/brian.tully/folders/Jing/media/78df8dad-1e72-4e01-bb46-a130ee93319c/00001091.png | 20:47 |
| tsufiev | btully, i can't see it right, working on Actions UI - very urgent... | 20:48 |
| tsufiev | *can't look at it | 20:49 |
| btully | np tsufiev i've updated the review with comments | 20:52 |
| btully | is there any way for me to make the changes for you? | 20:52 |
| tsufiev | you can upload a new patchset to that review | 20:52 |
| *** akuznetsova_ has joined #murano | 20:53 | |
| btully | super. will do | 20:53 |
| tsufiev | it's quite ok for several people to work on same commit | 20:53 |
| *** loganb has quit IRC | 20:53 | |
| *** asalkeld has joined #murano | 20:54 | |
| btully | tsufiev: patchset uploaded | 20:59 |
| tsufiev | btully, thanks! | 21:00 |
| btully | my pleasure ;) | 21:00 |
| *** akuznetsova has quit IRC | 21:10 | |
| openstackgerrit | A change was merged to stackforge/murano: Add policy checks to API https://review.openstack.org/94657 | 21:10 |
| openstackgerrit | Brian Tully proposed a change to stackforge/murano-dashboard: Disable all buttons and links until AppCatalog page is loaded https://review.openstack.org/99050 | 21:10 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Adds REST API endpoint for action execution https://review.openstack.org/99449 | 21:39 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Adds REST API endpoint for action execution https://review.openstack.org/99449 | 21:39 |
| sjmc7 | tsufiev - for the actions UI, do you just want to get something merged today as a proof of concept and make changes to tidy it up afterwards? | 21:40 |
| sjmc7 | i will adjust my reviewing hat accordingly | 21:40 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Maintain virtual MuranoPL stack trace https://review.openstack.org/97943 | 21:40 |
| tsufiev | sjmc7, yes, that is exactly what I want to achieve | 21:41 |
| sjmc7 | ok. the CI tests will likely be broken for a few days | 21:41 |
| *** asalkeld is now known as asalkeld_afk | 21:45 | |
| ruhe | sjmc7: you mean dashboard CI? | 21:47 |
| sjmc7 | yes | 21:47 |
| sjmc7 | or i can take a look now at fixing them | 21:48 |
| *** asalkeld_afk is now known as asalkeld | 22:01 | |
| ruhe | #info https://blueprints.launchpad.net/murano/+spec/online-app-repository moved to juno-2 | 22:05 |
| ruhe | #info https://blueprints.launchpad.net/murano/+spec/alembic-migrations moved to juno-2 | 22:05 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Adds REST API endpoint for action execution https://review.openstack.org/99449 | 22:18 |
| *** gokrokve has quit IRC | 22:25 | |
| openstackgerrit | A change was merged to stackforge/murano: Make sys:Resources class use resources belonging to its owner https://review.openstack.org/98837 | 22:40 |
| *** btully has quit IRC | 22:52 | |
| sjmc7 | stanlagun - https://review.openstack.org/#/c/99449/ looks mostly ok but the DB migration is failing | 22:56 |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/python-muranoclient: Provide method for running action in an environment https://review.openstack.org/99502 | 22:59 |
| openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Draft implementation of Actions UI https://review.openstack.org/99360 | 23:01 |
| sjmc7 | tsufiev - be better to put the actions stuff in a separate module in muranoclient | 23:08 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Adds REST API endpoint for action execution https://review.openstack.org/99449 | 23:10 |
| stanlagun | sjmc7 it looks like a problem in murano-ci. Can't figure out why it fails | 23:13 |
| sjmc7 | the DB migration? | 23:13 |
| stanlagun | yep | 23:13 |
| sjmc7 | the error is related to foreign keys, just taking a look now | 23:13 |
| *** drupalmonkey has quit IRC | 23:13 | |
| stanlagun | Last time it was another error in that place | 23:14 |
| stanlagun | I've just uploaded another patch-set to that commit addressing things that you pointed | 23:15 |
| sjmc7 | yep, saw that | 23:16 |
| stanlagun | Strange thing is that migrations do work on Serge's and my machine | 23:16 |
| stanlagun | On MySQL /InnoDB | 23:16 |
| sjmc7 | is the colum type changing? | 23:16 |
| sjmc7 | it's the Status.deployment_id -> task_id triggering the error | 23:17 |
| sjmc7 | maybe drop the foreign key first | 23:17 |
| sjmc7 | and reapply | 23:17 |
| stanlagun | just the name | 23:18 |
| sjmc7 | ok. i think you'll have to drop the constraint and re-add it | 23:18 |
| stanlagun | do you know how to drop FK constraint? | 23:18 |
| sjmc7 | google turns up a few examples of this | 23:18 |
| sjmc7 | yeah - look in 010_add_unique_environment_constraint.py | 23:19 |
| sjmc7 | err, wait, that's a uniqueconstraint | 23:19 |
| sjmc7 | 004_add_repository_tables.py has examples of creating them | 23:20 |
| sjmc7 | can drop them the same way | 23:20 |
| openstackgerrit | A change was merged to stackforge/murano: Maintain virtual MuranoPL stack trace https://review.openstack.org/97943 | 23:28 |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Adds ability to throw/catch/rethrow exceptions in MuranoPL https://review.openstack.org/98984 | 23:45 |
| sjmc7 | is timur still there? otherwise i'll make a correction to one of his commits | 23:46 |
| ruhe | i don't think so, you can go ahead | 23:47 |
| * sjmc7 puts his mask on | 23:47 | |
| ruhe | i'm going to leave. just fyi, we'll have to postpone a few more BPs/patches to j2. actions probably will be one of them | 23:53 |
| ruhe | we don't have much core reviewer capacity because of the upcoming holidays in russia (thursday and friday) | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
