*** rakhmerov has joined #murano | 00:01 | |
*** TravT has quit IRC | 00:04 | |
*** rakhmerov has quit IRC | 00:06 | |
*** drupalmonkey has quit IRC | 00:15 | |
*** sjmc7 has quit IRC | 00:26 | |
*** rakhmerov has joined #murano | 00:31 | |
*** rakhmerov has quit IRC | 00:36 | |
*** rakhmerov has joined #murano | 01:32 | |
*** rakhmerov has quit IRC | 01:36 | |
*** rakhmerov has joined #murano | 02:33 | |
*** rakhmerov has quit IRC | 02:37 | |
*** rakhmerov has joined #murano | 03:33 | |
*** rakhmerov has quit IRC | 03:38 | |
*** rakhmerov has joined #murano | 04:23 | |
*** chandan_kumar has quit IRC | 06:38 | |
*** slagun has joined #murano | 08:06 | |
*** stanlagun has quit IRC | 08:16 | |
*** bogdando has quit IRC | 08:16 | |
*** tnurlygayanov has quit IRC | 08:16 | |
*** smurashov has quit IRC | 08:16 | |
*** rakhmerov has quit IRC | 08:16 | |
*** asalkeld has quit IRC | 08:16 | |
*** openstackgerrit has quit IRC | 08:16 | |
*** ativelkov has quit IRC | 08:16 | |
*** akuznetsova has quit IRC | 08:16 | |
*** ogelbukh has quit IRC | 08:16 | |
*** igormarnat has quit IRC | 08:16 | |
*** tsufiev has quit IRC | 08:16 | |
*** dteselkin has quit IRC | 08:16 | |
*** peoplemerge has quit IRC | 08:16 | |
*** slagun has quit IRC | 08:17 | |
*** PierreRambaud has quit IRC | 08:17 | |
*** goneri has quit IRC | 08:17 | |
*** ruhe has quit IRC | 08:17 | |
*** christopheraedo has quit IRC | 08:17 | |
*** smurashov has joined #murano | 08:21 | |
*** bogdando has joined #murano | 08:21 | |
*** tnurlygayanov has joined #murano | 08:21 | |
*** slagun has joined #murano | 08:21 | |
*** rakhmerov has joined #murano | 08:21 | |
*** asalkeld has joined #murano | 08:21 | |
*** openstackgerrit has joined #murano | 08:21 | |
*** akuznetsova has joined #murano | 08:21 | |
*** ativelkov has joined #murano | 08:21 | |
*** ogelbukh has joined #murano | 08:21 | |
*** PierreRambaud has joined #murano | 08:21 | |
*** christopheraedo has joined #murano | 08:21 | |
*** goneri has joined #murano | 08:21 | |
*** igormarnat has joined #murano | 08:21 | |
*** peoplemerge has joined #murano | 08:21 | |
*** ruhe has joined #murano | 08:21 | |
*** tsufiev has joined #murano | 08:21 | |
*** dteselkin has joined #murano | 08:21 | |
*** sergmelikyan has joined #murano | 08:24 | |
*** bogdando has quit IRC | 08:33 | |
*** tnurlygayanov has quit IRC | 08:33 | |
*** smurashov has quit IRC | 08:33 | |
*** tnurlygayanov has joined #murano | 08:43 | |
*** bogdando has joined #murano | 08:43 | |
*** smurashov has joined #murano | 08:43 | |
*** slagun has quit IRC | 08:48 | |
*** slagun has joined #murano | 08:49 | |
openstackgerrit | A change was merged to stackforge/murano-dashboard: Change image title in dashboard test https://review.openstack.org/99341 | 09:09 |
---|---|---|
openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Add versionutils from oslo to use @deprecated helper https://review.openstack.org/98388 | 09:10 |
openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Change the way multiple values for dynamic UI 'type' attr are parsed https://review.openstack.org/94368 | 09:10 |
openstackgerrit | A change was merged to stackforge/murano: Return and Break were broken https://review.openstack.org/100290 | 09:18 |
openstackgerrit | A change was merged to stackforge/murano: MuranoPlException was referenced from incorrect module https://review.openstack.org/100285 | 09:20 |
*** goneri has quit IRC | 09:39 | |
openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Generate unique html ids for dynamic ui forms and fields https://review.openstack.org/100477 | 10:01 |
*** asalkeld has quit IRC | 10:03 | |
openstackgerrit | A change was merged to stackforge/python-muranoclient: Correct muranoclient service_get function https://review.openstack.org/99232 | 10:16 |
openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Generate unique html ids for dynamic ui forms and fields https://review.openstack.org/100477 | 10:49 |
openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Generate unique html ids for dynamic ui forms and fields https://review.openstack.org/100477 | 10:55 |
openstackgerrit | Anastasia Kuznetsova proposed a change to stackforge/murano-dashboard: Make WebUI tests refactoring https://review.openstack.org/100499 | 11:19 |
sergmelikyan | slagun, http://dev.cloudwatt.com/en/blog/introducing-flame-automatic-heat-template-generation.html - interesting, what use-cases for real world DevOps this thing can handle? | 11:23 |
*** rakhmerov has quit IRC | 11:36 | |
*** rakhmerov has joined #murano | 11:37 | |
*** rakhmerov has quit IRC | 11:38 | |
*** rakhmerov has joined #murano | 11:38 | |
openstackgerrit | Timur Sufiev proposed a change to stackforge/murano-dashboard: Generate unique html ids for dynamic ui forms and fields https://review.openstack.org/100477 | 11:53 |
smurashov | guys, we have some problem https://bugs.launchpad.net/murano/+bug/1330966 | 12:49 |
openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 13:05 |
*** rakhmerov has quit IRC | 13:16 | |
openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 13:46 |
*** drupalmonkey has joined #murano | 14:03 | |
*** sjmc7 has joined #murano | 14:14 | |
*** rakhmerov has joined #murano | 14:17 | |
*** rakhmerov has quit IRC | 14:30 | |
openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 14:33 |
openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add 'userdata_format' to Server heat template https://review.openstack.org/100344 | 14:36 |
*** btully has joined #murano | 14:51 | |
*** chandan_kumar has joined #murano | 15:04 | |
*** rakhmerov has joined #murano | 15:27 | |
*** rakhmerov has quit IRC | 15:41 | |
tnurlygayanov | slagun, about conditions in https://review.openstack.org/#/c/99449/14/murano/db/services/actions.py | 16:07 |
tnurlygayanov | I suggest to refactor this code | 16:08 |
tnurlygayanov | too many conditions for one dictionary | 16:08 |
slagun | tnurlygayanov, your variant wouldn't work at all | 16:08 |
tnurlygayanov | why? | 16:08 |
tnurlygayanov | oh... | 16:08 |
tnurlygayanov | yes | 16:08 |
tnurlygayanov | hm... None has not 'get'... | 16:09 |
slagun | besides it also masksk original intentions | 16:09 |
tsufiev | slagun, tnurlygayanov: what about my proposal for this fragment? | 16:09 |
slagun | the whole purpose was to check if dictionary has some well-known structure, not to get valye | 16:09 |
slagun | tsufiev, your version will work. But I think it is bad style to use | 16:10 |
tsufiev | slagun, it's the style marked in several guides as 'pythonic one' | 16:11 |
tsufiev | as opposed to the style called 'the defensive programming' | 16:11 |
tnurlygayanov | slagun - use many conditions to get two elements from the dict is the bad style too | 16:11 |
tsufiev | btw, if you look into 'in' operator implementation for dictionary - it silents exceptions as well | 16:12 |
slagun | is masks original code intentions. It also make think that the fact that key is missing is exceptional case whereas it it is not. When one sees except he usually adds logging of exception. But in this case it should not be logged because it is normal use case | 16:13 |
*** gokrokve has joined #murano | 16:14 | |
slagun | tnurlygayanov, I'm doing this not to get value, but to check if dict is object or just data dictionary. Thats why not checking it is masking of intentions | 16:14 |
*** akuznetsova_ has joined #murano | 16:14 | |
tsufiev | handling StopIteration exception is another example of normal flow | 16:15 |
tnurlygayanov | tsufiev - good examples for your variant. | 16:15 |
slagun | tsufiev, I'm not against using exceptions for flow control in general. I know it is Pythonic. It just wrong for this particular case | 16:16 |
*** akuznetsova_ has quit IRC | 16:18 | |
tsufiev | slagun, could this http://www.jeffknupp.com/blog/2013/02/06/write-cleaner-python-use-exceptions/ make you change you mind | 16:19 |
tsufiev | ? | 16:19 |
slagun | tsufiev You don't need to convince me that using exceptions for flow control is ok. Please see my response in gerrit | 16:20 |
slagun | The best code style is that makes reader understand programmer intentions | 16:21 |
tsufiev | ok | 16:21 |
*** IgorYozhikov has joined #murano | 16:23 | |
tsufiev | slagun, though i could argue that trying to obtain value at specific path is also a check for some well-known structure :) | 16:24 |
slagun | tsufiev, yes, but this is not obvious. One can think that the dict is expected to have these keys and author is just forgot to log exception or incorrectly muted it | 16:25 |
tsufiev | i would add a small comment for that case | 16:28 |
tsufiev | but that is bad practice - to use code with comment when there exists some not needing such comments | 16:29 |
slagun | also my version is easier to refactor. Current check is not completely right because it can give false positive on data-dictionary having '?' as a key. Suppose we later write method isObject(dict). Then you will have to rewrite it back not to use exceptions while in my version you will just need to change condition | 16:30 |
*** rakhmerov has joined #murano | 16:37 | |
*** rakhmerov has quit IRC | 16:42 | |
*** TravT has joined #murano | 16:57 | |
*** serg_melikyan has joined #murano | 17:00 | |
ruhe | weekly meeting started at #openstack-meeting-alt | 17:03 |
*** katyafervent2 has joined #murano | 17:12 | |
*** rakhmerov has joined #murano | 17:38 | |
*** rakhmerov has quit IRC | 17:42 | |
*** katyafervent2 has quit IRC | 17:58 | |
tsufiev | ruhe, seems that no AI this time also :) | 18:00 |
ruhe | tsufiev: we have one here http://eavesdrop.openstack.org/meetings/murano/2014/murano.2014-06-17-17.02.txt | 18:00 |
tsufiev | ruhe, ah, yes. I thought about Django testing framework | 18:01 |
ruhe | i'll just update the wiki with other ones | 18:01 |
ruhe | you can update the wiki too, if you want to | 18:01 |
tsufiev | so I'm afraid that it will be forgotten once again until the next meeting | 18:01 |
tsufiev | will do | 18:02 |
tsufiev | ruhe, could you point me to the wiki page address? | 18:03 |
ruhe | tsufiev: https://wiki.openstack.org/wiki/Meetings/MuranoAgenda#Agenda | 18:11 |
*** serg_melikyan has quit IRC | 18:14 | |
tsufiev | ruhe, where should I write addition AI? | 18:17 |
ruhe | to the agenda | 18:17 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Fixed incorrect information on Python frames in MuranoPL stack traces https://review.openstack.org/100640 | 18:27 |
tsufiev | ok, done it | 18:29 |
*** rakhmerov has joined #murano | 18:39 | |
*** rakhmerov has quit IRC | 18:43 | |
*** rakhmerov has joined #murano | 19:40 | |
*** rakhmerov has quit IRC | 19:44 | |
*** lecalcot has joined #murano | 20:17 | |
*** bogdando has quit IRC | 20:19 | |
*** tnurlygayanov has quit IRC | 20:19 | |
*** smurashov has quit IRC | 20:19 | |
*** tnurlygayanov has joined #murano | 20:20 | |
*** bogdando has joined #murano | 20:20 | |
*** smurashov has joined #murano | 20:20 | |
*** IgorYozhikov has quit IRC | 20:24 | |
*** chandan_kumar has quit IRC | 20:24 | |
*** slagun has quit IRC | 20:24 | |
*** chandan_kumar has joined #murano | 20:34 | |
*** IgorYozhikov has joined #murano | 20:36 | |
*** slagun has joined #murano | 20:36 | |
*** rakhmerov has joined #murano | 20:40 | |
*** rakhmerov has quit IRC | 20:44 | |
*** asalkeld has joined #murano | 20:48 | |
lecalcot | How does Murano use Mistral... or does/will it? | 20:56 |
sjmc7 | lecalcot - currently it does not. it's likely it will be able to in future, but there hasn't been much discussion about it yet | 21:06 |
lecalcot | @sjmc7, the two don't conflict in anyway, do they? | 21:06 |
sjmc7 | lecalcot - currently, no | 21:07 |
sjmc7 | it's our aim to use mistral if possible - we cerrtainly don't want to duplicate functionality | 21:07 |
*** lecalcot has quit IRC | 21:30 | |
*** rakhmerov has joined #murano | 21:41 | |
*** rakhmerov has quit IRC | 21:46 | |
*** drupalmonkey has quit IRC | 21:56 | |
*** lecalcot has joined #murano | 21:57 | |
*** lecalcot has quit IRC | 22:41 | |
*** rakhmerov has joined #murano | 22:42 | |
*** rakhmerov has quit IRC | 22:46 | |
*** btully has quit IRC | 23:08 | |
*** gokrokve has quit IRC | 23:09 | |
*** rakhmerov has joined #murano | 23:42 | |
*** gokrokve has joined #murano | 23:43 | |
*** rakhmerov has quit IRC | 23:47 | |
*** sjmc7 has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!