| *** rakhmerov has joined #murano | 00:19 | |
| *** rakhmerov has quit IRC | 00:23 | |
| *** sjmc7 has quit IRC | 00:57 | |
| *** TravT has quit IRC | 01:01 | |
| *** rakhmerov has joined #murano | 01:19 | |
| *** rakhmerov has quit IRC | 01:24 | |
| *** gokrokve has quit IRC | 01:25 | |
| *** gokrokve has joined #murano | 01:25 | |
| *** gokrokve has quit IRC | 01:30 | |
| *** gokrokve has joined #murano | 01:59 | |
| *** rakhmerov has joined #murano | 02:20 | |
| *** rakhmerov has quit IRC | 02:25 | |
| *** gokrokve has quit IRC | 03:00 | |
| *** rakhmerov has joined #murano | 03:21 | |
| *** rakhmerov has quit IRC | 03:25 | |
| *** gokrokve has joined #murano | 03:33 | |
| *** gokrokve_ has joined #murano | 03:36 | |
| *** gokrokve has quit IRC | 03:39 | |
| *** rakhmerov has joined #murano | 04:07 | |
| *** sab has joined #murano | 04:09 | |
| *** rakhmerov_ has joined #murano | 04:34 | |
| *** rakhmerov has quit IRC | 04:45 | |
| *** rakhmerov_ is now known as rakhmerov | 04:46 | |
| *** rakhmerov has quit IRC | 05:22 | |
| *** rakhmerov has joined #murano | 05:22 | |
| *** rakhmerov has quit IRC | 06:13 | |
| *** rakhmerov has joined #murano | 06:13 | |
| *** rakhmerov has quit IRC | 06:16 | |
| *** rakhmerov has joined #murano | 06:16 | |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Infrastructure update https://review.openstack.org/100954 | 06:29 |
|---|---|---|
| *** rakhmerov has quit IRC | 06:37 | |
| *** rakhmerov has joined #murano | 06:37 | |
| iyozhikov | test 4 renat | 06:39 |
| iyozhikov | test 4 renat | 06:40 |
| *** rakhmerov has quit IRC | 06:43 | |
| *** rakhmerov has joined #murano | 06:43 | |
| iyozhikov | test 4 renat | 06:44 |
| iyozhikov | test 4 renat2 | 06:44 |
| sergmelikyan | iyozhikov, testing bouncer? ) | 06:47 |
| rakhmerov | sergmelikyan, yes | 06:57 |
| rakhmerov | everything's ok now | 06:57 |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Infrastructure update https://review.openstack.org/100954 | 06:59 |
| *** gokrokve_ has quit IRC | 07:05 | |
| *** gokrokve has joined #murano | 07:15 | |
| openstackgerrit | Ekaterina Fedorova proposed a change to stackforge/python-muranoclient: Infrastructure update https://review.openstack.org/100954 | 07:19 |
| *** gokrokve has quit IRC | 07:19 | |
| *** igormarnat has quit IRC | 07:27 | |
| *** tsufiev has quit IRC | 07:27 | |
| *** dteselkin has quit IRC | 07:27 | |
| *** ogelbukh has quit IRC | 07:27 | |
| *** dteselkin has joined #murano | 07:28 | |
| *** tsufiev has joined #murano | 07:28 | |
| *** ogelbukh has joined #murano | 07:29 | |
| *** igormarnat has joined #murano | 07:29 | |
| *** gokrokve has joined #murano | 07:35 | |
| *** gokrokve has quit IRC | 07:40 | |
| *** chandan_kumar has quit IRC | 08:01 | |
| openstackgerrit | Anastasia Kuznetsova proposed a change to stackforge/murano-dashboard: Add Test package, remove uploding of extra apps https://review.openstack.org/100846 | 08:03 |
| *** slagun has joined #murano | 08:07 | |
| *** stan_lagun has quit IRC | 08:10 | |
| *** gokrokve has joined #murano | 08:27 | |
| *** gokrokve has quit IRC | 08:32 | |
| openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano-dashboard: Refactor web UI tests https://review.openstack.org/100499 | 09:06 |
| *** openstackgerrit has quit IRC | 09:14 | |
| *** gokrokve has joined #murano | 09:28 | |
| *** gokrokve has quit IRC | 09:33 | |
| *** gokrokve has joined #murano | 10:29 | |
| *** gokrokve_ has joined #murano | 10:31 | |
| *** gokrokve has quit IRC | 10:33 | |
| *** gokrokve_ has quit IRC | 10:35 | |
| *** _ruhe_ has joined #murano | 11:11 | |
| *** gokrokve has joined #murano | 11:32 | |
| *** gokrokve has quit IRC | 11:37 | |
| sergmelikyan | slagun, https://review.openstack.org/96471 I think this patch can be merged after rebase | 11:42 |
| sergmelikyan | ativelkov ? | 11:42 |
| slagun | -1 | 11:46 |
| sergmelikyan | why? | 11:53 |
| *** sab has quit IRC | 11:53 | |
| slagun | column lengths. I'm in the middle of writing comments in gerrit | 11:53 |
| sergmelikyan | ok | 11:55 |
| *** _ruhe_ has quit IRC | 11:58 | |
| *** gokrokve has joined #murano | 12:32 | |
| *** gokrokve has quit IRC | 12:37 | |
| *** asalkeld has quit IRC | 12:37 | |
| ruhe | slagun: i don't see any reason to increase id field length. we're using uuid for id in most places. there was a debate about some fileds, but it isn't resolved yet | 13:05 |
| slagun | It doesn't matter what we use. If ID is generated by API user that is out of our control we should not assume it is UUID. Where ID is generated by API we can assume it is UUID, but lets make it 36 chars length so that if we decide to use UUID with dashes nothing will break. I don't see a problem to have larger value. Bigger is not smaller | 13:15 |
| ruhe | do you have any particular use case where a user wouldn't be able to use uuid? | 13:16 |
| ruhe | and i'm afraid my patch will become too big if i try to update some of the fields to length=36. i suggest the following: keep all the lengths as is in this patch. create a new patch which updates all IDs to length=36 | 13:18 |
| slagun | By specification ID is unique string, not UUID. We have no need to enforce it to be UUID. API users may consider having something other identity system, for example URN scheme to simplify automation. We should not care. For us ID is a string and there is no need to have so tight restrictions for this string | 13:19 |
| slagun | For example IDs of *some* object may be equal to ID in external system if objects are related | 13:20 |
| sergmelikyan | ruhe, I don't think that increasing size of fields may make you patch bigger, since whole this file is a new and no new strings are added to the file :) | 13:21 |
| slagun | how it can be big if its just a matter of changing one number to another? | 13:21 |
| ruhe | i would start thinking about that when we see some real examples | 13:21 |
| ruhe | sergmelikyan: i think that i'll need to update code which generates IDs to produce a string of 36 characters in the same patch where i update db schema | 13:23 |
| ruhe | sergmelikyan: just to keep things consistent | 13:23 |
| slagun | It is much easier to do now a(nd it costs nothing) than later to write migration to enlarge columns. I don't even sure it can be done on all supported DBMSes | 13:23 |
| slagun | I see no reason for such restrictions. Why do you want to restrict by default? | 13:23 |
| ruhe | because it'll be easier to work with. whenever we need to work with ID we'll know what the exact length is | 13:25 |
| sergmelikyan | ruhe, not necessary, there is no reason to update IDs generation logic, since we enlarging fields and there is no requirement to fill whole field by id. Id may be smaller than corresponding fields. So if we need, we can upgrade generation logic letter | 13:25 |
| slagun | ruhe, when object model is not auto-generated (like in UT or hand-made environments) it would be much more convenient to have human-readable IDs than GUID. And in that case it can be longer than 32 | 13:25 |
| slagun | ruhe, there is no use case for knowing len(ID). | 13:26 |
| sergmelikyan | Plus, I agree with automation use-case | 13:26 |
| ruhe | slagun: what about printing id in the command line client? | 13:26 |
| slagun | print function accepts string of any length | 13:27 |
| ruhe | it does, but it'll look messy. what i like about other clients and projects is that they operate with uuid. that's a behavior you expect from an openstack project | 13:29 |
| slagun | I don't suggest to change ID generation algorithm. It would still be UUID | 13:30 |
| slagun | But if some customer would like to have something else than it is his wish and he will see something else. Because IDs in OM is a customer-facing thing, not implementation detail | 13:31 |
| ruhe | we haven't seen such requests yet | 13:31 |
| slagun | For cases when ID is generated by ID it sill be 36 | 13:32 |
| slagun | ruhe, we haven't seen requests for 32 either. I don't understand why make things wrong and then wait for a bug report if we can do right from the beginning and it costs nothing | 13:33 |
| *** gokrokve has joined #murano | 13:33 | |
| *** gokrokve has quit IRC | 13:37 | |
| ruhe | so, we all agree that we'll use 36 charecter uuid string everywhere. right? also, you say there might be cases where user might need to use something other than uuid. right? | 13:40 |
| slagun | 1) We use what is currently used (32 or 36). Personally I like 32 more and both are used in OS. There is no need to change currently working code for that but lets make maximum length for auto-generated IDs be 36 to fit both formats. 2) Not necessary need, but want. Spec is saying it is unique string not that it is UUID of a fixed length and there is no need to change spec | 13:44 |
| ruhe | ok. i'll update the patch right now | 13:47 |
| ruhe | btw | 13:47 |
| ruhe | you left a comment about instance_stats. i agree that we need to get rid of this hand-made stats counting, but i think that it should be done outside of this patch | 13:48 |
| slagun | agree. But if we do this before this patch than there will be no need to recreate that table with Alembic | 13:49 |
| ruhe | because, there is API, there is StatsCollectingService | 13:49 |
| slagun | and then remove it with another migration | 13:49 |
| slagun | I understand | 13:50 |
| ruhe | removing a table shouldn't be a big problem | 13:50 |
| slagun | Maybe it would be better to remove all of this and then switch to Alembic. Thus we will eliminate unneeded migration | 13:51 |
| slagun | but it is up to you | 13:51 |
| *** TravT has joined #murano | 13:59 | |
| *** gokrokve has joined #murano | 14:04 | |
| *** sjmc7 has joined #murano | 14:14 | |
| ruhe | everyone interest in dashboard tests, please take a look at https://blueprints.launchpad.net/murano/+spec/refactor-ui-tests | 14:54 |
| ruhe | *interested | 14:54 |
| *** TravT has quit IRC | 15:26 | |
| *** TravT has joined #murano | 15:35 | |
| *** katyafervent is now known as katyafervent_awa | 15:37 | |
| *** gokrokve has quit IRC | 16:49 | |
| *** gokrokve has joined #murano | 17:18 | |
| *** sab has joined #murano | 17:50 | |
| *** sab has quit IRC | 17:54 | |
| *** slagun has quit IRC | 18:08 | |
| *** rakhmerov has quit IRC | 18:08 | |
| *** gokrokve has quit IRC | 18:08 | |
| *** tsufiev has quit IRC | 18:08 | |
| *** tnurlygayanov has quit IRC | 18:08 | |
| *** smurashov has quit IRC | 18:08 | |
| *** gokrokve has joined #murano | 18:10 | |
| *** slagun has joined #murano | 18:10 | |
| *** tsufiev has joined #murano | 18:10 | |
| *** rakhmerov has joined #murano | 18:10 | |
| *** tnurlygayanov has joined #murano | 18:10 | |
| *** smurashov has joined #murano | 18:10 | |
| *** slagun has quit IRC | 18:14 | |
| *** rakhmerov has quit IRC | 18:14 | |
| *** gokrokve has quit IRC | 18:14 | |
| *** tsufiev has quit IRC | 18:14 | |
| *** tnurlygayanov has quit IRC | 18:14 | |
| *** smurashov has quit IRC | 18:14 | |
| *** gokrokve has joined #murano | 18:16 | |
| *** slagun has joined #murano | 18:16 | |
| *** tsufiev has joined #murano | 18:16 | |
| *** rakhmerov has joined #murano | 18:16 | |
| *** tnurlygayanov has joined #murano | 18:16 | |
| *** smurashov has joined #murano | 18:16 | |
| *** slagun has quit IRC | 18:33 | |
| *** slagun has joined #murano | 18:33 | |
| *** btully has joined #murano | 19:31 | |
| *** asalkeld has joined #murano | 20:58 | |
| *** openstackgerrit has joined #murano | 21:34 | |
| openstackgerrit | Brian Tully proposed a change to stackforge/murano-dashboard: Disable all buttons and links until AppCatalog page is loaded https://review.openstack.org/99050 | 22:32 |
| *** openstackgerrit has quit IRC | 22:34 | |
| *** 20WAAHXAJ has joined #murano | 22:35 | |
| *** btully has quit IRC | 22:48 | |
| *** openstack has joined #murano | 22:50 | |
| -dickson.freenode.net- [freenode-info] if you're at a conference and other people are having trouble connecting, please mention it to staff: http://freenode.net/faq.shtml#gettinghelp | 22:50 | |
| *** 20WAAHXAJ has quit IRC | 23:29 | |
| *** openstackgerrit has joined #murano | 23:30 | |
| openstackgerrit | Stan Lagun proposed a change to stackforge/murano: MuranoPL testing mini-framework https://review.openstack.org/101370 | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!