| *** sjmc7_ has quit IRC | 01:04 | |
| *** openstackgerrit has quit IRC | 02:31 | |
| *** gokrokve has joined #murano | 02:54 | |
| *** gokrokve_ has joined #murano | 02:56 | |
| *** gokrokve has quit IRC | 02:59 | |
| *** lazy_prince has joined #murano | 04:15 | |
| *** lazy_prince has quit IRC | 04:19 | |
| *** ankurrr has quit IRC | 04:25 | |
| *** lazy_prince has joined #murano | 04:34 | |
| *** gokrokve_ has quit IRC | 04:39 | |
| *** gokrokve_ has joined #murano | 04:43 | |
| *** gokrokve_ has quit IRC | 05:02 | |
| *** gokrokve has joined #murano | 05:59 | |
| *** chandan_kumar has quit IRC | 06:00 | |
| *** gokrokve has quit IRC | 06:04 | |
| *** asalkeld has joined #murano | 06:56 | |
| *** gokrokve has joined #murano | 07:00 | |
| *** gokrokve has quit IRC | 07:04 | |
| *** gokrokve has joined #murano | 08:00 | |
| *** iyozhikov is now known as IgorYozhikov | 08:03 | |
| *** katyafervent is now known as katyafervent_awa | 08:03 | |
| *** gokrokve has quit IRC | 08:06 | |
| *** slagun has joined #murano | 08:10 | |
| *** stanlagun has quit IRC | 08:13 | |
| *** katyafervent_awa is now known as katyafervent | 08:41 | |
| *** IgorYozhikov is now known as iyozhikov | 08:41 | |
| openstackgerrit | Sergey Murashov proposed a change to stackforge/murano: Add port checks after deployment success https://review.openstack.org/101190 | 08:52 |
|---|---|---|
| *** openstackgerrit has joined #murano | 08:52 | |
| openstackgerrit | Sergey Murashov proposed a change to stackforge/murano: Define asserts for python 2.6 https://review.openstack.org/101894 | 08:53 |
| *** gokrokve has joined #murano | 09:01 | |
| *** gokrokve has quit IRC | 09:06 | |
| openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 09:13 |
| openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Update package-import command https://review.openstack.org/102162 | 09:13 |
| *** sergmelikyan has joined #murano | 09:38 | |
| *** gokrokve has joined #murano | 10:02 | |
| *** gokrokve has quit IRC | 10:07 | |
| *** gokrokve has joined #murano | 10:37 | |
| *** gokrokve has quit IRC | 10:38 | |
| *** gokrokve has joined #murano | 11:08 | |
| *** gokrokve_ has joined #murano | 11:10 | |
| *** gokrokve has quit IRC | 11:13 | |
| *** gokrokve_ has quit IRC | 11:15 | |
| sergmelikyan | smurashov, https://review.openstack.org/101894 - I think we don't need this one | 11:20 |
| sergmelikyan | smurashov, indeed, in py2.6 asserts are pretty limited in comparison with py2.7. unittests2 adds all py2.7 asserts to py2.6. | 11:25 |
| sergmelikyan | But testtools has own list of asserts that cover part of asserts that are unavailable in py2.6. | 11:25 |
| sergmelikyan | So question is: should we use unittests2 or just rewrite asserts to use testtools ones | 11:26 |
| sergmelikyan | Actually, I like way with unittests2, but I am not sure, since usage of unittests2 was removed from unit-tests in Murano by ruhe | 11:27 |
| sergmelikyan | ruhe, what do you think? | 11:27 |
| sergmelikyan | smurashov, as you pointed out tempest chooses same way: https://github.com/openstack/tempest/blob/master/tempest/test.py#L237 | 11:28 |
| smurashov | yes, i think it is good way | 11:29 |
| ruhe | sergmelikyan: we'll have to use testtools | 11:30 |
| sergmelikyan | ruhe, only testtools or in conjunction with unittests2? | 11:31 |
| smurashov | if we want to use testtools | 11:32 |
| smurashov | we have to use it in conjuction with unittest2 | 11:33 |
| ruhe | sergmelikyan: just testtools | 11:33 |
| smurashov | for python 2.6 | 11:33 |
| sergmelikyan | ruhe, tempest has blessing to combine this two libs and we don't? ) | 11:33 |
| ruhe | it's tempest. other projects use only testtools | 11:34 |
| sergmelikyan | ruhe, what about https://review.openstack.org/101894 this patch? | 11:35 |
| ruhe | ah, you're speaking about these tests... | 11:37 |
| ruhe | i don't have any objections then :) | 11:37 |
| *** gokrokve has joined #murano | 11:37 | |
| ruhe | i thought you're talking about unit tests | 11:38 |
| openstackgerrit | Anastasia Kuznetsova proposed a change to stackforge/murano: Add articles about Automated Tests https://review.openstack.org/102500 | 11:41 |
| sergmelikyan | ruhe, I talked about both of them :) | 11:42 |
| *** gokrokve has quit IRC | 11:42 | |
| * sergmelikyan can't understand why they are treated differently in same case | 11:43 | |
| openstackgerrit | Anastasia Kuznetsova proposed a change to stackforge/murano: Add articles about Automated Tests https://review.openstack.org/102500 | 11:44 |
| ruhe | so. i think that we need to keep our unit-tests based on testtools only (that's the common practice among openstack projects) and let usage of unittest2 in functional tests since tempest does so | 11:44 |
| openstackgerrit | A change was merged to stackforge/murano: MuranoPL testing mini-framework https://review.openstack.org/101370 | 11:47 |
| *** drupalmonkey has joined #murano | 12:29 | |
| *** gokrokve has joined #murano | 12:38 | |
| *** asalkeld has quit IRC | 12:42 | |
| *** gokrokve has quit IRC | 12:43 | |
| openstackgerrit | Igor Yozhikov proposed a change to stackforge/murano-deployment: Refactored RabbitMQ.py https://review.openstack.org/102513 | 12:45 |
| *** lazy_prince has quit IRC | 12:47 | |
| openstackgerrit | Sergey Murashov proposed a change to stackforge/murano: Add testresources in test-requirements https://review.openstack.org/102451 | 12:47 |
| openstackgerrit | Igor Yozhikov proposed a change to stackforge/murano-deployment: Refactored RabbitMQ.py https://review.openstack.org/102513 | 12:52 |
| openstackgerrit | A change was merged to stackforge/murano: Add port checks after deployment success https://review.openstack.org/101190 | 12:53 |
| *** gokrokve has joined #murano | 12:53 | |
| ruhe | iyozhikov: does your patch fix problems with murano-ci on centos? | 12:53 |
| ruhe | or is just refactoring? | 12:53 |
| openstackgerrit | Igor Yozhikov proposed a change to stackforge/murano-deployment: Refactored RabbitMQ.py https://review.openstack.org/102513 | 12:56 |
| iyozhikov | this is improvement | 13:00 |
| ruhe | iyozhikov: will it fix something? | 13:01 |
| iyozhikov | with suppressed log output | 13:01 |
| iyozhikov | inside jenkins job | 13:01 |
| ruhe | iyozhikov: i would avoid any improvements and refactorings until we fix the real problem with rabbitmq | 13:01 |
| sergmelikyan | iyozhikov, plus I don't like this improvement at all :) | 13:07 |
| sergmelikyan | looks like pyrabbit doesn't have any stdout by it's own | 13:08 |
| sergmelikyan | So major part of the script looks useless | 13:08 |
| * sergmelikyan does not verified this, but have a gut feeling | 13:08 | |
| *** gokrokve has quit IRC | 13:25 | |
| sergmelikyan | iyozhikov, you are right - there is a bug in pyrabbit library | 13:28 |
| sergmelikyan | I agree with ruhe about that we should avoid spending time on improvement until we fix issues with rabbitmq on the lab. | 13:29 |
| sergmelikyan | When you will return to this script - let's work together on refactoring | 13:30 |
| *** gokrokve has joined #murano | 13:30 | |
| sergmelikyan | issue for this bug is opened more than half of year ago: https://github.com/bkjones/pyrabbit/issues/18 | 13:31 |
| sergmelikyan | let's consider moving to https://www.rabbitmq.com/management-cli.html | 13:33 |
| sergmelikyan | at least it's supported by authors of RabbitMQ itself | 13:33 |
| *** gokrokve has quit IRC | 13:33 | |
| *** killer_prince has joined #murano | 13:37 | |
| *** gokrokve has joined #murano | 13:53 | |
| *** sjmc7 has joined #murano | 14:20 | |
| ruhe | slagun: hi! i've just ran tox -e py26 and saw two bad things http://paste.openstack.org/show/84876/ | 14:25 |
| ruhe | 1. deprecation warning | 14:25 |
| ruhe | 2. stack trace. i understand it's part of the test, but it might confuse people . is there any way to suppress this stack trace? | 14:26 |
| ruhe | sjmc7: hi! we're waiting for your final vote on https://review.openstack.org/#/c/100954/ | 14:31 |
| sjmc7 | ah, sorry, missed that there was another patch | 14:31 |
| sjmc7 | done, ruhe | 14:32 |
| ruhe | thank you! | 14:32 |
| sjmc7 | ruhe - the stacktrace is part of the string representation of the DSL exception | 14:32 |
| sjmc7 | i agree that looks a bit messy - is tehre any documentation describing how exceptions should be reported from DSL processing? the underlying python stack trace generally is not helpful | 14:34 |
| sjmc7 | sergmelikyan - regarding https://review.openstack.org/#/c/102321/, the dashboard tests rely on openstack_dashboard which already heavily relies on mox | 14:37 |
| sjmc7 | if we don't use it, we'd need to rewrite the base tests and/or end up with mixed styles | 14:37 |
| sjmc7 | we can make that decision i guess before we go any further, but i would prefer to use what is already there if we can | 14:38 |
| sergmelikyan | sjmc7, thank you, missed that we reusing base class from openstack_dashboard. | 14:39 |
| sergmelikyan | +1 | 14:39 |
| sjmc7 | yeah. i get what you're saying, but i think until those tests are rewritten it'll be hard to change | 14:40 |
| openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: Added Murano config checks https://review.openstack.org/101723 | 14:40 |
| sjmc7 | also i much prefer mox :) | 14:40 |
| sergmelikyan | I don't like neither actually :) | 14:44 |
| sergmelikyan | But I think we need to slightly refactor tests in that change (break to several tests in one test-case, raise having many asserts in one test) | 14:45 |
| sergmelikyan | *rather | 14:45 |
| sjmc7 | yeah, we couldn't decide either way | 14:46 |
| sjmc7 | the tests are all very closely related, but i could be persuaded either way | 14:46 |
| slagun | ruhe, it is not part of the test | 14:46 |
| slagun | does it happen on py27? | 14:46 |
| sergmelikyan | sjmc7, creation of mock may be extracted to private method, than rest of the body may splitted to several tests by comment (each commented part - one test) | 14:48 |
| sergmelikyan | I think this is how it is generally done | 14:48 |
| sjmc7 | yeah, i was about to ask - is that the way it's normally done i openstack? | 14:48 |
| *** gokrokve has quit IRC | 14:49 | |
| *** gokrokve has joined #murano | 14:49 | |
| sergmelikyan | sjmc7, I think this is how it is done not only in OS, but everywhere. I have not so much experience in writing tests, but based on my last one - https://github.com/openstack/heat/blob/master/heat/tests/test_server.py | 14:50 |
| sergmelikyan | yes | 14:50 |
| sergmelikyan | *writing tests in OS | 14:50 |
| sjmc7 | yeah, ok. drupalmonkey - this seems to be openstack practice - i'd suggest breaking the tests into functions, but you can do the setup in a private function to avoid copy and pasting | 14:51 |
| sergmelikyan | sjmc7, setup certainly should be extracted and reused :) | 14:51 |
| sergmelikyan | sjmc7, you do tests differently usually? | 14:52 |
| sjmc7 | no, but i do it like this sometimes when it's testing minor changes in input and it's not very complicated | 14:52 |
| *** gokrokve has quit IRC | 14:53 | |
| sjmc7 | ruhe/sergmelikyan - thinking about https://blueprints.launchpad.net/murano/+spec/auth-for-long-running-requests | 15:04 |
| sjmc7 | i think keystone trusts would handle this, correct? | 15:05 |
| ruhe | slagun: i've seen it only on py26 | 15:06 |
| ruhe | sjmc7: i'll speak with folks from sahara, they use trusts to execute long-running mapreduce jobs. they might give useful inputs | 15:09 |
| sjmc7 | ok. we're a bit more complicated because i think we'd need delegation (to heat + whatever else) | 15:09 |
| ruhe | right | 15:10 |
| sergmelikyan | sjmc7, I know a very little about trusts :( So I am not sure. | 15:10 |
| sergmelikyan | Trusts delegation is an open issue, afaik | 15:10 |
| sjmc7 | me neither. but passing a token around isn't very secure and is brittle | 15:10 |
| sergmelikyan | sjmc7, agree | 15:11 |
| openstackgerrit | A change was merged to stackforge/python-muranoclient: Infrastructure update https://review.openstack.org/100954 | 15:19 |
| ruhe | iyozhikov: another instance of rabbitmq failure in murano-ci https://murano-ci.mirantis.com/jenkins/job/murano-dashboard-integration-tests-ubuntu/287/console ; would be able to take a look? | 15:22 |
| *** gokrokve has joined #murano | 15:26 | |
| *** gokrokve has quit IRC | 15:26 | |
| *** killer_prince is now known as lazy_prince | 15:29 | |
| *** lazy_prince is now known as killer_prince | 15:31 | |
| *** killer_prince is now known as lazy_prince | 15:43 | |
| *** lazy_prince is now known as killer_prince | 15:48 | |
| *** gokrokve has joined #murano | 15:53 | |
| *** gokrokve has quit IRC | 16:00 | |
| ruhe | slagun, sjmc7: what's the resolution about https://review.openstack.org/#/c/100344/ ? should it be abandoned or should it be merged? | 16:17 |
| sjmc7 | working on it now. having problems with multiple inheritance | 16:17 |
| slagun | resolution is not to merge until we get sure there is no other way to implement this | 16:18 |
| sjmc7 | slagun - regarding deletion, "deploy" is not called on the environment for deletes because the task 'action' is null | 16:18 |
| slagun | sjmc7, so this is a bug in API | 16:19 |
| slagun | sjmc7 can I help with inheritance? | 16:19 |
| sjmc7 | i don't know. i'm trying to debug it | 16:19 |
| slagun | sergmelikyan, can you fix deletion in API? That were your changes :) | 16:21 |
| *** gokrokve has joined #murano | 16:51 | |
| openstackgerrit | Igor Yozhikov proposed a change to stackforge/murano-deployment: Refactored RabbitMQ.py https://review.openstack.org/102513 | 16:51 |
| sjmc7 | slagun, i'm not having much luck with this. i've got a class that does nothing but extend both LinuxInstance and HeatSWConfigInstance, both of which extend Instance | 17:13 |
| sjmc7 | the line that's failing is the first in Instance:deploy | 17:14 |
| sjmc7 | securityGroupName: coalesce($.securityGroupName...) | 17:14 |
| sjmc7 | with an AttributeError | 17:14 |
| sjmc7 | i'm struggling to understand what's going on | 17:14 |
| slagun | I'll try to reproduce it | 17:17 |
| slagun | sjmc7, I'm getting LookupError instead | 17:28 |
| sjmc7 | yeah - i added more debugging and it originates from an attributeerror | 17:28 |
| slagun | can you show me stack trace? | 17:29 |
| sjmc7 | http://paste.openstack.org/show/kqSoj76dIDDDUW0qhhTq/ | 17:30 |
| openstackgerrit | Igor Yozhikov proposed a change to stackforge/murano-deployment: Refactored RabbitMQ.py https://review.openstack.org/102513 | 17:30 |
| sjmc7 | it doesn't happen if i don't inherit from linuxinstance (although i get an error from heat because the security group doesn't exist) | 17:30 |
| slagun | can you apply locally https://review.openstack.org/#/c/100640/ and paste it once again? | 17:31 |
| sjmc7 | yep, one sec | 17:33 |
| slagun | I understand LookupError but not how you get AttributError | 17:35 |
| sjmc7 | attributeerror is raised by muranoobject | 17:35 |
| slagun | what line? | 17:36 |
| openstackgerrit | Igor Yozhikov proposed a change to stackforge/murano-deployment: Refactored RabbitMQ.py https://review.openstack.org/102513 | 17:36 |
| sjmc7 | slagun - http://paste.openstack.org/show/ZtUs9M21MbxqjL00BNoZ/ is the stacktrace with that patch | 17:36 |
| sjmc7 | muranoobject raises attributeerror in get_proparty | 17:37 |
| slagun | it is LookupError in your stack trace. How it get converted to AttributeError? | 17:38 |
| sjmc7 | not sure | 17:44 |
| slagun | anyway, I know why you get LookupError and this need to be fixed | 17:52 |
| slagun | though it's not an easy task | 17:52 |
| sjmc7 | ok. so maybe this isn't the way to go | 17:53 |
| slagun | it's just a bug | 17:53 |
| slagun | what if I fix it tomorrow? | 17:53 |
| sjmc7 | ok | 17:53 |
| slagun | meanwhile you can just comment lines 114-115 in murano_object.py | 17:54 |
| sjmc7 | which lines? i may have moved something; line 114 is try: | 17:55 |
| slagun | if i > 1: raise LookupError() | 17:55 |
| sjmc7 | ok, thanks | 17:56 |
| slagun | btw are you sure you applied https://review.openstack.org/#/c/100640/1/murano/dsl/principal_objects/stack_trace.py correctly? There are <frame object at 0x4834860> instead of method names in your stack trace. I'm wondering if its a bug of mine | 17:58 |
| sjmc7 | i'm not certain, no; i have a load of debug stuff in there | 17:58 |
| openstackgerrit | Igor Yozhikov proposed a change to stackforge/murano-deployment: Refactored RabbitMQ.py https://review.openstack.org/102513 | 18:13 |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add 'userdata_format' to Server heat template https://review.openstack.org/100344 | 18:14 |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add 'userdata_format' to Server heat template https://review.openstack.org/100344 | 18:17 |
| openstackgerrit | Igor Yozhikov proposed a change to stackforge/murano-deployment: Refactored RabbitMQ.py https://review.openstack.org/102513 | 18:28 |
| slagun | sjmc7, Am i correct saying that the changes that you've just committed https://review.openstack.org/#/c/100344/ will work only after I fix the bug and should not be merged now? | 19:01 |
| sjmc7 | they can't be used until that bug is fixed, correct | 19:02 |
| sjmc7 | but i don't think it's specific to that change | 19:02 |
| sjmc7 | it's just that the new class can't be used | 19:03 |
| *** openstackgerrit has quit IRC | 19:04 | |
| *** openstackgerrit has joined #murano | 19:05 | |
| slagun | So let me fix the bug, and then you test it on your commit and then we merge it | 19:06 |
| slagun | btw can you do the same for MuranoAgent? | 19:06 |
| sjmc7 | do what? | 19:07 |
| sjmc7 | ah.. i need to correct the windows one | 19:08 |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Add 'userdata_format' to Server heat template https://review.openstack.org/100344 | 19:09 |
| sjmc7 | slagun - i'm going to write some test cases for the exceptions i've had that are confusing, so once any patches you're working on are merged i'll run them | 19:21 |
| openstackgerrit | Ryan Peters proposed a change to stackforge/murano-dashboard: Adds test coverage for flavor filter https://review.openstack.org/102321 | 19:53 |
| *** openstackgerrit has quit IRC | 20:05 | |
| *** openstackgerrit has joined #murano | 20:05 | |
| *** asalkeld has joined #murano | 20:49 | |
| *** gokrokve_ has joined #murano | 20:58 | |
| *** gokrokve has quit IRC | 21:01 | |
| *** drupalmonkey has quit IRC | 21:40 | |
| *** drupalmonkey has joined #murano | 21:41 | |
| *** gokrokve_ has quit IRC | 21:44 | |
| *** gokrokve has joined #murano | 21:44 | |
| *** gokrokve_ has joined #murano | 21:48 | |
| *** gokrokve has quit IRC | 21:49 | |
| *** gokrokve_ has quit IRC | 21:52 | |
| *** gokrokve has joined #murano | 21:52 | |
| *** openstackgerrit has quit IRC | 22:35 | |
| *** openstackgerrit has joined #murano | 22:35 | |
| *** drupalmonkey has quit IRC | 23:39 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!