*** IlyaE has quit IRC | 00:09 | |
*** gokrokve has quit IRC | 00:15 | |
*** IlyaE has joined #murano | 00:38 | |
*** gokrokve has joined #murano | 00:55 | |
*** IlyaE has quit IRC | 00:58 | |
*** IlyaE has joined #murano | 01:27 | |
*** IlyaE has quit IRC | 01:28 | |
*** gokrokve has quit IRC | 01:35 | |
*** gokrokve has joined #murano | 01:43 | |
*** gokrokve has quit IRC | 02:11 | |
*** gokrokve has joined #murano | 02:11 | |
*** killer_prince has quit IRC | 02:26 | |
*** killer_prince has joined #murano | 03:10 | |
*** killer_prince is now known as lazy_prince | 03:10 | |
*** tbharath has joined #murano | 03:58 | |
*** drupalmonkey has quit IRC | 04:02 | |
*** tbharath has quit IRC | 04:09 | |
*** IlyaE has joined #murano | 05:13 | |
*** gokrokve has quit IRC | 05:30 | |
*** IlyaE has quit IRC | 05:40 | |
*** gokrokve has joined #murano | 06:00 | |
*** IlyaE has joined #murano | 06:12 | |
*** gokrokve has quit IRC | 06:16 | |
*** chandan_kumar has joined #murano | 06:25 | |
*** lazy_prince is now known as killer_prince | 06:28 | |
*** IlyaE has quit IRC | 06:30 | |
*** killer_prince is now known as lazy_prince | 06:39 | |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 06:54 |
---|---|---|
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Update package-import command https://review.openstack.org/102162 | 07:01 |
*** gokrokve has joined #murano | 07:12 | |
*** gokrokve has quit IRC | 07:17 | |
*** gokrokve has joined #murano | 08:13 | |
*** stan_lagun has joined #murano | 08:15 | |
*** slagun has quit IRC | 08:18 | |
*** gokrokve has quit IRC | 08:18 | |
*** gokrokve has joined #murano | 08:31 | |
*** gokrokve has quit IRC | 08:35 | |
*** gokrokve has joined #murano | 09:31 | |
*** gokrokve has quit IRC | 09:36 | |
*** lazy_prince is now known as killer_prince | 09:40 | |
*** killer_prince is now known as lazy_prince | 09:48 | |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Update package-import command https://review.openstack.org/102162 | 10:16 |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Update package-import command https://review.openstack.org/102162 | 10:17 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for contracts https://review.openstack.org/104508 | 10:25 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for contracts https://review.openstack.org/104508 | 10:26 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for contracts https://review.openstack.org/104508 | 10:32 |
*** gokrokve has joined #murano | 10:32 | |
*** gokrokve has quit IRC | 10:37 | |
*** lazy_prince has quit IRC | 10:55 | |
*** lazy_prince has joined #murano | 10:56 | |
*** gokrokve has joined #murano | 11:33 | |
*** gokrokve has quit IRC | 11:37 | |
*** gokrokve has joined #murano | 12:33 | |
*** gokrokve has quit IRC | 12:38 | |
openstackgerrit | A change was merged to stackforge/murano-deployment: Cleaned up unused files https://review.openstack.org/103855 | 12:49 |
openstackgerrit | A change was merged to stackforge/murano-deployment: Add archiving MockApp(not from app-incubator) https://review.openstack.org/100856 | 12:52 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Code refactoring and improvements for MuranoPL testing mini-framework https://review.openstack.org/104199 | 13:08 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for contracts https://review.openstack.org/104508 | 13:10 |
ruhe | katyafervent__: i couldn't understand your comment at https://review.openstack.org/#/c/99465/14 ; can you please elaborate? | 13:11 |
*** chandan_kumar is now known as chandankumar | 13:18 | |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Code refactoring and improvements for MuranoPL testing mini-framework https://review.openstack.org/104199 | 13:26 |
*** kebray- has joined #murano | 13:26 | |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for contracts https://review.openstack.org/104508 | 13:26 |
*** gokrokve has joined #murano | 13:34 | |
*** gokrokve has quit IRC | 13:39 | |
*** kebray- has quit IRC | 13:43 | |
openstackgerrit | A change was merged to stackforge/murano: Added coveragerc https://review.openstack.org/101725 | 13:49 |
katyafervent__ | ruhe, done | 14:07 |
openstackgerrit | A change was merged to stackforge/murano: Code refactoring and improvements for MuranoPL testing mini-framework https://review.openstack.org/104199 | 14:13 |
*** sjmc7 has joined #murano | 14:15 | |
*** gokrokve has joined #murano | 14:19 | |
*** gokrokve has quit IRC | 14:32 | |
*** chandankumar has quit IRC | 14:38 | |
*** gokrokve has joined #murano | 14:40 | |
*** gokrokve has quit IRC | 14:57 | |
*** IlyaE has joined #murano | 14:58 | |
*** lazy_prince is now known as killer_prince | 14:59 | |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for contracts https://review.openstack.org/104508 | 15:18 |
*** gokrokve has joined #murano | 15:24 | |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Add package-create command https://review.openstack.org/99177 | 15:32 |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/python-muranoclient: Update package-import command https://review.openstack.org/102162 | 15:32 |
stan_lagun | sjmc7: are you here? | 15:37 |
sjmc7 | hi stan - yeah | 15:37 |
stan_lagun | hi. I'd like to discuss https://review.openstack.org/#/c/104508/ with you | 15:37 |
stan_lagun | I agree with your comments | 15:38 |
stan_lagun | But I'd like to do this in separate commit | 15:38 |
stan_lagun | I've done a long list of changes that I haven't committed yet. Now I'm trying to split all those changes into list of right commits | 15:39 |
sjmc7 | ok, sure | 15:39 |
stan_lagun | this includes the problems with inheritance | 15:39 |
sjmc7 | yeah, this is exactly what i was looking for (the exception stuff) | 15:40 |
stan_lagun | It will be committed today | 15:40 |
openstackgerrit | A change was merged to stackforge/python-muranoclient: Updated from global requirements https://review.openstack.org/103605 | 15:43 |
sjmc7 | great, thanks. i was away this week, still catching up on stuff | 15:43 |
stan_lagun | There is also a change that reworks entire contract system. Besides other things it changes all exception messages and they will contain not just parameter name, but the whole path in data structure (contracts can be of composite structure) and detailed explanation what value was wrong. Thats why I left exception messages until then | 15:43 |
sjmc7 | excellent, ok | 15:43 |
sjmc7 | yeah, i'm cool with separate commits | 15:43 |
sjmc7 | i like having the exception messages tested because it makes it easy to see what behavior to expect | 15:44 |
stan_lagun | there is a downside for that - you cannot fix type or my bad English in exception messages without breaking some tests | 15:45 |
sjmc7 | :) that's ok, tests can be updated at the same time | 15:45 |
stan_lagun | ... fix typo :) | 15:46 |
openstackgerrit | A change was merged to stackforge/murano: Updated from global requirements https://review.openstack.org/103592 | 15:46 |
stan_lagun | so can you remove your -1? | 15:47 |
sjmc7 | yep, will do | 15:47 |
stan_lagun | thanks | 15:47 |
sjmc7 | done | 15:52 |
openstackgerrit | A change was merged to stackforge/murano: Unit tests for contracts https://review.openstack.org/104508 | 16:20 |
*** katyafervent__ is now known as katyafervent_awa | 16:43 | |
*** btully has joined #murano | 16:45 | |
btully | howdy folks. just wanted to give a heads up that we are on holiday here in the States | 16:45 |
btully | also stan_lagun thanks again for the patch to fix the DB migration scripts. worked like a charm | 16:46 |
*** rakhmerov has quit IRC | 16:46 | |
btully | i was doing a code review of the patch and noticed that the jenkins and murano-ci tests failed. Does that mean I shouldn't +1 the code review? | 16:47 |
*** btully has quit IRC | 16:49 | |
stan_lagun | btully: it is ruhe's work. And AFAIK it is not using collations so it is not final | 16:50 |
stan_lagun | you can +1 but we usually don't do that before Jenkins | 16:51 |
*** rakhmerov has joined #murano | 16:53 | |
stan_lagun | sjmc7: have you created that bug with inheritance on launchpad? | 17:05 |
sjmc7 | stan_lagun - i don't think so. let me see if i can find the discussion in irc | 17:07 |
stan_lagun | sjmc7: I'm ready to commit that fix. Just need bug number. I can create bug report myself if you'd like to | 17:41 |
sjmc7 | give me a sec, got distracted | 17:41 |
sjmc7 | https://bugs.launchpad.net/murano/+bug/1337458 stan_lagun | 17:47 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for method and property access https://review.openstack.org/104627 | 17:53 |
stan_lagun | sjmc7: see ^^, especially murano_object.py. Now it has 98% UT coverage so probably everything should work fine | 17:54 |
sjmc7 | cool | 17:54 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for method and property access https://review.openstack.org/104627 | 18:05 |
*** IlyaE has quit IRC | 18:28 | |
sjmc7 | does the API support a 'workers' argument? | 18:42 |
sjmc7 | openstack.common.service:launch_service supports it, but cmd/api.py doesn't pass a value in | 18:43 |
*** IlyaE has joined #murano | 18:49 | |
*** IlyaE has quit IRC | 18:57 | |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for macro blocks https://review.openstack.org/104651 | 19:10 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for macro blocks https://review.openstack.org/104651 | 19:27 |
*** IlyaE has joined #murano | 19:51 | |
*** IlyaE has quit IRC | 20:03 | |
*** sjmc7 has quit IRC | 20:05 | |
*** IlyaE has joined #murano | 20:05 | |
*** IlyaE has quit IRC | 20:24 | |
*** IlyaE has joined #murano | 20:48 | |
*** IlyaE has quit IRC | 22:13 | |
*** IlyaE has joined #murano | 22:25 | |
openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: Fix DB migration scripts https://review.openstack.org/104205 | 23:04 |
*** IlyaE has quit IRC | 23:05 | |
*** gokrokve has quit IRC | 23:12 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!