*** lecalcot has joined #murano | 00:40 | |
*** lecalcot_ has quit IRC | 00:43 | |
*** lecalcot has quit IRC | 00:45 | |
*** bharath has joined #murano | 03:42 | |
bharath | sergmelikyan, ping | 04:15 |
---|---|---|
bharath | Any one have an idea on this blueprint https://blueprints.launchpad.net/murano/+spec/show-is-public-to-package-definitions? | 04:21 |
*** tsufiev has quit IRC | 04:50 | |
*** tsufiev has joined #murano | 04:54 | |
*** openstackgerrit has quit IRC | 06:43 | |
*** bharath has quit IRC | 06:47 | |
*** bharath has joined #murano | 07:06 | |
*** tnurlygayanov has quit IRC | 09:19 | |
*** tnurlygayanov has joined #murano | 09:21 | |
*** stanlagun has joined #murano | 10:45 | |
*** slagun has joined #murano | 12:03 | |
*** stanlagun has quit IRC | 12:06 | |
*** killer_prince has quit IRC | 12:57 | |
*** killer_prince has joined #murano | 13:17 | |
*** killer_prince is now known as lazy_prince | 13:17 | |
bharath | Any one have an idea on this blueprint https://blueprints.launchpad.net/murano/+spec/show-is-public-to-package-definitions? | 14:58 |
slagun | I have | 16:31 |
bharath | slagun, I have tried to implement it | 16:44 |
bharath | slagun, when admin user uploaded package and unchecked public option(not public), so I am not showing him package uploaded by admin to demo | 16:45 |
bharath | slagun, is that the exact functionality? | 16:45 |
slagun | public is when everybody sees the package. Not public is when it is accessible only within uploader's tenant | 16:47 |
slagun | I think it is already implemented on API side. Just need to make UI for that | 16:47 |
bharath | slagun, http://postimg.org/image/4mce6zbod/ http://postimg.org/image/of5fhrozt/ http://postimg.org/image/dqdwzyc5l/ | 16:50 |
slagun | Thats you added or those screenshots are from current version? | 16:52 |
bharath | slagun, but now when admin user uploaded package in admin project and is not public, we can see that package in demo project also | 16:52 |
bharath | slagun, I added | 16:52 |
slagun | Excelent! | 16:52 |
slagun | regarding visibility - I don't know why it is visible in demo. Maybe it is a bug | 16:53 |
bharath | slagun, thanks, I will assign it to myself tomorrow, I will submit patch tomorrow | 16:54 |
bharath | slagun, I have also wrote code for that too, so that in demo project we can't see that package | 16:54 |
slagun | bharath: thanks! | 16:55 |
bharath | slagun, How to submit for review if we have changes in two different git repos? | 16:56 |
slagun | If its not public in needs to be visible only in user's tenant. No exceptions/special cases AFAIK | 16:56 |
slagun | 2 separate commits | 16:57 |
bharath | slagun, http://paste.openstack.org/show/87293/ this is what I have changed for visibility | 16:57 |
slagun | Each on partialy implements BP | 16:57 |
slagun | looks good | 16:58 |
bharath | BP? | 16:58 |
slagun | blueprint | 16:58 |
slagun | Gerrit has Partially-Implements: BP-name | 16:59 |
bharath | slagun, oh okay | 16:59 |
bharath | slagun, you mean in commit message? | 16:59 |
slagun | yes/ Gerrit extract such strings from commit messages and updates BP status | 17:00 |
slagun | on launchpad | 17:00 |
bharath | slagun, oh okay | 17:01 |
*** bharath has quit IRC | 18:13 | |
*** joefides has quit IRC | 18:17 | |
*** joefides has joined #murano | 19:18 | |
*** joefides has quit IRC | 19:22 | |
*** asalkeld has joined #murano | 21:54 | |
*** peoplemerge has quit IRC | 23:39 | |
*** peoplemerge has joined #murano | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!