| *** DaveJ__ has quit IRC | 00:58 | |
| *** bharath has joined #murano | 01:22 | |
| openstackgerrit | bharaththiruveedula proposed a change to stackforge/python-muranoclient: Adds toggle public functionality https://review.openstack.org/108760 | 01:34 |
|---|---|---|
| *** sjmc7 has quit IRC | 01:35 | |
| openstackgerrit | bharaththiruveedula proposed a change to stackforge/murano-dashboard: Adds UI for 'is_public' option https://review.openstack.org/108747 | 02:01 |
| bharath | slagun, thanks for the review | 02:02 |
| bharath | slagun, I have changed the code for murano-dashboard,murnano-client and committed again | 02:02 |
| *** bharath_ has joined #murano | 02:03 | |
| *** bharath has quit IRC | 02:07 | |
| *** bharath_ has quit IRC | 02:16 | |
| *** bharath has joined #murano | 02:17 | |
| *** bharath has quit IRC | 02:39 | |
| *** asalkeld is now known as asalkeld_afk | 03:13 | |
| *** asalkeld_afk is now known as asalkeld | 03:33 | |
| openstackgerrit | Ryan Peters proposed a change to stackforge/murano-dashboard: Implements the License and Requirements tabs https://review.openstack.org/108480 | 04:11 |
| *** asalkeld has quit IRC | 04:33 | |
| *** asalkeld has joined #murano | 04:37 | |
| *** chandankumar has joined #murano | 05:18 | |
| *** chandankumar_ has joined #murano | 05:20 | |
| *** chandankumar has quit IRC | 05:22 | |
| *** ciypro|afk has quit IRC | 05:28 | |
| *** chandankumar_ is now known as chandankumar | 05:28 | |
| *** k4n0 has joined #murano | 05:33 | |
| *** asalkeld has quit IRC | 06:53 | |
| *** asalkeld has joined #murano | 06:53 | |
| openstackgerrit | Ekaterina Chernova proposed a change to stackforge/murano-dashboard: Fix statuses for environment state https://review.openstack.org/104801 | 06:58 |
| openstackgerrit | Ekaterina Chernova proposed a change to stackforge/murano-dashboard: Fix statuses for environment state https://review.openstack.org/104801 | 07:46 |
| *** asalkeld has quit IRC | 08:54 | |
| openstackgerrit | Ekaterina Chernova proposed a change to stackforge/murano-dashboard: Fix statuses for environment state https://review.openstack.org/104801 | 09:02 |
| tsufiev | katyafervent, are we ok with making public Application Package (which may be used by someone) not public? | 09:21 |
| katyafervent | tsufiev, one again | 10:25 |
| katyafervent | make packages non public by default? | 10:25 |
| katyafervent | I guess this is nit right, because the application is something you want to share with other users in your tenant . | 10:27 |
| katyafervent | The bigger the application catalogue the better | 10:27 |
| *** AndroUser has joined #murano | 10:30 | |
| *** AndroUser has quit IRC | 10:36 | |
| tsufiev | katyafervent, I'm speaking about 'Toggle public' button - should it work like switch, or should it be one-way (say, Make public) operation? | 10:47 |
| sergmelikyan | I think already deployed applications should be fine, I think this switch should not affect murano-engine | 10:56 |
| sergmelikyan | But user will be unable to deploy this package | 10:57 |
| sergmelikyan | But this mean that this functionality can be bypassed via API | 10:57 |
| tsufiev | sergmelikyan, we could add the necessary check to murano-api | 10:58 |
| tsufiev | i mean, ask bharath to add it | 10:58 |
| *** ankurrr has quit IRC | 10:59 | |
| *** asalkeld has joined #murano | 11:10 | |
| *** ankurrr has joined #murano | 11:11 | |
| openstackgerrit | A change was merged to stackforge/murano-dashboard: Enhance versionutils.deprecated to work with classes https://review.openstack.org/103502 | 11:19 |
| *** chandankumar has quit IRC | 11:47 | |
| *** chandankumar has joined #murano | 11:49 | |
| sergmelikyan | tsufiev, murano-engine relies on murano-api, if murano-api will not return packages that are deployed, but than are hidden, all is going to fail :) | 12:02 |
| *** k4n0 has quit IRC | 12:05 | |
| *** lecalcot has joined #murano | 12:18 | |
| openstackgerrit | A change was merged to stackforge/murano: Fix tests which checks stack deletion https://review.openstack.org/108625 | 13:13 |
| *** asalkeld has quit IRC | 13:32 | |
| *** chandankumar_ has joined #murano | 14:01 | |
| *** lecalcot has quit IRC | 14:03 | |
| *** chandankumar has quit IRC | 14:04 | |
| *** lecalcot has joined #murano | 14:04 | |
| *** chandankumar_ has quit IRC | 14:04 | |
| *** chandankumar has joined #murano | 14:06 | |
| *** bharath has joined #murano | 14:07 | |
| bharath | tsufiev thanks for the review | 14:08 |
| tsufiev | bharath, you're welcome | 14:09 |
| bharath | tsufiev I didn't get you what does rebase means in this contrext? | 14:09 |
| tsufiev | bharath, it is git concept, see here http://git-scm.com/book/en/Git-Branching-Rebasing | 14:11 |
| *** drupalmonkey has joined #murano | 14:11 | |
| bharath | tsufiev oh can we get that branch? | 14:15 |
| bharath | I think it is not merged to the tree | 14:15 |
| tsufiev | bharath, you should checkout that branch with tests refactoring locally, issue 'git checkout -b test-refactoring' then switch to you branch and issue 'git rebase test-refactoring' and then 'git review' | 14:16 |
| bharath | tsufiev oh okay sry for asking small doubts | 14:17 |
| tsufiev | bharath, np :) | 14:21 |
| *** bharath_ has joined #murano | 14:22 | |
| *** bharath has quit IRC | 14:22 | |
| *** chandankumar_ has joined #murano | 14:51 | |
| *** chandankumar has quit IRC | 14:55 | |
| *** lecalcot has quit IRC | 14:59 | |
| *** lecalcot_ has joined #murano | 15:00 | |
| *** lazy_prince is now known as killer_prince | 15:12 | |
| *** bharath_ has quit IRC | 15:16 | |
| *** lecalcot_ has quit IRC | 15:25 | |
| *** lecalcot has joined #murano | 15:26 | |
| *** lecalcot has quit IRC | 15:30 | |
| *** lecalcot has joined #murano | 15:32 | |
| *** sergmelikyan has quit IRC | 16:05 | |
| *** sergmelikyan has joined #murano | 16:06 | |
| *** chandankumar_ has quit IRC | 16:13 | |
| *** sjmc7 has joined #murano | 16:18 | |
| drupalmonkey | tsufiev: about https://review.openstack.org/#/c/108473, i am not able to replicate the issue you had in the image you posted, what browser are you using, and did you clear browser's cache and such? | 16:21 |
| tsufiev | drupalmonkey, just reproduced it after clearing the cache | 16:27 |
| tsufiev | I'm using Chromium browser on Linux | 16:27 |
| tsufiev | drupalmonkey, could you try uploading and adding the same package I did? | 16:27 |
| *** lecalcot has quit IRC | 16:29 | |
| *** lecalcot has joined #murano | 16:30 | |
| *** lecalcot has quit IRC | 16:31 | |
| *** lecalcot has joined #murano | 16:31 | |
| *** bharath has joined #murano | 16:41 | |
| sjmc7 | tsufiev, can you try a different browser? | 16:42 |
| drupalmonkey | tsufiev: hmm, this is what i get with the package you sent me: http://imgur.com/tEO42bL | 16:43 |
| drupalmonkey | tsufiev: looks the same in both firefox and chrome on my mac for me | 16:43 |
| *** killer_prince is now known as lazy_prince | 16:43 | |
| tsufiev | sjmc7, drupalmonkey: just tried the Firefox - and got the same look as with Chromium | 16:45 |
| tsufiev | drupalmonkey, do you use the latest Horizon? | 16:45 |
| drupalmonkey | tsufiev: does it look like that without my patch as well? my css shouldn't affect the left/right layout stuff like that | 16:45 |
| tsufiev | drupalmonkey, no, without you patch description returns to the right side | 16:49 |
| sjmc7 | if either of you haven't already, try recreating the virtualenv | 16:49 |
| tsufiev | drupalmonkey, but I've rebased your patch onto master to avoid one bug | 16:50 |
| drupalmonkey | sjmc7: yep, i'm rebuilding my venv | 16:51 |
| * tsufiev is doing the same | 16:51 | |
| tsufiev | I have rebuilt .venv, the same issue | 16:55 |
| tsufiev | katyafervent, could you help us? | 16:56 |
| sjmc7 | hmmm | 16:56 |
| drupalmonkey | tsufiev: yep, rebuilt .venv and still do not have the issue! | 16:56 |
| tsufiev | drupalmonkey, funny ). we need a third developer | 16:56 |
| sjmc7 | casting vote! :) | 16:57 |
| bharath | tsufiev, can I use same commit message for https://review.openstack.org/#/c/106767/? | 16:58 |
| *** gokrokve has joined #murano | 17:01 | |
| tsufiev | bharath, not sure I have understood you correctly | 17:05 |
| bharath | tsufiev, you said to rebase right? so I applied those changes and I will commit with same message? | 17:06 |
| sjmc7 | bharath, yes - rebase, commit --amend | 17:07 |
| sjmc7 | same message | 17:07 |
| bharath | sjmc7, I mean for functionaltest changes? | 17:08 |
| tsufiev | bharath, did you do `git rebase -i` and select 'squash' option? Or made `git commit --amend`? If no, you should have 2 commits, not one | 17:08 |
| tsufiev | bharath, normally, you should commit your work in separate commit, not squashed into functional tests change | 17:09 |
| bharath | tsufiev, I created new branch and made changes in functionaltests | 17:10 |
| bharath | tsufiev, that's it | 17:10 |
| tsufiev | bharath, could you write down all the commands you issued to git and paste them at http://paste.openstack.org/ - and send back the link? | 17:12 |
| *** gokrokve has quit IRC | 17:12 | |
| *** gokrokve has joined #murano | 17:13 | |
| tsufiev | bharath, so I could better understand where are you now in terms of git branches | 17:13 |
| bharath | tsufiev, okay | 17:15 |
| *** lazy_prince is now known as killer_prince | 17:17 | |
| *** gokrokve has quit IRC | 17:17 | |
| bharath | tsufiev, http://paste.openstack.org/show/87792/ | 17:18 |
| tsufiev | bharath, you don't need to recreate 'functional tests refactor' commit from scracth | 17:20 |
| tsufiev | here is simpler solution: paste.openstack.org/show/87793/ | 17:20 |
| bharath | tsufiev, but it also includes another commit "a1b1581 Remove checkbox column from environments table" | 17:29 |
| *** gokrokve has joined #murano | 17:34 | |
| tsufiev | bharath, that means your local branch contains more than 1 commit | 17:38 |
| * tsufiev leaving for home | 17:39 | |
| bharath | tsufiev, but I have only commit | 17:42 |
| bharath | sjmc7, any help? | 17:45 |
| sjmc7 | i haven't been following what you're doing. you need to make a review dependent on another one? | 17:45 |
| sjmc7 | https://wiki.openstack.org/wiki/Gerrit_Workflow#Add_dependency | 17:46 |
| sjmc7 | that's the usual way of doing it | 17:46 |
| sjmc7 | except since you've already got work, you won't create a new branch, you'll rebase onto the review branch | 17:47 |
| *** sergmelikyan has quit IRC | 17:47 | |
| bharath | sjmc7, yes but while git review, it is showing three commits? | 17:48 |
| openstackgerrit | Georgy Okrokvertskhov proposed a change to stackforge/murano-dashboard: Fix topology page issue with deps and images https://review.openstack.org/104064 | 17:55 |
| sjmc7 | three? the one you're rebasing on was dependent on another commit, so that may be ok | 17:57 |
| bharath | sjmc7, but that is not dependent I guess | 17:59 |
| bharath | sjmc7, a1b1581 Remove checkbox column from environments table | 18:00 |
| *** lecalcot has quit IRC | 18:00 | |
| sjmc7 | when you add a dependency, it'll appear as a separate commit in your branch but that's ok. i'm not sure exactly what steps you've done | 18:01 |
| *** lecalcot has joined #murano | 18:01 | |
| sjmc7 | i have a meeting now, but paste the review ids in question and i'l try and take a look | 18:01 |
| *** lecalcot has quit IRC | 18:01 | |
| bharath | sjmc7, okay | 18:02 |
| *** lecalcot has joined #murano | 18:02 | |
| *** lecalcot has quit IRC | 18:04 | |
| *** lecalcot has joined #murano | 18:06 | |
| bharath | sjmc7, I got this error http://paste.openstack.org/show/87797/, can you provide the solution here, I will see the logs | 18:13 |
| sjmc7 | what is the review id of a1b1581 ? | 18:14 |
| bharath | sjmc7, 107770 | 18:14 |
| sjmc7 | why are you dependent on that? | 18:15 |
| bharath | sjmc7, I followed these steps paste.openstack.org/show/87793/ | 18:16 |
| bharath | sjmc7, then I got that one | 18:16 |
| sjmc7 | ok.. i don't understand how https://review.openstack.org/#/c/107770 ended up in there though | 18:18 |
| sjmc7 | i suggest rebasing from master | 18:19 |
| sjmc7 | which i think will squash the 1ab1581 commit | 18:19 |
| sjmc7 | since it's already merged | 18:19 |
| sjmc7 | are you working on HEAD? | 18:20 |
| bharath | sjmc7, yeah | 18:28 |
| sjmc7 | ok. so you've ended up with the checkbox commit in the same tree | 18:28 |
| bharath | sjmc7, yeah | 18:28 |
| sjmc7 | you need to create a branch from the functional test change, and apply your is_public change to that and send it for review | 18:29 |
| sjmc7 | if you work off head, you end up with chains of commits in the same reviews. better to work off branches for everything | 18:29 |
| sjmc7 | e.g. i start a new feature with git checkout -b bp/this-is-my-blueprint, or checkout -b bugs/121231 | 18:29 |
| bharath | sjmc7, create a branch from the functional test change? I didnt get you | 18:30 |
| sjmc7 | do you work with anyone that knows git well? it's hard to explain this over IRC | 18:32 |
| sjmc7 | bbiab | 18:32 |
| *** lecalcot has quit IRC | 18:32 | |
| *** lecalcot has joined #murano | 18:33 | |
| *** lecalcot has quit IRC | 18:33 | |
| bharath | sjmc7, okay | 18:33 |
| *** lecalcot has joined #murano | 18:34 | |
| openstackgerrit | Georgy Okrokvertskhov proposed a change to stackforge/murano-dashboard: Fix topology page issue with deps and images https://review.openstack.org/104064 | 18:43 |
| *** lecalcot has quit IRC | 19:05 | |
| *** lecalcot has joined #murano | 19:05 | |
| *** lecalcot_ has joined #murano | 19:07 | |
| *** lecalcot has quit IRC | 19:07 | |
| *** bharath has quit IRC | 19:14 | |
| *** bharath has joined #murano | 19:17 | |
| *** lecalcot_ has quit IRC | 19:55 | |
| *** lecalcot has joined #murano | 19:55 | |
| *** lecalcot has quit IRC | 19:55 | |
| *** lecalcot has joined #murano | 19:56 | |
| *** lecalcot_ has joined #murano | 19:58 | |
| *** lecalcot has quit IRC | 19:58 | |
| *** gokrokve has quit IRC | 20:23 | |
| *** Meena has joined #murano | 20:38 | |
| -openstackstatus- NOTICE: nodepool is unable to build test nodes so check and gate tests are delayed | 20:39 | |
| *** ChanServ changes topic to "nodepool is unable to build test nodes so check and gate tests are delayed" | 20:39 | |
| *** gokrokve has joined #murano | 20:41 | |
| *** gokrokve has quit IRC | 20:56 | |
| *** asalkeld has joined #murano | 20:57 | |
| *** bharath has quit IRC | 20:59 | |
| *** gokrokve has joined #murano | 21:10 | |
| *** lecalcot_ has quit IRC | 21:23 | |
| *** gokrokve has quit IRC | 21:46 | |
| *** gokrokve has joined #murano | 21:47 | |
| *** gokrokve has quit IRC | 21:52 | |
| *** gokrokve has joined #murano | 21:53 | |
| -openstackstatus- NOTICE: zuul is working through a backlog of jobs due to an earlier problem with nodepool | 22:04 | |
| *** ChanServ changes topic to "zuul is working through a backlog of jobs due to an earlier problem with nodepool" | 22:04 | |
| *** drupalmonkey has quit IRC | 23:02 | |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Two fixes to API unit tests https://review.openstack.org/109151 | 23:25 |
| openstackgerrit | Steve McLellan proposed a change to stackforge/murano: Default is_public to false https://review.openstack.org/109153 | 23:40 |
| *** sjmc7 has quit IRC | 23:49 | |
| *** gokrokve has quit IRC | 23:51 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!