*** gokrokve has quit IRC | 01:03 | |
*** gokrokve has joined #murano | 01:03 | |
*** gokrokve has quit IRC | 01:08 | |
*** gokrokve has joined #murano | 01:34 | |
*** gokrokve has quit IRC | 01:36 | |
*** gokrokve has joined #murano | 01:37 | |
*** gokrokve has quit IRC | 01:41 | |
*** gokrokve has joined #murano | 01:53 | |
*** gokrokve has quit IRC | 01:54 | |
*** gokrokve has joined #murano | 01:54 | |
*** gokrokve_ has joined #murano | 03:07 | |
*** gokrokve has quit IRC | 03:11 | |
*** gokrokve_ has quit IRC | 03:12 | |
*** asalkeld has left #murano | 03:45 | |
*** gokrokve has joined #murano | 04:11 | |
*** gokrokve has quit IRC | 04:21 | |
*** gokrokve has joined #murano | 04:22 | |
*** gokrokve has quit IRC | 04:26 | |
*** chandankumar has joined #murano | 04:45 | |
*** gokrokve has joined #murano | 04:50 | |
*** serg_melikyan has quit IRC | 05:37 | |
*** killer_prince has quit IRC | 05:38 | |
*** killer_prince has joined #murano | 05:39 | |
*** killer_prince is now known as lazy_prince | 05:39 | |
*** gokrokve_ has joined #murano | 05:50 | |
*** k4n0 has joined #murano | 05:51 | |
*** gokrokve has quit IRC | 05:52 | |
*** gokrokve_ has quit IRC | 05:54 | |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for MuranoPL execution result serializer https://review.openstack.org/104721 | 08:37 |
---|---|---|
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for MuranoPL execution result serializer https://review.openstack.org/104721 | 08:39 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for MuranoPL execution result serializer https://review.openstack.org/104721 | 08:59 |
openstackgerrit | Stan Lagun proposed a change to stackforge/murano: Unit tests for MuranoPL execution result serializer https://review.openstack.org/104721 | 09:02 |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/murano-dashboard: Fix url_prefix in functional tests https://review.openstack.org/110654 | 09:21 |
*** slagun has joined #murano | 09:44 | |
*** stanlagun has quit IRC | 09:48 | |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/murano-dashboard: Add wizard for package uploading https://review.openstack.org/110894 | 10:26 |
*** k4n0 has quit IRC | 12:14 | |
openstackgerrit | A change was merged to stackforge/murano-dashboard: Fix url_prefix in functional tests https://review.openstack.org/110654 | 12:39 |
*** sergmelikyan has quit IRC | 13:03 | |
*** sergmelikyan has joined #murano | 13:03 | |
*** SaD has joined #murano | 13:12 | |
*** lazy_prince has quit IRC | 13:15 | |
*** sergmelikyan has quit IRC | 13:15 | |
*** chandankumar has quit IRC | 13:15 | |
*** akuznetsova has quit IRC | 13:15 | |
*** akuznetsova has joined #murano | 13:16 | |
*** killer_prince has joined #murano | 13:16 | |
*** killer_prince is now known as lazy_prince | 13:16 | |
*** chandankumar has joined #murano | 13:16 | |
*** drupalmonkey has joined #murano | 13:41 | |
*** btully has joined #murano | 14:05 | |
*** chandankumar has quit IRC | 14:05 | |
btully | Just a heads up. There was a change merged to Horizon master a few days ago that upgrades Twitter Bootstrap from version 2.x to version 3.x. There are lots of changes in the version upgrade that affect both CSS and JS, so if you pull a recent version of Horizon master into murano-dashboard, you'll likely see a lot of broken layouts and broken functionality (i.e., modals). The workaround, for me, was to explicitly download an older version of | 14:16 |
btully | horizon - horizon-2014.2.b2.tar.gz | 14:16 |
*** sjmc7 has joined #murano | 14:27 | |
sjmc7 | ruhe - it turns out updating to horizon master was not a good idea :) | 14:32 |
sjmc7 | i'm now backing my counter suggestion of updating to the latest release (i.e. 2014.2) | 14:32 |
sjmc7 | there was a huge change last week that affected nearly all the CSS files, and has broken our dashboard | 14:33 |
btully | sjmc7 not sure if you see IRC history, but i posted about in here about 20 minutes ago | 14:33 |
sjmc7 | ah, ok :) | 14:33 |
btully | "Just a heads up. There was a change merged to Horizon master a few days ago that upgrades Twitter Bootstrap from version 2.x to version 3.x. There are lots of changes in the version upgrade that affect both CSS and JS, so if you pull a recent version of Horizon master into murano-dashboard, you'll likely see a lot of broken layouts and broken functionality (i.e., modals). The workaround, for me, was to explicitly download an older version of | 14:34 |
btully | horizon - horizon-2014.2.b2.tar.gz" | 14:34 |
sjmc7 | that'll teach me for being late :) | 14:34 |
btully | nah. it's good to spread the word | 14:34 |
sjmc7 | is there agreement to peg to 2014.2 ? | 14:34 |
btully | thanks for the suggestion to revert to 2014.2 | 14:34 |
btully | haven't heard any response. maybe folks are in meetings or lunch/dinner | 14:35 |
ruhe | sjmc7: btully: so, we just need to update the dependency in tox.ini ? | 14:39 |
ruhe | to the latest milestone | 14:39 |
sjmc7 | i think so. and document it somewhere (since typically horizon's installed separately) | 14:39 |
ruhe | and file a critical bug | 14:39 |
sjmc7 | the alternative is to fix it, and have people use 2014.2 to match horizon 2014.2 | 14:40 |
btully | yes, that's a start. but you might need to explicitly download it again if you've already uprgraded to master. I had to delete horizon along with my pip cache and then run pip install http://tarballs.openstack.org/horizon/horizon-2014.2.b2.tar.gz | 14:41 |
sjmc7 | the problem for us is that we're going to be releasing things in a few weeks | 14:41 |
sjmc7 | but with horizon juno.2 | 14:41 |
ruhe | sjmc7: btully: is there a bug i could refer to in the commit message? (or should i create one?) | 14:43 |
btully | there is this bug that was filed against dashboard | 14:45 |
btully | https://bugs.launchpad.net/murano/+bug/1349894 | 14:45 |
sjmc7 | https://bugs.launchpad.net/murano/+bug/1349894, ruhe | 14:45 |
sjmc7 | jinx! | 14:45 |
btully | and in that bug there is a comment where I refer to the commit in horizon that broke things | 14:45 |
btully | http://git.openstack.org/cgit/openstack/horizon/commit/?id=92146772b677e9fce57cc11b4a4a1542a05c23b2 | 14:45 |
katyafervent | btully, I was in the middle of creation the same bugs | 14:47 |
openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano-dashboard: Switch to Horizon 2014.2.b2 https://review.openstack.org/110983 | 14:47 |
sjmc7 | we need to figure out what we do longer term i guess, when we switch versions | 14:47 |
btully | While it will be a lot of work, the good news is that there is some documentation on what the changes are in bootstrap 2 and 3 | 14:47 |
btully | This is a good start http://www.bootply.com/bootstrap-3-migration-guide | 14:48 |
sjmc7 | this means devstack will be broken, for instance | 14:48 |
btully | and http://upgrade-bootstrap.bootply.com/ | 14:48 |
sjmc7 | so actually... maybe this isn't the right fix | 14:48 |
*** sjmc7_ has joined #murano | 14:50 | |
katyafervent | but we still need to update murano to work with bootstrap 3, right? | 14:50 |
sjmc7_ | urgh, what a pain | 14:50 |
sjmc7_ | yeah, i think we will. otherwise anyone installing from devstack is going to immediately hit a problem | 14:51 |
katyafervent | and all selenium tests also need to be updated | 14:51 |
btully | yup, good call on the selenium tests | 14:51 |
sjmc7_ | ruhe - when was the 2014.2 release? | 14:52 |
sjmc7_ | for murano-dashboard, i mean | 14:52 |
ruhe | sjmc7_: jul24 | 14:52 |
*** gokrokve has joined #murano | 14:52 | |
sjmc7_ | ok. i think katyafervent is right - we will need to fix it | 14:53 |
ruhe | horizon 2014.2.b2 was release on jul23 | 14:53 |
ruhe | yeah, i think i need to abandon my patch | 14:53 |
ruhe | and mark that bug as critical | 14:53 |
sjmc7_ | ok. so for our release, we're going to have to use 2014.2 and cherry-pick anything since then | 14:53 |
sjmc7_ | urgh | 14:53 |
*** sjmc7 has quit IRC | 14:53 | |
*** sjmc7_ is now known as sjmc7 | 14:53 | |
ruhe | sjmc7: we'll need to make sure that patches you're going to cherry-pick do not rely on anything new from horizon master | 14:56 |
ruhe | just need to be more carefull | 14:56 |
sjmc7 | yeah. i'll identify anything we need. it also means the muranoclient version will be stuck at whatever was released for 2014.2 | 14:56 |
sjmc7 | which is also a pain | 14:56 |
sjmc7 | ok, so we're agreed we need to do the update | 14:57 |
sjmc7 | ruhe - separate issue; our automated test runner is failing on the db.migration.test_migrations.TestMigrations.test_postgresql_opportunistically test | 14:57 |
ruhe | sjmc7: there is no problem in releasing of new version of client as long as it is compatible with the dashboard 2014.2.b2 | 14:58 |
sjmc7 | ok | 14:58 |
openstackgerrit | Georgy Okrokvertskhov proposed a change to stackforge/murano: Adds REST API endpoint for action execution https://review.openstack.org/99449 | 14:58 |
ruhe | sjmc7: can you share corresponding logs? | 14:58 |
sjmc7 | yeah | 14:58 |
sjmc7 | http://paste.openstack.org/show/89393/ | 14:59 |
ruhe | the damn thing hides valuable error messages somewhere | 14:59 |
sjmc7 | http://paste.openstack.org/show/89396/ | 15:00 |
sjmc7 | more context | 15:00 |
sjmc7 | 'failed to migrate to version' | 15:00 |
sjmc7 | psycopg2 2.5.3 installed | 15:01 |
ruhe | sjmc7: can you update test_migrations_base.py and re-run the test? it's in the bottom of the file, we don't print the error message | 15:04 |
sjmc7 | this is an automated test; i don't have access to the environment | 15:04 |
sjmc7 | we have a CI server somewhere | 15:04 |
ruhe | would it be triggered if i send a patch on review? | 15:05 |
sjmc7 | umm... i might be able to force it to run, yeah | 15:06 |
sjmc7 | usually it just runs nightly off master | 15:06 |
openstackgerrit | Dmitry Teselkin proposed a change to stackforge/murano-deployment: Scripts to run dashboard tests on devstack https://review.openstack.org/110988 | 15:07 |
openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: Added logging for DB migration tests https://review.openstack.org/110989 | 15:09 |
ruhe | sjmc7: we'll get more details if this ^^ changes gets merged today | 15:09 |
sjmc7 | that should do the same thing | 15:10 |
sjmc7 | raise with no argument should reraise the caught exception | 15:10 |
sjmc7 | ah, i see, you added the error | 15:10 |
sjmc7 | the 'as e' 'raise e' isn't necessary | 15:10 |
katyafervent | If someone has a better English, please, fix the title and description of this bug https://bugs.launchpad.net/murano/+bug/1350900 | 15:10 |
sjmc7 | it's like a poem, katyafervent! i like it | 15:11 |
katyafervent | :) | 15:11 |
sjmc7 | ruhe, ok if i just approve that review now? | 15:12 |
ruhe | sjmc7: let's just wait for +1 from jenkins | 15:12 |
sjmc7 | yep | 15:12 |
ruhe | sjmc7: about as e' 'raise e'. does it apply to python 2.6? | 15:12 |
ruhe | does it behave the same way in python 2.6 and 2.7? | 15:13 |
sjmc7 | i think so.. i can't remember it not ever working | 15:13 |
sjmc7 | no harm doing it | 15:14 |
openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: Fixes to unit tests around policies https://review.openstack.org/109151 | 15:22 |
sjmc7 | thanks | 15:23 |
ruhe | it's just an automatic rebase. i don't know why zuul/gerrit couldn't do that for us | 15:23 |
sjmc7 | being difficult :) | 15:24 |
ruhe | i also want to find out why your patch https://review.openstack.org/#/c/109153/ is still failing on migrations | 15:25 |
sjmc7 | ah, it's the same error | 15:27 |
sjmc7 | as we're getting from our CI | 15:27 |
sjmc7 | so that's good, we can just tweak this patch | 15:27 |
ruhe | so, who's going to fix the horizon-master issue? can we split that work? katyafervent do you volunteer to be one of the heroes? | 15:29 |
katyafervent | Sure :) | 15:30 |
katyafervent | That should be just one problem for all our forms | 15:30 |
katyafervent | I can take this bug https://bugs.launchpad.net/horizon/+bug/1258421 | 15:30 |
btully | i'll volunteer as well | 15:30 |
katyafervent | btully, you can take that one https://bugs.launchpad.net/murano/+bug/1350900 | 15:31 |
sjmc7 | ruhe - same problem for https://review.openstack.org/#/c/109769/ | 15:31 |
btully | sure thing | 15:31 |
katyafervent | If you need more details - ask me | 15:31 |
ruhe | great! thank you katyafervent and btully! | 15:32 |
sjmc7 | ruhe - other patches are failing too on the same error | 15:33 |
sjmc7 | https://review.openstack.org/#/c/104721/ is one of stan's | 15:33 |
ruhe | sjmc7: i guess all of them have the same root cause | 15:33 |
btully | so how would we manage the commits to prevent anything from getting merged? | 15:33 |
ruhe | sjmc7: i'm working on that | 15:33 |
btully | did we agree to stick with 2014.2? | 15:33 |
sjmc7 | no btully | 15:34 |
btully | for next release? | 15:34 |
sjmc7 | er... "we" in hp, yes. the project will stick with master | 15:34 |
sjmc7 | so we'll fix it as though the discussion had enver happened | 15:34 |
btully | k | 15:34 |
sjmc7 | and we (hp) will not include the patch in our next release | 15:34 |
*** PierreRambaud has quit IRC | 15:43 | |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/murano-dashboard: Fix functional tests due to Bootstrap Update https://review.openstack.org/111000 | 15:46 |
openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: Default is_public to false https://review.openstack.org/109153 | 16:02 |
sjmc7 | tests are taking a long time today ruhe | 16:06 |
openstackgerrit | Dmitry Teselkin proposed a change to stackforge/murano-deployment: Scripts to run dashboard tests on devstack https://review.openstack.org/110988 | 16:13 |
*** gokrokve has quit IRC | 16:17 | |
ruhe | sjmc7: it's always like this. zuul queue is almost empty during our day and it gets crowded when folks in US wake up :) | 16:20 |
sjmc7 | :) | 16:20 |
*** mpitchiah has joined #murano | 16:24 | |
*** SaD has quit IRC | 16:27 | |
*** sergmelikyan has joined #murano | 16:27 | |
*** lazy_prince has quit IRC | 16:33 | |
openstackgerrit | Dmitry Teselkin proposed a change to stackforge/murano-deployment: Scripts to run dashboard tests on devstack https://review.openstack.org/110988 | 16:39 |
openstackgerrit | Dmitry Teselkin proposed a change to stackforge/murano-deployment: Scripts to run dashboard tests on devstack https://review.openstack.org/110988 | 16:42 |
*** killer_prince has joined #murano | 16:43 | |
*** killer_prince is now known as lazy_prince | 16:43 | |
*** gokrokve has joined #murano | 16:43 | |
*** gokrokve has quit IRC | 17:03 | |
*** gokrokve has joined #murano | 17:04 | |
btully | can someone explain to me how we inject the Murano navigation into the left sidebar? | 17:05 |
sjmc7 | me? :) | 17:05 |
btully | hehe was hoping not to bother you | 17:06 |
sjmc7 | it's all django - look at settings.py where murano-dashboard is added to the list of installed dashboards | 17:07 |
btully | HORIZON_CONFIG['dashboards'] += ('murano',) | 17:07 |
sjmc7 | yep, and then in muranodashboard/dashboards.py it registers the murano dashboards | 17:08 |
sjmc7 | some details at http://docs.openstack.org/developer/horizon/topics/tutorial.html | 17:08 |
btully | super, thanks | 17:08 |
*** sergmelikyan has quit IRC | 17:41 | |
*** sergmelikyan has joined #murano | 17:41 | |
sergmelikyan | https://github.com/sergmelikyan/io.murano.apps.linux.TwoInstances/commit/8888a96dd5bd3bab010cc3d9f8a2924178eba30a - share with bharath | 17:41 |
ruhe | CONTRIBUTING.rst should have a link to "how to setup an IRC bouncer" :) | 17:43 |
openstackgerrit | Ekaterina Chernova proposed a change to stackforge/murano-dashboard: Update to Twitter Botstrap 3 https://review.openstack.org/111020 | 17:45 |
btully | ruhe i just added a new blueprint for your review that I think will be useful when implemented and harmless if not utilized | 18:17 |
btully | https://blueprints.launchpad.net/murano/+spec/add-ability-to-override-dashboard-name | 18:17 |
btully | i have a 1 liner that implements it | 18:18 |
*** slagun has quit IRC | 18:33 | |
*** stanlagun has joined #murano | 18:50 | |
openstackgerrit | Georgy Okrokvertskhov proposed a change to stackforge/murano: Adds REST API endpoint for action execution https://review.openstack.org/99449 | 18:58 |
sjmc7 | ruhe - any luck with the test issue? can i be of assistance? | 19:33 |
sjmc7 | stanlagun - is there a concept of 'protected' in the inheritance model in muranopl? | 19:50 |
stanlagun | no. All methods are public | 19:50 |
sjmc7 | and all state is private? | 19:50 |
sjmc7 | or rather, immutable? | 19:50 |
stanlagun | immutable methods??? | 19:51 |
sjmc7 | state. variables | 19:51 |
sjmc7 | and related - the modifications you use to speed up the cycle of modifying a model and re-deploying it, are they documented/easy to copy? | 19:52 |
sjmc7 | it would be great if we could port it all to the CLI | 19:54 |
stanlagun | there is no access control available yet. Everything that is persisted in object model can be accessed by any class. The only exception are attributes. You can have getter methods with backing attribute to expose data that can be modified only by the owner class | 19:54 |
sjmc7 | that's what i thought, thanks | 19:55 |
stanlagun | no that is just a hack of my own. There is a BP to make it official | 19:55 |
sjmc7 | ok. are there big barriers to supporting it via CLI calls? | 19:56 |
stanlagun | I don't get how this is connects to CLI. Maybe we are talking about different things? | 19:56 |
sjmc7 | sergmelikyan, if you're there - https://blueprints.launchpad.net/murano/+spec/software-config-at-deploy-time | 19:56 |
sjmc7 | what we discussed yesterday | 19:56 |
openstackgerrit | Ruslan Kamaldinov proposed a change to stackforge/murano: [WIP] Default is_public to false https://review.openstack.org/111063 | 19:57 |
ruhe | that's just to find out why the original patch fails on DB migrations | 19:58 |
sjmc7 | why do you always use my patches when you're experimenting? :) | 19:58 |
stanlagun | What I do is patching engine code to work with different class loader and immediately working on some hardcoded object model. CLI talks to API, not engine. | 19:58 |
sjmc7 | stanlagun - yeah, i understand your hack isn't one we can use generally, but it should be possible to upload a package and deploy via the CLI at some stage | 19:59 |
stanlagun | This may be difficult because of current API - it was designed for another product and needs to be redesigned. But if you upload the package to database (via API) and can provide object model JSON you can do it already (at least to some degree) | 20:04 |
stanlagun | You cannot have "deploy this package" command :) | 20:05 |
sjmc7 | no, i guess not. it would be nice to speed up the package deploy cycle at least for development tho | 20:07 |
stanlagun | You can make configuration switch that will make engine load packages from 'meta' folder on disk instead on API. And then symlink your package to it. And then write simple CLI tool that sends object model to engine via RabbitMQ | 20:10 |
stanlagun | But much better to have complex solution for that: https://blueprints.launchpad.net/murano/+spec/simulated-execution-mode-murano-engine | 20:11 |
stanlagun | the idea is to have "debug mode" switch in engine that will allow sumbitting JSON that contains object model, login/password in keystone, list of directories where engine should search for packages and the level of mocking (mock Heat, mock Agents etc) | 20:14 |
stanlagun | +CLI tool to submit that JSON | 20:14 |
*** asalkeld has joined #murano | 20:53 | |
*** gokrokve has quit IRC | 20:54 | |
*** openstackgerrit has quit IRC | 21:01 | |
*** openstackgerrit has joined #murano | 21:02 | |
*** openstack has joined #murano | 21:08 | |
*** asalkeld has left #murano | 21:25 | |
*** gokrokve has joined #murano | 22:07 | |
*** tsufiev has quit IRC | 23:04 | |
*** tsufiev has joined #murano | 23:09 | |
*** asalkeld has joined #murano | 23:12 | |
*** asalkeld has left #murano | 23:12 | |
openstackgerrit | Steve McLellan proposed a change to stackforge/python-muranoclient: Support keystone v3 https://review.openstack.org/111117 | 23:38 |
*** sjmc7 has quit IRC | 23:48 | |
*** lazy_prince has quit IRC | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!