*** gokrokve_ has joined #murano | 00:50 | |
*** gokrokve has quit IRC | 00:52 | |
*** gokrokve_ has quit IRC | 00:55 | |
*** gokrokve has joined #murano | 00:56 | |
*** gokrokve has quit IRC | 01:00 | |
*** gokrokve has joined #murano | 01:26 | |
*** gokrokve has quit IRC | 01:27 | |
*** gokrokve has joined #murano | 01:28 | |
*** gokrokve has quit IRC | 01:32 | |
*** gokrokve has joined #murano | 01:40 | |
*** gokrokve has quit IRC | 01:44 | |
*** asalkeld has quit IRC | 02:13 | |
*** asalkeld has joined #murano | 02:27 | |
*** gokrokve has joined #murano | 02:40 | |
*** gokrokve has quit IRC | 02:45 | |
*** asalkeld has quit IRC | 03:16 | |
*** asalkeld has joined #murano | 03:36 | |
*** gokrokve has joined #murano | 03:40 | |
*** gokrokve has quit IRC | 03:45 | |
*** chandankumar has joined #murano | 04:11 | |
*** asalkeld has quit IRC | 04:25 | |
*** chandankumar has quit IRC | 04:38 | |
*** asalkeld has joined #murano | 04:42 | |
*** gokrokve has joined #murano | 04:48 | |
*** chandankumar has joined #murano | 04:51 | |
*** gokrokve has quit IRC | 04:52 | |
*** killer_prince is now known as lazy_prince | 04:53 | |
*** gokrokve has joined #murano | 05:13 | |
*** gokrokve has quit IRC | 05:18 | |
*** gokrokve has joined #murano | 05:40 | |
*** asalkeld has quit IRC | 05:44 | |
*** gokrokve has quit IRC | 05:46 | |
*** k4n0 has joined #murano | 06:06 | |
*** asalkeld has joined #murano | 06:12 | |
*** chandankumar has quit IRC | 07:01 | |
*** openstackgerrit has quit IRC | 07:02 | |
*** romainh has joined #murano | 07:16 | |
*** gokrokve has joined #murano | 07:40 | |
*** gokrokve has quit IRC | 07:42 | |
*** gokrokve has joined #murano | 07:42 | |
*** gokrokve has quit IRC | 07:46 | |
*** stan_lagun has joined #murano | 08:18 | |
*** slagun has quit IRC | 08:21 | |
*** gokrokve has joined #murano | 08:40 | |
*** sjmc7 has quit IRC | 08:43 | |
*** gokrokve has quit IRC | 08:46 | |
*** romainh has quit IRC | 09:35 | |
*** gokrokve has joined #murano | 09:40 | |
*** gokrokve has quit IRC | 09:45 | |
*** gokrokve has joined #murano | 10:40 | |
*** gokrokve has quit IRC | 10:44 | |
*** asalkeld has quit IRC | 10:52 | |
*** romainh has joined #murano | 11:11 | |
*** asalkeld has joined #murano | 11:24 | |
*** gokrokve has joined #murano | 11:40 | |
*** gokrokve has quit IRC | 11:45 | |
*** k4n0 has quit IRC | 11:46 | |
*** sergmelikyan has quit IRC | 12:19 | |
*** asalkeld has quit IRC | 12:40 | |
*** lazy_prince is now known as killer_prince | 13:36 | |
*** gokrokve has joined #murano | 13:40 | |
*** gokrokve has quit IRC | 13:45 | |
*** gokrokve has joined #murano | 13:56 | |
*** drupalmonkey has joined #murano | 14:05 | |
*** openstackgerrit has joined #murano | 14:05 | |
*** sergmelikyan has joined #murano | 14:06 | |
*** sjmc7 has joined #murano | 14:12 | |
*** sjmc7_ has joined #murano | 14:13 | |
*** sjmc7 has quit IRC | 14:17 | |
*** killer_prince is now known as lazy_prince | 14:18 | |
*** sjmc7_ is now known as sjmc7 | 14:21 | |
openstackgerrit | A change was merged to stackforge/murano-dashboard: Set permissions for Murano dashboard https://review.openstack.org/117807 | 14:43 |
---|---|---|
*** btully has joined #murano | 14:52 | |
*** gokrokve has quit IRC | 15:15 | |
openstackgerrit | Serg Melikyan proposed a change to stackforge/murano: Remove partial clean-up in Instance.destroy https://review.openstack.org/118172 | 15:16 |
*** gokrokve has joined #murano | 15:19 | |
*** Murali has joined #murano | 15:22 | |
*** sjmc7 has quit IRC | 15:38 | |
*** sjmc7 has joined #murano | 15:39 | |
sjmc7 | sergmelikyan - i think https://review.openstack.org/#/c/118107/ may have introduced a problem | 15:54 |
sjmc7 | or possibly exposed a problem | 15:55 |
btully | katyafervent: when you get a chance, can you read this? https://bugs.launchpad.net/murano/+bug/1357220/comments/8 | 15:55 |
sjmc7 | it looks like Default no longer works for Runtime properties? | 15:55 |
stan_lagun | sjmc7: it never supposed to | 15:57 |
stan_lagun | Runtimes are what you instantiate in 'initialize' | 15:57 |
sjmc7 | ok | 15:57 |
sergmelikyan | sjmc7, Runtime properties should not have defaults | 15:59 |
sjmc7 | if i have a property that i want to default to an empty list, and will be assigned later, what is the appropriate Usage? | 15:59 |
sergmelikyan | brrrrr | 15:59 |
sergmelikyan | forgot what I have said | 15:59 |
sergmelikyan | 'In' if it not intended to be passed from ObjectModel | 16:00 |
sergmelikyan | InOut (one that is by default) when it can be passed | 16:00 |
stan_lagun | though it my be reasonable to initialize Runtime properties with their default value/null. But not to try to get value from object model | 16:00 |
sjmc7 | as an example, softwareConfigs in https://github.com/stackforge/murano/blob/master/meta/io.murano/Classes/resources/HeatSWConfigInstance.yaml | 16:01 |
stan_lagun | sergmelikyan: In it the default | 16:01 |
stan_lagun | sergmelikyan: and 'In' values are from OM | 16:01 |
sergmelikyan | http://murano.readthedocs.org/en/latest/articles/murano_pl.html#usage | 16:02 |
sergmelikyan | Yeah, I am wrong | 16:02 |
sjmc7 | in my case, Runtime seems correct | 16:03 |
*** Murali has quit IRC | 16:04 | |
sergmelikyan | sjmc7, yes, Runtime seems correct here... and looks like #1357220 introduced behavior when Runtime properties can't have defaults | 16:04 |
*** Murali has joined #murano | 16:04 | |
sjmc7 | 1357220 is the dashboard. so what behavior is correct - Runtime properties cannot have Defaults? or they can? | 16:06 |
stan_lagun | sjmc7: they can | 16:08 |
stan_lagun | sergmelikyan: lets improve that commit | 16:08 |
sergmelikyan | They was not supposed to have defaults and it was side-effect of the bug. But I think that we should fix this | 16:09 |
sergmelikyan | https://bugs.launchpad.net/murano/+filebug | 16:09 |
sergmelikyan | https://bugs.launchpad.net/murano/+bug/1364484 | 16:09 |
sergmelikyan | stan_lagun, commit was already merged :( | 16:09 |
stan_lagun | sjmc7: sergmelikyan: on a second thought this need more thinking | 16:10 |
sjmc7 | if they're not supposed to have Defaults, then that should be enforced and the documentation and heatSWconfig template changed. currently it fails silently | 16:10 |
sergmelikyan | stan_lagun, can you share your second thoughts? Why it is bad idea to have defaults? | 16:10 |
sergmelikyan | sjmc7, definitely | 16:10 |
stan_lagun | sergmelikyan: is is not bad. The tricky part is when to initialize such properties. You must not try to initialize them with values from OM. Suppose that you have runtime property with notNull() contract that initilized in 'initialize'. It has no Default. If you try to initialize it with something you get an exception | 16:12 |
sergmelikyan | mm can you explain a little bit more? I didn't get example | 16:14 |
stan_lagun | sergmelikyan: and if you don't and forget to initilize it in constructor you need exception to be thrown | 16:14 |
stan_lagun | imagine runtime property without default and with notNull() contract | 16:14 |
stan_lagun | you cannot use null to initialize it | 16:16 |
sergmelikyan | yes | 16:16 |
stan_lagun | You can initialize only those runtime properties that have explicit Default | 16:16 |
ruhe | stan_lagun: i know you're on vacation. but can i ask you to either 1) update trusts BP with the latests findings you have or 2) give an update on weekly IRC meeting? #1 is preferrable | 16:16 |
stan_lagun | ruhe: ok | 16:17 |
stan_lagun | sergmelikyan: but this is also bad | 16:17 |
stan_lagun | at least because if you initialize only properties with Default you won't get an exception if you forget to initialize it in 'initialize' method | 16:19 |
sergmelikyan | stan_lagun, what is your suggestion for issue found by sjmc7? | 16:20 |
stan_lagun | what you need to do is to initialize runtime properties *after* 'initialize' method and initialize it with their current value (setPropertyValue('xxx', getPropertyValue('xxx')) so that they either remain the same or the setter will use default for NoValue | 16:22 |
stan_lagun | this is a little bit tricky (even to explain) | 16:22 |
stan_lagun | so I suggest for now just to move initialization to 'initialize' and not to rely on Default. I will improve this as soon as I get back from vacation | 16:23 |
ruhe | sjmc7: please take a look at whiteboard of https://blueprints.launchpad.net/murano/+spec/auth-for-long-running-requests | 16:45 |
ruhe | i've put this into a topic for irc meeting | 16:45 |
ruhe | folks, please update https://wiki.openstack.org/wiki/Meetings/MuranoAgenda#Agenda if you have something to discuss today | 16:45 |
sjmc7 | ruhe - i'm double booked here already. i'll keep an eye on the meeting but i won't be very noisy | 16:46 |
*** gokrokve has quit IRC | 16:47 | |
ruhe | sjmc7: ok. i see. please drop a note on the whiteboard when you have time then (if you have any comments) | 16:47 |
*** katyafervent2 has joined #murano | 17:00 | |
*** lazy_prince is now known as killer_prince | 17:01 | |
*** ankurrr has joined #murano | 17:09 | |
*** romainh has quit IRC | 17:11 | |
*** katyafervent2 has quit IRC | 17:38 | |
*** gokrokve has joined #murano | 18:44 | |
*** romainh has joined #murano | 19:14 | |
*** dteselkin has quit IRC | 19:14 | |
*** igormarnat has quit IRC | 19:14 | |
*** katyafervent has quit IRC | 19:15 | |
*** IgorYozhikov has quit IRC | 19:15 | |
*** igormarnat has joined #murano | 19:15 | |
*** IgorYozhikov has joined #murano | 19:15 | |
*** dteselkin has joined #murano | 19:18 | |
*** katyafervent has joined #murano | 19:20 | |
*** romainh has left #murano | 19:35 | |
*** stan_lagun has quit IRC | 20:56 | |
*** romainh has joined #murano | 21:10 | |
*** Murali has quit IRC | 21:22 | |
*** Murali has joined #murano | 21:23 | |
*** asalkeld has joined #murano | 21:24 | |
*** asalkeld has quit IRC | 21:43 | |
*** drupalmonkey has quit IRC | 21:49 | |
*** asalkeld has joined #murano | 21:52 | |
*** Murali has quit IRC | 22:13 | |
*** romainh has left #murano | 22:42 | |
*** gokrokve has quit IRC | 23:23 | |
*** gokrokve has joined #murano | 23:23 | |
*** gokrokve has quit IRC | 23:44 | |
*** gokrokve has joined #murano | 23:45 | |
*** gokrokve has quit IRC | 23:49 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!