| *** drupalmonkey has quit IRC | 00:00 | |
| serg_melikyan | Ok | 00:04 |
|---|---|---|
| serg_melikyan | can we restore somehow patch that was merged? | 00:04 |
| ruhe | serg_melikyan: just revert the actual commit | 00:10 |
| ruhe | git revert 65f514 | 00:12 |
| serg_melikyan | I mean, after revert: merge a -> revert a -> put back changes from a to git review | 00:13 |
| serg_melikyan | Is there short way to do the last part? | 00:13 |
| ruhe | i don't get it. can you elabore a bit more? | 00:15 |
| serg_melikyan | I want to get original changeset from Steve back to review | 00:18 |
| ruhe | ah | 00:19 |
| ruhe | cherry-pick it | 00:20 |
| ruhe | but replace change id | 00:20 |
| *** serg_melikyan has quit IRC | 00:30 | |
| *** serg_melikyan has joined #murano | 00:32 | |
| openstackgerrit | Serg Melikyan proposed stackforge/python-muranoclient: Revert "Add keystone v3 support to client" https://review.openstack.org/141529 | 00:32 |
| *** serg_melikyan has quit IRC | 00:45 | |
| stan_lagun | I found why it fails | 00:52 |
| stan_lagun | Instead of reverting https://review.openstack.org/#/c/141529/ I can try to fix it | 00:53 |
| stan_lagun | the problem is how to test it | 00:54 |
| *** IlyaE has quit IRC | 00:58 | |
| *** serg_melikyan has joined #murano | 01:10 | |
| serg_melikyan | stan_lagun: can you elaborate a little bit more? | 01:11 |
| serg_melikyan | It fails die to incorrect http request IMO | 01:11 |
| stan_lagun | serg_melikyan: forget it. I was wrong | 01:11 |
| serg_melikyan | stan_lagun: https://review.openstack.org/#/c/111117/16/muranoclient/v1/packages.py | 01:11 |
| serg_melikyan | stan_lagun: ok | 01:11 |
| serg_melikyan | once https://review.openstack.org/141529 we can start rechecking jobs | 01:12 |
| serg_melikyan | *will be merged | 01:12 |
| stan_lagun | I'm not sure it will help | 01:13 |
| stan_lagun | I will be surprised if it will | 01:13 |
| stan_lagun | Because I've studied its code and how it works | 01:13 |
| *** serg_melikyan has quit IRC | 01:16 | |
| *** serg_melikyan has joined #murano | 01:16 | |
| *** serg_melikyan has quit IRC | 01:16 | |
| *** serg_melikyan has joined #murano | 01:17 | |
| serg_melikyan | I have debugged this | 01:17 |
| serg_melikyan | issue indeed caused by this patch and by this particular lines. I am pretty sure | 01:17 |
| stan_lagun | i just don't see how | 01:19 |
| serg_melikyan | https://github.com/stackforge/python-muranoclient/blob/master/muranoclient/v1/packages.py#L53 | 01:19 |
| serg_melikyan | we call raw_request to send body + files (essentially POST multi-part/data) | 01:20 |
| stan_lagun | we still do it | 01:20 |
| serg_melikyan | here we set Content-Type to https://github.com/stackforge/python-muranoclient/blob/bac56b4989a8d707917d43361382908f3c685cce/muranoclient/common/http.py#L262 | 01:20 |
| serg_melikyan | application/octet-stream | 01:20 |
| serg_melikyan | and after that murano-api returns 415 for this request | 01:21 |
| serg_melikyan | code in murano-api: https://github.com/stackforge/murano/blob/master/murano/common/wsgi.py#L668 | 01:22 |
| serg_melikyan | https://github.com/stackforge/murano/blob/master/murano/common/wsgi.py#L324 | 01:23 |
| serg_melikyan | https://github.com/stackforge/murano/blob/master/murano/common/wsgi.py#L285 | 01:23 |
| stan_lagun | serg_melikyan: I saw all of this | 01:23 |
| serg_melikyan | as you see no application/octet-stream | 01:23 |
| serg_melikyan | stan_lagun: what is your concern then? | 01:23 |
| serg_melikyan | https://github.com/stackforge/murano/blob/master/murano/common/wsgi.py#L669 - this will be thrown | 01:24 |
| serg_melikyan | caught here https://github.com/stackforge/murano/blob/master/murano/common/wsgi.py#L364 | 01:24 |
| serg_melikyan | and re-raised here as 415 https://github.com/stackforge/murano/blob/master/murano/common/wsgi.py#L366 | 01:24 |
| serg_melikyan | and this is what we see in the logs of failed CI jobs | 01:24 |
| stan_lagun | serg_melikyan: I know. You don't need to post me 100 links | 01:25 |
| stan_lagun | I just missed that header though I've seen this method 10 times | 01:25 |
| stan_lagun | Probably explicitly setting header will help | 01:26 |
| serg_melikyan | probably - I will restore this changeset, I think we should not stop working on keystone v3 support | 01:26 |
| stan_lagun | Maybe instead of revert-commit you will try this fix? | 01:27 |
| openstackgerrit | Merged stackforge/python-muranoclient: Revert "Add keystone v3 support to client" https://review.openstack.org/141529 | 01:27 |
| stan_lagun | why did you merged it? | 01:28 |
| serg_melikyan | We decided to revert commit and work on this issue after that | 01:28 |
| serg_melikyan | stan_lagun: cause we need to unblock our CI ASAP - Review Day :) | 01:28 |
| stan_lagun | So I guess you know how to fix it and you don't need my help here anymore | 01:29 |
| *** serg_melikyan has quit IRC | 01:34 | |
| *** murano_zabbix has joined #murano | 03:08 | |
| murano_zabbix | OK: murano-engine is broken (3+ test runs during last 4 hours have failed, see https://murano-ci.mirantis.com/jenkins/) | 03:08 |
| *** murano_zabbix has quit IRC | 03:08 | |
| *** murano_zabbix has joined #murano | 03:11 | |
| murano_zabbix | OK: murano-dashboard is broken (3+ test runs during last 4 hours have failed, see https://murano-ci.mirantis.com/jenkins/) | 03:11 |
| *** murano_zabbix has quit IRC | 03:11 | |
| *** lazy_prince has quit IRC | 04:10 | |
| *** IlyaE has joined #murano | 04:45 | |
| *** IlyaE has quit IRC | 04:47 | |
| *** IlyaE has joined #murano | 04:59 | |
| *** IlyaE has quit IRC | 05:09 | |
| *** IlyaE has joined #murano | 05:21 | |
| *** IlyaE has quit IRC | 05:29 | |
| *** IlyaE has joined #murano | 05:34 | |
| *** IlyaE has quit IRC | 06:08 | |
| *** killer_prince has joined #murano | 06:25 | |
| *** killer_prince is now known as lazy_prince | 06:26 | |
| *** lazy_prince has quit IRC | 07:09 | |
| *** killer_prince has joined #murano | 07:26 | |
| *** killer_prince is now known as lazy_prince | 07:26 | |
| *** lazy_prince has quit IRC | 10:04 | |
| *** killer_prince has joined #murano | 10:47 | |
| *** killer_prince is now known as lazy_prince | 10:47 | |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano: [WIP] Drop unused dependencies https://review.openstack.org/141556 | 14:45 |
| *** Raggs has joined #murano | 14:50 | |
| Raggs | Hello | 14:50 |
| Raggs | Hi | 14:50 |
| *** Raags has joined #murano | 14:52 | |
| Raags | Helo | 14:52 |
| *** Raggs has quit IRC | 14:55 | |
| *** Raags has quit IRC | 14:55 | |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano: Drop unused dependencies https://review.openstack.org/141556 | 15:04 |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano: Replace anyjson with oslo.serialization https://review.openstack.org/141557 | 15:08 |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano: Replace anyjson with oslo.serialization https://review.openstack.org/141557 | 15:10 |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano: Replace anyjson with oslo.serialization https://review.openstack.org/141557 | 15:11 |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano: Drop ordereddict from requirements https://review.openstack.org/141559 | 15:23 |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano: Drop unused dependencies https://review.openstack.org/141556 | 15:24 |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano: Removed unused uml-generator from contrib https://review.openstack.org/141562 | 15:39 |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano: Removed deprecated run_tests.sh https://review.openstack.org/141563 | 15:42 |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano-dashboard: Removed statistics panel https://review.openstack.org/141568 | 17:34 |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano-dashboard: DO NOT LOOK AT ME https://review.openstack.org/141569 | 18:02 |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano-dashboard: Removed statistics panel https://review.openstack.org/141568 | 18:09 |
| *** IlyaE has joined #murano | 18:12 | |
| *** IlyaE has quit IRC | 18:21 | |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano-dashboard: Fixed selenium tests https://review.openstack.org/141570 | 18:32 |
| *** slagun has joined #murano | 21:54 | |
| *** stan_lagun has quit IRC | 21:58 | |
| *** serg_melikyan has joined #murano | 23:17 | |
| openstackgerrit | Ruslan Kamaldinov proposed stackforge/murano-dashboard: Removed statistics panel https://review.openstack.org/141568 | 23:43 |
| *** serg_mel_ has joined #murano | 23:47 | |
| *** slagun has quit IRC | 23:49 | |
| *** serg_melikyan has quit IRC | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!