| *** smc7 has joined #murano | 00:41 | |
| *** smc7 has quit IRC | 00:47 | |
| *** serg_melikyan has joined #murano | 00:52 | |
| *** serg_melikyan has quit IRC | 00:56 | |
| *** stan_lagun has joined #murano | 01:36 | |
| *** slagun has quit IRC | 01:39 | |
| *** BB__ has quit IRC | 01:54 | |
| *** eghobo has joined #murano | 02:05 | |
| *** yamamoto has joined #murano | 02:27 | |
| *** eghobo has quit IRC | 02:31 | |
| *** eghobo has joined #murano | 02:32 | |
| *** eghobo has quit IRC | 02:46 | |
| *** smc7 has joined #murano | 04:19 | |
| *** smc7 has quit IRC | 04:24 | |
| *** eghobo has joined #murano | 05:04 | |
| *** imarnat has joined #murano | 05:07 | |
| *** eghobo has quit IRC | 05:38 | |
| *** eghobo has joined #murano | 05:38 | |
| *** imarnat has quit IRC | 06:00 | |
| *** asalkeld has left #murano | 06:02 | |
| *** eghobo_ has joined #murano | 06:14 | |
| *** eghobo has quit IRC | 06:16 | |
| *** eghobo_ has quit IRC | 06:34 | |
| *** kzaitsev_ has joined #murano | 06:53 | |
| kzaitsev_ | gate-murano-dashboard-seleniumUNSTABLE in 39m 46s — wow, that is like the 1st time I see that =) | 07:14 |
|---|---|---|
| *** kzaitsev_ has quit IRC | 07:24 | |
| openstackgerrit | Merged stackforge/murano: Makes exception_traceback optional for exception_result https://review.openstack.org/161157 | 07:36 |
| *** eghobo has joined #murano | 07:55 | |
| *** eghobo has quit IRC | 07:56 | |
| *** eghobo has joined #murano | 07:56 | |
| *** smc7 has joined #murano | 07:57 | |
| openstackgerrit | Merged stackforge/murano: Remove deprecated Kubernetes binary "kubecfg" from DIB element. https://review.openstack.org/161703 | 08:01 |
| *** eghobo_ has joined #murano | 08:02 | |
| openstackgerrit | Florian Walker proposed stackforge/murano-apps: Closes-Bug: #1427503 Fix invalid block-statement https://review.openstack.org/162046 | 08:04 |
| openstack | bug 1427503 in murano "[kubernetes] Malformed KubernetesCluster.yaml causes upload error" [Undecided,New] https://launchpad.net/bugs/1427503 | 08:04 |
| *** eghobo has quit IRC | 08:06 | |
| openstackgerrit | Florian Walker proposed stackforge/murano-apps: Closes-Bug: #1427503 Removed invalid character from block statement https://review.openstack.org/162054 | 08:20 |
| openstack | bug 1427503 in murano "[kubernetes] Malformed KubernetesCluster.yaml causes upload error" [Undecided,New] https://launchpad.net/bugs/1427503 | 08:20 |
| *** imarnat has joined #murano | 08:25 | |
| *** kzaitsev_ has joined #murano | 08:28 | |
| *** kzaitsev_ has quit IRC | 08:28 | |
| openstackgerrit | Kirill Zaitsev proposed stackforge/python-muranoclient: Add support for required images file https://review.openstack.org/160903 | 08:37 |
| *** kzaitsev_ has joined #murano | 08:40 | |
| *** eghobo_ has quit IRC | 08:49 | |
| *** serg_melikyan has joined #murano | 08:49 | |
| openstackgerrit | Kirill Zaitsev proposed stackforge/python-muranoclient: Allow importing bundles of packages https://review.openstack.org/159506 | 08:55 |
| openstackgerrit | Florian Walker proposed stackforge/murano-apps: Closes-Bug: #1427503 Minor fix of KubernetesCluster app https://review.openstack.org/162054 | 08:57 |
| openstack | bug 1427503 in murano "[kubernetes] Malformed KubernetesCluster.yaml causes upload error" [Undecided,New] https://launchpad.net/bugs/1427503 | 08:57 |
| openstackgerrit | Kirill Zaitsev proposed stackforge/python-muranoclient: Client support for Require section in manifest https://review.openstack.org/160371 | 08:57 |
| openstackgerrit | Kirill Zaitsev proposed stackforge/python-muranoclient: Add support for required images file https://review.openstack.org/160903 | 08:58 |
| openstackgerrit | Kirill Zaitsev proposed stackforge/python-muranoclient: Handle package already exists in CLI https://review.openstack.org/161787 | 09:00 |
| openstackgerrit | Serg Melikyan proposed stackforge/murano-apps: Minor fix of KubernetesCluster app https://review.openstack.org/162054 | 09:05 |
| openstackgerrit | Merged stackforge/murano-apps: Minor fix of KubernetesCluster app https://review.openstack.org/162054 | 09:05 |
| *** yamamoto has quit IRC | 09:10 | |
| *** imarnat has quit IRC | 09:14 | |
| *** igormarnat is now known as imarnat | 09:14 | |
| *** kzaitsev_ has quit IRC | 09:15 | |
| openstackgerrit | Serg Melikyan proposed stackforge/python-muranoclient: Allow importing packages by url https://review.openstack.org/159134 | 09:17 |
| *** kzaitsev_ has joined #murano | 09:23 | |
| kzaitsev_ | Could someone give me TLDR for what does `Patch Set xx was rebased` means and why it doesn't depend on anything anymore? | 09:33 |
| openstackgerrit | Ekaterina Chernova proposed stackforge/murano-dashboard: Add category management page https://review.openstack.org/147565 | 09:34 |
| openstackgerrit | Ekaterina Chernova proposed stackforge/murano: Implement category management API https://review.openstack.org/144632 | 09:36 |
| *** kzaitsev_ has quit IRC | 09:53 | |
| openstackgerrit | Alexey Deryugin proposed stackforge/murano: [DIB] Kubernetes: added installation of flannel and haproxy https://review.openstack.org/162075 | 10:08 |
| openstackgerrit | Alexey Deryugin proposed stackforge/murano: [DIB] Kubernetes: added installation of flannel and haproxy https://review.openstack.org/162075 | 10:16 |
| *** smc7 has quit IRC | 10:32 | |
| *** serg_melikyan has quit IRC | 10:34 | |
| *** serg_melikyan has joined #murano | 10:35 | |
| openstackgerrit | Kirill Zaitsev proposed stackforge/python-muranoclient: Allow importing packages by FQPN https://review.openstack.org/159408 | 10:41 |
| *** kzaitsev_ has joined #murano | 10:48 | |
| freerunner | Hi folks! Please, review patch which contains some improvements for our tests ;) https://review.openstack.org/#/c/153955/ | 10:48 |
| openstackgerrit | Viktor Ryzhenkin proposed stackforge/murano: Reworked functional tests for Murano https://review.openstack.org/153955 | 10:50 |
| kzaitsev_ | I'd like to note that guidelines of pep8 and openstack are only guidelines and should be treated as such. | 10:51 |
| kzaitsev_ | Some are promoted to rules, some are not. | 10:52 |
| kzaitsev_ | And we have some projects to look up to, like nova or keystone. And if they do not enforce any particular specific rule, that some of us find unsatisfying — why should we? | 10:56 |
| *** imarnat is now known as igormarnat | 10:57 | |
| openstackgerrit | Kirill Zaitsev proposed stackforge/python-muranoclient: Allow importing bundles of packages https://review.openstack.org/159506 | 10:57 |
| openstackgerrit | Kirill Zaitsev proposed stackforge/python-muranoclient: Client support for Require section in manifest https://review.openstack.org/160371 | 10:58 |
| openstackgerrit | Kirill Zaitsev proposed stackforge/python-muranoclient: Handle package already exists in CLI https://review.openstack.org/161787 | 10:58 |
| openstackgerrit | Kirill Zaitsev proposed stackforge/python-muranoclient: Add support for required images file https://review.openstack.org/160903 | 10:58 |
| *** igormarnat is now known as imarnat | 11:04 | |
| *** kzaitsev_ has quit IRC | 11:05 | |
| *** kzaitsev_ has joined #murano | 11:06 | |
| freerunner | kzaitsev_: As QA Engineer i'm expect that the significant part of large and complex functions will be covered with docstings to increase code-understanding. But docstrings not needed for simply functions. | 11:14 |
| katyafervent | so it's up to developer to decide write it or not | 11:15 |
| kzaitsev_ | Yep, like simple tests, that only consist of several lines of code and have self-describing name | 11:15 |
| freerunner | katyafervent: Yes, ofc. | 11:19 |
| *** yamamoto has joined #murano | 11:20 | |
| ddovbii | Guys, I would like to say some words about docstrings. I think each contributer decide for itself how to comment his code. But he must be prepared to the fact that anyone can ask him to create docstrings if the code is unclear. Also it will be cool if each contributor will add docstrings to the methods created by another developer in cases when contributor spent a lot of time to understand them. | 11:24 |
| *** yamamoto has quit IRC | 11:24 | |
| tsufiev | +1 for common sense. Classical example of comments wrong usage is 'i = 1; // assigns 1 to variable i' | 11:29 |
| stan_lagun | ...and one pep8 to rule them all... | 11:31 |
| pashkin | kzaitsev_ Keystone and Nova are different projects, their developers are not concerned about making Murano codebase better, but we are concerned | 11:32 |
| kzaitsev_ | You're not even answering my question. | 11:33 |
| pashkin | Rules are valuable when they are general and mandatory, when they fuzzy and not mandatory they not valuable at all | 11:34 |
| pashkin | What do you saying - we should not introduce rules that not in Keystone or Nova? | 11:35 |
| kzaitsev_ | I can repeat my question if it's not clear. | 11:35 |
| pashkin | Go on | 11:36 |
| kzaitsev_ | If the rest of openstack does not enforce a specific rule, that some of us find unsatisfying — why should we? | 11:36 |
| serg_melikyan | pashkin: I think we should use common sense, I don't think that mandatory doc-string will bring to us much value at this point of time. | 11:36 |
| pashkin | Use the common sense, Luke... | 11:36 |
| serg_melikyan | yep :) | 11:36 |
| pashkin | kzaitsev_ We shouldn't but we can | 11:38 |
| kzaitsev_ | That's it. We shouldn't and majority agrees not to do so. I kind of do not understand why you're so stubborn against this kind of decision. | 11:40 |
| *** kzaitsev_ has quit IRC | 11:43 | |
| openstackgerrit | Merged stackforge/murano: Implement category management API https://review.openstack.org/144632 | 11:46 |
| *** serg_melikyan has quit IRC | 11:46 | |
| openstackgerrit | Merged stackforge/murano-dashboard: Add draggable components to the 'Components page' https://review.openstack.org/161178 | 11:47 |
| openstackgerrit | Merged stackforge/murano-dashboard: Track currently focused field in Wizard's Description section https://review.openstack.org/155156 | 11:49 |
| openstackgerrit | Merged stackforge/murano-dashboard: Show current/all steps at the 'Add App' Wizard's header https://review.openstack.org/159511 | 11:49 |
| pashkin | kzaitsev_ Because I'm for quality codeabase | 11:50 |
| openstackgerrit | Merged stackforge/murano: Reworked functional tests for Murano https://review.openstack.org/153955 | 11:58 |
| *** yamamoto has joined #murano | 11:58 | |
| *** imarnat is now known as igormarnat | 12:02 | |
| *** igormarnat is now known as imarnat | 12:04 | |
| *** kzaitsev_ has joined #murano | 12:12 | |
| *** smc7 has joined #murano | 12:18 | |
| *** serg_melikyan has joined #murano | 12:20 | |
| *** smc7 has quit IRC | 12:23 | |
| openstackgerrit | Merged stackforge/murano-apps: Implement deleteContainer method https://review.openstack.org/160691 | 12:27 |
| stan_lagun | pashkin: you assume that code with 100% of functions having doc-strings to be of a more quality that doesn't have them. But if you take any code and comment every single line this code is guarantee to became unreadable. Even not taking in account the quality of comments themselves | 12:27 |
| *** imarnat is now known as igormarnat | 12:27 | |
| stan_lagun | most of the time the code itself is a best docsting | 12:28 |
| openstackgerrit | Ekaterina Chernova proposed stackforge/murano-dashboard: [WIP] Support actions with TableWidget https://review.openstack.org/155951 | 12:29 |
| openstackgerrit | Serg Melikyan proposed stackforge/murano-dashboard: Close Murano test package zip file https://review.openstack.org/160768 | 12:29 |
| *** igormarnat is now known as imarnat | 12:30 | |
| katyafervent | Do we have everything ready to test docker with actions on our master? | 12:30 |
| katyafervent | will it work with juno heat? | 12:30 |
| stan_lagun | katyafervent: it should work but currently we are working on new docker implementation so it may be reasonable to wait for it and test it there | 12:31 |
| *** imarnat is now known as igormarnat | 12:35 | |
| serg_melikyan | stan_lagun: can you check changes regarding murano repository? | 12:35 |
| serg_melikyan | I would appreciate review | 12:35 |
| stan_lagun | serg_melikyan: you mean marketplace? | 12:35 |
| serg_melikyan | stan_lagun: yeah | 12:36 |
| serg_melikyan | but we call it murano repository | 12:36 |
| *** yamamoto has quit IRC | 12:38 | |
| *** kzaitsev_ has quit IRC | 12:39 | |
| *** yamamoto has joined #murano | 12:40 | |
| *** stan_lagun has quit IRC | 12:40 | |
| *** yamamoto has quit IRC | 12:46 | |
| *** StanLagun has joined #murano | 12:49 | |
| *** yamamoto has joined #murano | 12:51 | |
| openstackgerrit | Merged stackforge/python-muranoclient: Enable category management support https://review.openstack.org/147873 | 12:54 |
| openstackgerrit | Merged stackforge/murano-dashboard: Revert "Close Murano test package zip file" https://review.openstack.org/160767 | 12:56 |
| *** serg_melikyan has quit IRC | 12:57 | |
| *** kzaitsev_ has joined #murano | 12:57 | |
| pashkin | stan_lagun Well - "comment every single line" is an extreme situation, of course I'm not for comment every line =) | 12:58 |
| *** serg_melikyan has joined #murano | 13:02 | |
| *** yamamoto has quit IRC | 13:07 | |
| pashkin | By the way, check out SQLALchemy code https://bitbucket.org/zzzeek/sqlalchemy/src/05ac6bcc0e2f7557f26a05e171be956c651f443a/lib/sqlalchemy/engine/base.py?at=master | 13:07 |
| serg_melikyan | StanLagun: I think Marketplace implies web-site with a catalog, and nice API. This will be our next step regarding Murano Repository | 13:10 |
| serg_melikyan | I think we can come up with another name later, so far we decided to use Murano Repository | 13:10 |
| StanLagun | serg_melikyan: thats confusing because local catalog is also a repository | 13:11 |
| serg_melikyan | StanLagun: agree, do you have better name? | 13:12 |
| *** igormarnat is now known as imarnat | 13:12 | |
| StanLagun | murano hub (similar to docker) | 13:13 |
| *** kzaitsev_ has quit IRC | 13:13 | |
| serg_melikyan | StanLagun: nice, I also like this name | 13:13 |
| openstackgerrit | Ekaterina Chernova proposed stackforge/murano-dashboard: Separate js code from the template https://review.openstack.org/162149 | 13:25 |
| openstackgerrit | Ekaterina Chernova proposed stackforge/murano-dashboard: Add category management page https://review.openstack.org/147565 | 13:27 |
| *** yamamoto has joined #murano | 13:54 | |
| *** smc7 has joined #murano | 14:07 | |
| *** smc7 has quit IRC | 14:11 | |
| *** serg_melikyan has quit IRC | 14:17 | |
| *** serg_melikyan has joined #murano | 14:22 | |
| *** imarnat is now known as igormarnat | 14:22 | |
| *** igormarnat is now known as imarnat | 14:24 | |
| *** serg_melikyan has quit IRC | 14:28 | |
| *** kzaitsev_ has joined #murano | 14:33 | |
| kzaitsev_ | I hope I won't have to recreate the spec, the blueprint, and the patch-set =))) | 14:35 |
| openstackgerrit | Kirill Zaitsev proposed stackforge/python-muranoclient: Add support for required images file https://review.openstack.org/160903 | 14:38 |
| kzaitsev_ | pashkin: check out SQLAlchemy tests ;) https://bitbucket.org/zzzeek/sqlalchemy/src/05ac6bcc0e2f7557f26a05e171be956c651f443a/test/orm/test_bind.py?at=master | 14:41 |
| kzaitsev_ | StanLagun: changes regarding murano repository(/hub/whatever name we agree on) can be found here https://review.openstack.org/#/q/status:open+project:stackforge/python-muranoclient+branch:master+topic:bp/muranoclient-marketplace-support,n,z | 14:42 |
| ruhe | kzaitsev_: i recommend to take a look at https://github.com/stackforge/gerrit-dash-creator . it allows to create highly customized dashboards in gerrit | 14:44 |
| kzaitsev_ | ruhe: yep, looks extremely promising! | 14:45 |
| ruhe | just browse through existing dashboards: http://ghostcloud.net/openstack_gerrit_dashboards/ | 14:46 |
| ruhe | i've been using it for a long time, when i was active reviewer :) | 14:46 |
| kzaitsev_ | Well... I was actually hoping for smth a bit more motivating (and less 90s =))) But these should also do well. | 14:51 |
| *** imarnat is now known as igormarnat | 14:56 | |
| *** igormarnat is now known as imarnat | 14:56 | |
| openstackgerrit | Andrew Pashkin proposed stackforge/python-muranoclient: Add keystone v3 support to client https://review.openstack.org/161205 | 14:58 |
| *** imarnat is now known as igormarnat | 15:00 | |
| pashkin | kzaitsev_ Facepalm.jpg | 15:01 |
| pashkin | kzaitsev_ Ok, let's leave this topic for some time ;) | 15:03 |
| kzaitsev_ | Agreed =) | 15:03 |
| ruhe | kzaitsev_: you should take a look at https://github.com/stackforge/gertty - it's a console based itnerface for gerrit. it's true 90s :) | 15:11 |
| kzaitsev_ | I said less, not more =)))) But I love cli, yep =) | 15:11 |
| *** smc7 has joined #murano | 15:17 | |
| *** yamamoto has quit IRC | 15:34 | |
| *** yamamoto has joined #murano | 15:34 | |
| *** freerunner has quit IRC | 15:36 | |
| pashkin | I think we should have some thingy for conveniently create db objects in tests | 15:52 |
| *** Miouge has joined #murano | 16:02 | |
| kzaitsev_ | serg_melikyan: Stan and I decided that we could implement a really nice primitive for downloading packages instead of bulky function, that is used right now. It wont take long to implement and it wouldn't impact code much, but it would make code a lot more reusable. I expect to implement it over the weekend =) | 16:07 |
| openstackgerrit | Andrew Pashkin proposed stackforge/murano: Fixed 500 error in get_result API handler https://review.openstack.org/162206 | 16:15 |
| *** freerunner has joined #murano | 16:31 | |
| openstackgerrit | Kirill Zaitsev proposed stackforge/murano-dashboard: Support uploading packages from murano repository https://review.openstack.org/162214 | 16:40 |
| *** kzaitsev_ has quit IRC | 16:41 | |
| *** Miouge has quit IRC | 16:58 | |
| *** eghobo has joined #murano | 17:27 | |
| *** eghobo has quit IRC | 17:27 | |
| *** eghobo has joined #murano | 17:28 | |
| *** serg_melikyan has joined #murano | 17:29 | |
| *** serg_melikyan has quit IRC | 17:33 | |
| *** eghobo has quit IRC | 17:35 | |
| *** eghobo has joined #murano | 17:37 | |
| *** eghobo has quit IRC | 18:00 | |
| *** eghobo has joined #murano | 18:06 | |
| *** yamamoto has quit IRC | 18:09 | |
| *** eghobo_ has joined #murano | 18:39 | |
| *** eghobo__ has joined #murano | 18:40 | |
| *** eghobo has quit IRC | 18:42 | |
| *** eghobo_ has quit IRC | 18:43 | |
| *** yamamoto has joined #murano | 19:09 | |
| *** yamamoto has quit IRC | 19:14 | |
| *** eghobo__ has quit IRC | 19:35 | |
| *** igormarnat is now known as imarnat | 19:39 | |
| *** imarnat is now known as igormarnat | 19:44 | |
| *** smc7 has quit IRC | 20:50 | |
| pashkin | Check out my proposal for new structure of Murano docs: https://github.com/AndrewPashkin/murano-docs/blob/master/TOC.rst | 20:51 |
| *** eghobo has joined #murano | 20:55 | |
| *** eghobo_ has joined #murano | 20:58 | |
| *** eghobo has quit IRC | 21:01 | |
| *** yamamoto has joined #murano | 21:12 | |
| *** smc7 has joined #murano | 21:15 | |
| *** yamamoto has quit IRC | 21:16 | |
| *** eghobo_ has quit IRC | 21:35 | |
| *** eghobo has joined #murano | 21:38 | |
| *** eghobo has quit IRC | 22:22 | |
| *** eghobo has joined #murano | 23:10 | |
| *** pashkin_ has joined #murano | 23:14 | |
| *** yamamoto has joined #murano | 23:14 | |
| *** yamamoto has quit IRC | 23:18 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!