*** yamamoto has joined #murano | 00:02 | |
*** kzaitsev_mb has joined #murano | 00:06 | |
*** yamamoto has quit IRC | 00:12 | |
*** kzaitsev_mb has quit IRC | 00:37 | |
*** jasonsb has quit IRC | 00:48 | |
*** lan__ has quit IRC | 00:54 | |
*** lan__ has joined #murano | 00:55 | |
*** xiangxinyong has joined #murano | 01:28 | |
*** kzaitsev_mb has joined #murano | 01:33 | |
*** kzaitsev_mb has quit IRC | 01:38 | |
*** tobe has joined #murano | 01:39 | |
*** jdandrea has quit IRC | 01:43 | |
openstackgerrit | Li Yingjun proposed openstack/murano: Handle ValueError from hot_package at API level https://review.openstack.org/200339 | 02:10 |
---|---|---|
*** jasonsb has joined #murano | 02:20 | |
*** yamamoto has joined #murano | 02:49 | |
*** yamamoto has quit IRC | 02:54 | |
*** xiangxinyong has quit IRC | 02:55 | |
*** Nikolay_St has joined #murano | 04:17 | |
*** xiangxinyong has joined #murano | 04:37 | |
*** xiangxinyong1 has joined #murano | 04:44 | |
*** tobe has quit IRC | 04:44 | |
*** xiangxinyong has quit IRC | 04:47 | |
openstackgerrit | Nikolay Starodubtsev proposed openstack/murano: Move load_paste_app to the place it should be https://review.openstack.org/199016 | 04:59 |
*** xiangxinyong1 has quit IRC | 05:21 | |
*** yamamoto has joined #murano | 05:39 | |
*** yamamoto has quit IRC | 05:42 | |
*** kzaitsev_mb has joined #murano | 05:48 | |
*** kzaitsev_mb has quit IRC | 05:55 | |
*** Miouge has joined #murano | 05:59 | |
*** Avin has joined #murano | 06:08 | |
*** Nikolay_St has quit IRC | 06:21 | |
*** ddovbii has joined #murano | 06:34 | |
*** yamamoto has joined #murano | 06:42 | |
*** tobe has joined #murano | 06:45 | |
openstackgerrit | Marc Koderer proposed openstack/murano: Enable devstack external interface https://review.openstack.org/194077 | 06:46 |
*** yamamoto has quit IRC | 06:47 | |
openstackgerrit | Marc Koderer proposed openstack/murano: Enable devstack external interface https://review.openstack.org/194077 | 07:01 |
*** Avin has quit IRC | 07:15 | |
*** Avin has joined #murano | 07:15 | |
openstackgerrit | Li Yingjun proposed openstack/murano-dashboard: Disable `Edit Environment` when it is deleting https://review.openstack.org/200404 | 07:15 |
*** Avin has quit IRC | 07:16 | |
*** Avin has joined #murano | 07:17 | |
*** yingjun has joined #murano | 07:21 | |
*** Avin has quit IRC | 07:22 | |
*** prefer has joined #murano | 07:29 | |
*** exploreshaifali has joined #murano | 07:41 | |
*** yingjun_ has joined #murano | 07:42 | |
*** yamamoto has joined #murano | 07:44 | |
*** samuelBartel has joined #murano | 07:45 | |
*** yingjun has quit IRC | 07:46 | |
*** asalkeld has quit IRC | 08:12 | |
*** Avin has joined #murano | 08:17 | |
*** Avin has quit IRC | 08:22 | |
*** kzaitsev_mb has joined #murano | 08:23 | |
*** prefer has quit IRC | 08:50 | |
*** Avin has joined #murano | 08:53 | |
*** Avin has quit IRC | 08:55 | |
*** lan__ has quit IRC | 08:59 | |
*** lan__ has joined #murano | 09:00 | |
*** kzaitsev_mb has quit IRC | 09:01 | |
ruhe | kzaitsev_ws: i agree we also need to release. should we until monday when Serg gets back from vacation? | 09:03 |
*** kzaitsev_mb has joined #murano | 09:04 | |
kzaitsev_mb | ruhe: sure! everyone releases on Thursday, and we have around 20 patches on queue to stable/kilo =) | 09:04 |
kzaitsev_mb | there's no point in releasing today =) | 09:05 |
ruhe | ok. thanks | 09:05 |
kzaitsev_mb | s/on Thursday/next Thursday/ | 09:06 |
kzaitsev_mb | =) | 09:06 |
*** yamamoto has quit IRC | 09:09 | |
*** kzaitsev_mb has quit IRC | 09:10 | |
openstackgerrit | Li Yingjun proposed openstack/murano-dashboard: Disable `Edit Environment` when it is deleting https://review.openstack.org/200404 | 09:12 |
openstackgerrit | Ekaterina Chernova proposed openstack/murano-specs: Rework package class loader logic https://review.openstack.org/198745 | 09:14 |
openstackgerrit | Sergey Vilgelm proposed openstack/murano: Remove the wrong assert_is_called checking https://review.openstack.org/200430 | 09:17 |
openstackgerrit | Sergey Vilgelm proposed openstack/murano: Remove the wrong assert_is_called checking https://review.openstack.org/200430 | 09:24 |
openstackgerrit | Timur Nurlygayanov proposed openstack/murano: Added scripts for unit tests coverage job https://review.openstack.org/200433 | 09:25 |
openstackgerrit | Timur Nurlygayanov proposed openstack/murano: Added scripts for unit tests coverage job https://review.openstack.org/200433 | 09:27 |
openstackgerrit | Timur Nurlygayanov proposed openstack/murano: Added script for unit tests coverage job https://review.openstack.org/200433 | 09:31 |
*** yingjun_ has quit IRC | 09:32 | |
openstackgerrit | Sergey Vilgelm proposed openstack/murano: Remove the wrong assert_is_called checking https://review.openstack.org/200430 | 09:34 |
*** Miouge has quit IRC | 09:35 | |
*** khivin_ has joined #murano | 09:35 | |
khivin_ | Hello! May I ask for review? https://review.openstack.org/#/c/199260/ | 09:36 |
openstackgerrit | Sergey Vilgelm proposed openstack/murano: Remove the wrong assert_is_called checking https://review.openstack.org/200430 | 09:39 |
*** exploreshaifali has quit IRC | 09:43 | |
*** yamamoto has joined #murano | 09:48 | |
*** prefer has joined #murano | 09:48 | |
openstackgerrit | Dmytro Dovbii proposed openstack/murano-specs: Add spec for bundle-save feature https://review.openstack.org/199961 | 09:51 |
*** xiangxinyong1 has joined #murano | 09:53 | |
ruhe | btw, seems like we're also affected by the new release of mock | 09:54 |
*** StanLagun has joined #murano | 09:54 | |
ruhe | ah, probably https://review.openstack.org/#/c/200430/ should fix that | 09:55 |
openstackgerrit | Dmytro Dovbii proposed openstack/python-muranoclient: Add bundle-save CLI command https://review.openstack.org/199973 | 09:57 |
*** kzaitsev_mb has joined #murano | 10:02 | |
*** yamamoto has quit IRC | 10:03 | |
openstackgerrit | Merged openstack/murano-specs: Add simulation mode spec https://review.openstack.org/190608 | 10:08 |
*** yamamoto has joined #murano | 10:09 | |
*** Nikolay_St has joined #murano | 10:16 | |
katyafervent | khivin_, hi! will look | 10:18 |
khivin_ | katyafervent: thank you! | 10:18 |
kzaitsev_mb | katyafervent, ativelkov, StanLagun can we pls discuss my alternative for package class loader logic https://review.openstack.org/#/c/198745/ ? | 10:20 |
kzaitsev_mb | I'm ok with current variant, but really like my own option =) | 10:20 |
openstackgerrit | Sergey Vilgelm proposed openstack/python-muranoclient: Fix the unit tests with wrong using of mock https://review.openstack.org/200457 | 10:20 |
openstackgerrit | Sergey Vilgelm proposed openstack/python-muranoclient: Fix the unit tests with wrong using of mock https://review.openstack.org/200457 | 10:22 |
*** svilgelm has joined #murano | 10:22 | |
svilgelm | May I ask for review, please? https://review.openstack.org/#/c/200457/ | 10:23 |
svilgelm | I fixed the using of mock for the muranoclient | 10:23 |
kzaitsev_mb | svilgelm: is assert_called_once removed from newer version of mock? | 10:24 |
kzaitsev_mb | oh | 10:24 |
kzaitsev_mb | it was never there, right? | 10:24 |
svilgelm | I didn't find | 10:26 |
svilgelm | only mock.assert_called_once_with() | 10:26 |
kzaitsev_mb | svilgelm: yep. assert names are poisonous in mock module =( | 10:27 |
kzaitsev_mb | damn! my backports are failing | 10:28 |
kzaitsev_mb | can you pls backport it to s/kilo s/juno too? | 10:28 |
svilgelm | What should i do? Should i create the same patches for all branches? | 10:29 |
svilgelm | or what? | 10:29 |
*** Miouge has joined #murano | 10:29 | |
*** Miouge has quit IRC | 10:30 | |
Nikolay_St | svilgelm: and there is the same fix for murano itself? | 10:31 |
svilgelm | yep | 10:31 |
kzaitsev_mb | svilgelm: yes, you can try to cherry pick to stable/kilo from web-ui. let's just wait for the tests to go green before doing so | 10:31 |
svilgelm | Ok | 10:32 |
kzaitsev_mb | not a day without a broken gate! | 10:32 |
*** Miouge has joined #murano | 10:32 | |
kzaitsev_mb | I'm going to need to meditate a bit... | 10:32 |
*** xiangxinyong1 has quit IRC | 10:36 | |
svilgelm | I need the second +2 for the murano's patch: https://review.openstack.org/#/c/200430/ | 10:36 |
StanLagun | kzaitsev_mb, i like your idea about class loader. What exactly do you want to discuss? I think you just need to coordinate with Kate and update the spec | 10:36 |
kzaitsev_mb | katyafervent: what do you think about changing the spec, to my proposition? | 10:37 |
Nikolay_St | StanLagun: kzaitsev_mb can you please take a look at https://review.openstack.org/#/c/192250/ | 10:37 |
*** yamamoto has quit IRC | 10:38 | |
kzaitsev_mb | svilgelm: you have the wrong bug-id | 10:39 |
kzaitsev_mb | can you pls fix it? we'll review it as top priority anyway | 10:39 |
StanLagun | Nikolay_St, I didn't get from your spec how Cloud Foundry is going to provide parameters for Murano applications. Can you point me to where it is described? | 10:40 |
openstackgerrit | Kirill Zaitsev proposed openstack/murano: Remove the wrong assert_is_called checking https://review.openstack.org/200430 | 10:41 |
katyafervent | kzaitsev_mb, I added your comment as an alternative. I don't think that we need to implement that approach right now, since we don't have any requests regarding custom loaders | 10:41 |
kzaitsev_mb | svilgelm: pls let's use correct bug id | 10:43 |
kzaitsev_mb | katyafervent: StanLagun that's what I wanted to discuss | 10:43 |
kzaitsev_mb | I'm ok with current simpler state of events | 10:43 |
kzaitsev_mb | we can add my idea as a BP for later implementation | 10:44 |
kzaitsev_mb | svilgelm: if we use wrong bug-id the bot would not update l-pad and we would not be able to track things correctly | 10:45 |
StanLagun | kzaitsev_mb, if this is an extra work that we can do it later. But if it is alternative then we need to estimate both of them and start with the one we can implement sooner | 10:45 |
kzaitsev_mb | StanLagun: kate, has already implemented her variant, I think =) So let's leave it as is then =) | 10:46 |
StanLagun | ok. let it be so | 10:46 |
kzaitsev_mb | https://review.openstack.org/#/c/198745/ | 10:46 |
kzaitsev_mb | i just didn't want this work to go to waste =) | 10:47 |
kzaitsev_mb | will add a bp, to remember we had such an idea | 10:47 |
* StanLagun is going to be AFK for about a hour | 10:48 | |
svilgelm | kzaitsev_mb : i'm sorry, i didn't check this chat | 10:48 |
kzaitsev_mb | svilgelm: do we have a similar issue in dashboard, btw? | 10:48 |
kzaitsev_mb | I think we do =( | 10:48 |
kzaitsev_mb | svilgelm: can I ask you to look into murano-dashboard for this bug, pls? | 10:49 |
svilgelm | kzaitsev_mb: what is the murano-dashboard? i don't know, sorry :) | 10:50 |
kzaitsev_mb | svilgelm: it's a separate repository with horizon plugin, for murano. https://review.openstack.org/#/admin/projects/openstack/murano-dashboard | 10:51 |
svilgelm | i don't know, i'll check | 10:52 |
svilgelm | thanks | 10:52 |
kzaitsev_mb | svilgelm: thanks a lot! | 10:52 |
openstackgerrit | Filip Blaha proposed openstack/murano-specs: Policy Based Modification of Environment https://review.openstack.org/188044 | 10:56 |
svilgelm | kzaitsev_mb: murano-agent doesn't have this problem | 10:57 |
svilgelm | and dashboard is Ok | 10:57 |
svilgelm | py27: commands succeeded | 10:57 |
Nikolay_St | StanLagun: nice catch. I'll update the spec ASAP. where should I land the description? "Proposed change" section is ok? | 10:59 |
openstackgerrit | Merged openstack/murano-dashboard: Remove unused and unsupported table field https://review.openstack.org/198796 | 11:00 |
kzaitsev_mb | svilgelm: thanks. seems like client 2.6 is broken though | 11:01 |
kzaitsev_mb | but that's another beast | 11:01 |
svilgelm | kzaitsev_mb: yes | 11:01 |
svilgelm | kzaitsev_mb: because the latest version of mock doesn't work with py26 | 11:02 |
kzaitsev_mb | svilgelm: dict comprehensions, yes | 11:02 |
svilgelm | kzaitsev_mb: we can add Depends-On: https://review.openstack.org/#/c/200344/ | 11:02 |
mkoderer | folks, I adapted the murano project config | 11:03 |
mkoderer | could you have a look: https://review.openstack.org/#/c/200464/ | 11:03 |
kzaitsev_mb | svilgelm: this would not make the tests green though | 11:03 |
svilgelm | kzaitsev_mb: yep | 11:03 |
kzaitsev_mb | let's just wait for it to be merged | 11:03 |
svilgelm | kzaitsev_mb: ok | 11:03 |
katyafervent | kzaitsev_mb, yeap, It looks like a separate blueprint, not connected to the simulation mode | 11:05 |
kzaitsev_mb | katyafervent: agreed then! | 11:05 |
freerunner | mkoderer: LGTM. Correct me, if I wrong. This patch allows us change a localrc file in pre_test_hook.sh script? | 11:06 |
*** histrio has joined #murano | 11:06 | |
mkoderer | freerunner: yeahhh.. exaclty | 11:06 |
mkoderer | freerunner: otherwise it gets deleted all the time | 11:06 |
mkoderer | freerunner: https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate.sh#L72 | 11:07 |
freerunner | mkoderer: Oh. So, I think we can ping infra-cores to merge it ;) | 11:07 |
StanLagun | Nikolay_St, yes | 11:08 |
openstackgerrit | Ekaterina Chernova proposed openstack/murano: Remove hardcoded dns from config file https://review.openstack.org/155397 | 11:14 |
*** tobe has quit IRC | 11:15 | |
*** yamamoto has joined #murano | 11:15 | |
*** tobe has joined #murano | 11:16 | |
*** svilgelm has quit IRC | 11:20 | |
*** svilgelm has joined #murano | 11:20 | |
openstackgerrit | Filip Blaha proposed openstack/murano-specs: Murano API - All Tenants Search https://review.openstack.org/187207 | 11:23 |
*** svilgelm has quit IRC | 11:27 | |
*** Miouge has quit IRC | 11:32 | |
openstackgerrit | Merged openstack/murano-dashboard: Disable `Edit Environment` when it is deleting https://review.openstack.org/200404 | 11:37 |
openstackgerrit | Merged openstack/murano-apps: Add Guacamole https://review.openstack.org/197946 | 11:38 |
*** tobe has quit IRC | 11:45 | |
openstackgerrit | Merged openstack/murano: Remove the wrong assert_is_called checking https://review.openstack.org/200430 | 11:47 |
openstackgerrit | Victor Ryzhenkin proposed openstack/python-muranoclient: Add passenv parameter for tox G.variables passthrough https://review.openstack.org/200488 | 11:51 |
*** Nikolay_St has quit IRC | 11:52 | |
ativelkov | Folks, I've sent an email summary of our yesterdays' discussion on versioning to the ML. Feel free to comment | 11:53 |
openstackgerrit | Ekaterina Chernova proposed openstack/murano-apps: Add Active Directory app https://review.openstack.org/187576 | 11:56 |
openstackgerrit | Filip Blaha proposed openstack/murano-specs: Murano API - Core Model Component Integration Improvement https://review.openstack.org/187498 | 11:56 |
*** Miouge has joined #murano | 11:57 | |
*** Miouge has quit IRC | 12:04 | |
*** Miouge has joined #murano | 12:05 | |
*** Miouge has quit IRC | 12:12 | |
*** Miouge has joined #murano | 12:13 | |
*** Miouge has quit IRC | 12:19 | |
*** Miouge has joined #murano | 12:21 | |
*** Nikolay_St has joined #murano | 12:24 | |
*** Miouge has quit IRC | 12:30 | |
openstackgerrit | Sergey Vilgelm proposed openstack/murano: Move load_paste_app to the place it should be https://review.openstack.org/199016 | 12:30 |
*** Miouge has joined #murano | 12:31 | |
*** Miouge has quit IRC | 12:43 | |
*** Miouge has joined #murano | 12:44 | |
*** Miouge has quit IRC | 12:44 | |
*** Miouge has joined #murano | 12:46 | |
openstackgerrit | Nikolay Starodubtsev proposed openstack/murano-specs: Add spec cloud-foundry-service-broker-api https://review.openstack.org/192250 | 12:49 |
Nikolay_St | StanLagun: spec updated and I think I bring the light to your question | 12:50 |
Nikolay_St | ativelkov: your comment was already done :) | 12:51 |
*** Miouge has quit IRC | 12:51 | |
ativelkov | Nikolay_St: thanks | 12:51 |
*** yingjun has joined #murano | 12:51 | |
openstackgerrit | Dmytro Dovbii proposed openstack/python-muranoclient: Add bundle-save CLI command https://review.openstack.org/199973 | 12:55 |
kzaitsev_mb | ativelkov: thanks for summurizing the current state and roadmap for the much needed versioning feature! | 12:57 |
kzaitsev_mb | ativelkov: can you maybe copy-paste it to an etherpad, for easy commenting/suggestions? | 12:57 |
kzaitsev_mb | or is it a bad idea? | 12:57 |
ativelkov | kzaitsev_mb: I'd prefer to do the further discussion in a spec | 12:57 |
kzaitsev_mb | ativelkov: as you wish =) just had this suggestion | 12:59 |
Nikolay_St | ativelkov: I agree with kzaitsev_mb because spec can be overloaded with comments | 13:01 |
*** yamamoto has quit IRC | 13:02 | |
*** jdandrea has joined #murano | 13:02 | |
mkoderer | ativelkov: should it be possible to update an environment to a newer version? | 13:02 |
ativelkov | mkoderer: what exactly do you mean by environment? Murano environment? | 13:03 |
mkoderer | ativelkov: yep Murano environment | 13:03 |
Nikolay_St | mkoderer: and what do you mean under 'newer version' | 13:04 |
kzaitsev_mb | mkoderer: and what do you mean by update =) sorry for bandwagoning =) | 13:04 |
*** yamamoto has joined #murano | 13:04 | |
kzaitsev_mb | seems like you should elaborate a bit, cause you made us all confused ))) | 13:04 |
mkoderer | Nikolay_St: so versions are cool but what happends with the old already deployed environments? | 13:05 |
mkoderer | should I give an example? ;) | 13:06 |
*** yamamoto has quit IRC | 13:06 | |
mkoderer | let's say we have a app package "apache-0.0.1" and there is a never version available "apache-0.0.2" | 13:12 |
mkoderer | will there be an upgrade path to upgrade instances of "apache-0.0.1" to 0.0.2? I guess this is out-of-scope, right? | 13:12 |
mkoderer | ativelkov: or maybe I misunderstud your proposal at all :) | 13:13 |
ativelkov | mkoderer: I understand now | 13:14 |
kzaitsev_mb | mkoderer: well, I think the document does not cover it. original spec had an idea of "adapters", but basically whay you're asking for is "code-migrations". It is going to be real hell in supporting. | 13:14 |
ativelkov | Well, that is out of the scope for now anyway | 13:14 |
ativelkov | kzaitsev_mb: this has nothign to do with adapters | 13:14 |
kzaitsev_mb | ativelkov: why not? looks exactly like their use-case | 13:15 |
ativelkov | kzaitsev_mb: nope, the concept of adapters was needed to make newer class talk to older classes | 13:15 |
ativelkov | (and vise versa) | 13:15 |
ativelkov | and the thing mkoderer asks about is ability to upgrade already existing classes to their newer versions | 13:16 |
ativelkov | This is much easier then adapters | 13:16 |
ativelkov | However it is still out of the scope :) | 13:16 |
ativelkov | Technically this becomes a special kind of an action | 13:16 |
ativelkov | i.e. the application developer includes the upgrade code right in the newer version of a package | 13:17 |
*** Nikolay_St has quit IRC | 13:17 | |
ativelkov | and if an old instance exists, it gets coerced to a new version - and then that "upgrade code" gets executed | 13:17 |
ativelkov | it is clear how to implement this (yet the applicability is limited), but please, not in L ) | 13:17 |
mkoderer | ativelkov: from an enterprise user standpoint it's a important feature ;) I will think about it :) | 13:21 |
ativelkov | mkoderer: sure. This is an upgradability of a package | 13:22 |
StanLagun | this is kind of migration routine. Similar to those for databases | 13:22 |
mkoderer | yeah, but that's all usual "lifecylce" tasks you have to do for an app instance. It's might out-of-scope for murano at all.. | 13:24 |
kzaitsev_mb | that's exactly what I said about "code-migrations" =) do not want to argue about adapters, since they're out of scope anyway =) | 13:25 |
ativelkov | mkoderer: nope, I don't think that it is out of murano scope: murano indeed is supposed to manage apps lifecycle. So, it's a real task for murano, but not just for L | 13:25 |
StanLagun | I don't think it is out of scope. I believe that Murano should manage application through all lifecycle, not just istall and forget | 13:25 |
mkoderer | ativelkov: ok let | 13:27 |
mkoderer | ok let's see if I have time for a spec for it | 13:27 |
ativelkov | mkoderer: great, thanks! | 13:30 |
*** Nikolay_St has joined #murano | 13:31 | |
StanLagun | great. Just remember that it need to be aligned with versioning as those things are closely related. Any migration from version X to version Y is a code that deals simultaneously with 2 versions of the same class (or classes?) and this needs at least special treatment from class loader | 13:32 |
mkoderer | StanLagun: yeah, it might takes a bit.. I am still in learning mode for Murano :) | 13:33 |
openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Use setup_develop in devstack libs and plugin for devstack https://review.openstack.org/200531 | 13:34 |
StanLagun | mkoderer, will be glad to help you with that | 13:35 |
*** Nikolay_St has quit IRC | 13:37 | |
*** Nikolay_St has joined #murano | 13:41 | |
*** Miouge has joined #murano | 13:41 | |
*** exploreshaifali has joined #murano | 13:46 | |
*** yamamoto has joined #murano | 13:50 | |
*** yingjun has quit IRC | 14:03 | |
*** Miouge has quit IRC | 14:06 | |
*** Miouge has joined #murano | 14:06 | |
*** Nikolay_St has quit IRC | 14:10 | |
*** Miouge has quit IRC | 14:11 | |
*** Miouge has joined #murano | 14:12 | |
*** Miouge has quit IRC | 14:12 | |
openstackgerrit | Merged openstack/murano: Improve dsl exception readability https://review.openstack.org/196542 | 14:13 |
kzaitsev_mb | ok, half of our backports are in place =) | 14:19 |
kzaitsev_mb | StanLagun: if you have a couple of moments — would love to hear your opinion on https://review.openstack.org/#/c/194422/ TOSCA support spec | 14:25 |
StanLagun | kzaitsev_mb, I promise to review it today | 14:27 |
*** Miouge has joined #murano | 14:31 | |
*** anteaya has joined #murano | 14:34 | |
anteaya | is the owner of this patch in channel? https://review.openstack.org/#/c/192730/3 | 14:34 |
anteaya | we need some comments addressed if it is to be renamed | 14:34 |
StanLagun | anteaya, he is on vocation | 14:34 |
anteaya | can someone else address the comments | 14:34 |
anteaya | or would you like us to leave it aside until he returns? | 14:35 |
kzaitsev_mb | anteaya: unfortunatelly no — he's on vacation till monday, but I guess we can address it ourselves =) | 14:35 |
anteaya | your call | 14:35 |
kzaitsev_mb | StanLagun: you're ok if do this? | 14:35 |
StanLagun | kzaitsev_mb, you want me to do this? | 14:36 |
kzaitsev_mb | StanLagun: nope =) I want to do it myself =) | 14:36 |
StanLagun | kzaitsev_mb, no problem with that =) | 14:36 |
*** exploreshaifali has quit IRC | 14:36 | |
anteaya | please ensure the new patchset has project-rename as the topic | 14:37 |
kzaitsev_mb | anteaya: will do | 14:38 |
openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Use setup_develop in devstack libs and plugin for devstack https://review.openstack.org/200531 | 14:38 |
openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Use setup_develop in devstack libs and plugin for devstack https://review.openstack.org/200531 | 14:39 |
anteaya | thank you | 14:39 |
openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Use setup_develop in devstack libs and plugin for devstack https://review.openstack.org/200531 | 14:41 |
openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Use setup_develop in devstack libs and plugin for devstack https://review.openstack.org/200531 | 14:43 |
kzaitsev_mb | anteaya: I'll remove beaker-jobs then and add it as a separate dependant commit. Feels like a right thing to do. | 14:43 |
anteaya | thank you | 14:44 |
anteaya | I agree with that decision | 14:44 |
StanLagun | kzaitsev_mb, I've -1 TOSCA spec :( | 14:47 |
StanLagun | kzaitsev_mb, what are your thoughts? | 14:49 |
kzaitsev_mb | StanLagun: I'll take a look. I'm actually not even sure why it can't be done with Heat-Translator normally. like translate TOSCA -> HOT. Then as a separate step HOT -> murano. | 14:51 |
kzaitsev_mb | well of course it can, right | 14:51 |
StanLagun | kzaitsev_mb, probably the reason is that HOT translator gets better all the time and it is better to have package with TOSCA definition (that are our sources) that will be converted with new version of translator on each import or deployment rather than have package with generated HOT that will not be updated | 14:56 |
StanLagun | but this is a good question to a spec author. I'm just guessing | 14:56 |
anteaya | kzaitsev_mb: let's try again, in projects.yaml and layout.yaml you didn't remove the old code, like the patchset prior did, also beaker-jobs are still present | 14:57 |
*** prefer has quit IRC | 14:57 | |
openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Use setup_develop in devstack libs and plugin for devstack https://review.openstack.org/200531 | 15:00 |
kzaitsev_mb | anteaya: yes, seems like the patch was really old, and I messed up a little when resolving conflicts | 15:26 |
kzaitsev_mb | anteaya: also, I'm a bit puzzled — should I remove gate-{name}-puppet-syntax-future, seems that it was removed some time after the patch was initially submitted. | 15:27 |
kzaitsev_mb | I guess I should | 15:27 |
anteaya | kzaitsev_mb: I too am confused | 15:32 |
anteaya | kzaitsev_mb: I went back to git blame to see what is going on and found this patch: https://review.openstack.org/#/c/155688/1 | 15:32 |
anteaya | which actually has beaker jobs in it, so they originally were there | 15:32 |
anteaya | I have no idea how they got removed | 15:32 |
kzaitsev_mb | anteaya: well, seems like all the syntax-feature jobs were removed at some point | 15:33 |
kzaitsev_mb | I believe we should make renaming easy and consistent, and would rather add missing jobs (if they're required) later =) | 15:34 |
anteaya | kzaitsev_mb: well they were there in patchset 3 | 15:35 |
anteaya | I agree yes, but this is a bit of a mess | 15:35 |
anteaya | and I would like to get it sorted out not make it worse | 15:35 |
kzaitsev_mb | anteaya: they were in patchset 3, because patchset 3 failed to merge cleanly, when syntax-feature got removed. It was in merge failed state | 15:37 |
anteaya | this is the current state of zuul/layout.yaml: http://git.openstack.org/cgit/openstack-infra/project-config/tree/zuul/layout.yaml#n7318 | 15:39 |
anteaya | how did the beaker and syntax future jobs get removed? https://review.openstack.org/#/c/155688/1/zuul/layout.yaml | 15:40 |
anteaya | okay there is where puppet syntax future went: https://review.openstack.org/#/c/197216/5/zuul/layout.yaml | 15:43 |
anteaya | so it should not return | 15:43 |
*** Miouge has quit IRC | 15:46 | |
openstackgerrit | Victor Ryzhenkin proposed openstack/python-muranoclient: WIP https://review.openstack.org/200599 | 15:47 |
kzaitsev_mb | anteaya: cool. I've already updated the commit, to be more clean rename-wise | 15:47 |
anteaya | there is how the beaker jobs disappeared: https://review.openstack.org/#/c/175434/14 | 15:53 |
kzaitsev_mb | anteaya: hm. seems that it was deleted by accident then | 15:55 |
kzaitsev_mb | so I'll return it in a separate commit, to make renaming cleaner | 15:55 |
anteaya | no | 15:57 |
anteaya | it wasn't deleted by accident | 15:57 |
*** samuelBartel has quit IRC | 16:00 | |
anteaya | i have commented on the patch with links to the patches that remove the jobs | 16:00 |
anteaya | let's get agreement on the review | 16:00 |
*** Miouge has joined #murano | 16:00 | |
*** Nikolay_St has joined #murano | 16:01 | |
*** alex__ has joined #murano | 16:09 | |
ddovbii | folks, please help to find decision =) https://review.openstack.org/#/c/199961/ | 16:11 |
*** khivin_ has quit IRC | 16:12 | |
*** yingjun has joined #murano | 16:37 | |
openstackgerrit | Victor Ryzhenkin proposed openstack/python-muranoclient: Update test-requirements due mock update https://review.openstack.org/200617 | 16:39 |
openstackgerrit | Merged openstack/murano: Move load_paste_app to the place it should be https://review.openstack.org/199016 | 16:41 |
*** kzaitsev_mb has quit IRC | 16:42 | |
*** yingjun has quit IRC | 16:47 | |
*** Miouge has quit IRC | 16:52 | |
*** Miouge has joined #murano | 16:53 | |
openstackgerrit | Sergey Vilgelm proposed openstack/murano: Switch to oslo.service https://review.openstack.org/195461 | 16:56 |
*** bitblt has joined #murano | 17:01 | |
openstackgerrit | Sergey Vilgelm proposed openstack/murano: Declare the CONF variable https://review.openstack.org/195643 | 17:04 |
*** slagun has joined #murano | 17:52 | |
*** slagun has quit IRC | 17:54 | |
*** slagun has joined #murano | 17:55 | |
*** StanLagun has quit IRC | 17:58 | |
*** Miouge has quit IRC | 18:04 | |
*** Miouge has joined #murano | 18:12 | |
*** exploreshaifali has joined #murano | 18:35 | |
*** svilgelm has joined #murano | 19:17 | |
*** exploreshaifali has quit IRC | 19:18 | |
svilgelm | Hi. Guys, i suggest to combine my and Viktor's patches to one and merge them to fix the problem with mock in muranoclient. What do you think? Viktors: https://review.openstack.org/#/c/200617/ My: https://review.openstack.org/#/c/200457/ | 19:19 |
openstackgerrit | Sergey Vilgelm proposed openstack/python-muranoclient: Fix the unit tests with wrong using of mock https://review.openstack.org/200457 | 19:25 |
slagun | svilgelm, +2 | 19:40 |
svilgelm | thank you | 19:40 |
*** Nikolay_St has quit IRC | 19:44 | |
*** Nikolay_St has joined #murano | 19:45 | |
*** Miouge has quit IRC | 19:48 | |
*** svilgelm has quit IRC | 19:51 | |
*** bitblt has quit IRC | 20:14 | |
*** svilgelm has joined #murano | 20:17 | |
*** dkusidlo has joined #murano | 20:17 | |
svilgelm | Please, second +2 is necessary for the patch: https://review.openstack.org/#/c/200457/ | 20:18 |
*** svilgelm_ has joined #murano | 20:21 | |
*** svilgelm has quit IRC | 20:22 | |
openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Use setup_develop in devstack libs and plugin for devstack https://review.openstack.org/200531 | 20:35 |
*** svilgelm_ has quit IRC | 20:50 | |
*** dkusidlo has quit IRC | 20:54 | |
*** yamamoto has quit IRC | 20:54 | |
-openstackstatus- NOTICE: Gerrit will be unavailable from 22:00 to 22:30 UTC for project renames | 21:01 | |
*** kzaitsev_mb has joined #murano | 21:30 | |
kzaitsev_mb | anteaya: is there something I should do about the -2? | 21:39 |
anteaya | no, that is mine to prevent the stack from merging before gerrit is offline | 21:39 |
anteaya | kzaitsev_mb: patch is in shape to merge, don't touch anything | 21:40 |
anteaya | thanks for asking though | 21:40 |
kzaitsev_mb | anteaya: ok, won't touch it, then =) | 21:40 |
anteaya | thank you | 21:40 |
anteaya | you are welcome to join #openstack-infra if you want to follow the rename | 21:41 |
kzaitsev_mb | anteaya: ok, sounds good. Serg asked me to handle any community-related questions in his absence, anyway, so will do =) | 21:43 |
anteaya | great | 21:43 |
anteaya | glad he empowered you before he departed on his vacation | 21:43 |
kzaitsev_mb | well he'll be back on Monday, so I don't have much time to mess things up =) | 21:44 |
anteaya | :) | 21:51 |
-openstackstatus- NOTICE: Gerrit is unavailable from approximately 22:00 to 22:30 UTC for project renames | 21:56 | |
*** ChanServ changes topic to "Gerrit is unavailable from approximately 22:00 to 22:30 UTC for project renames" | 21:56 | |
*** ChanServ changes topic to "Wiki: https://wiki.openstack.org/wiki/Murano | Launchpad: https://launchpad.net/Murano" | 22:29 | |
*** dhellmann has quit IRC | 22:54 | |
*** dhellmann has joined #murano | 22:56 | |
*** alex__ has quit IRC | 23:00 | |
openstackgerrit | Kirill Zaitsev proposed openstack/murano-dashboard: WIP: apply AUTO_DISCOVER_STATIC_FILES https://review.openstack.org/200764 | 23:34 |
*** openstackgerrit has quit IRC | 23:39 | |
*** openstackgerrit has joined #murano | 23:39 | |
*** yamamoto has joined #murano | 23:49 | |
*** yamamoto has quit IRC | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!