| *** yamamoto has joined #murano | 00:11 | |
| *** yamamoto has quit IRC | 00:16 | |
| *** stanchan has quit IRC | 00:32 | |
| *** sergmelikyan has quit IRC | 00:37 | |
| *** StanLagun has joined #murano | 01:29 | |
| *** jdandrea has quit IRC | 01:40 | |
| *** jasonsb has joined #murano | 02:23 | |
| *** zhonghua-lee has joined #murano | 02:27 | |
| *** yamamoto has joined #murano | 02:48 | |
| *** xiangxinyong2 has joined #murano | 03:03 | |
| *** xiangxinyong2 is now known as xiangxinyong | 03:18 | |
| *** sergmelikyan has joined #murano | 03:23 | |
| *** sergmelikyan has quit IRC | 03:28 | |
| *** Nikolay_St has joined #murano | 03:34 | |
| *** yamamoto has quit IRC | 04:21 | |
| *** yamamoto has joined #murano | 04:25 | |
| *** zhonghua-lee has quit IRC | 04:27 | |
| *** xiangxinyong has quit IRC | 04:28 | |
| *** zhonghua-lee has joined #murano | 04:35 | |
| *** sergmelikyan has joined #murano | 04:48 | |
| *** yamamoto has quit IRC | 04:54 | |
| *** Nikolay_St has quit IRC | 04:55 | |
| *** yamamoto has joined #murano | 05:00 | |
| *** yamamoto has quit IRC | 05:25 | |
| *** yamamoto has joined #murano | 05:29 | |
| *** Nikolay_St has joined #murano | 05:37 | |
| Nikolay_St | kzaitsev_ws: katyafervent I have a question for you as the most active reviewers of https://review.openstack.org/#/c/209922 | 06:19 |
|---|---|---|
| Nikolay_St | I want to see markers for exception/error log levels usage | 06:19 |
| Nikolay_St | we should discuss it and update a spec after it. | 06:20 |
| *** zhonghua-lee has quit IRC | 06:33 | |
| *** ddovbii has joined #murano | 06:46 | |
| *** sergmelikyan has quit IRC | 06:53 | |
| *** xiangxinyong has joined #murano | 07:42 | |
| katyafervent | Hi Nikolay_St ! | 07:48 |
| *** kzaitsev_mb has joined #murano | 07:49 | |
| katyafervent | What concerns do you have? I don't mind updating the spec, I like log.exception + we already have it. So I don't see negative sides of using that type of logs :) | 07:50 |
| kzaitsev_mb | Nikolay_St: I think, that we should use exception when exceptiontype is unknown and unexpected | 07:50 |
| kzaitsev_mb | or if the exception is muted by except construct and not passed onwards. | 07:51 |
| *** Nikolay_St has quit IRC | 07:51 | |
| kzaitsev_mb | in this case having a stacktrace in the log is benefitial to debugging | 07:51 |
| kzaitsev_mb | if we know exactly what exception we're waiting for (say db.DuplicateEntry) and we do not mute the error (raise HTTPConflict) — there is no need in stacktrace. | 07:52 |
| katyafervent | kzaitsev_mb, +1 | 07:53 |
| kzaitsev_mb | on the contrary, when we do not know what exception to expect (but still want to mute it for the sake of API robustness) we use very general except Exception. In that case a simple log error message would not be enough to debug the problem a user might encounter. | 07:57 |
| kzaitsev_mb | so a stack trace is crucial to understanding what broke where | 07:57 |
| kzaitsev_mb | We can put in the spec like that, I guess =) | 07:59 |
| kzaitsev_mb | although I'd rather not limit it to the case of just except Exception. It's that except Exception is just a very strong marker for such situation. There can be others. like except HTTPException for example, when we do not know how to behave if we got non 2xx response from API looks like another good example of such pattern | 08:01 |
| *** exploreshaifali has joined #murano | 08:14 | |
| *** kzaitsev_mb has quit IRC | 08:15 | |
| *** kzaitsev_mb has joined #murano | 08:17 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/murano: Updated from global requirements https://review.openstack.org/213026 | 08:17 |
| *** exploreshaifali has quit IRC | 08:23 | |
| *** kzaitsev_mb has quit IRC | 08:24 | |
| *** kzaitsev_mb has joined #murano | 08:25 | |
| *** zhonghua-lee has joined #murano | 08:28 | |
| *** Nikolay_St has joined #murano | 08:28 | |
| Nikolay_St | kzaitsev_mb: ok, I get it | 08:54 |
| Nikolay_St | so, we can say something like: "we prefer to use exception log level in cases when we don't know what's going wrong and catch a general exception e.g Exception, HTTPException" | 08:56 |
| Nikolay_St | katyafervent: ^^ | 08:56 |
| Nikolay_St | right? | 08:56 |
| kzaitsev_mb | Nikolay_St: sounds fine to me. Although docs prefer to "write to the user" | 08:57 |
| Nikolay_St | so, I think we need a review from katyafervent on the latest available review for https://review.openstack.org/#/c/209922/ | 08:58 |
| Nikolay_St | everybody is welcome by the way | 08:59 |
| katyafervent | ok | 08:59 |
| kzaitsev_mb | so it should be smth like: "In cases you don't know what might go wrond and cathc general exception (Exception, HTTPException) and a stack-trace would be benefitial for debugging purposes, consider using exception handler" | 08:59 |
| kzaitsev_mb | or smth ) | 08:59 |
| katyafervent | Nikolay_St, what is the difference between _ and _LE | 09:00 |
| katyafervent | sometimes you use one, sometimes another | 09:00 |
| Nikolay_St | katyafervent: _ has much priority for translators | 09:01 |
| Nikolay_St | so we should use it when the message will be passed to end-user | 09:02 |
| *** kzaitsev_mb has quit IRC | 09:04 | |
| StanLagun | Nikolay_St: I put temporary block on this commit | 09:06 |
| Nikolay_St | StanLagun: and what is the reason? | 09:07 |
| StanLagun | Nikolay_St: >Do not merge before new engine get merged | 09:07 |
| Nikolay_St | StanLagun: ok | 09:07 |
| StanLagun | but you can rebase it on top of my commit if you'd like | 09:08 |
| Nikolay_St | StanLagun: will do it as soon as I end with unittests for cloud foundry service broker | 09:09 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/murano: Updated from global requirements https://review.openstack.org/213026 | 09:16 |
| *** junhongl has joined #murano | 09:34 | |
| *** zhonghua-lee has quit IRC | 09:35 | |
| *** slagun has joined #murano | 09:39 | |
| openstackgerrit | Merged openstack/python-muranoclient: Add parameter support to pagination-list https://review.openstack.org/207775 | 09:40 |
| *** StanLagun has quit IRC | 09:42 | |
| *** zhonghua-lee has joined #murano | 09:58 | |
| *** kzaitsev_mb has joined #murano | 10:22 | |
| *** dgollub has joined #murano | 10:24 | |
| *** Nikolay_St has quit IRC | 10:27 | |
| *** exploreshaifali has joined #murano | 10:33 | |
| *** dgollub has quit IRC | 10:37 | |
| *** xiangxinyong has quit IRC | 10:37 | |
| *** yamamoto has quit IRC | 10:44 | |
| *** yamamoto has joined #murano | 10:46 | |
| *** junhongl has quit IRC | 10:49 | |
| *** yamamoto has quit IRC | 11:11 | |
| openstackgerrit | Merged openstack/murano: Updated from global requirements https://review.openstack.org/213026 | 11:11 |
| *** dgollub has joined #murano | 11:18 | |
| *** zhonghua-lee has quit IRC | 11:25 | |
| *** exploreshaifali has quit IRC | 11:36 | |
| *** kzaitsev_mb has quit IRC | 11:50 | |
| *** yamamoto has joined #murano | 12:03 | |
| *** yamamoto has quit IRC | 12:20 | |
| *** kzaitsev_mb has joined #murano | 12:21 | |
| *** Nikolay_St has joined #murano | 12:42 | |
| *** exploreshaifali has joined #murano | 12:44 | |
| *** yamamoto has joined #murano | 12:51 | |
| openstackgerrit | Kirill Zaitsev proposed openstack/python-muranoclient: Generate ids in environment-apps-edit command https://review.openstack.org/213136 | 12:52 |
| openstackgerrit | Kirill Zaitsev proposed openstack/python-muranoclient: Generate ids in environment-apps-edit command https://review.openstack.org/213136 | 13:00 |
| *** kzaitsev_mb has quit IRC | 13:06 | |
| *** kzaitsev_mb has joined #murano | 13:08 | |
| openstackgerrit | Stan Lagun proposed openstack/murano-specs: Improved MuranoPL object construction https://review.openstack.org/213144 | 13:34 |
| *** kumar has joined #murano | 13:35 | |
| openstackgerrit | Stan Lagun proposed openstack/murano: Migration to yaql 1.0 https://review.openstack.org/204099 | 13:41 |
| openstackgerrit | Stan Lagun proposed openstack/murano: Migration to yaql 1.0 https://review.openstack.org/204099 | 13:44 |
| openstackgerrit | zhu.rong proposed openstack/murano: Fix user can not see public packages https://review.openstack.org/213156 | 13:52 |
| *** exploreshaifali has quit IRC | 13:53 | |
| openstackgerrit | zhu.rong proposed openstack/murano: Update the gitingore file https://review.openstack.org/213157 | 13:53 |
| *** exploreshaifali has joined #murano | 13:55 | |
| *** kumar has quit IRC | 13:58 | |
| *** sergmelikyan has joined #murano | 14:06 | |
| *** yamamoto has quit IRC | 14:48 | |
| *** yamamoto has joined #murano | 14:52 | |
| *** exploreshaifali has quit IRC | 15:01 | |
| *** yamamoto has quit IRC | 15:25 | |
| *** openstackgerrit has quit IRC | 15:31 | |
| *** openstackgerrit has joined #murano | 15:31 | |
| *** sergmelikyan has quit IRC | 15:33 | |
| *** yamamoto has joined #murano | 15:35 | |
| openstackgerrit | Merged openstack/murano: Update the gitingore file https://review.openstack.org/213157 | 15:37 |
| *** sergmelikyan has joined #murano | 15:48 | |
| *** jasonsb has quit IRC | 16:15 | |
| *** sergmelikyan has quit IRC | 16:31 | |
| *** sergmelikyan has joined #murano | 16:33 | |
| *** sergmelikyan has quit IRC | 16:33 | |
| *** sergmelikyan has joined #murano | 16:34 | |
| *** sergmelikyan has quit IRC | 16:34 | |
| *** yamamoto has quit IRC | 16:41 | |
| *** yamamoto has joined #murano | 16:41 | |
| *** yamamoto has quit IRC | 16:42 | |
| *** exploreshaifali has joined #murano | 16:45 | |
| *** sergmelikyan has joined #murano | 16:49 | |
| *** sergmelikyan has quit IRC | 16:52 | |
| *** sergmelikyan has joined #murano | 17:09 | |
| *** jasonsb has joined #murano | 17:11 | |
| *** sergmelikyan has quit IRC | 17:12 | |
| *** jasonsb has quit IRC | 17:12 | |
| *** jasonsb has joined #murano | 17:13 | |
| *** sergmelikyan has joined #murano | 17:14 | |
| *** yamamoto has joined #murano | 17:43 | |
| *** yamamoto has quit IRC | 17:48 | |
| *** sergmelikyan has quit IRC | 17:55 | |
| *** sergmelikyan has joined #murano | 17:57 | |
| *** kzaitsev_mb has quit IRC | 18:14 | |
| *** exploreshaifali has quit IRC | 18:41 | |
| *** sergmelikyan has quit IRC | 18:59 | |
| *** sergmelikyan has joined #murano | 19:31 | |
| *** kzaitsev_mb has joined #murano | 20:08 | |
| *** slagun has quit IRC | 20:59 | |
| *** kzaitsev_mb has quit IRC | 21:00 | |
| *** kzaitsev_mb has joined #murano | 21:01 | |
| *** jasonsb has quit IRC | 21:05 | |
| *** yamamoto has joined #murano | 21:06 | |
| *** jasonsb has joined #murano | 21:06 | |
| *** yamamoto has quit IRC | 21:11 | |
| *** dgollub has quit IRC | 22:19 | |
| *** sergmelikyan has quit IRC | 22:33 | |
| *** jasonsb has quit IRC | 22:56 | |
| *** jasonsb has joined #murano | 23:22 | |
| *** jasonsb has quit IRC | 23:28 | |
| *** kzaitsev_mb has quit IRC | 23:29 | |
| *** kzaitsev_mb has joined #murano | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!