| *** vahidh has quit IRC | 00:10 | |
| openstackgerrit | Stan Lagun proposed openstack/murano: Wait for state progress of Heat stack upon delete https://review.openstack.org/260278 | 00:16 |
|---|---|---|
| *** vahidh has joined #murano | 00:17 | |
| *** sergmelikyan has joined #murano | 00:42 | |
| *** vahidh has quit IRC | 00:49 | |
| *** sergmelikyan has quit IRC | 00:50 | |
| *** sergmelikyan has joined #murano | 00:53 | |
| *** vahidh has joined #murano | 00:55 | |
| *** vahidh_ has joined #murano | 01:03 | |
| *** vahidh has quit IRC | 01:06 | |
| *** sergmelikyan has quit IRC | 01:19 | |
| *** kzaitsev_mb has quit IRC | 01:34 | |
| *** zhurong has joined #murano | 02:11 | |
| *** vahidh_ has quit IRC | 02:36 | |
| *** vahidh has joined #murano | 02:54 | |
| *** zhurong has quit IRC | 03:48 | |
| *** vahidh_ has joined #murano | 03:50 | |
| *** vahidh has quit IRC | 03:53 | |
| *** sergmelikyan has joined #murano | 04:22 | |
| *** sergmelikyan has quit IRC | 04:27 | |
| *** kzaitsev_mb has joined #murano | 04:55 | |
| *** enthurohini has joined #murano | 05:05 | |
| *** Nikolay_St has quit IRC | 05:07 | |
| *** vahidh_ has quit IRC | 05:07 | |
| *** vahidh has joined #murano | 05:10 | |
| *** sergmelikyan has joined #murano | 05:24 | |
| enthurohini | hello kzaitsev_mb | 05:24 |
| kzaitsev_mb | morning | 05:25 |
| kzaitsev_mb | it's early morning in here %) | 05:26 |
| enthurohini | I am preety confused with test cases, should i test that templates contains the tag parameter or stacks generated ate get tagged or not? | 05:26 |
| enthurohini | ohh then you can answer or not | 05:27 |
| *** sergmelikyan has quit IRC | 05:28 | |
| kzaitsev_mb | enthurohini: tbh — I'm not sure about how tags are implemented in heat. is the template different from usual? | 05:28 |
| kzaitsev_mb | also | 05:29 |
| enthurohini | nope, its not different, itjust contain one extra parameter that is tag | 05:29 |
| kzaitsev_mb | than it's the same, rigth? =) | 05:29 |
| enthurohini | yup, | 05:29 |
| kzaitsev_mb | I mean "templates contains the tag parameter or stacks generated ate get tagged" are basically the same things, rigth? | 05:30 |
| enthurohini | nd i have introduced this extra parameter in push function where we send the template to the heat | 05:30 |
| enthurohini | yeah | 05:31 |
| kzaitsev_mb | well that's your answer then =) | 05:32 |
| kzaitsev_mb | you can mock the function call and check that it get's called with tag parameter | 05:33 |
| kzaitsev_mb | you're adding unit tests to murano/tests/unit/test_heat_stack.py right? | 05:34 |
| enthurohini | means i have to mock function and should check, but sont you think it will be a repaet, coz another test cases https://github.com/openstack/murano/blob/master/murano/tests/unit/test_heat_stack.py#L65 also asset the parameters | 05:35 |
| enthurohini | yes | 05:35 |
| enthurohini | and i have already modified them | 05:35 |
| kzaitsev_mb | enthurohini: well then you don't have to mock anything additional, I believe | 05:36 |
| kzaitsev_mb | setUp there already mocks all the calls | 05:36 |
| enthurohini | yes, and i have to assert only that new template contains tag parameter or not. right? | 05:37 |
| kzaitsev_mb | so all you have to do is set up (no pun intended =)) config prarmeter that controlls heat stack-tags (or pass the value to the HeatStack) and then assert that create was called correctly | 05:37 |
| kzaitsev_mb | take a look at those tests | 05:38 |
| kzaitsev_mb | those are unit tests | 05:38 |
| kzaitsev_mb | they do not actually create anything in heat | 05:38 |
| kzaitsev_mb | or anywhere | 05:38 |
| kzaitsev_mb | they only check validity and correctness of a small set of functions | 05:38 |
| *** vahidh has quit IRC | 05:38 | |
| enthurohini | no pun means? | 05:38 |
| kzaitsev_mb | =) | 05:38 |
| kzaitsev_mb | ok, this would be a lesson in enginsh, you ok with that? =) | 05:39 |
| enthurohini | not getting you :P means your last line | 05:40 |
| kzaitsev_mb | pun is a joke about playing words =) | 05:40 |
| kzaitsev_mb | oh I've found an easy one | 05:41 |
| kzaitsev_mb | "Every calendar's days are numbered" | 05:41 |
| kzaitsev_mb | it's a joke, because it's days are numbered, meaning that it is gonna die soon, but at the same time they're literally numbered ) | 05:41 |
| kzaitsev_mb | that's a pun =) | 05:41 |
| enthurohini | kzaitsev_mb, plaese take a look at the patch, https://review.openstack.org/#/c/258661/6/murano/tests/unit/test_heat_stack.py, here i have fetched config parameter | 05:42 |
| enthurohini | :P | 05:42 |
| kzaitsev_mb | why do you modify self.mock_murano_class.declared_parents ? | 05:43 |
| enthurohini | still not getting, but will explore about ur joke :P | 05:43 |
| kzaitsev_mb | enthurohini: I was trying to explain the concept, not a joke =) | 05:43 |
| enthurohini | i have not modified that | 05:44 |
| kzaitsev_mb | the joke is silly =) like all puns are =) that's why I said, that I didn't intend the "set up the SetUp" pun =) | 05:44 |
| kzaitsev_mb | enthurohini: you did | 05:44 |
| kzaitsev_mb | it's in the patch | 05:44 |
| enthurohini | yup its showing, but non remember | 05:44 |
| enthurohini | i will look that | 05:45 |
| enthurohini | so i was saying that tag parameter is already assetred many times, so shoud i do it one more time? | 05:45 |
| kzaitsev_mb | it's actually not a good idea to use config in tests | 05:46 |
| enthurohini | then what can i do? | 05:46 |
| kzaitsev_mb | although looking at your code it's kind of ok | 05:46 |
| kzaitsev_mb | can you check murano (and maybe a couple of other projects) on what they do in this case? And if there is a way to mock oslo_config.cfg.CONF. | 05:48 |
| enthurohini | ok , i will check | 05:48 |
| enthurohini | and will do according to that | 05:48 |
| kzaitsev_mb | ideally you would "mock the call to oslo_config.cfg.CONF" and make it return a set of tags, then verify, that stacks.create was called with that set of parameters | 05:49 |
| enthurohini | nd to check it i should write a seprate function | 05:50 |
| enthurohini | right? | 05:51 |
| *** vahidh has joined #murano | 05:52 | |
| *** zhurong has joined #murano | 05:55 | |
| kzaitsev_mb | looked at the code | 05:55 |
| kzaitsev_mb | yes, if we can mock CONF somehow — yes a separate test function would be good | 05:56 |
| enthurohini | ok, thankyou so much kzaitsev_mb | 05:57 |
| enthurohini | disturbed you in early morning | 05:57 |
| kzaitsev_mb | =)) | 05:58 |
| kzaitsev_mb | it's also my birthday and I had to blow the candles =Р | 05:58 |
| enthurohini | ohh wow, many many happy returns of the day. :). really sorry yr | 05:59 |
| kzaitsev_mb | don't be sorry =) | 05:59 |
| kzaitsev_mb | If I hadn't time I would politely ask you to wait =) So come and ask whenever you're not sure about anything ) | 06:00 |
| enthurohini | thanks kzaitsev_mb, i am lucky to have you as my mentor | 06:01 |
| kzaitsev_mb | so — absolutely no problem =) | 06:01 |
| enthurohini | :) | 06:01 |
| enthurohini | kzaitsev_mb, for how many you wll be on holiday for newyear or christmas? | 06:04 |
| kzaitsev_mb | we have pretty long holidays starting with 1st Jan in Russia. 1 till 10th this year I think. I will not be available/online 1-3 Jan, after that I would most likely have my laptop/internet just fine =) | 06:06 |
| kzaitsev_mb | how bout your holidays? +) | 06:06 |
| enthurohini | from 25 th dec to 3rd jan, but i will work throughout | 06:07 |
| enthurohini | because i am very slow programmer | 06:07 |
| kzaitsev_mb | you're doing fine =) | 06:10 |
| kzaitsev_mb | and be sure to have a couple days off =) it usually increases your productivity ;) | 06:10 |
| enthurohini | :), k will take from 1st to 3rd. one more thing, why i dont have option to assign BP to myself? | 06:11 |
| kzaitsev_mb | I think only "drivers" can do that | 06:11 |
| kzaitsev_mb | you can do it for bps you created, but not for the ones other people created | 06:12 |
| enthurohini | ok, then can you plz do that for me? | 06:12 |
| enthurohini | ok, got it | 06:12 |
| enthurohini | thankyou :) | 06:13 |
| kzaitsev_mb | + | 06:13 |
| *** kzaitsev_mb has quit IRC | 06:34 | |
| *** kzaitsev_mb has joined #murano | 06:37 | |
| *** vgridnev has joined #murano | 06:37 | |
| *** vahidh has quit IRC | 06:37 | |
| *** enthurohini has quit IRC | 06:39 | |
| *** kzaitsev_mb has quit IRC | 06:43 | |
| *** enthurohini has joined #murano | 06:46 | |
| *** kzaitsev_mb has joined #murano | 06:53 | |
| *** kzaitsev_mb has quit IRC | 07:03 | |
| *** kzaitsev_mb has joined #murano | 07:04 | |
| *** kzaitsev_mb has quit IRC | 07:09 | |
| *** vahidh has joined #murano | 07:22 | |
| *** vahidh has quit IRC | 07:34 | |
| *** enthurohini has quit IRC | 07:47 | |
| *** Nikolay_St has joined #murano | 08:00 | |
| *** zhurong has quit IRC | 08:14 | |
| *** vahidh has joined #murano | 08:17 | |
| *** vahidh has quit IRC | 08:22 | |
| *** yamamoto has joined #murano | 08:33 | |
| *** yamamoto has quit IRC | 08:36 | |
| *** yamamoto has joined #murano | 08:36 | |
| *** yamamoto has quit IRC | 08:41 | |
| *** vgridnev has quit IRC | 08:43 | |
| *** kzaitsev_mb has joined #murano | 09:10 | |
| *** sergmelikyan has joined #murano | 09:27 | |
| *** sergmelikyan has quit IRC | 09:32 | |
| *** gangadhar has joined #murano | 09:41 | |
| *** yamamoto has joined #murano | 09:42 | |
| *** yamamoto has quit IRC | 09:48 | |
| *** vgridnev has joined #murano | 09:49 | |
| *** yamamoto has joined #murano | 09:58 | |
| *** vahidh has joined #murano | 10:06 | |
| *** yamamoto has quit IRC | 10:10 | |
| *** vahidh has quit IRC | 10:11 | |
| *** stan_lagun has joined #murano | 10:18 | |
| *** slagun has quit IRC | 10:21 | |
| *** yamamoto has joined #murano | 10:23 | |
| *** yamamoto has quit IRC | 10:24 | |
| *** sergmelikyan has joined #murano | 10:28 | |
| *** sergmelikyan has quit IRC | 10:32 | |
| *** zhurong has joined #murano | 10:39 | |
| *** yamamoto has joined #murano | 11:02 | |
| *** yamamoto has quit IRC | 11:02 | |
| *** yamamoto has joined #murano | 12:19 | |
| *** yamamoto has quit IRC | 12:23 | |
| *** yamamoto has joined #murano | 12:25 | |
| *** sergmelikyan has joined #murano | 12:30 | |
| *** sergmelikyan has quit IRC | 12:36 | |
| *** yamamoto has quit IRC | 12:40 | |
| *** vahidh has joined #murano | 12:49 | |
| *** yamamoto has joined #murano | 12:50 | |
| *** vahidh has quit IRC | 12:54 | |
| openstackgerrit | janonymous proposed openstack/python-muranoclient: Put py34 first in the env order of tox https://review.openstack.org/260498 | 13:00 |
| *** sergmelikyan has joined #murano | 13:04 | |
| openstackgerrit | Stan Lagun proposed openstack/murano-specs: Support for OpenStack regions https://review.openstack.org/257098 | 13:05 |
| openstackgerrit | janonymous proposed openstack/murano-dashboard: Put py34 first in the env order of tox https://review.openstack.org/260514 | 13:13 |
| openstackgerrit | Ekaterina Chernova proposed openstack/murano-apps: [Tomcat] Add unit-tests to Tomcat application https://review.openstack.org/259434 | 13:20 |
| *** sergmelikyan has quit IRC | 13:21 | |
| *** sergmelikyan has joined #murano | 13:22 | |
| *** yamamoto has quit IRC | 13:47 | |
| *** yamamoto has joined #murano | 13:48 | |
| *** sergmelikyan has quit IRC | 14:20 | |
| *** yamamoto has quit IRC | 14:22 | |
| *** sergmelikyan has joined #murano | 14:34 | |
| *** enthurohini has joined #murano | 14:34 | |
| *** zhurong has quit IRC | 14:51 | |
| *** kzaitsev_mb has quit IRC | 14:53 | |
| *** zigo_ is now known as zigo | 15:19 | |
| *** thumpba has joined #murano | 15:21 | |
| *** Nikolay_St has quit IRC | 15:46 | |
| *** sergmelikyan has quit IRC | 15:46 | |
| *** yamamoto has joined #murano | 15:49 | |
| *** sergmelikyan has joined #murano | 15:54 | |
| *** ducttape_ has joined #murano | 16:03 | |
| *** ddovbii has quit IRC | 16:05 | |
| *** ducttape_ has quit IRC | 16:11 | |
| *** ducttape_ has joined #murano | 16:12 | |
| *** vgridnev has quit IRC | 16:15 | |
| *** sergmelikyan has quit IRC | 16:16 | |
| *** yamamoto has quit IRC | 16:19 | |
| *** sergmelikyan has joined #murano | 16:25 | |
| *** vahidh has joined #murano | 16:26 | |
| *** ducttape_ has quit IRC | 16:29 | |
| *** sergmelikyan has quit IRC | 16:30 | |
| *** sergmelikyan has joined #murano | 16:30 | |
| *** vahidh has quit IRC | 16:31 | |
| *** ducttape_ has joined #murano | 16:38 | |
| openstackgerrit | Kirill Zaitsev proposed openstack/murano-dashboard: Introduced python3 support https://review.openstack.org/251417 | 16:43 |
| *** yamamoto has joined #murano | 16:44 | |
| *** thumpba_ has joined #murano | 16:46 | |
| *** thumpba has quit IRC | 16:49 | |
| *** ducttape_ has quit IRC | 16:51 | |
| *** yamamoto has quit IRC | 16:56 | |
| *** yamamoto has joined #murano | 16:56 | |
| *** yamamoto has quit IRC | 16:58 | |
| *** kzaitsev_mb has joined #murano | 17:00 | |
| *** Nikolay_St has joined #murano | 17:02 | |
| openstackgerrit | Merged openstack/python-muranoclient: Updated from global requirements https://review.openstack.org/260268 | 17:06 |
| openstackgerrit | janonymous proposed openstack/python-muranoclient: Put py34 first in the envlist order of tox https://review.openstack.org/260498 | 17:11 |
| openstackgerrit | Merged openstack/murano: Updated from global requirements https://review.openstack.org/260255 | 17:14 |
| *** vgridnev has joined #murano | 17:14 | |
| *** jfluhmann has joined #murano | 17:17 | |
| *** jfluhmann has left #murano | 17:19 | |
| *** kzaitsev_mb has quit IRC | 17:23 | |
| *** sergmelikyan has quit IRC | 17:26 | |
| *** vahidh has joined #murano | 17:40 | |
| openstackgerrit | Merged openstack/murano-dashboard: Add maximum disk, vcpu and memory requirement https://review.openstack.org/257281 | 17:45 |
| openstackgerrit | Merged openstack/murano: [test-runner] Put TestFixture class check to the right place https://review.openstack.org/260008 | 17:50 |
| *** openstackgerrit has quit IRC | 18:02 | |
| *** openstackgerrit has joined #murano | 18:02 | |
| *** vahidh_ has joined #murano | 18:04 | |
| *** vahidh has quit IRC | 18:06 | |
| *** vahidh has joined #murano | 18:10 | |
| *** vahidh_ has quit IRC | 18:14 | |
| *** vahidh has quit IRC | 18:22 | |
| openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Use murano client for getting final status of environment https://review.openstack.org/259721 | 18:26 |
| openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Use murano client for getting final status of environment https://review.openstack.org/259721 | 18:28 |
| *** vahidh has joined #murano | 18:32 | |
| openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Adjust '410 Gone' exception in service broker negative tests https://review.openstack.org/259718 | 18:37 |
| *** vgridnev has quit IRC | 19:33 | |
| *** vgridnev has joined #murano | 19:44 | |
| *** vahidh_ has joined #murano | 20:18 | |
| *** vahidh has quit IRC | 20:20 | |
| openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Adjust '410 Gone' exception in service broker negative tests https://review.openstack.org/259718 | 20:32 |
| *** vahidh has joined #murano | 20:39 | |
| *** vahidh_ has quit IRC | 20:39 | |
| *** sergmelikyan has joined #murano | 21:01 | |
| openstackgerrit | Victor Ryzhenkin proposed openstack/murano: Adjust '410 Gone' exception in service broker negative tests https://review.openstack.org/259718 | 21:02 |
| *** vahidh has quit IRC | 21:08 | |
| *** sergmelikyan has quit IRC | 21:09 | |
| *** vgridnev has quit IRC | 21:11 | |
| *** sergmelikyan has joined #murano | 21:15 | |
| *** vahidh has joined #murano | 21:17 | |
| *** sergmelikyan has quit IRC | 21:24 | |
| *** vahidh has quit IRC | 21:36 | |
| *** vahidh has joined #murano | 21:37 | |
| *** vahidh has quit IRC | 21:51 | |
| *** vahidh has joined #murano | 21:52 | |
| *** sergmelikyan has joined #murano | 21:53 | |
| *** vahidh has quit IRC | 22:06 | |
| *** vahidh has joined #murano | 22:08 | |
| *** enthurohini has quit IRC | 22:12 | |
| *** sergmelikyan has quit IRC | 22:20 | |
| *** sergmelikyan has joined #murano | 22:22 | |
| *** yamamoto has joined #murano | 22:24 | |
| *** yamamoto has quit IRC | 22:25 | |
| *** vahidh has quit IRC | 22:26 | |
| *** vahidh has joined #murano | 22:31 | |
| *** sergmelikyan has quit IRC | 22:42 | |
| *** vahidh has quit IRC | 22:51 | |
| *** mfisch` is now known as mfisch | 22:55 | |
| *** mfisch is now known as Guest13696 | 22:56 | |
| *** vahidh has joined #murano | 22:59 | |
| openstackgerrit | Ivan Udovichenko proposed openstack/python-muranoclient: Remove argparse dependency from requirements.txt file https://review.openstack.org/260745 | 23:19 |
| *** vahidh has quit IRC | 23:26 | |
| *** vahidh has joined #murano | 23:26 | |
| *** vahidh_ has joined #murano | 23:30 | |
| *** vahidh has quit IRC | 23:31 | |
| *** vahidh has joined #murano | 23:51 | |
| *** vahidh_ has quit IRC | 23:52 | |
| *** vahidh has quit IRC | 23:57 | |
| *** vahidh has joined #murano | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!