*** kzaitsev_mb has quit IRC | 00:20 | |
*** ducttape_ has joined #murano | 00:22 | |
*** jasonsb has joined #murano | 00:28 | |
*** stanchan has quit IRC | 00:42 | |
*** jfluhmann has quit IRC | 00:47 | |
*** ducttape_ has quit IRC | 01:10 | |
*** ducttape_ has joined #murano | 01:24 | |
*** ducttape_ has quit IRC | 01:30 | |
openstackgerrit | Aaron Ding proposed openstack/murano: Modify filter by 'Name' in Package Definition https://review.openstack.org/263517 | 01:36 |
---|---|---|
openstackgerrit | Aaron Ding proposed openstack/murano-dashboard: Modify filter by 'Name' in Package Definition https://review.openstack.org/263518 | 01:37 |
*** Liuqing has joined #murano | 01:37 | |
*** ducttape_ has joined #murano | 01:41 | |
*** lin_yang has joined #murano | 01:55 | |
*** zhurong has joined #murano | 02:09 | |
*** ducttape_ has quit IRC | 02:47 | |
*** klkumar has joined #murano | 03:24 | |
*** klkumar has quit IRC | 03:34 | |
*** enthurohini has joined #murano | 04:52 | |
*** Liuqing has quit IRC | 05:05 | |
*** zhurong has quit IRC | 05:05 | |
*** zhurong has joined #murano | 05:05 | |
*** Liuqing has joined #murano | 05:06 | |
*** enthurohini has quit IRC | 05:21 | |
*** Liuqing has quit IRC | 05:51 | |
*** kodokuu has quit IRC | 06:30 | |
*** vahidh has quit IRC | 06:45 | |
*** samuelBartel has joined #murano | 07:52 | |
*** tobe has joined #murano | 08:41 | |
*** tobe has quit IRC | 08:41 | |
*** jsheeren has joined #murano | 08:45 | |
*** nareshtr has joined #murano | 08:52 | |
*** gangadhar has quit IRC | 08:55 | |
*** kzaitsev_mb has joined #murano | 09:15 | |
*** vahidh has joined #murano | 09:17 | |
*** vahidh has quit IRC | 09:22 | |
*** zhurong has quit IRC | 09:22 | |
*** kzaitsev_mb has quit IRC | 09:24 | |
*** klkumar has joined #murano | 09:30 | |
*** kodokuu has joined #murano | 09:45 | |
kodokuu | ddovbii Hi | 09:45 |
ddovbii | kodokuu, hi! | 09:51 |
kodokuu | I see your message for the bug, Works now | 09:51 |
kodokuu | I don't know why I haven't this commit because I download stable/kilo on github | 09:51 |
kodokuu | strange ^^ | 09:52 |
*** klkumar has quit IRC | 10:02 | |
*** tlashchova has joined #murano | 10:11 | |
*** klkumar has joined #murano | 10:13 | |
*** zhurong has joined #murano | 10:33 | |
*** kzaitsev_mb has joined #murano | 10:42 | |
*** nareshtr has quit IRC | 10:43 | |
*** yamamoto has joined #murano | 10:56 | |
*** jsheeren has quit IRC | 10:58 | |
*** samuelBartel has quit IRC | 10:58 | |
*** kzaitsev_mb has quit IRC | 11:02 | |
*** yamamoto has quit IRC | 11:04 | |
*** kzaitsev_mb has joined #murano | 11:15 | |
*** klkumar has quit IRC | 11:17 | |
*** klkumar has joined #murano | 11:20 | |
*** kzaitsev_mb has quit IRC | 11:31 | |
*** enthurohini has joined #murano | 11:32 | |
*** vahidh has joined #murano | 12:00 | |
*** vahidh has quit IRC | 12:05 | |
*** klkumar has quit IRC | 12:22 | |
*** klkumar has joined #murano | 12:25 | |
*** klkumar has quit IRC | 12:43 | |
*** raildo-afk is now known as raildo | 12:47 | |
*** kzaitsev_mb has joined #murano | 12:52 | |
*** vahidh has joined #murano | 12:55 | |
*** vahidh has quit IRC | 12:59 | |
openstackgerrit | Dmytro Dovbii proposed openstack/murano-dashboard: Delete only murano data from image metadata https://review.openstack.org/263719 | 13:01 |
kodokuu | ddovbii great :) | 13:04 |
ddovbii | kodokuu, =) | 13:04 |
kzaitsev_mb | by the looks of it you still set purge_props to True | 13:05 |
*** ducttape_ has joined #murano | 13:06 | |
kzaitsev_mb | probably it would work though | 13:07 |
*** ducttape_ has quit IRC | 13:07 | |
kzaitsev_mb | but I'd rather just remove purge_props at all from the glance call. | 13:08 |
ddovbii | kzaitsev_mb, i tried both options. Without purge_props glance call does nothing | 13:09 |
*** idvoretskyi has quit IRC | 13:10 | |
ddovbii | if purge_props is provided, other data is saved | 13:10 |
ddovbii | and murano data is deleted | 13:10 |
kzaitsev_mb | hm. | 13:11 |
kzaitsev_mb | I see your point | 13:11 |
*** zhurong has quit IRC | 13:12 | |
*** ducttape_ has joined #murano | 13:13 | |
kzaitsev_mb | actually that's kind of a bit strange API on the glance side | 13:15 |
kzaitsev_mb | but well =) | 13:15 |
kzaitsev_mb | so long as it works ) | 13:15 |
ddovbii | =) | 13:15 |
enthurohini | kzaitsev_mb, there? | 13:20 |
kodokuu | ddovbii Can I try your patch ? | 13:22 |
*** samuelBartel has joined #murano | 13:24 | |
kzaitsev_mb | enthurohini: will be back in 30-45 min | 13:24 |
ddovbii | kodokuu, why not? kzaitsev_mb, should I backport it to kilo and liberty or maybe it is better to wait until it will be merged to master? | 13:24 |
kzaitsev_mb | ddovbii: usually better to wait before it is merged in master | 13:25 |
ddovbii | ok | 13:25 |
enthurohini | ok | 13:25 |
kzaitsev_mb | and I'm not sure if it's a good idea to backport it to kilo | 13:25 |
kzaitsev_mb | definitelly liberty though | 13:25 |
kzaitsev_mb | and we still have kilo broken anyway ) | 13:26 |
ddovbii | due to fact that it is not critical looks like you are right | 13:26 |
*** kzaitsev_mb has quit IRC | 13:31 | |
*** ducttape_ has quit IRC | 13:36 | |
*** lin_yang has quit IRC | 13:44 | |
*** lin_yang has joined #murano | 13:44 | |
*** kzaitsev_mb has joined #murano | 14:09 | |
*** ducttape_ has joined #murano | 14:22 | |
*** ducttape_ has quit IRC | 14:28 | |
*** kzaitsev_mb has quit IRC | 14:30 | |
kodokuu | ddovbii your patch works ;) | 14:42 |
*** sergmelikyan has joined #murano | 14:48 | |
*** ducttape_ has joined #murano | 14:48 | |
ddovbii | kodokuu, cool =) | 14:49 |
*** kzaitsev_mb has joined #murano | 15:32 | |
enthurohini | kzaitsev_mb, can we talk? | 15:40 |
kzaitsev_mb | sure | 15:41 |
kzaitsev_mb | got any questions? | 15:41 |
enthurohini | kzaitsev_mb, i have setup openstack via devstack, and i dont have python-muranoclient repo | 15:42 |
kzaitsev_mb | what do you mean you dont have python-muranoclient repo ? | 15:42 |
enthurohini | during devstack installation it get installed via pip through script, so i have it in dist package but it is not a git repo | 15:43 |
enthurohini | so how can i contribute | 15:43 |
kzaitsev_mb | just download yourself a copy =) | 15:44 |
enthurohini | means i should clone this repo and it will work? | 15:44 |
kzaitsev_mb | ofcourse. after all it is all python code and python executables are just .py files, nothing more | 15:46 |
kzaitsev_mb | also | 15:46 |
enthurohini | yup. | 15:47 |
kzaitsev_mb | you can download the repo (for example to the directory /home/enthurohini/python-muranoclient) | 15:47 |
kzaitsev_mb | and then pip install -e /home/enthurohini/python-muranoclient | 15:48 |
enthurohini | then i will have two muranoclient i think :P | 15:48 |
enthurohini | as one is already installed | 15:49 |
kzaitsev_mb | so what happens when you type 'murano'? | 15:49 |
kzaitsev_mb | which one woule be executed? =) | 15:49 |
enthurohini | the new one installed | 15:49 |
kzaitsev_mb | why are you so sure? =) | 15:50 |
enthurohini | because, i have tried it prevoiusly | 15:50 |
kzaitsev_mb | when you type 'top' where is the actual 'top' file located? | 15:50 |
kzaitsev_mb | and is there a 'top' file? what do you think? =) | 15:52 |
enthurohini | i didnot tried top, but once upon i have installed devstack nd afterwards i installed muranoclient manually, then i was unable to find env that i have in dashboard. I was able to see env that i have created via command only | 15:52 |
enthurohini | when i used issue morano environment list | 15:53 |
kzaitsev_mb | and when you type 'murano' — where is that 'murano' file located? | 15:54 |
kzaitsev_mb | enthurohini: (it's ok to say that you don't know ;) it's not an exam =) ) | 15:55 |
*** alraddara has joined #murano | 15:55 | |
enthurohini | i dont know cz i cant try it right now, cz i have a new setup now | 15:56 |
kzaitsev_mb | enthurohini: I'm trying to teach you something generic here =) | 15:56 |
kzaitsev_mb | it doesn't really matter if it's devstack or not | 15:57 |
kzaitsev_mb | it's a question of shell or bash | 15:57 |
enthurohini | currently, when i issue murano, it provides usage info | 15:57 |
kzaitsev_mb | exactly as it should | 15:58 |
kzaitsev_mb | but what did I ask? I asked you where is that file, that get's executed. | 15:58 |
kzaitsev_mb | aren't you curious about it? =) | 15:58 |
enthurohini | it is in /usr/local/python2.7/dist-packages/muranoclient | 15:59 |
enthurohini | yup, all the pip installed packages reside in ^ above folder | 15:59 |
kzaitsev_mb | no the file 'murano' is not from there most likely | 16:00 |
enthurohini | then? | 16:01 |
*** mragupat has joined #murano | 16:01 | |
enthurohini | now, i am really curious | 16:01 |
kzaitsev_mb | and even if it would — how would simple command 'murano' know to look in that directory? =) | 16:01 |
kzaitsev_mb | ok, I'm about to stop torturing you with all this questions =) | 16:02 |
kzaitsev_mb | type `which murano` | 16:02 |
enthurohini | i like ur all this questions as it opens my mind | 16:02 |
enthurohini | ok | 16:02 |
enthurohini | it is /usr/local/bin/murano | 16:03 |
kzaitsev_mb | so it actually was in /usr/local/bin/ not in /usr/local/python2.7/dist-packages/muranoclient =) | 16:04 |
enthurohini | but i saw the same files as we have in our repo muranoclient there. then what was that? | 16:05 |
kzaitsev_mb | so. actually when you type 'murano' your shell (i.e. bash) looks for a file named 'murano' in all the directories that are mentioned in the environmental variable $PATH, you can examine them by typing 'echo $PATH' in your console. So | 16:06 |
kzaitsev_mb | oh, another important thing — first one found wins. so you can have multiple files named murano in all those directories. But the first one found there, in the order they are mentioned in $PATH wins | 16:08 |
kzaitsev_mb | SO | 16:08 |
enthurohini | yeah, this path is mentioned there | 16:08 |
enthurohini | ok. | 16:09 |
kzaitsev_mb | what pip install -e does, is that along the lines it puts executable file murano, which is an entry point to murano client into /usr/local/bin/ or you local venv bin directory. Somewhere along the path | 16:11 |
kzaitsev_mb | for example when I 'sudo pip install -vv -e ./python-muranoclient/' it tells me | 16:11 |
kzaitsev_mb | 'Installing murano script to /usr/local/bin' | 16:12 |
kzaitsev_mb | the library files are put somewhere python interpreter can find them, usually it's something like /usr/local/python2.7/dist-packages/, but that's a different story =) | 16:12 |
kzaitsev_mb | so | 16:12 |
kzaitsev_mb | coming back to your question =) | 16:13 |
kzaitsev_mb | it's totally ok to pip install -e ./path/to/muranoclient =) | 16:13 |
enthurohini | and if i have already file inside /usr/local/bin, then it will overwright? | 16:13 |
kzaitsev_mb | yep, the binary would get overwritten most likely | 16:13 |
kzaitsev_mb | or not, if it was in a different directory | 16:14 |
enthurohini | ok. | 16:14 |
kzaitsev_mb | and the library files would also be overriden in /usr/local/python2.7/dist-packages/ =) | 16:14 |
kzaitsev_mb | sorry for such a long explanation =) | 16:14 |
enthurohini | please, dont be sorry. | 16:15 |
kzaitsev_mb | could've just said — 'everything would be ok =)' but that would not be that fun, right ;) | 16:15 |
enthurohini | i love to learn, nd knowing concepts, thaty i said you already that i love your mentorship | 16:15 |
enthurohini | yup, you are absolutely right. | 16:16 |
kzaitsev_mb | So. I hope, that now you know a bit more, about what actually happens under the hood of 'pip install' and calls to 'murano'. =) | 16:16 |
enthurohini | yeah, and millions of thanks for long explaination :) | 16:17 |
kzaitsev_mb | I tend to exaplain it from the bottom, when I notice, that someone does not understand some concepts =) | 16:17 |
enthurohini | it is very nice thing abou you | 16:18 |
enthurohini | kzaitsev_mb, lets come to openstack client support now | 16:18 |
kzaitsev_mb | yep | 16:21 |
enthurohini | As to enable openstackclient support, we need to make a client and register it into entry points, so we will require to give name to this plugin. And u said that murano is not a good name, can we name it application_catalog? | 16:21 |
kzaitsev_mb | so yep, I think 'pip install -e' should be a good place to start and make it working | 16:22 |
kzaitsev_mb | yes | 16:22 |
kzaitsev_mb | 'application-catalog' | 16:22 |
kzaitsev_mb | I think we replaced _ with - some time ago, due to some bug in keystone | 16:22 |
alraddara | kzaitsev_mb: Hi, are you the same person that filed this bug: https://bugs.launchpad.net/murano/+bug/1514756 ? I am going to work on it and have a couple of simple questions whenever you get done with your current discussion :) | 16:26 |
openstack | Launchpad bug 1514756 in Murano "Murano still uses the term tenant in multiple places" [Low,In progress] - Assigned to Darla Ahlert (da741q) | 16:26 |
enthurohini | kzaitsev_mb, ok. now i am starting coding for it. and will submit patch for it soon | 16:27 |
*** vgridnev has joined #murano | 16:27 | |
kzaitsev_mb | enthurohini: awesome! =) we've been wanting to have support for it for quite some time =) | 16:27 |
kzaitsev_mb | alraddara: yep, what questions do you have? ) | 16:27 |
alraddara | kzaitsev_mb: should i replace every instance of the word 'tenant' with 'project'? and should i only complete these changes in the "doc" directory? | 16:31 |
alraddara | i'm new to the community so i'm totally open to any guidance you may have | 16:31 |
*** vgridnev_ has joined #murano | 16:32 | |
*** vgridnev has quit IRC | 16:32 | |
kzaitsev_mb | alraddara: oh, well. =) that's a good question to be fair ) | 16:40 |
kzaitsev_mb | I think, that you should replace most if not all mentions of tenant to 'project' | 16:41 |
kzaitsev_mb | alraddara: maybe somewhere it would be more appropriate to use something like 'project (tenant)' | 16:43 |
kzaitsev_mb | I think it's a matter of personal taste | 16:43 |
kzaitsev_mb | but I'd like to have it more appropriate. | 16:43 |
kzaitsev_mb | also. `keystone` CLI client is deprecated. we have several calls to it in documentation. Those should be replaced with calls to 'openstack' | 16:44 |
kzaitsev_mb | sry, for answering slow, was a bit busy =) | 16:46 |
alraddara | kzaitsev_mb: that's fine! and okay sounds good. But I should only be working within the "doc" directory, correct? | 16:47 |
alraddara | i will look around to see where in the documentation it might be nice to have 'project (tenant)' | 16:47 |
kzaitsev_mb | alraddara: with this bug — yes. Most likely there are mentions in other places. but the bug is about docs. so feel free to fix just the docs. | 16:48 |
alraddara | perfect. thanks so much for your help. i will begin working in this today | 16:48 |
kzaitsev_mb | however if you want to look at other parts of code — and feel that there is anything appropriate there — you can also alter that | 16:48 |
kzaitsev_mb | maybe in a separate commit | 16:48 |
kzaitsev_mb | although it's completely optional | 16:48 |
kzaitsev_mb | fixing the docs would already do a great deal =) | 16:49 |
kzaitsev_mb | no rush =) | 16:49 |
alraddara | i will definitely keep an eye out as i work on fixing the docs. | 16:49 |
alraddara | thanks again | 16:50 |
kzaitsev_mb | alraddara: most of core reviewers are on vacation as far as I know =) I do check the code now and then, but we'll need a second +2 +) | 16:50 |
enthurohini | :) | 16:51 |
kzaitsev_mb | but everyone would be back next monday ) | 16:51 |
alraddara | awesome. sounds good to me! | 16:51 |
*** kzaitsev_mb has quit IRC | 16:57 | |
*** alraddara has left #murano | 16:58 | |
*** alraddarla has joined #murano | 16:59 | |
*** kzaitsev_mb has joined #murano | 16:59 | |
*** vahidh has joined #murano | 17:12 | |
*** ducttape_ has quit IRC | 17:14 | |
*** ducttape_ has joined #murano | 17:14 | |
*** samuelBartel has quit IRC | 17:18 | |
*** kzaitsev_mb has quit IRC | 17:19 | |
*** vgridnev_ has quit IRC | 17:24 | |
*** _ducttape_ has joined #murano | 17:40 | |
*** ducttape_ has quit IRC | 17:40 | |
*** tlashchova has quit IRC | 17:48 | |
*** mragupat has quit IRC | 17:56 | |
*** mragupat has joined #murano | 17:56 | |
*** vahidh has quit IRC | 18:07 | |
*** vahidh has joined #murano | 18:07 | |
*** vahidh has quit IRC | 18:12 | |
*** _ducttape_ has quit IRC | 18:37 | |
*** alraddarla has quit IRC | 18:39 | |
*** vahidh has joined #murano | 19:01 | |
*** enthurohini has quit IRC | 19:20 | |
*** ducttape_ has joined #murano | 19:30 | |
*** kzaitsev_mb has joined #murano | 20:45 | |
*** mragupat has quit IRC | 20:57 | |
*** mragupat has joined #murano | 20:58 | |
*** mragupat has quit IRC | 20:59 | |
*** mragupat has joined #murano | 21:01 | |
*** kzaitsev_mb has quit IRC | 21:02 | |
*** mragupat has quit IRC | 21:05 | |
*** mragupat has joined #murano | 21:05 | |
*** mragupat has quit IRC | 21:06 | |
*** mragupat has joined #murano | 21:06 | |
*** mragupat has quit IRC | 21:11 | |
*** mragupat has joined #murano | 21:20 | |
*** kzaitsev_mb has joined #murano | 21:29 | |
*** mragupat has quit IRC | 21:30 | |
*** mragupat has joined #murano | 21:30 | |
*** mragupat_ has joined #murano | 21:32 | |
*** mragupat has quit IRC | 21:35 | |
*** stanchan has joined #murano | 22:02 | |
openstackgerrit | Merged openstack/murano-agent: Updated from global requirements https://review.openstack.org/262902 | 22:14 |
*** kzaitsev_mb has quit IRC | 22:24 | |
openstackgerrit | Merged openstack/murano-dashboard: Delete only murano data from image metadata https://review.openstack.org/263719 | 22:40 |
openstackgerrit | Merged openstack/murano: Change LOG.warn to LOG.warning https://review.openstack.org/263007 | 22:40 |
*** mragupat has joined #murano | 22:41 | |
openstackgerrit | Merged openstack/murano: Add mutable default arguments hacking check https://review.openstack.org/262401 | 22:42 |
*** mragupat_ has quit IRC | 22:44 | |
*** mragupat has quit IRC | 23:09 | |
*** sergmelikyan has quit IRC | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!