| openstackgerrit | Stan Lagun proposed openstack/murano: Major refactoring of how OS clients are created and managed https://review.openstack.org/276016 | 00:45 |
|---|---|---|
| *** yamamoto_ has joined #murano | 01:48 | |
| *** katyafervent_awa has quit IRC | 01:50 | |
| *** katyafervent_awa has joined #murano | 01:53 | |
| *** yamamoto_ has quit IRC | 02:07 | |
| *** yamamoto_ has joined #murano | 02:08 | |
| *** yamamoto_ has quit IRC | 02:10 | |
| *** yamamoto_ has joined #murano | 02:10 | |
| *** yamamoto_ has quit IRC | 02:10 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/murano: Updated from global requirements https://review.openstack.org/277235 | 02:39 |
| openstackgerrit | Stan Lagun proposed openstack/murano: Added property to associate environment with OS region https://review.openstack.org/277240 | 02:42 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-muranoclient: Updated from global requirements https://review.openstack.org/277250 | 02:43 |
| *** mragupat has joined #murano | 02:55 | |
| *** yamamoto_ has joined #murano | 02:58 | |
| *** mragupat has quit IRC | 03:09 | |
| *** mragupat has joined #murano | 03:10 | |
| *** Marga__ has quit IRC | 04:19 | |
| *** mragupat has quit IRC | 04:22 | |
| *** x00350071_ has joined #murano | 04:35 | |
| *** ByPasS has quit IRC | 04:35 | |
| *** ByPasS has joined #murano | 04:38 | |
| *** x00350071 has quit IRC | 04:39 | |
| *** ducttape_ has joined #murano | 04:43 | |
| *** kzaitsev_mb has joined #murano | 04:50 | |
| *** gangadhar has joined #murano | 04:53 | |
| *** Marga_ has joined #murano | 04:54 | |
| *** ducttape_ has quit IRC | 05:18 | |
| *** dfflanders has quit IRC | 05:40 | |
| openstackgerrit | Merged openstack/python-muranoclient: Updated from global requirements https://review.openstack.org/277250 | 05:41 |
| openstackgerrit | Merged openstack/murano: Updated from global requirements https://review.openstack.org/277235 | 05:42 |
| *** Marga_ has quit IRC | 06:02 | |
| *** Marga_ has joined #murano | 06:24 | |
| *** kzaitsev_mb has quit IRC | 07:08 | |
| *** vahidh has quit IRC | 07:23 | |
| openstackgerrit | Madhuri Kumari proposed openstack/murano: [WIP] Adding Magnum app to deploy Kubernetes Cluster https://review.openstack.org/269250 | 07:28 |
| *** madhuri_ has joined #murano | 07:30 | |
| madhuri_ | Hi anyone here? | 07:30 |
| *** samuelBartel has joined #murano | 08:13 | |
| ddovbii | madhuri_, yep | 08:24 |
| ddovbii | hi! | 08:24 |
| madhuri_ | ddovbii: Hi | 08:44 |
| openstackgerrit | Hidekazu Nakamura proposed openstack/murano: Fix adding unit test module https://review.openstack.org/277323 | 08:53 |
| *** kzaitsev_mb has joined #murano | 08:55 | |
| ddovbii | madhuri_, may I help you? | 08:57 |
| madhuri_ | Yes ddovbii | 08:59 |
| madhuri_ | ddovbii: https://review.openstack.org/#/c/269250/ | 09:00 |
| madhuri_ | I am getting error with the patch and not sure why is it | 09:00 |
| kzaitsev_mb | what error are you getting? | 09:00 |
| madhuri_ | kzaitsev_mb: http://paste.openstack.org/show/486198/ | 09:01 |
| madhuri_ | Still argument error | 09:01 |
| *** openstackgerrit has quit IRC | 09:02 | |
| kzaitsev_mb | have you restarted the engine since? | 09:02 |
| *** openstackgerrit has joined #murano | 09:02 | |
| madhuri_ | Yes | 09:02 |
| kzaitsev_mb | have you had this error on your 4th patchset? | 09:05 |
| madhuri_ | kzaitsev_mb: Let me check | 09:06 |
| kzaitsev_mb | I wonder if we broke the code at some point or whether it was always this way | 09:06 |
| kzaitsev_mb | I don't rally like the idea of a function with 19 (!!!) arguments | 09:07 |
| kzaitsev_mb | why don't you like stan's suggestion to have 1 dict for params? | 09:07 |
| madhuri_ | kzaitsev_mb: It was failing then also | 09:08 |
| madhuri_ | I also don't like long list of params | 09:08 |
| kzaitsev_mb | well, I pointed you at what's wrong | 09:08 |
| madhuri_ | But **kwargs was not working so I changed it this way | 09:09 |
| kzaitsev_mb | muranopl does not expand **kwargs | 09:09 |
| kzaitsev_mb | just use a single dict | 09:09 |
| kzaitsev_mb | do not expand it to positional kwargs | 09:09 |
| kzaitsev_mb | also | 09:10 |
| madhuri_ | Ok | 09:11 |
| kzaitsev_mb | how did you install the plugin? | 09:11 |
| kzaitsev_mb | pip install -e? | 09:11 |
| kzaitsev_mb | from what I see in the error message — it says: 'Invalid argument tls_disabled' | 09:11 |
| kzaitsev_mb | hm weird. | 09:12 |
| kzaitsev_mb | I thought to advice you to re-install the plugin in your env, but that probably shouldn't help | 09:13 |
| madhuri_ | I installed using python setup.py install | 09:13 |
| kzaitsev_mb | the argument name seems correct | 09:13 |
| kzaitsev_mb | can you try re-installing it? | 09:13 |
| madhuri_ | Yes the patch should work | 09:13 |
| madhuri_ | Yes I can do that | 09:13 |
| madhuri_ | brb | 09:13 |
| madhuri_ | 1. reinstalled | 09:14 |
| kzaitsev_mb | madhuri_: have you re-installed the plugin after you made changes? | 09:14 |
| madhuri_ | 2. murao-engine restarted | 09:14 |
| madhuri_ | Yes | 09:15 |
| madhuri_ | :) | 09:15 |
| ddovbii | madhuri_, why tlsDisabled has a different types in ui and workflow? | 09:15 |
| kzaitsev_mb | right now, or before? =) | 09:15 |
| *** Nikolay_St has joined #murano | 09:15 | |
| madhuri_ | Before also :D | 09:16 |
| kzaitsev_mb | if I were you I'd use 'pip install -e' instead of python setup.py install =) | 09:16 |
| kzaitsev_mb | https://pip.pypa.io/en/stable/reference/pip_wheel/?highlight=#cmdoption-e | 09:16 |
| madhuri_ | :) | 09:16 |
| madhuri_ | I remember also because I had indentation error and it was not installed | 09:16 |
| madhuri_ | Ok I will do that now | 09:16 |
| ddovbii | and the same situation with number of other properties | 09:16 |
| kzaitsev_mb | it would allow you to edit the plugin without re-installing it all the time | 09:17 |
| kzaitsev_mb | so. any lucK with the param? | 09:17 |
| madhuri_ | param I haven't tried now | 09:17 |
| kzaitsev_mb | I mean does it work after reinstalling and all the things you did? | 09:18 |
| madhuri_ | I haven't run it yet | 09:19 |
| madhuri_ | Gimme 2 mins | 09:19 |
| madhuri_ | kzaitsev_mb: my env is broken | 09:21 |
| madhuri_ | I have to rebuild it | 09:21 |
| kzaitsev_mb | sure =) ping me as soon as can test the code =) I can help you refactor it to a single dict, if you like | 09:23 |
| madhuri_ | yes sure kzaitsev_mb | 09:25 |
| madhuri_ | kzaitsev_mb: Thanks it worked | 09:35 |
| madhuri_ | The issue was wrong type | 09:35 |
| madhuri_ | in UI and class | 09:35 |
| madhuri_ | :) | 09:35 |
| ddovbii | and the same situation with number of other properties [1] | 09:36 |
| madhuri_ | ddovbii: public and registry_enabled? | 09:39 |
| ddovbii | yes | 09:40 |
| madhuri_ | Yes done | 09:41 |
| madhuri_ | kzaitsev_mb: There? | 09:43 |
| *** kzaitsev_mb has quit IRC | 09:50 | |
| *** vahidh has joined #murano | 10:00 | |
| *** vahidh has quit IRC | 10:05 | |
| *** kzaitsev_mb has joined #murano | 10:06 | |
| kzaitsev_mb | madhuri_: will be back in 30 mins =) Let's finish off this commit today ;) | 10:13 |
| madhuri_ | yes sure kzaitsev_mb | 10:14 |
| gangadhar | Hi all. Getting below error: | 10:23 |
| gangadhar | [exceptions.IOError]: [Errno 2] No such file or directory: u'/tmp/murano-packages-cache/6893d8e5-29cc-468f-98cb-e6e8a4c75e86/io.murano.apps.docker.kubernetes.KubernetesCluster/Resources/scripts/destinationFile' | 10:23 |
| gangadhar | Here is the engine log: http://paste.openstack.org/show/486266/ | 10:25 |
| gangadhar | Here is the code: http://paste.openstack.org/show/486267/ | 10:30 |
| gangadhar | ddovbii slagun ^^ | 10:31 |
| slagun | gangadhar: hi! | 10:31 |
| slagun | can you show PutFile.template? | 10:31 |
| slagun | oh, it is in hte same paste | 10:32 |
| slagun | I see | 10:35 |
| slagun | There was a bug fix that was done along the way when we introduced Linux.yaml | 10:36 |
| slagun | https://review.openstack.org/#/c/213708/ | 10:36 |
| slagun | https://review.openstack.org/#/c/213708/17/murano/engine/system/agent.py | 10:36 |
| slagun | it should have been backported | 10:36 |
| slagun | but seems that it's not | 10:36 |
| gangadhar | Wait. I understand the problem | 10:39 |
| slagun | without this fix the only solution I see is to make $fileContent (that is base64 encoded string) to be a putFile.sh second parameter and to modify the script according to that | 10:39 |
| gangadhar | I was trying write content to file "/etc/autoscale/MuranoAppDevelopment.json". But at that time there is no "/etc/autoscale" directory. | 10:40 |
| *** kzaitsev_mb has quit IRC | 10:41 | |
| gangadhar | slagun: what do you think? | 10:41 |
| slagun | Path /etc/autoscale/MuranoAppDevelopment.json becomes <package_path_in_the_cache>/Resources/etc/autoscale/MuranoAppDevelopment.json | 10:42 |
| slagun | The problem is that you don't have https://review.openstack.org/#/c/213708/17/murano/engine/system/agent.py change | 10:42 |
| slagun | but this not necessary the only problem | 10:43 |
| * slagun afk for 30 min | 10:46 | |
| *** x00350071_ has quit IRC | 10:48 | |
| *** x00350071 has joined #murano | 10:49 | |
| openstackgerrit | Nikolay Starodubtsev proposed openstack/murano-specs: MuranoPL metadata https://review.openstack.org/270124 | 11:12 |
| madhuri_ | kzaitsev_ws: ping | 11:16 |
| *** yamamoto_ has quit IRC | 11:27 | |
| *** kzaitsev_mb has joined #murano | 11:38 | |
| *** kzaitsev_mb has quit IRC | 11:43 | |
| *** vgridnev has joined #murano | 11:55 | |
| madhuri_ | kzaitsev_mb I will leave now. Thanks | 11:56 |
| *** madhuri_ has quit IRC | 11:56 | |
| *** kzaitsev_mb has joined #murano | 12:00 | |
| *** enthurohini has joined #murano | 12:00 | |
| *** tlashchova has quit IRC | 12:06 | |
| *** vgridnev has quit IRC | 12:07 | |
| *** tlashchova has joined #murano | 12:08 | |
| *** vgridnev has joined #murano | 12:13 | |
| kzaitsev_mb | dang =) madhuri is not around anymore | 12:15 |
| kzaitsev_mb | should've asked for permission to alter her commit =) | 12:15 |
| gangadhar | slagun: I have tried what you have said. But only a piece of text is copying to file not the whole text. | 12:15 |
| gangadhar | Here the code I have tried: http://paste.openstack.org/show/486273/ . Am I missing anything? | 12:16 |
| gangadhar | "piece of text" means only the last word is copying to file | 12:18 |
| *** yamamoto has joined #murano | 12:21 | |
| openstackgerrit | Stan Lagun proposed openstack/python-muranoclient: Fixes TypeError in Client constructor https://review.openstack.org/277358 | 12:23 |
| openstackgerrit | Stan Lagun proposed openstack/python-muranoclient: Fixes incorrect endpoint_override handling https://review.openstack.org/277361 | 12:33 |
| *** krotscheck_dcm is now known as krotscheck | 12:39 | |
| *** yamamoto has quit IRC | 12:42 | |
| *** vahidh has joined #murano | 12:43 | |
| *** yamamoto has joined #murano | 12:43 | |
| *** sergmelikyan has joined #murano | 12:47 | |
| *** vahidh has quit IRC | 12:47 | |
| *** yamamoto has quit IRC | 12:48 | |
| enthurohini | kzaitsev_mb, there? | 12:50 |
| kzaitsev_mb | hi! =) | 12:50 |
| enthurohini | hi, did you go through the patch? | 12:50 |
| kzaitsev_mb | have been planning on looking through your code — would start doing it in 5-10 minutes ) | 12:50 |
| kzaitsev_mb | not yet ) | 12:50 |
| enthurohini | ok, let me know when you will done. i found one more thing that to debug command i can use --debug option | 12:51 |
| openstackgerrit | Stan Lagun proposed openstack/python-muranoclient: Adds region parameter to environment-create https://review.openstack.org/277370 | 12:52 |
| kzaitsev_mb | =) | 12:52 |
| kzaitsev_mb | you do | 12:52 |
| enthurohini | i got to know before 15 to 20 min, so using now :P | 12:54 |
| *** yamamoto has joined #murano | 12:58 | |
| kzaitsev_mb | enthurohini: k. looking at your code ) | 13:03 |
| enthurohini | kzaitsev_mb, "$ openstack environment list [--all-tenants]" command is working properly only along with test case | 13:04 |
| *** krotscheck has quit IRC | 13:06 | |
| enthurohini | kzaitsev_mb, command "$ openstack environment show <id>" is getting correct data but formatting is inproper. Also this command is not working when env name is given as positional arg. | 13:06 |
| *** ducttape_ has joined #murano | 13:13 | |
| kzaitsev_mb | enthurohini: not so fast =) I have old config, so I had to update keystone services for your code to work properly ) | 13:15 |
| enthurohini | ok. np | 13:16 |
| kzaitsev_mb | dang. I can't set murano-api url with your code =( | 13:18 |
| *** krotscheck has joined #murano | 13:18 | |
| kzaitsev_mb | meaning I'll have to use the one from keystone =/ | 13:18 |
| kzaitsev_mb | wonder if it would be OK osc-wise to override it ) | 13:19 |
| enthurohini | opps but i cant understand you fully, cz i didnt do such kind of thing | 13:20 |
| kzaitsev_mb | no worries =) just thinking out loud ) | 13:22 |
| enthurohini | at my end keystone authentication is working properly | 13:23 |
| openstackgerrit | Stan Lagun proposed openstack/python-muranoclient: Adds region parameter to environment-create https://review.openstack.org/277370 | 13:24 |
| openstackgerrit | Nikolay Starodubtsev proposed openstack/murano-specs: MuranoPL metadata https://review.openstack.org/270124 | 13:24 |
| kzaitsev_mb | enthurohini: ok. so environment list works pretty nice for me | 13:24 |
| enthurohini | yeah, for me too | 13:24 |
| kzaitsev_mb | cool, so what's the problem? =) | 13:25 |
| enthurohini | issue the second command | 13:25 |
| kzaitsev_mb | I' think there's only one thing I do not like — it doesn't print anything if there are no environments | 13:25 |
| enthurohini | kzaitsev_mb, command "$ openstack environment show <id>" is getting correct data but formatting is inproper. Also this command is not working when env name is given as positional arg. | 13:25 |
| kzaitsev_mb | should probably print a | 13:26 |
| kzaitsev_mb | an empty table | 13:26 |
| kzaitsev_mb | why is it improper? | 13:26 |
| enthurohini | kzaitsev_mb, ok will take care of your suggestion | 13:26 |
| kzaitsev_mb | enthurohini: try `openstack service list` | 13:27 |
| kzaitsev_mb | then `openstack service show <id> | 13:27 |
| kzaitsev_mb | ;) | 13:27 |
| *** yamamoto has quit IRC | 13:27 | |
| enthurohini | yup done | 13:28 |
| enthurohini | what you want me to notice? | 13:29 |
| *** ducttape_ has quit IRC | 13:29 | |
| kzaitsev_mb | I'd say, that everything I saw thus far works as expected | 13:29 |
| kzaitsev_mb | enthurohini: I do not see where you're having a problem ) | 13:29 |
| kzaitsev_mb | could you please point me — what's the problem ) | 13:29 |
| kzaitsev_mb | is it in the tests? | 13:30 |
| enthurohini | kzaitsev_mb, i am saying that when i issue "$ openstack environment show <id>", it not printing output in proper format, table structure get disturbed. is it happening for you? | 13:30 |
| kzaitsev_mb | enthurohini: no, it's not. | 13:31 |
| enthurohini | really? | 13:31 |
| enthurohini | you mean to say, proper table format is get printed? | 13:31 |
| kzaitsev_mb | https://www.dropbox.com/s/mtjcmk54ejn1c3j/Screenshot%202016-02-08%2016.31.45.png?dl=0 | 13:32 |
| kzaitsev_mb | here's what I get | 13:32 |
| enthurohini | it is proper coz all values are of one line | 13:33 |
| kzaitsev_mb | I see, =) | 13:33 |
| kzaitsev_mb | let me test | 13:33 |
| enthurohini | try to deploy env then it will have long value for services then you will get messy table | 13:34 |
| openstackgerrit | Dmytro Dovbii proposed openstack/murano: [Core-Library] Add ability to boot instance from volume https://review.openstack.org/275221 | 13:36 |
| kzaitsev_mb | enthurohini: ok, now I see | 13:38 |
| kzaitsev_mb | let's take a look at how we solved this for murano CLI | 13:38 |
| enthurohini | yeah, now just compare the output of command murano environment-show | 13:39 |
| enthurohini | ok , | 13:39 |
| kzaitsev_mb | yep, I get what you're having problem with ) | 13:39 |
| enthurohini | great, let me know | 13:39 |
| kzaitsev_mb | enthurohini: 1) I think we're supposed to use https://github.com/openstack/python-openstackclient/blob/258c1102cc6b93a860bcd7cc083d4e14ae0025ce/openstackclient/common/command.py | 13:44 |
| kzaitsev_mb | not cliff directly | 13:44 |
| *** permalac has joined #murano | 13:44 | |
| enthurohini | why so? | 13:46 |
| kzaitsev_mb | enthurohini: imagine that osc adds some fancy print message before each command | 13:46 |
| kzaitsev_mb | if we use those — we do not have to worry | 13:46 |
| kzaitsev_mb | if we do not — we would have to duplicate that code | 13:47 |
| kzaitsev_mb | enthurohini: you would also not need to add that debug messages explicitly ;) | 13:48 |
| kzaitsev_mb | at the very least | 13:48 |
| kzaitsev_mb | and it's genearally better to use abstractions, supplied by the library we use | 13:48 |
| kzaitsev_mb | imaging in a couple of releases — osc migrates away from cliff entirelly. If we inherit from openstackclient.common.command.Show — we have nothing to worry about. Otherwise we might break compatibility with future code | 13:49 |
| enthurohini | ohk, mns i need to replace cliff imports with openstackclient.common.command | 13:51 |
| enthurohini | and kzaitsev_mb, how do you know, osc will migrate? | 13:51 |
| kzaitsev_mb | I don't | 13:52 |
| kzaitsev_mb | I'm just giving you examples of situations, where we would benefit from inheriting from openstackclient.common.command instead of cliff directly | 13:52 |
| enthurohini | ohk, getting it know | 13:52 |
| kzaitsev_mb | yep, this way we will remove direct cliff dependency too | 13:53 |
| kzaitsev_mb | which is kind of good ) | 13:53 |
| enthurohini | yeah :) | 13:53 |
| enthurohini | i think , this will not solve formatting problem. will it? | 13:54 |
| kzaitsev_mb | nah, it' will not | 13:54 |
| enthurohini | i like your suggestion, will remove cliff dependence | 13:56 |
| enthurohini | so, what about the formatting issue? | 13:57 |
| kzaitsev_mb | enthurohini: I have an idea =) | 13:58 |
| *** yamamoto has joined #murano | 13:58 | |
| enthurohini | kzaitsev_mb, i take help from https://github.com/openstack/python-muranoclient/blob/master/muranoclient/v1/shell.py. is it right place? | 13:59 |
| kzaitsev_mb | yeah, it's pretty do-able =) we can do the following: | 13:59 |
| enthurohini | i will like to hear idea | 13:59 |
| kzaitsev_mb | we can change helper methods | 14:01 |
| gangadhar | Thank you slagun. Passing as an argument is working fine. | 14:02 |
| *** gangadhar has quit IRC | 14:02 | |
| kzaitsev_mb | in muranoclient/common/utils.py | 14:02 |
| kzaitsev_mb | we can move most of the logic from print_dict to, for example, format_dict, that would return the formatted string. print_dict would just call format_dict and print the result | 14:03 |
| kzaitsev_mb | enthurohini: then in `take_action` you can basically do https://github.com/openstack/python-muranoclient/blob/03f3df02f25f1e761abbb6d8f485e602d5dda8f2/muranoclient/v1/shell.py#L146-L154 this (just copy these lines, it should be mostly fine) | 14:04 |
| kzaitsev_mb | and replace print_dict with our new format_dict | 14:05 |
| kzaitsev_mb | ahhh | 14:05 |
| kzaitsev_mb | no | 14:05 |
| kzaitsev_mb | it won't work | 14:05 |
| enthurohini | kzitseb_mb, i have tried this approach already | 14:05 |
| enthurohini | i copied the ur suggested lines, but it creates error of circular dependency | 14:06 |
| enthurohini | sorry, circular refferences | 14:07 |
| kzaitsev_mb | you can work around those, by importing something only when you really need it | 14:07 |
| kzaitsev_mb | i.e. inside the function itself | 14:07 |
| enthurohini | kzaitsev_mb, if you will explain the complete flow when we issue openstack environment show <id> command | 14:09 |
| enthurohini | it will give me proper understanding | 14:09 |
| kzaitsev_mb | k. my idea will not work, but the issue is actually really easy to fix | 14:11 |
| enthurohini | and i think circular references creates when again imports the same. nd if it so means that lines are already executing. then why formatting is not happening properly? | 14:12 |
| kzaitsev_mb | enthurohini: just import inside function | 14:12 |
| enthurohini | ok, trying | 14:12 |
| kzaitsev_mb | but printing from `take_action` is not really correct | 14:12 |
| enthurohini | yup, coz take_actions returns data to somewhere else for formatting | 14:15 |
| kzaitsev_mb | ok, I'm not happy with any of the options we have here =/ | 14:15 |
| openstackgerrit | Nikolay Starodubtsev proposed openstack/murano: Enable keystone v3 in DevStack by default https://review.openstack.org/277410 | 14:15 |
| enthurohini | along with column names | 14:15 |
| enthurohini | kzaitsev_mb, there are some other problems too, along with formatting | 14:16 |
| kzaitsev_mb | hah | 14:17 |
| kzaitsev_mb | it's actually easy! | 14:17 |
| enthurohini | :) | 14:17 |
| kzaitsev_mb | is it the 3d time I'm saying this? =) | 14:17 |
| enthurohini | np. i tried too with same confidence | 14:18 |
| enthurohini | kzaitsev_mb, i am not able to understand that why it is happening | 14:20 |
| openstackgerrit | Dmytro Dovbii proposed openstack/murano: [Core-Library] Reset all out properties during releasing https://review.openstack.org/277412 | 14:21 |
| kzaitsev_mb | enthurohini: just 2 lines would solve your problem | 14:24 |
| kzaitsev_mb | 1) from muranoclient.common import utils | 14:24 |
| kzaitsev_mb | 2) data['services'] = utils.json_formatter(data['services']) | 14:24 |
| *** yamamoto has quit IRC | 14:28 | |
| kzaitsev_mb | enthurohini: works fine, not even circular imports there ) | 14:28 |
| kzaitsev_mb | just needed to renamve 1) from muranoclient.common import utils as murano_utils | 14:28 |
| enthurohini | yeah, solved | 14:28 |
| enthurohini | i tried too | 14:29 |
| enthurohini | thanks, kzaitsev_mb | 14:29 |
| enthurohini | kzaitsev_mb, do you know where the control transfers when take_action returns data and column names? | 14:31 |
| enthurohini | kzaitsev_mb, one more thing that api call works fine with enviroment id but not with environment name | 14:35 |
| kzaitsev_mb | nope, I do not actually know that ) | 14:42 |
| kzaitsev_mb | yes, it should be id almost everywhere | 14:42 |
| enthurohini | but murano commands uses name as well as positional argument, and i looked in muranoclient/v1/shells.py it do not do anything extra when env name is passes | 14:47 |
| enthurohini | passed as posituonal arg | 14:48 |
| enthurohini | i think muranoclient/common/http.py is actually responsible for api calls | 14:50 |
| kzaitsev_mb | `@utils.arg("id", metavar="<NAME or ID>",` | 14:51 |
| *** ducttape_ has joined #murano | 14:51 | |
| kzaitsev_mb | `help="Environment ID or name.")` | 14:52 |
| kzaitsev_mb | sorry | 14:53 |
| kzaitsev_mb | I was on a meeting | 14:53 |
| kzaitsev_mb | where and what did you pass? =) | 14:53 |
| enthurohini | yeah, i have done the same | 14:53 |
| enthurohini | look at the get_parser function | 14:54 |
| kzaitsev_mb | I don't get your question | 14:54 |
| enthurohini | ok, let me explain | 14:55 |
| kzaitsev_mb | yep pls do =) | 14:55 |
| enthurohini | kzaitsev_mb, murano environment show command takes either id or name as positional env which is defined at @utils.arg("id", metavar="<NAME or ID>",`. I did the same by in get_parser function (osc has little bit diiferent code to add argument to command) but for me, env name as positional argument is not working. i got http 404 error instead | 14:58 |
| enthurohini | s/positional env/positional arg | 14:58 |
| *** vgridnev has quit IRC | 14:59 | |
| kzaitsev_mb | does it work for murano environment-show? | 14:59 |
| enthurohini | yup | 14:59 |
| enthurohini | murano environment-show <env_name> works fine | 15:02 |
| kzaitsev_mb | https://github.com/openstack/python-muranoclient/blob/master/muranoclient/v1/shell.py#L137-L139 | 15:02 |
| kzaitsev_mb | compare this to your code | 15:03 |
| enthurohini | yeah, in that code args.id can be either env id or env name because murano environment-show <env_name> works fine. my code is also doing same. well i didnt go through the session-id. need to look at that | 15:09 |
| kzaitsev_mb | enthurohini: in your code you call `client.environments.get(` | 15:09 |
| kzaitsev_mb | code in do_environment_show calls `utils.find_resource(` | 15:10 |
| kzaitsev_mb | that's all the difference | 15:10 |
| kzaitsev_mb | `find_resource` 1st tries name, then id. | 15:11 |
| kzaitsev_mb | that's all the difference | 15:11 |
| enthurohini | i did this, 'https://github.com/openstack/python-muranoclient/blob/master/muranoclient/v1/environments.py#L57' :P | 15:12 |
| kzaitsev_mb | enthurohini: did I answer your question? | 15:12 |
| enthurohini | yup, you gave me the current pointer | 15:13 |
| enthurohini | i will try it | 15:14 |
| enthurohini | kzaitsev_mb, i am moving away from keyboard for half hour | 15:15 |
| kzaitsev_mb | sure =) I'm going to have 2-3 more meetings today, so I will not be responsive either =) | 15:15 |
| enthurohini | ohk, then we will talk tomorrow. good night | 15:16 |
| kzaitsev_mb | enthurohini: basically I believe you have everything to move forward and add more commands ) | 15:16 |
| enthurohini | yeah | 15:17 |
| enthurohini | i will do this asap | 15:17 |
| kzaitsev_mb | no real hurry =) it's just that I think — that we've covered almost all the code you have in that commit today =)) | 15:19 |
| enthurohini | yes. :) | 15:19 |
| enthurohini | thankyou so much for your pointres | 15:20 |
| enthurohini | pointers* | 15:20 |
| *** mragupat has joined #murano | 15:21 | |
| *** vgridnev has joined #murano | 15:22 | |
| *** vahidh has joined #murano | 15:25 | |
| openstackgerrit | Nikolay Starodubtsev proposed openstack/murano: Enable keystone v3 in DevStack by default https://review.openstack.org/277410 | 15:25 |
| *** vahidh has quit IRC | 15:29 | |
| *** tlashchova has quit IRC | 15:35 | |
| openstackgerrit | Merged openstack/python-muranoclient: Fixes TypeError in Client constructor https://review.openstack.org/277358 | 15:51 |
| *** vgridnev has quit IRC | 15:59 | |
| *** Nikolay_St has quit IRC | 16:00 | |
| *** vgridnev has joined #murano | 16:03 | |
| *** vahidh has joined #murano | 16:09 | |
| *** vahidh has quit IRC | 16:18 | |
| *** _ducttape_ has joined #murano | 16:19 | |
| *** ducttape_ has quit IRC | 16:21 | |
| *** vgridnev has quit IRC | 16:31 | |
| *** vgridnev has joined #murano | 16:31 | |
| *** vgridnev has quit IRC | 16:31 | |
| *** mragupat has quit IRC | 16:32 | |
| *** mragupat has joined #murano | 16:32 | |
| *** _ducttape_ has quit IRC | 16:40 | |
| *** ducttape_ has joined #murano | 16:41 | |
| *** vahidh has joined #murano | 16:45 | |
| *** kzaitsev_mb has quit IRC | 16:49 | |
| *** mragupat_ has joined #murano | 16:51 | |
| *** mragupat has quit IRC | 16:54 | |
| *** permalac has quit IRC | 17:02 | |
| *** samuelBartel has quit IRC | 17:13 | |
| *** yamamoto has joined #murano | 17:21 | |
| *** yamamoto has quit IRC | 17:22 | |
| *** vgridnev has joined #murano | 17:35 | |
| *** yamamoto has joined #murano | 17:43 | |
| *** kzaitsev_mb has joined #murano | 17:45 | |
| *** kzaitsev_mb has quit IRC | 17:51 | |
| *** jasonsb has quit IRC | 17:58 | |
| *** enthurohini has quit IRC | 17:59 | |
| *** kzaitsev_mb has joined #murano | 18:02 | |
| *** yamamoto has quit IRC | 18:26 | |
| *** sergmelikyan has quit IRC | 18:31 | |
| *** sergmelikyan has joined #murano | 18:33 | |
| *** sergmelikyan has quit IRC | 18:35 | |
| *** sergmelikyan has joined #murano | 18:39 | |
| *** sergmelikyan has quit IRC | 18:55 | |
| *** _ducttape_ has joined #murano | 19:08 | |
| *** ducttape_ has quit IRC | 19:11 | |
| *** sergmelikyan has joined #murano | 19:14 | |
| *** _ducttape_ has quit IRC | 19:22 | |
| *** ducttape_ has joined #murano | 19:22 | |
| *** kzaitsev_mb has quit IRC | 19:50 | |
| *** vgridnev has quit IRC | 20:05 | |
| *** ducttape_ has quit IRC | 20:41 | |
| *** sergmelikyan has quit IRC | 20:44 | |
| *** Nikolay_St has joined #murano | 20:47 | |
| *** ducttape_ has joined #murano | 20:56 | |
| *** kzaitsev_mb has joined #murano | 21:08 | |
| openstackgerrit | Stan Lagun proposed openstack/python-muranoclient: Adds region parameter to environment-create https://review.openstack.org/277370 | 21:20 |
| openstackgerrit | Stan Lagun proposed openstack/murano: Major refactoring of how OS clients are created and managed https://review.openstack.org/276016 | 21:49 |
| openstackgerrit | Stan Lagun proposed openstack/murano: Added property to associate environment with OS region https://review.openstack.org/277240 | 21:49 |
| *** kzaitsev_mb has quit IRC | 21:52 | |
| *** kzaitsev_mb has joined #murano | 21:55 | |
| openstackgerrit | Stan Lagun proposed openstack/murano: Added property to associate environment with OS region https://review.openstack.org/277240 | 22:01 |
| *** vahidh has quit IRC | 22:10 | |
| *** kzaitsev_mb has quit IRC | 22:12 | |
| *** kzaitsev_mb has joined #murano | 22:22 | |
| *** kzaitsev_mb has quit IRC | 22:22 | |
| *** kzaitsev1mb has joined #murano | 22:22 | |
| *** kzaitsev1mb is now known as kzaitsev_mb | 22:24 | |
| *** kzaitsev_mb has quit IRC | 22:29 | |
| *** mragupat_ has quit IRC | 23:02 | |
| *** Marga_ has quit IRC | 23:03 | |
| *** sergmelikyan has joined #murano | 23:38 | |
| *** Marga_ has joined #murano | 23:40 | |
| openstackgerrit | Stan Lagun proposed openstack/python-muranoclient: Adds region parameter to environment-create https://review.openstack.org/277370 | 23:40 |
| *** sergmelikyan has quit IRC | 23:42 | |
| *** ducttape_ has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
