hubbot | FAILING CHECK JOBS on stable/ocata: gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/564291, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-scenario003-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci- (2 more messages) | 00:07 |
---|---|---|
*** tosky has quit IRC | 00:08 | |
*** yolanda_ has joined #oooq | 00:13 | |
*** yolanda has quit IRC | 00:16 | |
*** jaganathan has joined #oooq | 00:25 | |
hubbot | FAILING CHECK JOBS on stable/ocata: gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/564291, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-scenario003-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci- (2 more messages) | 02:07 |
*** gkadam has joined #oooq | 02:47 | |
*** pliu_ has joined #oooq | 03:07 | |
*** sanjay__u has joined #oooq | 03:13 | |
*** saneax-_-|AFK is now known as saneax | 03:21 | |
*** JohnGalt26000M47 has joined #oooq | 03:39 | |
*** JohnGalt26000M47 has quit IRC | 03:40 | |
*** agopi has joined #oooq | 03:41 | |
*** udesale has joined #oooq | 03:55 | |
hubbot | FAILING CHECK JOBS on stable/ocata: gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/564291, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata-branch, (2 more messages) | 04:07 |
*** gkadam has quit IRC | 04:20 | |
*** gkadam has joined #oooq | 04:20 | |
*** ykarel|away has joined #oooq | 04:31 | |
*** ykarel|away is now known as ykarel | 04:31 | |
*** pgadiya has joined #oooq | 04:32 | |
*** pgadiya has quit IRC | 04:32 | |
*** pliu_ has quit IRC | 05:26 | |
*** anande has joined #oooq | 05:29 | |
*** quiquell|off is now known as quiquell | 05:31 | |
*** pliu_ has joined #oooq | 05:33 | |
*** jfrancoa has joined #oooq | 05:34 | |
*** marios has joined #oooq | 05:39 | |
*** anande has quit IRC | 05:48 | |
*** ratailor has joined #oooq | 06:04 | |
hubbot | FAILING CHECK JOBS on stable/ocata: gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/564291, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata-branch, (2 more messages) | 06:07 |
*** agopi has quit IRC | 06:10 | |
*** agopi has joined #oooq | 06:15 | |
*** agopi has quit IRC | 06:24 | |
*** links has joined #oooq | 06:31 | |
ykarel | quiquell, hi | 06:31 |
quiquell | Hi ykarel | 06:31 |
ykarel | quiquell, do you know how to hold vms | 06:32 |
ykarel | i mean vms in ci job | 06:32 |
quiquell | You mean puse them ? | 06:32 |
quiquell | Or shelve them | 06:32 |
quiquell | What do you want to do ? | 06:32 |
ykarel | quiquell, so vms get destroyed once job finishes, i want to keep them to debug | 06:32 |
quiquell | You can try shelve | 06:33 |
quiquell | It generates a snapshot and do a stop | 06:33 |
quiquell | I don't know if th snapshot get destroy when the image vm get destroy | 06:33 |
ykarel | Ok, afaik there is a better method | 06:34 |
quiquell | ykarel: I have only using manually at my stuff | 06:34 |
ykarel | ack | 06:35 |
ykarel | let's wait for amoralej|off then | 06:35 |
quiquell | ykarel: You can manually shutdown and download the image too | 06:35 |
quiquell | with manually I mean in the script | 06:36 |
*** holser__ has joined #oooq | 06:36 | |
ykarel | anyway i don't have access to ci tenant | 06:38 |
quiquell | ykarel: I have, what do you need ? | 06:38 |
*** gkadam has quit IRC | 06:39 | |
ykarel | quiquell, i need to hold upstream-centos-7-rdo-cloud-tripleo-168566 and upstream-centos-7-rdo-cloud-tripleo-168099 | 06:39 |
ykarel | amoralej|off, ^^ when you are back | 06:39 |
quiquell | Let me check | 06:39 |
ykarel | jobs are currently running so don't do an operation which can affect it | 06:40 |
*** anande has joined #oooq | 06:41 | |
quiquell | openstack-nodepool will be the one having them | 06:41 |
quiquell | ok got them | 06:42 |
quiquell | | af9cbdb8-58b6-4287-90c2-9dd2607c56bd | upstream-centos-7-rdo-cloud-tripleo-168566 | ACTIVE | provision-7780=192.0.2.4; public-7780=10.0.0.11; private=192.168.102.168, 38.145.32.240 | template-upstream-centos-7-1525947227 | ci.m1.nodepool | | 06:42 |
quiquell | You need to download the image of it ? | 06:43 |
ykarel | quiquell, downloading it currently will not work for me | 06:43 |
quiquell | What do you need ? | 06:43 |
ykarel | https://review.rdoproject.org/jenkins/job/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-queens-upload/201/consoleText | 06:44 |
ykarel | these jobs are failing at TASK [modify-image : Run virt-customize on the provided image] | 06:44 |
ykarel | and i need .__repo_setup.sh.log file | 06:45 |
quiquell | It's not saved after finish ? | 06:45 |
ykarel | which is not available due to https://review.rdoproject.org/r/#/c/13401/ | 06:45 |
quiquell | Ahh | 06:46 |
quiquell | ok | 06:46 |
ykarel | see my comment ^^ | 06:46 |
ykarel | so if we can hold vm, we can check that log file and debug | 06:46 |
quiquell | ykarel: If we have the .pem file we can ssh it | 06:47 |
quiquell | Or if user:password is allow | 06:47 |
ykarel | yup, do you have priv key | 06:47 |
quiquell | This image is the undercloud ? | 06:47 |
ykarel | yes | 06:47 |
quiquell | Let me check if I have the .pem for nodepool instances | 06:48 |
ykarel | ack | 06:48 |
*** anande has quit IRC | 06:53 | |
quiquell | ykarel: Have to leave know, let me check later on | 06:56 |
*** quiquell is now known as quiquell|afk | 06:56 | |
ykarel | quiquell|afk, ack | 06:57 |
*** kopecmartin has joined #oooq | 06:58 | |
*** ccamacho has joined #oooq | 07:00 | |
*** udesale_ has joined #oooq | 07:05 | |
*** udesale has quit IRC | 07:08 | |
*** dmellado has quit IRC | 07:09 | |
*** dmellado has joined #oooq | 07:10 | |
*** skramaja has joined #oooq | 07:12 | |
*** skramaja has quit IRC | 07:14 | |
*** bogdando has joined #oooq | 07:15 | |
*** arxcruz|off is now known as arxcruz | 07:18 | |
*** tesseract has joined #oooq | 07:20 | |
*** ykarel is now known as ykarel|afk | 07:22 | |
*** amoralej|off is now known as amoralej | 07:22 | |
amoralej | quiquell|afk, ykarel|afk i thought we fixed the .__repo_setup.sh.log | 07:24 |
amoralej | we are still not getting it into the log server? | 07:24 |
*** pliu_ has quit IRC | 07:24 | |
*** skramaja has joined #oooq | 07:26 | |
*** jtomasek has joined #oooq | 07:30 | |
amoralej | quiquell|afk, ykarel|afk i've put https://review.rdoproject.org/jenkins/job/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-master-upload/223/ on hold | 07:32 |
*** pliu_ has joined #oooq | 07:33 | |
*** dalvarez has quit IRC | 07:36 | |
*** udesale_ has quit IRC | 07:38 | |
*** udesale_ has joined #oooq | 07:39 | |
*** jfrancoa has quit IRC | 07:39 | |
*** jfrancoa has joined #oooq | 07:40 | |
*** amoralej has quit IRC | 07:40 | |
*** ykarel|afk is now known as ykarel | 07:41 | |
*** tosky has joined #oooq | 07:47 | |
*** quiquell|afk is now known as quiquell | 07:47 | |
quiquell | upstream-centos-7-rdo-cloud-tripleo-168566 | 07:49 |
quiquell | arxcruz: Do you know if we have access to the RDO jenkins slaves ? | 07:50 |
quiquell | I have some pem files around but non of it is working | 07:50 |
arxcruz | quiquell: not sure | 07:55 |
arxcruz | quiquell: i think you need to talk with dmanchard if i recall correctly | 07:55 |
*** ykarel is now known as ykarel|lunch | 07:59 | |
panda | jfrancoa: what time is the meeting ? | 08:05 |
jfrancoa | panda: hey, it's a 15:30, are you available? | 08:06 |
hubbot | FAILING CHECK JOBS on stable/ocata: gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/564291, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata-branch, (2 more messages) | 08:07 |
quiquell | panda: Good morning | 08:07 |
jfrancoa | panda: I sent you the invitation to the event | 08:09 |
panda | quiquell: 'morning | 08:11 |
*** amoralej has joined #oooq | 08:12 | |
quiquell | panda: Do you know if we have access to the RDO jenkins slaves ? | 08:15 |
quiquell | I have some pems around but non works | 08:15 |
panda | quiquell: I don't think so, why do you need access to the slaves ? | 08:17 |
quiquell | ykarel|lunch: Need some log file, that are not saved | 08:17 |
quiquell | A problem with this https://review.rdoproject.org/r/#/c/13401/ | 08:18 |
quiquell | Prevent from having | 08:18 |
quiquell | .__repo_setup.sh.log | 08:18 |
panda | ah, again with this | 08:20 |
panda | yeah I see why it's not working | 08:20 |
panda | no, to hae access to the slaves/undercloud you need to ask to put the job on hold, then ask to put a key there for you | 08:22 |
panda | but if the script is run with -e I need a ugly hack somewhere | 08:23 |
quiquell | panda: Ok, it's already on hold, ykarel|lunch will ask for it's key to be injected | 08:24 |
panda | hm let's see if I can access there in some way | 08:24 |
quiquell | f | 08:24 |
panda | f ? | 08:24 |
panda | 1111 ? | 08:24 |
panda | 15 ? | 08:24 |
quiquell | there is on 0x | 08:25 |
panda | pythonists don't need no 0x | 08:25 |
*** lucas-afk is now known as lucasagomes | 08:25 | |
panda | ... | 08:26 |
panda | ok they need it | 08:26 |
panda | ugh 458 instances on the tenant | 08:29 |
panda | we need to launch the cleanup script | 08:30 |
panda | quiquell: what's the ip of the undercloud to access ? | 08:30 |
*** ykarel|lunch is now known as ykarel | 08:30 | |
*** gkadam has joined #oooq | 08:30 | |
ykarel | amoralej, yup it was not fixed completely | 08:30 |
panda | ykarel: after you finish with the node, we need to launch the cleanup script | 08:31 |
quiquell | panda: 38.145.32.240 | 08:31 |
ykarel | panda, ack | 08:31 |
panda | amoralej: ykarel yes, if we launch the previous script with -e it stops everything else to be run, and the copy is skipped | 08:31 |
ykarel | amoralej, have you looked to the isue? | 08:31 |
ykarel | panda, ack, it should be handled somehow | 08:32 |
ykarel | to avoid holding a node | 08:32 |
panda | there is not clean way to copy this file, we need hacks | 08:32 |
ykarel | as we are blank without the logs | 08:32 |
ykarel | panda, go on with the hacks :) | 08:32 |
panda | I hate hacks | 08:32 |
panda | hacks are offsprings of bad design | 08:33 |
panda | and they are like gremlins in the water | 08:33 |
ykarel | hmm, then we need to consider design again | 08:33 |
panda | you create one, 4 other are already in queue | 08:33 |
panda | hacks are diseases | 08:33 |
panda | hacks are the plague of humanity | 08:33 |
ykarel | correct | 08:34 |
* panda dress as prophet for today | 08:34 | |
panda | no, undercloud nodes don't have the same keypair associated as the other nodes | 08:40 |
panda | they don't have any keipar associated | 08:40 |
panda | not sure if that is wanted | 08:41 |
amoralej | ykarel, panda http://paste.openstack.org/show/720807/ | 08:47 |
amoralej | we need to remove the hack for the supermin kernel | 08:48 |
amoralej | yo hoy he borrado un nodo que puse ayer on hold | 08:48 |
amoralej | con nodepool | 08:48 |
amoralej | es todo lo que he hecho | 08:48 |
ykarel | Ok, we can override the kernel for now | 08:49 |
amoralej | ^ wrong channel | 08:53 |
arxcruz | amoralej: no te preocupa yo conpreendo | 09:04 |
*** openstack has joined #oooq | 09:25 | |
amoralej | arxcruz, :) | 09:34 |
amoralej | ykarel, panda https://review.rdoproject.org/r/#/c/13737 worked in my test in the holded node | 09:34 |
*** zoli is now known as zoli|lunch | 09:34 | |
*** dsneddon_ has quit IRC | 09:35 | |
ykarel | amoralej, nice. amoralej is there a way to run only the failed jobs | 09:35 |
amoralej | no | 09:35 |
ykarel | ahh, so need to run all jobs then, | 09:36 |
ykarel | anyway we only need 002 to pass this time | 09:38 |
amoralej | ykarel, falures in fs019 and 027 are known? | 09:43 |
ykarel | amoralej, network issue | 09:43 |
ykarel | 1 failed with docker inspect and other mirror.rdocloud | 09:44 |
amoralej | ok | 09:45 |
amoralej | so, ykarel let's get https://review.rdoproject.org/r/#/c/13737/ merged first | 09:45 |
amoralej | then abort current jobs | 09:45 |
amoralej | and reschedule | 09:45 |
ykarel | yup | 09:45 |
hubbot | FAILING CHECK JOBS on stable/ocata: gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/564291, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-scenario003-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci- (2 more messages) | 10:07 |
*** pliu_ has quit IRC | 10:24 | |
*** dtantsur|afk is now known as dtantsur | 10:28 | |
*** saneax is now known as saneax-_-|AFK | 10:39 | |
*** zoli|lunch is now known as zoli | 11:00 | |
quiquell | panda: How strict are we with pep8 ? | 11:00 |
panda | quiquell: very | 11:03 |
quiquell | Do we use tools like yapf ? | 11:03 |
quiquell | To autoformat ? | 11:03 |
panda | quiquell: never heard of it, I sometimes used autopep8 | 11:03 |
quiquell | https://github.com/google/yapf#usage | 11:04 |
panda | quiquell: but pep8 is hard requirement for all projects uptream | 11:04 |
quiquell | Ok, that's cool | 11:04 |
*** panda is now known as panda|lunch | 11:09 | |
*** ratailor has quit IRC | 11:13 | |
*** lucasagomes is now known as lucas-hungry | 11:13 | |
*** agopi has joined #oooq | 11:22 | |
*** gkadam_ has joined #oooq | 12:03 | |
*** gkadam has quit IRC | 12:04 | |
hubbot | FAILING CHECK JOBS on stable/ocata: gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/564291, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-scenario003-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci- (2 more messages) | 12:07 |
*** lucas-hungry is now known as lucasagomes | 12:09 | |
*** trown|outtypewww is now known as trown | 12:09 | |
*** agopi has quit IRC | 12:15 | |
*** agopi has joined #oooq | 12:15 | |
*** dtantsur is now known as dtantsur|brb | 12:17 | |
*** panda|lunch is now known as panda | 12:20 | |
*** agopi has quit IRC | 12:25 | |
weshay | myoung|ruck, hey.. I'm in some mtgs this morning.. please focus on the image upload issue | 12:28 |
weshay | panda, will need ur help today | 12:28 |
weshay | re: the promotion server | 12:28 |
weshay | amoralej, ykarel thanks for poking at the jobs | 12:28 |
weshay | amoralej, can you get us on the image server? | 12:29 |
panda | weshay: what do you need ? | 12:30 |
weshay | panda, so.. just a few minutes on tmate I suspect.. myself and others were unable to ssh to the promotion server | 12:31 |
panda | weshay: added your key now | 12:34 |
*** rlandy has joined #oooq | 12:35 | |
*** saneax-_-|AFK is now known as saneax | 12:37 | |
*** amoralej is now known as amoralej|lunch | 12:44 | |
rlandy | quiquell: hello - thanks for your comments re: tox ... | 12:48 |
rlandy | do you know how to kick tox tests in zuul outside of the jobs listed here: https://docs.openstack.org/infra/openstack-zuul-jobs/jobs.html#job-openstack-tox | 12:48 |
rlandy | I managed to get the tests to kick with zuul using the functional naming | 12:49 |
rlandy | openstack-tox directly did not work for me | 12:49 |
rlandy | trown: ^^ do you know how to kick custom-named tests in tox? | 12:50 |
rlandy | also, I am going to limit the files that trigger the jobs to run | 12:50 |
trown | rlandy: hmm no... maybe py27 makes more sense though? | 12:53 |
trown | rlandy: py27 (and py35) are the typical unittest tox envs | 12:54 |
rlandy | trown: that's fine - not really more descriptive | 12:54 |
rlandy | can I make that switch | 12:54 |
rlandy | trown: wrt https://review.openstack.org/#/c/567060/, I removed any calls to tests in the patch - so it's just the dryrun option to be kick manually and creating the files to logs variables, release script output and playbook args. I am removing my w-1 and WIP as I think it we can review this on its own merit - unless you have any objections | 12:57 |
rlandy | I'll looking into the custom tox names more | 13:00 |
trown | rlandy: nope sounds good, I will re-review a bit later | 13:00 |
rlandy | cool - thanks | 13:00 |
trown | rlandy: why do we want a custom name? | 13:00 |
rlandy | trown: so it's unique to the script tests | 13:00 |
trown | custom name = custom job (to do the same thing as other projects unittest jobs) | 13:00 |
rlandy | iiuc, calling py27 and py35 kicks the tests that are listed under those testenvs | 13:01 |
trown | rlandy: I dont think we want that tbh... I think we just want to use the same format as other openstack projects | 13:01 |
trown | rlandy: it does... but we dont have any unittests in tripleo-ci repo currently, so we are free to take it | 13:01 |
panda | they also have openstack-tox-linters | 13:01 |
trown | panda: ya this isnt a linter though | 13:01 |
rlandy | that is a different matter | 13:02 |
trown | it is python unittests | 13:02 |
rlandy | I can add the linter in a separate review | 13:02 |
trown | which are run via `tox -e py27` or `tox -e py35` in every other openstack project | 13:02 |
rlandy | correct | 13:02 |
trown | so we shouldnt diverge without a really good reason | 13:02 |
panda | https://docs.openstack.org/infra/openstack-zuul-jobs/jobs.html | 13:03 |
trown | because that means we have to maintain our own job for it | 13:03 |
rlandy | when I did some testing though - w/o any tests listed in testenv:py27, I got no tests running | 13:03 |
rlandy | but I will out back that change to discuss | 13:03 |
*** saneax is now known as saneax-_-|AFK | 13:03 | |
trown | rlandy: right you would have to change the testenv where we run pytest to "testenv:py27" | 13:03 |
rlandy | yep | 13:03 |
trown | rlandy: what im saying is that there is not currently any "testenv:py27" so we are free to take it | 13:04 |
*** atoth_ has quit IRC | 13:04 | |
rlandy | ok - it's ours | 13:04 |
*** atoth has joined #oooq | 13:04 | |
rlandy | makes it easier | 13:05 |
rlandy | we want 27 and 35? | 13:05 |
rlandy | panda: pls see comments above re: https://review.openstack.org/#/c/567060/ - it's just the standalone code for dryrun so I removed my WIP - I think we can review this independently now | 13:07 |
* rlandy fixes tox patch | 13:07 | |
panda | rlandy: ok | 13:08 |
panda | rlandy: and you want to create a differnt one to add the linters env ? | 13:08 |
trown | rlandy: ya we should make py35 tests too ... no reason to be writing python code that cant run on python3 at this stage | 13:10 |
*** openstackstatus has joined #oooq | 13:10 | |
trown | panda: what kind of linters env? pep8? | 13:11 |
trown | panda: that exists... but actually fails in the testenv broker code... easy fix though | 13:11 |
panda | trown: I don't think we have decided, I was thinking pylint too, but we have to configure it to not annoy us too much | 13:12 |
rlandy | easy enough to add the call to the linters test | 13:12 |
panda | trown: does the script invocation looks anything like this ? https://review.openstack.org/#/c/566565/5/toci_gate_test-oooq.sh@125 | 13:12 |
rlandy | but we had not addressed the linter card yet | 13:12 |
*** Goneri has joined #oooq | 13:12 | |
panda | trown: sorry https://review.openstack.org/#/c/566565/5/toci_gate_test-oooq.sh@220 | 13:12 |
rlandy | panda: either way, we are not merging the tox review until the test pass so we can add to it any time | 13:14 |
-openstackstatus- NOTICE: Due to a Zuul outage, patches uploaded to Gerrit between 09:00UTC and 12:50UTC, were not properly added to Zuul. Please recheck any patches during this window and apologies for the inconvenience. | 13:14 | |
panda | ouch | 13:14 |
trown | panda: seems reasonable | 13:15 |
trown | quiquell: for https://review.openstack.org/567521 seems like we are just missing 2 things now: 1. actual parsing of featureset file and 2. command line args handling ... Do you mind if I go after those today? | 13:20 |
trown | quiquell: and do you agree that is all we have left? | 13:20 |
quiquell | trown: mtg give a minute | 13:22 |
trown | quiquell: sure no worries | 13:23 |
myoung|ruck | panda: could you please add my key to the promoter server? | 13:25 |
panda | myoung|ruck: no, because I hate you | 13:27 |
panda | (done) | 13:27 |
* myoung|ruck has to wonder WTF he did this week to offend | 13:27 | |
quiquell | trown: I am back, and also merging dlrn hash, go for it. | 13:28 |
quiquell | Add some patchsets there, we can even do a end-to-end test with real fs, but that's not unit test | 13:28 |
myoung|ruck | panda: we have world on fire, going to skip upgrades meeting, cool cool? | 13:29 |
trown | quiquell: ya I was thinking of just mocking a featureset in the same way I did for dlrn_hash patch | 13:29 |
panda | myoung|ruck: sure | 13:30 |
quiquell | mock at file API ? | 13:30 |
quiquell | That will do it | 13:30 |
weshay | panda, trown rlandy anyone want to chat w/ the ugprade folks? | 13:33 |
trown | i can | 13:34 |
rlandy | can join | 13:34 |
panda | rlandy: trown wes forgot to mention that the meeting is now https://redhat.bluejeans.com/5192173135 | 13:43 |
trown | panda: thanks | 13:43 |
panda | well, 15 minutes ago in fact | 13:43 |
*** udesale_ has quit IRC | 13:48 | |
*** amoralej|lunch is now known as amoralej | 13:54 | |
hubbot | FAILING CHECK JOBS on stable/ocata: gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/564291, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-scenario003-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci- (2 more messages) | 14:07 |
weshay | panda, ok.. need you for a minute | 14:17 |
weshay | panda, in blue | 14:18 |
rlandy | quiquell: https://review.openstack.org/#/c/567521/9/scripts/emit_releases_file/pytest.ini wrt coverage report | 14:23 |
rlandy | we are not collecting that | 14:24 |
rlandy | it's being sent to the pytestroordir | 14:24 |
rlandy | root | 14:24 |
quiquell | rlandy: Where do we specify what to collect in zuul ? in the fs ? | 14:24 |
rlandy | quiquell: leaving comments in the review - let's discuss | 14:25 |
quiquell | rlandy: We can forget about coverage, is was just easy to include. | 14:25 |
*** saneax-_-|AFK is now known as saneax | 14:25 | |
rlandy | panda: I will pick up the linter card later today and we can discuss that - pls ping me before you leave | 14:30 |
trown | I really like having coverage report... it is like OCD to get to 100% | 14:31 |
quiquell | trown: Was so easy to include | 14:31 |
trown | quiquell: ya I wonder if we have access to $WORKSPACE var for --rootdir there. | 14:34 |
trown | small things... I am sure we can get the coverage report collected without much work | 14:35 |
quiquell | rlandy: Have you alred do the linter card with the pep8 in tox ? | 14:35 |
quiquell | btw has fix it for the script | 14:35 |
rlandy | quiquell: was about to - I am commenting the unit tests now | 14:36 |
rlandy | we don;t call the linter tests though | 14:36 |
rlandy | need to add that to the jobs | 14:36 |
rlandy | if you have the pep8 fix, I can rebase my change on that | 14:36 |
panda | weshay: https://review.rdoproject.org/r/#/c/13737 | 14:37 |
quiquell | rlandy: but tox is checking pep8 also in other scripts under 'script' directory | 14:41 |
quiquell | maybe we can narrow that | 14:41 |
rlandy | quiquell: we can - considering the naming I am not sure we want to | 14:41 |
quiquell | ok, let's make the thing run over all it can | 14:44 |
*** holser__ has quit IRC | 14:48 | |
*** quiquell is now known as quiquell|off | 14:57 | |
weshay | panda, http://38.145.34.55/master.log | 14:57 |
*** kopecmartin has quit IRC | 15:04 | |
*** ykarel is now known as ykarel|afk | 15:04 | |
panda | myoung|ruck: no devel tool meeting, we're skipping | 15:06 |
myoung|ruck | panda, weshay: we still chatting about devel tools? | 15:07 |
myoung|ruck | k | 15:07 |
myoung|ruck | panda: is this because you hate me? | 15:07 |
myoung|ruck | panda: let me know when you want me to reschedule | 15:08 |
panda | myoung|ruck: yes | 15:08 |
*** jtomasek has quit IRC | 15:09 | |
*** saneax is now known as saneax-_-|AFK | 15:10 | |
*** dtrainor has quit IRC | 15:12 | |
*** dtrainor has joined #oooq | 15:12 | |
weshay | myoung|ruck, can you please write up a lp on the logging issue w/ fs02 and repo setup | 15:12 |
weshay | myoung|ruck, fyi.. this is what fixed that job btw https://review.rdoproject.org/r/#/c/13737/2/ci-scripts/tripleo-upstream/convert-upload-undercloud.sh | 15:13 |
weshay | amoralej++ | 15:13 |
hubbot | weshay: amoralej's karma is now 1 | 15:13 |
weshay | ykarel++ | 15:13 |
weshay | myoung|ruck, we should have sagi look to fix that bug on sunday/monday | 15:13 |
amoralej | we got that promotion, right? | 15:13 |
weshay | amoralej, it's promoting now thanks to you | 15:14 |
weshay | and yatin | 15:14 |
amoralej | glad to help | 15:14 |
* ykarel|afk me too | 15:14 | |
weshay | thanks man :) | 15:14 |
weshay | guys | 15:14 |
* ykarel|afk hoping to see everything green soon | 15:15 | |
myoung|ruck | weshay: ack, was composing the logging issue with fs02 / repo setup https://review.rdoproject.org/etherpad/p/ruckrover-sprint13 with the intent to creat LP...easier to compose details there, and need it in etherpad anyway | 15:17 |
myoung|ruck | weshay: regarding "the plan" (https://review.rdoproject.org/etherpad/p/ruckrover-sprint13 @ L191) is that accurate? | 15:17 |
panda | rlandy: I'm free now, wanted to discuss the linter ? | 15:20 |
rlandy | panda: yep - just picked up the linter card | 15:20 |
rlandy | because I am busy with adding tox tests anyways | 15:20 |
rlandy | I am adding a the pep8 job to tripleo-ci | 15:21 |
rlandy | the rest is open to design | 15:21 |
rlandy | I am making a new dependent patch to work from | 15:21 |
*** holser__ has joined #oooq | 15:21 | |
rlandy | panda: the design come in what we want to check | 15:21 |
panda | rlandy: yes, we can make the linter very annoying or very forgiving. I see already a default job for pylint | 15:22 |
*** holser___ has joined #oooq | 15:22 | |
rlandy | panda: ok - adding pep8 and pylint - let's see what that does | 15:23 |
rlandy | we can review the results and decide | 15:24 |
myoung|ruck | amoralej, ykarel|afk - (curious) how you diagnosed the failure and got to root cause regarding https://review.rdoproject.org/r/#/c/13737/2/ci-scripts/tripleo-upstream/convert-upload-undercloud.sh | 15:24 |
panda | rlandy: yep | 15:24 |
*** links has quit IRC | 15:24 | |
*** holser___ has quit IRC | 15:24 | |
amoralej | myoung|ruck, i put a node on hold | 15:25 |
amoralej | and check the log | 15:25 |
amoralej | but we suspected of it | 15:25 |
rlandy | panda: we also probably want to limit where these linter tests run | 15:25 |
rlandy | scripts dir only? | 15:25 |
amoralej | as it happened right after 7.5 was released | 15:25 |
*** holser__ has quit IRC | 15:26 | |
myoung|ruck | amoralej: ack. is there a process / doc on how to get onto a node to diagnose? last night we ran into "don't have the logs, can't poke the node" | 15:26 |
ykarel|afk | myoung|ruck, some more background https://review.rdoproject.org/r/#/q/status:merged+project:rdo-infra/ci-config+branch:master+topic:bug/1743749 | 15:26 |
myoung|ruck | ykarel|afk, amoralej thx! will read up | 15:27 |
ykarel|afk | i pushed a patch last day also but forgot about kernel override | 15:27 |
panda | rlandy: I think it's better to pull the script review and launch pylint there, it just blocked without even starting, I guess it will need a lot of iterations | 15:27 |
panda | rlandy: also, I think we can narrow it to the scripts/emit_release_file only for now | 15:27 |
myoung|ruck | ykarel|afk, amoralej: ahh I see... | 15:28 |
panda | rlandy: if you make it point to a dir, it will assume it's a python package, and will look for __init__.py | 15:28 |
panda | rlandy: maybe it's easier to copy pylint configuration from another upstream job that already uses it, to start at least | 15:29 |
panda | Global evaluation | 15:30 |
panda | ----------------- | 15:30 |
panda | Your code has been rated at 6.72/10 | 15:30 |
panda | first pass of pylint is not encouraging :) quiquell|off trown ^ | 15:31 |
*** skramaja has quit IRC | 15:33 | |
rlandy | panda: what blocked without starting? | 15:39 |
rlandy | I am narrowing the trigger | 15:40 |
rlandy | pep8 also has a lot of failures | 15:40 |
rlandy | will have to narrow that as well | 15:40 |
*** jfrancoa has quit IRC | 15:40 | |
rlandy | brb | 15:40 |
*** rlandy is now known as rlandy|brb | 15:40 | |
*** ykarel|afk has quit IRC | 15:43 | |
panda | rlandy|brb: I tried to run it pointing it to scrips/emit-release-file/ and it looked for __init__.py, so it didn't start. We have to point it to *.py or it will assume you want to lint a module | 15:44 |
*** dtantsur|brb is now known as dtantsur | 15:49 | |
*** dtantsur is now known as dtantsurrealism | 15:52 | |
*** zoli is now known as zoli|gone | 15:53 | |
*** zoli|gone is now known as zoli | 15:53 | |
*** bogdando has quit IRC | 15:54 | |
panda | rlandy|brb: trown can we merge the tox.ini changes now and eventually merge the jobs later ? we can check code locally and add the job when we're sure it passes. | 15:55 |
trown | panda: rlandy|brb, works for me, just rebase it on master | 15:55 |
trown | panda 6.72 isnt that a solid C? | 15:56 |
trown | seems ok to me :P | 15:56 |
trown | dont know if they used A-F grading where you went to school actually | 15:57 |
panda | trown: oh, I pasted to single file result, sorry | 15:57 |
panda | Your code has been rated at 5.50/10 (previous run: 4.59/10, +0.90) | 15:57 |
panda | trown: this is the result afterf running pylint *.py | 15:57 |
trown | oh... well we are improving at least | 15:57 |
panda | anyway, lot and lot of noise | 15:58 |
trown | 20% improvement there | 15:58 |
trown | :) | 15:58 |
*** rlandy|brb is now known as rlandy | 16:01 | |
rlandy | panda: I though the idea was to merge the tests and leave the tox changes until the tests pass? | 16:02 |
rlandy | right now, if we merge the tox changes - rebased on master, nothing will run | 16:03 |
*** marios has quit IRC | 16:03 | |
panda | rlandy: if you look at the developer workflow, it makes sens to merge the tox.ini changes first. A developer would usually run tox -e in th elocal machine to check for his code, and not be forced to wait the jobs. If we have the tox.ini in place, we can check if the script works immediately, without having to rebase the change and wait for the job to run. | 16:05 |
weshay | panda, hrm.. https://console.registry.rdoproject.org/registry#/images/master/centos-binary-base | 16:07 |
hubbot | FAILING CHECK JOBS on stable/ocata: gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/564291, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-scenario003-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci- (2 more messages) | 16:07 |
* weshay wonders how that was tagged, was that manual? | 16:07 | |
panda | weshay: it's taking ages to open the URL | 16:08 |
weshay | panda, nvrmind that was master, not tripleomaster | 16:09 |
* weshay checking tripleomaster now | 16:09 | |
weshay | it is slow | 16:09 |
weshay | panda, sorry | 16:09 |
weshay | myoung|ruck, the container upload is suspect at this point | 16:09 |
weshay | myoung|ruck, fyi https://console.registry.rdoproject.org/registry#/images/tripleomaster/centos-binary-base:a09f481909fd75d8be4d42ed9f678bf6d1387792_99947e05 | 16:13 |
myoung|ruck | weshay, sshnaidm|off https://bugs.launchpad.net/tripleo/+bug/1770684 featureset002 (container upload promotion job) does not collect virt-customize logs | 16:15 |
openstack | Launchpad bug 1770684 in tripleo "featureset002 (container upload promotion job) does not collect virt-customize logs" [High,Triaged] | 16:15 |
* myoung|ruck looks at container upload | 16:15 | |
weshay | myoung|ruck, did we get a bug on http://logs.openstack.org/80/567580/1/check/tripleo-ci-centos-7-containers-multinode/fb7bc13/ | 16:16 |
myoung|ruck | weshay: that's OC deploy fail due to pacemaker version mismatch : http://logs.openstack.org/80/567580/1/check/tripleo-ci-centos-7-containers-multinode/fb7bc13/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz#_2018-05-11_02_47_34, writing that up now | 16:19 |
weshay | myoung|ruck, k.. no need to go too deep on it | 16:24 |
weshay | hrm.. myoung|ruck so.. this is interesting | 16:25 |
weshay | https://hub.docker.com/r/tripleoupstream/centos-binary-base/tags/ | 16:25 |
weshay | https://console.registry.rdoproject.org/registry#/images/tripleomaster/centos-binary-base:a09f481909fd75d8be4d42ed9f678bf6d1387792_99947e05 | 16:25 |
*** trown is now known as trown|lunch | 16:25 | |
weshay | we are infact building the container centos-base but not uploading it | 16:25 |
weshay | we would not need to run update if we uploaded it | 16:26 |
myoung|ruck | weshay: k, that's on deck i guess. I'm logging a trite LP for the pcs issue | 16:26 |
myoung|ruck | weshay: 1:1 in 5 | 16:26 |
weshay | panda, ugh.. sorry... thinking we could adjust tripleo-common to ensure we upload centos-base on each promotion | 16:27 |
*** lucasagomes is now known as lucas-afk | 16:27 | |
panda | why we need to upload centos-base too ? | 16:29 |
myoung|ruck | weshay: https://bugs.launchpad.net/tripleo/+bug/1770692 needs a better writeup, but it's there for now | 16:34 |
openstack | Launchpad bug 1770692 in tripleo "pacemaker version mismatch (BM vs.container) causing OC deploy failures in gates" [Critical,Triaged] | 16:34 |
myoung|ruck | weshay: inc --> bj | 16:34 |
panda | rlandy: now that I'm looking a bit more at the other projects, practically nothing is testing more than pep8, some add bashate to the pep8 tests, other run also bandit. Only neutron seems to use pylint, calling it in the pep8 tox env, and I'm not even sure they are enabling it. | 16:43 |
rlandy | so tripleo-ci had pep8 tests | 16:44 |
rlandy | so really we are just missing the job to kick that piece | 16:45 |
panda | rlandy: just ran tox -e pep8, got errors in two scripts. One is not used anymore, the other is used for the cistatus site. We can fix one and skip the other, but then the env needs configuration | 16:56 |
rlandy | panda: https://review.openstack.org/567898 | 16:57 |
rlandy | ^^ just the toc and test-requirements changes | 16:57 |
rlandy | separated from zuul changes | 16:58 |
rlandy | if you want to merge those | 16:58 |
rlandy | panda: just because other teams don't use pylink, doen't mean we don't have to | 16:58 |
rlandy | pylint | 16:59 |
*** tesseract has quit IRC | 16:59 | |
*** openstackstatus has quit IRC | 17:00 | |
*** openstack has joined #oooq | 17:01 | |
panda | rlandy: weel, it means two things: 1) project that have almost 100% python codebase don't see much value in running pylint, 2) we don't have many configurations to use as base for our test, only the one from neutron (which passes 10/10 with our broken script) | 17:04 |
*** brault has quit IRC | 17:13 | |
*** panda is now known as panda|off | 17:28 | |
*** dsneddon has joined #oooq | 17:29 | |
*** trown|lunch is now known as trown | 17:39 | |
*** dtantsurrealism is now known as dtantsur|afk | 17:55 | |
hubbot | FAILING CHECK JOBS on stable/queens: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-scenario003-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-queens, gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035-queens, tripleo-ci-centos-7-scenario004 (2 more messages) | 18:07 |
*** jaganathan has quit IRC | 18:22 | |
*** brault has joined #oooq | 18:39 | |
*** brault has quit IRC | 18:45 | |
rlandy | weshay: hi - re: zuul.d/layout.yaml - do I read this correctly, that files includes only the files, that if they change, the job will kick? | 19:19 |
*** holser__ has joined #oooq | 19:23 | |
*** amoralej is now known as amoralej|off | 19:24 | |
*** gkadam_ has quit IRC | 19:28 | |
*** brault has joined #oooq | 19:46 | |
*** brault has quit IRC | 19:54 | |
*** holser__ has quit IRC | 19:59 | |
weshay | rlandy, the one in tripleo-ci? | 20:02 |
rlandy | weshay: I am trying to limit where jobs kick | 20:02 |
weshay | rlandy, ok.. for the unit test job? | 20:03 |
rlandy | I am comparing to https://review.openstack.org/#/c/562353/13/zuul.d/layout.yaml | 20:03 |
rlandy | right but I want similar in https://review.openstack.org/#/c/567649/16/zuul.d/unittest-jobs.yaml | 20:04 |
weshay | rlandy, right.. so yes, thanks for the context | 20:04 |
weshay | yes.. | 20:04 |
rlandy | zuul keeps telling me I get the syntax placing wrong | 20:04 |
weshay | files: | 20:04 |
rlandy | help me out here, please | 20:04 |
weshay | indicates when only those files change.. the job kicks | 20:04 |
* weshay looks | 20:04 | |
rlandy | correct | 20:04 |
rlandy | see the zuul comments | 20:04 |
rlandy | I have tried placing files everywhere - no show | 20:05 |
rlandy | what am I missing? | 20:05 |
* rlandy need to add similar for pep8 and pylint | 20:05 | |
rlandy | working on that now | 20:05 |
weshay | k | 20:05 |
* weshay looking sec | 20:05 | |
rlandy | ty | 20:06 |
hubbot | FAILING CHECK JOBS on stable/ocata: gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/564291, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-scenario003-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci- (2 more messages) | 20:07 |
weshay | rlandy, ok.. remove what you have in layout.yaml | 20:08 |
weshay | and add under templates | 20:08 |
weshay | - tripleo-ci-tox | 20:08 |
weshay | which is defined here https://review.openstack.org/#/c/567649/16/zuul.d/unittest-jobs.yaml | 20:09 |
weshay | line 7 | 20:09 |
rlandy | ok | 20:10 |
rlandy | and put what there? | 20:10 |
weshay | ha ha.. | 20:10 |
weshay | k | 20:10 |
weshay | it's hard to code over irc | 20:10 |
weshay | want to jump on blue? | 20:10 |
rlandy | well, you'll see my attempts in the various patches | 20:11 |
weshay | ya.. the lint is fairly quick | 20:11 |
rlandy | I have put it in templates | 20:11 |
weshay | give me a sec, I'll throw up a patch | 20:11 |
weshay | to a new review | 20:11 |
rlandy | like 13 for example | 20:11 |
weshay | hrm.. trown is in there too :) | 20:12 |
rlandy | ok - let's bj's | 20:13 |
trown | ? | 20:13 |
trown | where am I? | 20:13 |
trown | oh I rebased that patch to put up my arg/yaml parse on top of it | 20:13 |
rlandy | there are really only two plays in play | 20:14 |
trown | this is starting to become a patch maze, but my git-foo is strong | 20:14 |
rlandy | I'm trying to stop the maze | 20:16 |
rlandy | weshay: bj? | 20:16 |
rlandy | and I need to add the linter stuff on top | 20:17 |
weshay | rlandy, not saying I know this to be correct, my guess is https://review.openstack.org/#/c/567937/ | 20:17 |
rlandy | weshay; I had that already | 20:17 |
weshay | ah k | 20:17 |
rlandy | I want to kick per only some files | 20:17 |
rlandy | in your bj | 20:17 |
weshay | rlandy, trown's patch just passed the linter | 20:18 |
weshay | for py27 | 20:18 |
rlandy | which patch are you watching? | 20:18 |
weshay | hrm.. https://review.openstack.org/#/c/567649/16..17/test-requirements.txt | 20:19 |
weshay | but that's all he changed | 20:19 |
trown | I didnt even really change that... just rebased | 20:21 |
myoung|ruck | weshay: fyi...trouble in paradise | 20:43 |
myoung|ruck | May 11 16:11:36 promoter-server.rdocloud dockerd-current[1085]: time="2018-05-11T16:11:36.770508105Z" level=error msg="Attempting next endpoint for pull after error: Get https://trunk.registry.rdoproject.org/v2/tripleomaster/centos-binary-multipathd/manifests/a09f481909fd75d8be4d42ed9f678bf6d1387792_99947e05: Get https://trunk.registry.rdoproject.org/openshift/token?account=unused&scope=repository%3Atripleomaster%2Fcentos-binary-multipathd | 20:43 |
myoung|ruck | %3Apull: net/http: request canceled (Client.Timeout exceeded while awaiting headers)" | 20:43 |
hubbot | myoung|ruck: Error: "3Apull:" is not a valid command. | 20:43 |
myoung|ruck | hubbot: stop being so nosey | 20:43 |
hubbot | myoung|ruck: Error: "stop" is not a valid command. | 20:43 |
trown | have a good weekend folks | 21:00 |
*** trown is now known as trown|outtypewww | 21:00 | |
rlandy | weshay: zuul didn't like that either https://review.openstack.org/#/c/567649/ | 21:15 |
weshay | rlandy, sorry debugging the promote w/ matt | 21:39 |
rlandy | weshay: no worries - will put in the linter patch independently | 21:39 |
rlandy | just wanted to let you know that zuul didn;t like that one either | 21:40 |
*** dsneddon_ has joined #oooq | 21:53 | |
*** rlandy has quit IRC | 22:03 | |
*** strattao has quit IRC | 22:05 | |
*** strattao has joined #oooq | 22:05 | |
hubbot | FAILING CHECK JOBS on stable/ocata: gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/564291, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-scenario003-multinode-oooq-container, tripleo-ci-centos-7-3nodes-multinode, tripleo-ci-centos-7-scenario001-multinode-oooq-container, gate-tripleo-ci- (2 more messages) | 22:07 |
*** tosky has quit IRC | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!