hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-fedora-28-standalone, tripleo-ci-centos-7-scenario003-multinode-oooq-container @ https://review.openstack.org/604298, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-fedora-28-standalone, tripleo-ci-centos-7-scenario003-multinode-oooq-container @ https://review.openstack.org/560445, stable/queens: tripleo-ci-centos-7-scenario008-multinode- (1 more message) | 00:53 |
---|---|---|
*** d0ugal has quit IRC | 02:33 | |
hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-fedora-28-standalone, tripleo-ci-centos-7-scenario003-multinode-oooq-container @ https://review.openstack.org/604298, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-centos-7-scenario003-multinode-oooq-container, tripleo-ci-fedora-28-standalone @ https://review.openstack.org/560445, stable/queens: tripleo-ci-centos-7-scenario008-multinode- (1 more message) | 02:53 |
*** udesale has joined #oooq | 03:13 | |
*** ykarel|away has joined #oooq | 03:40 | |
*** ykarel|away is now known as ykarel | 03:44 | |
*** dtrainor__ has joined #oooq | 04:42 | |
*** dtrainor_ has quit IRC | 04:45 | |
hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/604298, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-fedora-28-standalone @ https://review.openstack.org/560445, stable/queens: tripleo-ci-centos-7-scenario008-multinode-oooq-container, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/567224 | 04:53 |
*** dtrainor__ has quit IRC | 04:57 | |
*** ykarel has quit IRC | 05:07 | |
*** ykarel has joined #oooq | 05:24 | |
*** saneax has joined #oooq | 05:44 | |
*** ratailor has joined #oooq | 05:45 | |
*** dtrainor__ has joined #oooq | 05:58 | |
*** dtrainor__ has quit IRC | 06:11 | |
*** chandankumar has joined #oooq | 06:23 | |
*** chandankumar is now known as chkumar|rover | 06:25 | |
*** chkumar|rover is now known as chkumar|ruck | 06:25 | |
ykarel | chkumar|ruck, hi | 06:29 |
ykarel | chkumar|ruck, i think we can promote rocky: https://trunk-primary.rdoproject.org/api-centos-rocky/api/civotes_detail.html?commit_hash=be2d6da7046fa95876db49ec82c1c652bc3e26ee&distro_hash=9ed865e1f6937967f87b3b09969966f2a50bf1b6 | 06:29 |
ykarel | only fs001,035 failed from promotion criteria | 06:30 |
ykarel | which are ovb and the failure reason for those is already known | 06:31 |
ykarel | sshnaidm, panda|rover ^^ | 06:31 |
ykarel | rocky is +24 days, so good to clear that atleast | 06:32 |
ykarel | and refresh containers/packages for gate | 06:32 |
*** jfrancoa has joined #oooq | 06:35 | |
*** quiquell|off is now known as quiquell | 06:41 | |
hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/604298, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-fedora-28-standalone @ https://review.openstack.org/560445, stable/queens: tripleo-ci-centos-7-scenario008-multinode-oooq-container, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/567224 | 06:53 |
chkumar|ruck | ykarel, hello sir | 07:03 |
ykarel | chkumar|ruck, i have already put my case ^^, it's for ur judgement :) | 07:05 |
chkumar|ruck | ykarel, fs01 can be cleared | 07:05 |
chkumar|ruck | ykarel, but for fs035 it is failing with different issue https://logs.rdoproject.org/openstack-periodic/git.openstack.org/openstack-infra/tripleo-ci/master/periodic-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035-rocky/797d1bd/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz#_2018-11-23_02_18_02 | 07:05 |
chkumar|ruck | ykarel, I think we can do a promotion | 07:06 |
ykarel | yup | 07:06 |
chkumar|ruck | ykarel, do you want to me to skip those jobs? | 07:06 |
chkumar|ruck | ykarel, and rekick the promotion pipeline? | 07:06 |
ykarel | chkumar|ruck, yes i think we should do | 07:06 |
chkumar|ruck | ykarel, I think the same goes for master also | 07:06 |
ykarel | chkumar|ruck, no need to kick promotion pipelline | 07:07 |
ykarel | just need to update promotion criteria | 07:07 |
chkumar|ruck | ykarel, ok | 07:07 |
ykarel | i think first clean rocky | 07:07 |
ykarel | i think master has multiple issues | 07:07 |
chkumar|ruck | ykarel, ok | 07:08 |
ykarel | master jobs: https://trunk-primary.rdoproject.org/api-centos-master-uc/api/civotes_detail.html?commit_hash=618d3ab83cd319e03fac86c1d6de510ef4a5134b&distro_hash=be9e0d5ccc3bd5a194c7b77587223e48b8469219 | 07:08 |
chkumar|ruck | ykarel, sshnaidm panda|rover quiquell https://review.rdoproject.org/r/#/c/17464/ | 07:17 |
*** kopecmartin|off is now known as kopecmartin | 07:17 | |
chkumar|ruck | ykarel, till then let me deal with master | 07:17 |
ykarel | chkumar|ruck, ack | 07:17 |
chkumar|ruck | ykarel, get the above patch merged so that we have a promotion | 07:18 |
ykarel | chkumar|ruck, i have only +1 there | 07:20 |
chkumar|ruck | ykarel, I think quiquell has powers or we can ping number80 | 07:20 |
ykarel | chkumar|ruck, ack | 07:21 |
quiquell | hello | 07:26 |
quiquell | Have powers now | 07:26 |
quiquell | chkumar|ruck, ykarel: Going to also workflow it | 07:28 |
quiquell | ok ? | 07:28 |
chkumar|ruck | quiquell, yes | 07:28 |
chkumar|ruck | quiquell, thanks :-) | 07:28 |
ykarel | yes | 07:28 |
quiquell | ok done | 07:29 |
*** skramaja has joined #oooq | 07:29 | |
*** dtantsur|afk is now known as dtantsur | 07:38 | |
*** quiquell is now known as quiquell|brb | 07:56 | |
*** jtomasek has joined #oooq | 08:04 | |
*** amoralej|off is now known as amoralej | 08:05 | |
chkumar|ruck | marios, quiquell|brb https://review.openstack.org/#/c/619568/ and https://review.openstack.org/619492 simple fixes | 08:06 |
marios | chkumar|ruck: quid pro qo https://review.openstack.org/#/c/616872/ please check :) | 08:08 |
marios | chkumar|ruck: also about https://review.openstack.org/#/c/619568/1 you sure did you ask alex/emilien? i think there was some standalone stuff merged in rocky | 08:09 |
chkumar|ruck | marios, we donot run standalone for rocky | 08:10 |
marios | chkumar|ruck: you mean the job wasn't defined in rocky, i.e. they added in s | 08:11 |
chkumar|ruck | marios, https://review.openstack.org/#/c/618612/ | 08:11 |
chkumar|ruck | marios, the standalone jobs were introduced in stein cycle | 08:11 |
marios | chkumar|ruck: thanks for checking going to revote | 08:12 |
chkumar|ruck | marios, that's why i have also removed yesterday from periodic pipeline | 08:12 |
marios | thanks chkumar|ruck | 08:12 |
chkumar|ruck | marios, https://review.rdoproject.org/r/#/c/17431/ | 08:13 |
marios | please i need reviews here https://review.openstack.org/#/c/616872/ we need this one for scenario1 /4 quiquell|brb panda|rover rfolco ssbarnea|bkp2 | 08:17 |
marios | chkumar|ruck: ^ | 08:17 |
marios | thank you | 08:17 |
*** quiquell|brb is now known as quiquell | 08:17 | |
quiquell | Back | 08:17 |
quiquell | marios: Better to have a role, I think panda|rover is already moving v3 to little roles | 08:20 |
marios | quiquell: it *is* the role... it started out as a role anyway, but on reviews it became 'just dev/loop3 for ceph' in the bootstrap-subnodes | 08:22 |
marios | quiquell: here i'm just moving it to a new file so i can include in a second place | 08:22 |
marios | quiquell: and we need this for scenario1 and 4 jobs | 08:23 |
marios | quiquell: i'm not defining something new, just moving | 08:23 |
marios | quiquell: so would rather merge that now so we can get the 2 jobs please | 08:23 |
quiquell | marios: Well having a role has same difficulty, and run-v3.yaml is going to include little roles in the future | 08:23 |
marios | quiquell: so you changed your mind from what we discussed yesterday? I mean are you going to block this? | 08:24 |
*** ykarel is now known as ykarel|lunch | 08:25 | |
quiquell | marios: Humm quite the opposite, having ceph-loop3 as a role, is going to be easier to reuse directly at standalone deploy | 08:25 |
quiquell | marios: I mean we have tripleo-ci/roles | 08:26 |
quiquell | marios: The change is like moving ceph-loop3-tasks.yaml to tripleo-ci/roles/ceph-loop3/tasks/main.yaml | 08:26 |
quiquell | marios: Also including playbooks at playbooks is not good thing | 08:27 |
marios | quiquell: not including playbooks | 08:27 |
marios | quiquell: include_tasks | 08:27 |
quiquell | marios: Humm ahh they are taskks | 08:27 |
marios | quiquell: we already have those. i don't see why there are dangerous | 08:27 |
marios | quiquell: at least i missed that warning in the docs | 08:27 |
marios | quiquell: but mostly i believe we talked exactly about this and you said you were ok with it | 08:28 |
quiquell | marios: Not dangeris but is not the way to design stuff | 08:28 |
marios | quiquell: on the phone i mean | 08:28 |
quiquell | marios: Humm i though it was going to be a role | 08:29 |
quiquell | If we have stuff run by different playbooks the best way is to have a role | 08:29 |
marios | my argument is that moving it to a role is a fine idea, but it should be a different task than this. it should be its own review | 08:29 |
quiquell | also the interface has to variables, so it's just perfect to define it | 08:29 |
marios | quiquell: man, phone? easier please https://redhat.bluejeans.com/7661925373 | 08:30 |
quiquell | marios: Yes yes | 08:30 |
marios | here i'm not adding something new, we already have those tasks. my review just moves them to new file | 08:30 |
marios | ! | 08:30 |
marios | k joining | 08:30 |
*** holser_ has joined #oooq | 08:33 | |
*** holser_ has quit IRC | 08:33 | |
*** holser_ has joined #oooq | 08:34 | |
chkumar|ruck | marios, this one --- missing https://review.openstack.org/#/c/616872/47/playbooks/tripleo-ci/ceph-loop3-tasks.yaml | 08:39 |
marios | thanks chkumar|ruck gonna update that now | 08:43 |
marios | thanks for checking | 08:43 |
marios | quiquell: thanks for insisting ;) | 08:52 |
marios | quiquell: its nice i like it going to post in a bit | 08:52 |
marios | quiquell: (but would still argue it could come later) ... ;) | 08:53 |
hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/604298, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-fedora-28-standalone @ https://review.openstack.org/560445, stable/queens: tripleo-ci-centos-7-scenario008-multinode-oooq-container, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/567224 | 08:53 |
*** d0ugal has joined #oooq | 08:54 | |
quiquell | marios: Good thing you like it, sorry about my stubborness on that, you know how thinks are here is very difficult to merge stuff, so better to make it good from the beginning | 08:56 |
marios | quiquell: yeah but now i have to get this right, cycle through reviews and merge it before i can consider merging scenario 1 and 4 | 08:57 |
marios | quiquell: and it isn't additive... | 08:58 |
marios | anway | 08:58 |
marios | we had this duscussion (the current version was tested many times already i just moved it to new reveiw to get it merged easier and out the way) | 08:58 |
*** brault has joined #oooq | 08:58 | |
*** ykarel|lunch is now known as ykarel | 09:10 | |
quiquell | marios: Humm you are going to kill me but better use "defaults" than "vars" I think you cannot override the values later on if you put that at vars | 09:13 |
*** tosky has joined #oooq | 09:15 | |
*** bogdando has joined #oooq | 09:28 | |
marios | quiquell: i think its the other way around | 09:40 |
marios | quiquell: i mean https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#variable-precedence-where-should-i-put-a-variable | 09:40 |
marios | so role/vars are much lower precedence than defaults | 09:40 |
marios | quiquell: so i chose role/vars so it is lower priority and they can override it | 09:41 |
marios | defaults is like 2nd highest after cli so we don't want those? | 09:41 |
quiquell | marios: Humm I read this | 09:42 |
quiquell | "If you are writing a redistributable role with reasonable defaults, put those in the roles/x/defaults/main.yml file. This means the role will bring along a default value but ANYTHING in Ansible will override it. See Roles for more info about this:" | 09:42 |
quiquell | And about "vars" | 09:42 |
quiquell | If you are writing a role and want to ensure the value in the role is absolutely used in that role, and is not going to be overridden by inventory, you should put it in roles/x/vars/main.yml like so, and inventory values cannot override it. -e however, still will: | 09:42 |
marios | quiquell: ah it says least to greatest | 09:42 |
marios | quiquell: here i mean https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#variable-precedence-where-should-i-put-a-variable | 09:42 |
quiquell | marios: So looks like if you open the door for override it has to be defaults | 09:43 |
marios | quiquell: i was reading the list the other way around. so role defaults have lower priority ok will change | 09:43 |
marios | quiquell: "Here is the order of precedence from least to greatest (the last listed variables winning prioritization):" | 09:43 |
marios | i thought the one on top was greatest | 09:43 |
marios | quiquell: but this is the kind of thing i was referring to... | 09:44 |
marios | quiquell: this should have come later in its own task | 09:44 |
*** derekh has joined #oooq | 09:44 | |
quiquell | I see as doing it right from the beginning, is not much work | 09:45 |
*** sshnaidm is now known as sshnaidm|off | 09:52 | |
*** holser_ has quit IRC | 09:52 | |
*** holser_ has joined #oooq | 09:52 | |
marios | i'll forgive you if we merge https://review.openstack.org/#/c/616872/50 and https://review.openstack.org/#/c/619468/3 today | 09:53 |
marios | quiquell: ^ | 09:53 |
marios | quiquell: (plus a beer, then we're even) | 09:53 |
*** jfrancoa has quit IRC | 09:55 | |
bogdando | o/ can we merge https://review.openstack.org/#/c/603069 ? | 09:56 |
quiquell | marios: You look bigger than my at bluejeans so you have merge, beear and all my money mate | 09:57 |
quiquell | marios: Next thing is fixing the linting issue, didn't have time with the f28 sh... | 09:58 |
quiquell | marios: I cannot merge my own stuff, can I ? | 09:59 |
marios | quiquell: avoided but not unknown if urgent | 09:59 |
bogdando | and https://review.openstack.org/#/c/610039/ please | 10:01 |
quiquell | marios: Going to workflow this https://review.openstack.org/#/c/619468 | 10:02 |
quiquell | marios: It's really safe, no cat is going to die ? | 10:02 |
quiquell | marios: ok ? | 10:02 |
panda|rover | so it begins | 10:02 |
panda|rover | spreading overrides to the featuresets | 10:03 |
panda|rover | until we strip any meaning from it. | 10:03 |
marios | panda|rover: is this how skynet was born? | 10:05 |
quiquell | skynet overriding humanity | 10:06 |
panda|rover | marios: no but this is how the pitiful humans lost control over it | 10:06 |
panda|rover | wasnt' there any reasonable way to get the same functionality without overriding ? | 10:08 |
*** jfrancoa has joined #oooq | 10:08 | |
panda|rover | ssbarnea|bkp2: I don't thinkg you should rename the topic for the bugs | 10:19 |
panda|rover | ssbarnea|bkp2: it's standard policy to have the bug name in gerrit topic | 10:19 |
panda|rover | ssbarnea|bkp2: can't be sure but it may affect launchpad automatic bug updates | 10:20 |
quiquell | marios going to workflow the container_cli override | 10:22 |
quiquell | ok ?= | 10:22 |
*** chkumar|ruck has quit IRC | 10:22 | |
panda|rover | quiquell: isn't there any other way to accomplish this ? | 10:22 |
panda|rover | overriding featuresets is dangerous, counterintuitive and should be done only in emergency cases | 10:23 |
quiquell | panda|rover: well the container cli is set at the featureset | 10:25 |
quiquell | panda|rover: for standalone without scenarios podman is used | 10:25 |
quiquell | panda|rover: we can create another featureset for scenarios only for that | 10:25 |
quiquell | panda|rover: with all the duplication | 10:26 |
quiquell | panda|rover: other thing we can do is implement a fallback somewhere at THT so for those not supporting podman use docker | 10:27 |
panda|rover | quiquell: doesn't scenario have a featureset on it's own already ? | 10:27 |
quiquell | panda|rover: nope | 10:27 |
quiquell | panda|rover: we are just reusing fs052 and overriding the custom_env option it's Alex design | 10:27 |
panda|rover | whay not ? past jobs had one featureset per scenario | 10:27 |
panda|rover | oh god | 10:27 |
panda|rover | why ? | 10:27 |
quiquell | panda|rover: To reduce diplication | 10:27 |
quiquell | panda|rover: Maintain featurets is costly too | 10:27 |
quiquell | panda|rover: But you where there when Alex told us | 10:28 |
panda|rover | this is absolutely against everything we designed | 10:28 |
panda|rover | I probably did no understand this part | 10:28 |
quiquell | panda|rover: This is a design from the beggining commented in the design week man | 10:28 |
panda|rover | I know, I could not follow the cards there | 10:28 |
panda|rover | damn damn damn damn | 10:29 |
quiquell | panda|rover: anyways, this is how we are doing it, also we are limiting thinks a little at run-v3.yaml | 10:29 |
quiquell | panda|rover: it's dangerous enough already ? | 10:29 |
panda|rover | this is not how featureset works | 10:29 |
panda|rover | I understand. there is no hope to have something working, we are effectively overriding featureset by design | 10:30 |
quiquell | panda|rover: part of it is limited by a list | 10:31 |
panda|rover | we might as well throw the featureset in the thrash | 10:31 |
panda|rover | quiquell: the list will grow | 10:31 |
quiquell | panda|rover: And then we can decide | 10:31 |
panda|rover | quiquell: until everythign will be overridable | 10:31 |
quiquell | panda|rover: It's not like we don't know what is being passed | 10:31 |
panda|rover | we always though "1 job, 1 featureset" | 10:32 |
quiquell | panda|rover: this is not the same like, 1 job one set of vars ? | 10:32 |
panda|rover | quiquell: no, you don't understand, you can't look at a featureset anymore and desume from it wht are you running | 10:32 |
quiquell | panda|rover: now that we can read vars from josb | 10:32 |
panda|rover | you need to follow the logic | 10:32 |
panda|rover | this is what tripleo.sh was doing | 10:33 |
quiquell | panda|rover: humm yep, also you depend on ci to run scenarios for example | 10:33 |
quiquell | panda|rover: they have the proper missing stuff to run them | 10:33 |
panda|rover | until nobody could understand what the hell a job is doing | 10:33 |
quiquell | panda|rover: but we also have the featureset_override feature implemented in previous sprints man | 10:33 |
quiquell | panda|rover: And we where ok with that | 10:33 |
panda|rover | quiquell: it was only for tempest, there was another reason, and we accepted it becaus having it different forced us to restructure our code heavily | 10:34 |
panda|rover | and we didn't have time | 10:34 |
*** chandan_kumar has joined #oooq | 10:35 | |
panda|rover | this sprint was done by design by a person we dosn't know wy it was done on the first place | 10:35 |
quiquell | I see... | 10:35 |
*** chandan_kumar is now known as chkumar|ruck | 10:35 | |
quiquell | Now is a feature from CI :-/ | 10:35 |
quiquell | Thanks for explanation | 10:35 |
quiquell | panda|rover: Another option would be a flag that we understand at featureset | 10:38 |
quiquell | panda|rover: we can also go back to featuresets and re-limit featureset-override | 10:39 |
quiquell | panda|rover: I am we are testing that stuff is working, moving stuff is doable at the end | 10:39 |
quiquell | panda|rover: that would be ok ? | 10:39 |
quiquell | marios: ^ ? | 10:40 |
panda|rover | quiquell: marios sorry for being dense, where is the part that says "use featureset52 and override" in the design card ? | 10:41 |
panda|rover | "make sure services already in standalone are not duplicate like qemu" | 10:42 |
panda|rover | featureset: replace multinode-scenario featuresets | 10:42 |
quiquell | panda|rover: is here https://tree.taiga.io/project/tripleo-ci-board/task/363?kanban-status=1447275 | 10:46 |
quiquell | panda|rover: " Thus instead of reserving and defining a new featureset, copied from fs 052 (standalone) just to override this standalone_custom_env_files we will instead use the featureset_override mechanism." | 10:46 |
panda|rover | oh the design in the task ... ok | 10:48 |
quiquell | panda|rover: Humm you mean the user story | 10:49 |
panda|rover | oh, and then we discovered we cannot reuse past featureset numbers | 10:50 |
panda|rover | because there are projects counting on them still | 10:50 |
quiquell | panda|rover: well we have this at the design "docs.openstack.org/tripleo-quickstart/latest/feature-configuration.html | 10:50 |
quiquell | etherpad" | 10:50 |
panda|rover | I asked in the past to no reuse featureset numbers | 10:50 |
quiquell | panda|rover: ahh nah forget about last line | 10:51 |
panda|rover | and there was a reason for that too | 10:51 |
panda|rover | .... | 10:51 |
hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/604298, master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-fedora-28-standalone @ https://review.openstack.org/560445, stable/queens: tripleo-ci-centos-7-scenario008-multinode-oooq-container, tripleo-ci-centos-7-undercloud-upgrades @ https://review.openstack.org/567224 | 10:53 |
*** udesale has quit IRC | 11:07 | |
*** holser_ is now known as holser|lunch | 11:08 | |
chkumar|ruck | quiquell, Hello | 11:20 |
chkumar|ruck | quiquell, do we have some script in place to compare passed and timedout job? | 11:20 |
quiquell | chkumar|ruck: compare-review.py | 11:21 |
quiquell | chkumar|ruck: will compare stuff at logs.o.o | 11:21 |
chkumar|ruck | quiquell, let me check that | 11:21 |
quiquell | tripleo-ci/scripts/compare-review.py I think | 11:21 |
chkumar|ruck | quiquell, let me try that | 11:23 |
quiquell | you can override the file it compares if you need | 11:23 |
marios | quiquell: panda|rover sorry folks was getting some lunch. perhaps we should have a sync about this in the afternoon? | 11:32 |
marios | quiquell: panda|rover usual scrum time whoever wants? | 11:32 |
quiquell | marios: agree with that | 11:33 |
quiquell | marios: btw looking into linting issue now, I think 1/3/4 will have them too | 11:34 |
marios | quiquell: man how am i still getting this http://logs.openstack.org/08/619508/5/check/tripleo-ci-centos-7-scenario001-standalone/f87e946/logs/undercloud/home/zuul/standalone_deploy.log.txt.gz#_2018-11-23_10_50_52 | 11:34 |
quiquell | Argg you kidding me ? | 11:35 |
marios | quiquell: the rebase/chain lgtm | 11:35 |
marios | quiquell: and 4 http://logs.openstack.org/20/619520/6/check/tripleo-ci-centos-7-scenario004-standalone/c0e97aa/logs/undercloud/home/zuul/standalone_deploy.log.txt.gz#_2018-11-23_10_54_13 | 11:36 |
quiquell | marios: Ahh found it | 11:36 |
quiquell | marios: You have now another -1 :-P | 11:36 |
quiquell | marios: Just joking, check indentation at https://review.openstack.org/#/c/619508 | 11:37 |
* marios rage | 11:37 | |
quiquell | marios: the docker thing is part of featureset_override | 11:37 |
marios | quiquell: but i don't see th eindentaion problem | 11:37 |
* marios squint | 11:37 | |
quiquell | marios: you are the vocabulary guy :-) didn't know about 'squint' that so good for reviews | 11:38 |
marios | quiquell: wait | 11:38 |
marios | quiquell: where is the indentation nit | 11:38 |
quiquell | marios: Now it's under 'vars' not under 'featurest_override' | 11:39 |
rfolco | marios, quiquell scen3 is also only failing lint, please review https://review.openstack.org/#/q/topic:standalone_scen3+(status:open+OR+status:merged) | 11:40 |
marios | quiquell: oh standalone_container_cli is a featureste_override not a variabvle | 11:40 |
quiquell | yep | 11:40 |
marios | quiquell: i guess this is what panda was -1 about | 11:40 |
marios | ok | 11:40 |
marios | thanks | 11:40 |
marios | updating | 11:40 |
quiquell | rfolco: yep we all are going to fail at linting | 11:40 |
quiquell | rfolco, marios: I think ansible has no "pacemaker_resource" module | 11:42 |
quiquell | We are missing something there | 11:42 |
marios | quiquell: pretty sure there is an ansible-pacemaker cos matbu wrote it | 11:43 |
marios | quiquell: we use it in upgrades | 11:44 |
marios | quiquell: but don't nkow about pacemaker_resource where is that from | 11:44 |
marios | (logs? | 11:44 |
quiquell | marios: Maybe it's misspelled let's compare with passing standalone | 11:44 |
rfolco | https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/standalone/tasks/main.yml#L47 | 11:45 |
quiquell | rfolco: Yep, they check they generated stuff | 11:46 |
quiquell | rfolco: But is the first time this is run | 11:46 |
quiquell | rfolco: the issue is ansible running pacemaker_resource | 11:46 |
rfolco | my point is that they knew this happened | 11:46 |
quiquell | rfolco: misspelled or not installed | 11:46 |
rfolco | ok | 11:46 |
quiquell | This is serios stuff more than style | 11:47 |
chkumar|ruck | panda|rover, please have a look at this bug https://bugs.launchpad.net/tripleo/+bug/1804812 | 12:02 |
openstack | Launchpad bug 1804812 in tripleo "[master][noop] multinode container update job failed with RuntimeError: Update failed with: {u'status': u'RUNNING', while overcloud minor update" [Critical,Triaged] | 12:02 |
*** jfrancoa has quit IRC | 12:52 | |
hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/604298, stable/pike: tripleo-ci-centos-7-scenario001-multinode-oooq-container @ https://review.openstack.org/602248, master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/560445, stable/queens: tripleo-ci-centos-7-scenario008-multinode-oooq-container, tripleo-ci-centos-7-undercloud-upgrades @ (1 more message) | 12:54 |
*** jfrancoa has joined #oooq | 13:06 | |
*** skramaja has quit IRC | 13:18 | |
*** ratailor has quit IRC | 13:20 | |
*** holser|lunch is now known as holser_ | 13:31 | |
chkumar|ruck | marios, https://review.openstack.org/#/c/616872/ can we add some readme to the new role | 13:39 |
chkumar|ruck | ? | 13:39 |
marios | chkumar|ruck: yes we can | 13:39 |
marios | chkumar|ruck: sec | 13:39 |
*** quiquell is now known as quiquell|lunch | 13:39 | |
chkumar|ruck | marios, thanks :-) | 13:39 |
marios | chkumar|ruck: but you will have to ask gfidente and quiquell /aka help me sell it after i update your fate is forever bonded to this review now | 13:40 |
* marios stares intensely | 13:40 | |
marios | goes | 13:40 |
chkumar|ruck | marios, may be in a new patchset will also work | 13:40 |
chkumar|ruck | sorry new review | 13:40 |
marios | chkumar|ruck: is fine but lemme check if the last run was good | 13:40 |
marios | rfolco: please revisit your -1 @ https://review.openstack.org/#/c/619508/6 | 13:42 |
marios | rfolco: i replied to your commnt | 13:42 |
quiquell|lunch | marios: Do you see the linting issues now ? | 13:43 |
marios | still running | 13:44 |
marios | http://zuul.openstack.org/stream/25dce6c1615842e688fb21fa5a1d5614?logfile=console.log | 13:44 |
marios | quiquell|lunch: ^ | 13:44 |
quiquell|lunch | ack | 13:44 |
marios | chkumar|ruck: i'll update after it finishes | 13:44 |
*** amoralej is now known as amoralej|lunch | 14:00 | |
*** ykarel is now known as ykarel|away | 14:01 | |
*** quiquell|lunch is now known as quiquell | 14:01 | |
chkumar|ruck | Good night guys, Happy weekend :-) | 14:15 |
*** chkumar|ruck has quit IRC | 14:15 | |
panda|rover | marios: quiquell: do we need to discuss anything in the end ? | 14:15 |
marios | panda|rover: i didn't hear anything but quiquell do you want to talk for a bit? | 14:23 |
marios | panda|rover: sure | 14:23 |
marios | i mean i'm available | 14:23 |
quiquell | I am available too | 14:24 |
*** ykarel|away has quit IRC | 14:25 | |
*** jfrancoa has quit IRC | 14:41 | |
*** saneax has quit IRC | 14:43 | |
*** ratailor has joined #oooq | 14:43 | |
quiquell | panda|rover, marios: I am going to drop, let's talk next week ? | 14:47 |
quiquell | We can still have fs per job if we want | 14:48 |
panda|rover | marios: quiquell nevermind guys, I understand, it's too late, there's nothing we can do, and I give up. Carry on. | 14:48 |
quiquell | We have make good progress this week | 14:48 |
marios | quiquell: ? sorry didn't realise we were on a call. i was waiting for someone to respond. there was no bluejeans posted. .. | 14:48 |
panda|rover | we weren't | 14:48 |
marios | panda|rover: quiquell ack next week works. it wasn't even clear to me as i missed your original discussion here or i was doing something else i mean | 14:48 |
quiquell | marios: just fs per job vs fs override | 14:49 |
marios | quiquell: panda|rover wat no man now? | 14:49 |
marios | i mean sure express your opinion | 14:49 |
marios | but we had this discussion already | 14:49 |
marios | like last week | 14:49 |
marios | panda|rover: please vote on the reviews and we can be specific . lets take it from there | 14:50 |
marios | we can sync next week | 14:50 |
quiquell | marios: did you found something about the linting, didn't have time today | 14:50 |
marios | quiquell: no i didn't get to it i was meant to also check rlandy thing. me env indeed got to toci_gate_test but wanted to revisit/debug and progres.s.. | 14:50 |
marios | i am kinda hoping to do that in the next hour lets see | 14:51 |
marios | ... | 14:51 |
marios | quiquell: rlandy thing i mean reproducer zuul3 | 14:51 |
marios | with rlandy patch | 14:51 |
quiquell | ok no problem I think we have make a very good progress on scenarios this linting thing will be easy | 14:51 |
quiquell | we have success deploys all around | 14:51 |
marios | quiquell: hey man progress this week imo job(s) actually running and now passing deploys | 14:51 |
marios | with ceph | 14:51 |
marios | \o/ | 14:52 |
quiquell | yey let's celebrate this week | 14:52 |
quiquell | I own you a beer | 14:52 |
quiquell | :-) | 14:52 |
quiquell | Are we friends again ? | 14:52 |
*** ykarel|away has joined #oooq | 14:54 | |
hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/604298, stable/pike: tripleo-ci-centos-7-scenario001-multinode-oooq-container @ https://review.openstack.org/602248, master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/560445, stable/queens: tripleo-ci-centos-7-scenario008-multinode-oooq-container, tripleo-ci-centos-7-undercloud-upgrades @ (1 more message) | 14:54 |
marios | quiquell: no | 14:54 |
marios | quiquell: beer first | 14:54 |
*** trown|outtypewww has quit IRC | 14:54 | |
marios | until then | 14:54 |
marios | we cannot | 14:54 |
quiquell | argg island people | 14:54 |
quiquell | is all beer | 14:54 |
marios | lol | 14:54 |
quiquell | Ok guys have a good one | 14:55 |
*** jfrancoa has joined #oooq | 14:55 | |
quiquell | see you next week | 14:55 |
*** quiquell is now known as quiquell|off | 14:55 | |
ykarel|away | cool master too promoted | 14:57 |
ykarel|away | happy Friday :) | 14:57 |
*** trown|brb has joined #oooq | 14:58 | |
panda|rover | WHAT ? | 15:11 |
*** amoralej|lunch is now known as amoralej | 15:11 | |
panda|rover | featureset002 passed introspection ? | 15:11 |
panda|rover | oh my I was prepared to fo manual tricks this night | 15:11 |
panda|rover | ykarel|away: weren't we waiting for a patch in tempest ? | 15:12 |
panda|rover | oh that was for rocky | 15:12 |
ykarel|away | master rocky both promoted | 15:12 |
panda|rover | uhm ... | 15:13 |
panda|rover | that's weird | 15:13 |
ykarel|away | weird, why? | 15:13 |
panda|rover | last sync with chandan said we were wating on some patches | 15:13 |
ykarel|away | today sync? | 15:14 |
panda|rover | and the situation with master was grimm, without fs002 passing | 15:14 |
panda|rover | ykarel|away: a few hours ago sync | 15:14 |
ykarel|away | fs002 passed | 15:15 |
ykarel|away | https://trunk-primary.rdoproject.org/api-centos-master-uc/api/civotes_detail.html?commit_hash=618d3ab83cd319e03fac86c1d6de510ef4a5134b&distro_hash=be9e0d5ccc3bd5a194c7b77587223e48b8469219 | 15:15 |
ykarel|away | master is not consistent so multiple runs with same hash | 15:15 |
ykarel|away | fs002 passed in morning run, and fs001 with chandan's patch | 15:17 |
ykarel|away | DNM patch: https://review.rdoproject.org/r/#/c/17348/ | 15:17 |
ykarel|away | out of dependencies two merged, 1 in gate ^^ | 15:18 |
ykarel|away | panda|rover, there is an issue with -upload job in rocky/master, convert-overcloud-undercloud is failing | 15:19 |
ykarel|away | ERROR! Unexpected Exception, this is probably a bug: No module named tripleo_common | 15:20 |
ykarel|away | https://logs.rdoproject.org/openstack-periodic/git.openstack.org/openstack-infra/tripleo-ci/master/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-master-upload/9d87f18/job-output.txt.gz#_2018-11-23_02_28_15_187877 | 15:20 |
panda|rover | ykarel|away: so I don't understand, what promoted ? | 15:21 |
panda|rover | if fs01 is passing with a patch and fs2 is failing the upload | 15:21 |
ykarel|away | panda|rover, upload passed, just undercloud.qcow2 didn't uploaded due to the issue i mentioned | 15:22 |
ykarel|away | undercloud.qcow2 is created with convert-overcloud playbook | 15:22 |
panda|rover | so upload failed | 15:22 |
panda|rover | no, because we are just blindly syncing everything it's in that directory and not checking if a file is missing | 15:24 |
ykarel|away | yup | 15:25 |
panda|rover | and undercloud.qcow is used only by users, not by I | 15:31 |
panda|rover | CI | 15:31 |
panda|rover | so we don't care enough to block the promotion anyway | 15:32 |
ykarel|away | yup but good to fix that, i not said block promotion promotion | 15:35 |
* ykarel|away out | 15:39 | |
ykarel|away | happy weekend | 15:39 |
*** ykarel|away has quit IRC | 15:43 | |
*** ykarel|away has joined #oooq | 15:45 | |
panda|rover | ykarel|away: back so soon ? | 15:48 |
panda|rover | :) | 15:48 |
*** kopecmartin is now known as kopecmartin|off | 16:01 | |
*** jfrancoa has quit IRC | 16:18 | |
*** ratailor has quit IRC | 16:29 | |
hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/604298, stable/pike: tripleo-ci-centos-7-scenario001-multinode-oooq-container @ https://review.openstack.org/602248, master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/560445, stable/queens: tripleo-ci-centos-7-scenario008-multinode-oooq-container, tripleo-ci-centos-7-undercloud-upgrades @ (1 more message) | 16:54 |
*** holser_ has quit IRC | 17:00 | |
*** bogdando has quit IRC | 17:03 | |
*** dtantsur is now known as dtantsur|afk | 17:07 | |
*** derekh has quit IRC | 18:00 | |
*** ykarel|away has quit IRC | 18:22 | |
*** amoralej is now known as amoralej|off | 18:40 | |
*** d0ugal has quit IRC | 18:41 | |
hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/604298, stable/pike: tripleo-ci-centos-7-scenario001-multinode-oooq-container @ https://review.openstack.org/602248, master: tripleo-ci-fedora-28-standalone @ https://review.openstack.org/560445, stable/queens: tripleo-ci-centos-7-scenario008-multinode-oooq-container, tripleo-ci-centos-7-undercloud-upgrades @ (1 more message) | 18:54 |
*** d0ugal has joined #oooq | 18:58 | |
*** jtomasek has quit IRC | 19:40 | |
*** rfolco has quit IRC | 19:40 | |
*** dtrainor__ has joined #oooq | 20:41 | |
hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-fedora-28-standalone @ https://review.openstack.org/604298, stable/pike: tripleo-ci-centos-7-scenario001-multinode-oooq-container @ https://review.openstack.org/602248, master: tripleo-ci-centos-7-containers-multinode-rocky, tripleo-ci-fedora-28-standalone @ https://review.openstack.org/560445, stable/queens: (1 more message) | 20:54 |
*** holser_ has joined #oooq | 21:12 | |
*** chem` has quit IRC | 21:54 | |
*** holser_ has quit IRC | 22:10 | |
hubbot1 | FAILING CHECK JOBS on master: tripleo-ci-centos-7-scenario002-multinode-oooq-container, tripleo-ci-fedora-28-standalone @ https://review.openstack.org/604298, stable/pike: tripleo-ci-centos-7-scenario001-multinode-oooq-container @ https://review.openstack.org/602248, master: tripleo-ci-centos-7-containers-multinode-rocky, tripleo-ci-fedora-28-standalone @ https://review.openstack.org/560445, stable/queens: (1 more message) | 22:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!