*** jmasud has joined #oooq | 00:11 | |
*** rlandy has quit IRC | 00:21 | |
*** jmasud has quit IRC | 00:27 | |
*** jmasud has joined #oooq | 00:37 | |
*** jmasud has quit IRC | 00:59 | |
*** jmasud has joined #oooq | 01:18 | |
*** jmasud has quit IRC | 01:36 | |
*** jmasud has joined #oooq | 02:01 | |
*** jmasud has quit IRC | 02:18 | |
*** jmasud has joined #oooq | 02:21 | |
*** ysandeep|away is now known as ysandeep | 02:24 | |
*** jmasud has quit IRC | 02:34 | |
*** jmasud has joined #oooq | 02:38 | |
*** jmasud has quit IRC | 02:39 | |
*** ykarel has joined #oooq | 04:40 | |
*** ykarel has quit IRC | 04:45 | |
*** udesale has joined #oooq | 05:03 | |
*** ykarel has joined #oooq | 05:04 | |
*** udesale_ has joined #oooq | 05:13 | |
*** ratailor has joined #oooq | 05:15 | |
*** udesale has quit IRC | 05:15 | |
*** frenzy_friday has quit IRC | 05:56 | |
*** frenzy_friday has joined #oooq | 05:57 | |
*** jmasud has joined #oooq | 06:11 | |
*** marios has joined #oooq | 06:15 | |
*** skramaja has joined #oooq | 06:23 | |
*** jfrancoa has joined #oooq | 06:27 | |
*** slaweq has quit IRC | 07:18 | |
*** jmasud has quit IRC | 07:21 | |
*** slaweq has joined #oooq | 07:21 | |
*** frenzy_friday has quit IRC | 08:02 | |
*** amoralej|off is now known as amoralej | 08:10 | |
*** sanjayu_ has joined #oooq | 08:52 | |
*** saneax has quit IRC | 08:54 | |
*** saneax has joined #oooq | 08:59 | |
*** jpena|off is now known as jpena | 08:59 | |
*** sanjayu_ has quit IRC | 09:01 | |
*** saneax has quit IRC | 09:07 | |
slaweq | hi oooq team | 09:13 |
---|---|---|
slaweq | I have a question about testing ovn patch in the rdo job | 09:14 |
slaweq | I have test patch https://review.rdoproject.org/r/#/c/31356/ to run my test job | 09:14 |
slaweq | and I need to use ovn from the scratch build there | 09:14 |
slaweq | so Chandan last week adviced me to modify https://review.opendev.org/c/openstack/tripleo-quickstart/+/768079/2/config/release/tripleo-ci/CentOS-8/master.yml and add my scratch build repo there | 09:15 |
slaweq | so I did | 09:15 |
slaweq | but I still don't have my scratch build ovn installed in the containers in that job | 09:15 |
slaweq | can You take a look what I have missed/did wrong? | 09:15 |
slaweq | thx in advance for any help | 09:15 |
marios | slaweq: o/ see https://review.opendev.org/c/openstack/tripleo-quickstart/+/768079/2/config/release/tripleo-ci/CentOS-8/master.yml#1 | 09:19 |
slaweq | marios: thx a lot | 09:20 |
slaweq | so I did the change in wrong file | 09:20 |
slaweq | I still need to learn a lot about tripleo ci :) | 09:21 |
marios | slaweq: yeah it is using the promotion-testing-hash-master file so make the changes there | 09:21 |
marios | slaweq: its not 'ci' its 'tripleo big mess quickstart too many places and things to configure' | 09:21 |
marios | slaweq: so don't feel bad about it | 09:21 |
marios | slaweq: most of the time even we forget these things and have to dig... | 09:21 |
slaweq | marios: sure, thx a lot | 09:22 |
slaweq | great that I can always come here and have help quickly :) | 09:22 |
marios | np slaweq | 09:22 |
*** danpawlik has quit IRC | 09:32 | |
*** danpawlik0 has joined #oooq | 09:32 | |
ykarel | slaweq, if you want to update containers with that repo then you also need to override update_containers_repo so that repo get's used | 09:46 |
ykarel | can use container_prep_additional_repos var to add that | 09:47 |
slaweq | ykarel: so isn't https://review.opendev.org/c/openstack/tripleo-quickstart/+/768079 enough? | 09:47 |
ykarel | or can build container in job itself and with that repo will be used using build_container_images: true | 09:47 |
ykarel | slaweq, no with just that containers will not get updated, on host it will work though | 09:48 |
slaweq | ykarel: I need new ovn in the container, not on the host | 09:48 |
ykarel | slaweq, you have two option to do that pass build_container_images: true which will build containers in job itself or container_prep_additional_repos: <repo name> to update containers with repo content | 09:49 |
slaweq | ykarel: so if I have already that change which adds repo, I just need to add build_container_images: true to the job's parameters, is that correct? | 09:51 |
ykarel | slaweq, yes correct | 09:51 |
slaweq | ykarel: thx a lot | 09:51 |
ykarel | with standalone job that option should work fine | 09:52 |
slaweq | ykarel: https://review.rdoproject.org/r/#/c/31356/ done | 09:52 |
slaweq | lets wait for results now :) | 09:53 |
ykarel | ack looks fine | 09:53 |
slaweq | ykarel++ thx a lot | 09:54 |
*** dtantsur|afk is now known as dtantsur | 10:21 | |
*** udesale__ has joined #oooq | 10:23 | |
*** udesale_ has quit IRC | 10:25 | |
*** jmasud has joined #oooq | 10:27 | |
*** johnsom has joined #oooq | 10:33 | |
*** jmasud has quit IRC | 10:40 | |
*** saneax has joined #oooq | 10:53 | |
*** holser_ has quit IRC | 11:04 | |
*** holser has joined #oooq | 11:06 | |
*** jmasud has joined #oooq | 11:15 | |
ysandeep | marios, is it okay to cleanup old container build job from internal repos as we have moved to tcib - http://git.app.eng.bos.redhat.com/git/openstack/tripleo-ci-internal-jobs.git/tree/zuul.d/tripleo-build-containers.yaml#n3 | 11:19 |
ysandeep | i don't think we will reuse them. | 11:20 |
marios | ysandeep: sure if it isn't being used any more | 11:21 |
ysandeep | thanks! | 11:23 |
*** frenzy_friday has joined #oooq | 12:00 | |
ykarel | slaweq, i updated ur testproject patch | 12:01 |
ykarel | there is an issue in release file used | 12:01 |
*** tosky has joined #oooq | 12:02 | |
ykarel | also pushed a parallel change https://review.rdoproject.org/r/#/c/31415/ to update containers instead of building, there result should get early | 12:02 |
slaweq | ykarel: thx a lot | 12:04 |
slaweq | ykarel++ | 12:04 |
*** jmasud has quit IRC | 12:13 | |
*** ratailor has quit IRC | 12:15 | |
*** jpena is now known as jpena|lunch | 12:35 | |
*** udesale has joined #oooq | 12:54 | |
*** udesale__ has quit IRC | 12:56 | |
soniya29|rover | weshay|ruck, meeting? | 13:00 |
weshay|ruck | soniya29|rover, aye.. | 13:00 |
soniya29|rover | weshay|ruck, morning :) | 13:01 |
weshay|ruck | :) | 13:01 |
*** rlandy has joined #oooq | 13:03 | |
weshay|ruck | bhagyashris|ruck, want to sync w/ soniya29|rover and I? | 13:05 |
weshay|ruck | https://meet.google.com/pbj-bcin-uss?authuser=1 | 13:05 |
bhagyashris|ruck | weshay|ruck, give me 2 to 3 min i will join | 13:06 |
weshay|ruck | k | 13:06 |
marios | http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019522.html [tripleo] next meeting Tuesday Dec 22 @ 1400 UTC in #tripleo Please consider adding your news/blockers/plans in https://etherpad.opendev.org/p/tripleo-meeting-items even if you cannot attend | 13:09 |
*** udesale_ has joined #oooq | 13:11 | |
*** amoralej is now known as amoralej|lunch | 13:12 | |
*** udesale has quit IRC | 13:12 | |
*** amoralej|lunch is now known as amoralej | 13:13 | |
bhagyashris|ruck | arxcruz, rfolco, zbr, sshnaidm, rlandy, marios, ysandeep, bhagyashris, svyas, pojadhav, akahat, weshay, chandankumar, frenzy_friday | 13:28 |
bhagyashris|ruck | Community call | 13:29 |
bhagyashris|ruck | in 2 min | 13:29 |
*** skramaja has quit IRC | 13:29 | |
bhagyashris|ruck | plz add agenda if you have any | 13:30 |
*** jpena|lunch is now known as jpena | 13:33 | |
rlandy | weshay|ruck: have time this afternoon to review the repoquery diff script? | 13:47 |
weshay|ruck | sure | 13:49 |
*** ykarel_ has joined #oooq | 13:53 | |
*** ykarel has quit IRC | 13:56 | |
rlandy | weshay|ruck: thanks - will ping you | 13:57 |
*** ykarel_ is now known as ykarel | 14:07 | |
ykarel | slaweq, both patches have ovn from scratch build installed in containers | 14:07 |
ykarel | https://logserver.rdoproject.org/56/31356/6/check/periodic-tripleo-ci-centos-8-standalone-full-tempest-scenario-master/a804dba/logs/undercloud/var/log/extra/podman/containers/ovn-dbs-bundle-podman-0/podman_info.log.txt.gz | 14:07 |
ykarel | https://logserver.rdoproject.org/15/31415/1/check/periodic-tripleo-ci-centos-8-standalone-full-tempest-scenario-master/04eb206/logs/undercloud/var/log/extra/podman/containers/ovn-dbs-bundle-podman-0/podman_info.log.txt.gz | 14:07 |
ykarel | ovn2.13.x86_64 20.09.0-23bz1908391.el8fdn @brew-task-repo-ovn2.13-20.09.0-23bz1908391.el8fdn-scratch | 14:08 |
* bhagyashris|ruck brb | 14:09 | |
*** amoralej is now known as amoralej|lunch | 14:11 | |
*** derekh has joined #oooq | 14:12 | |
slaweq | ykarel: great, thx a lot for help | 14:15 |
weshay|ruck | rlandy, have all your ipa changes merged? | 14:23 |
weshay|ruck | ysandeep, any need to sync? seems we're caught up w/ each other to me | 14:25 |
ysandeep | weshay|ruck, lets skip today's mtg | 14:26 |
weshay|ruck | aye | 14:26 |
rlandy | weshay|ruck: all except the one to make the job voting again | 14:28 |
rlandy | I wanted to get the stats to a good place | 14:28 |
ysandeep | weshay|ruck, thanks for raising bug for 16.2 | 14:28 |
ysandeep | slaweq, https://bugzilla.redhat.com/show_bug.cgi?id=1909795#c1 , we have python3-networking-ansible rpm in our container | 14:28 |
openstack | bugzilla.redhat.com bug 1909795 in openstack-neutron "rhos 16.2 neutron dhcp agent failing due to amq timouts, unable to sync network state" [Urgent,New] - Assigned to rhos-maint | 14:28 |
ysandeep | ~~~ | 14:28 |
ysandeep | [root@overcloud-controller-0 ~]# podman exec -it neutron_api bash | 14:28 |
ysandeep | [neutron@overcloud-controller-0 /]$ rpm -qa | grep -i networking-ansible | 14:28 |
ysandeep | python3-networking-ansible-3.0.1-2.20201030230708.e24d01c.el8ost.noarch | 14:28 |
ysandeep | ~~~ | 14:28 |
ysandeep | i checked in different job but we use some containers for all integration line jobs | 14:29 |
ysandeep | also, upstream train job also have ansible driver in addition to ovn for sc12 - https://logserver.rdoproject.org/openstack-component-baremetal/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-scenario012-standalone-baremetal-train/cb857ad/logs/undercloud/var/lib/config-data/puppet-generated/neutron/etc/neutron/plugins/ml2/ml2_conf.ini.txt.gz but its not failing | 14:31 |
slaweq | ysandeep: hi, let me check | 14:44 |
ysandeep | slaweq, i have reproducer now.. if you want to cehck | 14:45 |
ysandeep | check* | 14:45 |
slaweq | ysandeep: that would be great | 14:45 |
ysandeep | will ping tmate in pm, in a minute | 14:45 |
*** amoralej|lunch is now known as amoralej | 14:49 | |
ysandeep | weshay|ruck, fyi.. in bug https://bugzilla.redhat.com/show_bug.cgi?id=1909795 we are hitting a bug from networking-ansible , https://opendev.org/x/networking-ansible/commit/28e22565070bfde3e2b476bd3cfd323dbe2d34c4 is fix for this.. thanks to slaweq++ he helped us in figuring this out.. | 15:06 |
openstack | bugzilla.redhat.com bug 1909795 in openstack-neutron "rhos 16.2 neutron dhcp agent failing due to amq timouts, unable to sync network state" [Urgent,New] - Assigned to rhos-maint | 15:06 |
weshay|ruck | slaweq++ | 15:07 |
weshay|ruck | ysandeep, so do we just need a networking compponent promotion? | 15:10 |
weshay|ruck | that patch landed in may.. | 15:10 |
weshay|ruck | so no | 15:10 |
ysandeep | i think that package comes from some rhel repos.. let me double check | 15:10 |
slaweq | weshay|ruck: this patch seems to be in networking-ansible 5.0.0 included | 15:10 |
weshay|ruck | aye.. built here http://osp-trunk.hosted.upshift.rdu2.redhat.com/rhel8-osp16-2/component/network/e2/4d/e24d01c8e4412f15d37870a84130cfc8097702dd_8de43e10_1a31d3f2_75661a49/rpmbuild.log | 15:11 |
slaweq | if we need backports I would wait with it for dradez who is maintainer of the networking-ansible project | 15:11 |
weshay|ruck | oh that guy... | 15:11 |
weshay|ruck | ah ya. .this is 16.2 so.. need to roll to train | 15:11 |
weshay|ruck | radez, there's my man | 15:12 |
weshay|ruck | radez, HI HONEY | 15:12 |
weshay|ruck | he's probably pto | 15:12 |
slaweq | yes, he's on pto | 15:13 |
* weshay|ruck updated card.. | 15:15 | |
ysandeep | 16.2-line++ | 15:15 |
weshay|ruck | if we can cherrypick that back.. in the mean time it would be a ++ I didn't see any cherrypicks or other reviews in that topic | 15:16 |
weshay|ruck | also a conflict cherrypicking to victoria | 15:16 |
weshay|ruck | slaweq, any idea why we don't see that in train? | 15:16 |
slaweq | weshay|ruck: probably we have older version of network-runner package | 15:17 |
weshay|ruck | see.. this crap shouldn't happen | 15:18 |
weshay|ruck | train should = 16.2 | 15:18 |
slaweq | weshay|ruck: https://review.opendev.org/c/x/networking-ansible/+/768222 | 15:21 |
weshay|ruck | slaweq, ysandeep there may be a pin in rdoinfo | 15:21 |
slaweq | I proposed backport of that patch | 15:21 |
slaweq | to stable/train | 15:21 |
slaweq | but lets wait what radez will say about it :) | 15:21 |
ysandeep | weshay|ruck, i will check - pinning for network-runner for stable/train | 15:22 |
slaweq | weshay|ruck: for train-release I see in rdo https://github.com/redhat-openstack/rdoinfo/blob/master/buildsys-tags/cloud8-openstack-train-release.yml#L1444 | 15:23 |
*** udesale_ has quit IRC | 15:23 | |
slaweq | so 0.1.7 is used there | 15:24 |
slaweq | and that works fine without this patch in networking-ansible | 15:24 |
weshay|ruck | python3-ansible-runner-1.4.0-1.el8ost.noarch | 15:25 |
weshay|ruck | https://sf.hosted.upshift.rdu2.redhat.com/logs/openstack-periodic-integration-rhos-16.2/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-rhel-8-scenario012-standalone-rhos-16.2/9eeccd7/logs/undercloud/var/log/extra/rpm-list.txt | 15:25 |
slaweq | weshay|ruck: You should check python3-network-runner package AFAIK | 15:25 |
weshay|ruck | python3-network-runner-0:0.2.2-2.el8ost.noarch | 15:26 |
weshay|ruck | https://sf.hosted.upshift.rdu2.redhat.com/logs/openstack-periodic-integration-rhos-16.2/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-rhel-8-scenario012-standalone-rhos-16.2/9eeccd7/logs/undercloud/var/log/extra/all_available_packages.txt | 15:26 |
*** derekh has quit IRC | 15:26 | |
slaweq | weshay|ruck: yes, that is version which needs that patch basically | 15:26 |
weshay|ruck | this is why I'm working on https://github.com/rdo-infra/ci-config/tree/master/ci-scripts/infra-setup/roles/rrcockpit/files/compare_rpms | 15:29 |
slaweq | may be useful :) | 15:35 |
weshay|ruck | slaweq, any chance https://bugs.launchpad.net/tripleo/+bug/1908976 could be caused by new libvirt packages? | 15:37 |
openstack | Launchpad bug 1908976 in tripleo "ovsdbapp.backend.ovs_idl.idlutils.RowNotFound: Cannot find Logical_Router with name=neutron-<uuid> is failing on featureset001 and featureset035 master" [High,Triaged] | 15:37 |
slaweq | weshay|ruck: looking | 15:41 |
weshay|ruck | slaweq, https://termbin.com/zr6y "Control Package Version" is last known good/working | 15:42 |
weshay|ruck | slaweq, https://review.rdoproject.org/zuul/builds?job_name=periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001-master | 15:42 |
weshay|ruck | 06.0.0 -> 06.6 | 15:43 |
slaweq | weshay|ruck: I'm not sure why there are those neutron errors there | 15:48 |
slaweq | but IMHO the main problem is in nova | 15:48 |
slaweq | see e.g. in nova-api log: 2020-12-22 03:32:50.964 11 ERROR nova.api.openstack.wsgi nova.exception.CinderConnectionFailed: Connection to cinder host failed: SSL exception connecting to https://[2001:db8:fd00:1000::5]:13776/v3/b39f976ab44e43b7b2401ecf21de8a97/volumes/3fe59841-f133-47bc-bbdc-071ab54b5105: HTTPSConnectionPool(host='2001:db8:fd00:1000::5', port=13776): Max retries exceeded with url: | 15:48 |
slaweq | /v3/b39f976ab44e43b7b2401ecf21de8a97/volumes/3fe59841-f133-47bc-bbdc-071ab54b5105 (Caused by SSLError(SSLError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:897)'),)) | 15:48 |
slaweq | that is IMO error which is causing all those tests fails | 15:48 |
weshay|ruck | slaweq, /me pushes this to compute | 15:49 |
slaweq | weshay|ruck: I will also ask flavio to look at this neutron error there | 15:50 |
ysandeep | weshay|ruck, ansible-role-network-runner comes from osptrunk-candidate-deps, in the meantime should be request rel-del to revert to older good known version ansible-role-network-runner-0:0.1.7-3.el8ost.noarch | 15:52 |
slaweq | weshay|ruck: I asked flaviof in our internal neutron channel to check that | 15:52 |
slaweq | I will be go offline in few minutes :) | 15:53 |
ysandeep | till 15th(last good job) we were getting ansible-role-network-runner-0:0.1.7-3.el8ost.noarch https://sf.hosted.upshift.rdu2.redhat.com/logs/openstack-periodic-integration-rhos-16.2/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-rhel-8-scenario012-standalone-rhos-16.2/7213337/logs/undercloud/var/log/extra/all_available_packages.txt | 15:53 |
weshay|ruck | slaweq, thanks again | 15:53 |
slaweq | weshay|ruck: np | 15:53 |
slaweq | yw | 15:53 |
weshay|ruck | ysandeep, ask them to align w/ rdo :) | 15:53 |
ysandeep | aye o/ | 15:54 |
slaweq | Happy Holidays and see You next year! o/ | 15:56 |
*** derekh has joined #oooq | 15:59 | |
ysandeep | slaweq, Merry christmas and happy new year :) | 16:00 |
*** ykarel has quit IRC | 16:16 | |
*** jfrancoa has quit IRC | 16:16 | |
marios | weshay|ruck: rlandy: sshnaidm: please check when you have a minute easy one (component criteria fix) https://review.rdoproject.org/r/#/c/31418/ | 16:22 |
ysandeep | weshay|ruck, pinged on rhos-del but shrestha is not around.. i will try to check with her tomorrow | 16:24 |
weshay|ruck | ysandeep, thanks | 16:24 |
ysandeep | rlandy, hey o/ if you get some time i would appreciate some reviews on https://code.engineering.redhat.com/gerrit/#/c/219297/ and https://code.engineering.redhat.com/gerrit/#/q/topic:remove_obselete_container_build_job+(status:open+OR+status:merged) | 16:28 |
rlandy | ok | 16:28 |
ysandeep | rlandy++ thanks! | 16:28 |
* ysandeep leaves for the day, Happy holidays to those who are goings on Ptos | 16:28 | |
weshay|ruck | thanks ysandeep | 16:28 |
weshay|ruck | 0/ | 16:28 |
*** ysandeep is now known as ysandeep|away | 16:29 | |
rlandy | weshay|ruck: have time for a repoquery diff review now? | 16:39 |
weshay|ruck | rlandy, :) indeed chttps://review.rdoproject.org/r/31419 | 16:39 |
rlandy | weshay|ruck: meet.google.com/tnw-jevs-ifz | 16:40 |
weshay|ruck | https://meet.google.com/dye-njgs-fva?authuser=1 | 16:40 |
weshay|ruck | oops | 16:40 |
weshay|ruck | joining urs | 16:40 |
*** marios is now known as marios|out | 17:16 | |
zbr | weshay|ruck: can you please +W https://review.opendev.org/c/openstack/tripleo-common/+/767358 ? | 17:30 |
*** amoralej is now known as amoralej|off | 17:43 | |
weshay|ruck | zbr, so output is.. | 17:44 |
weshay|ruck | pylint...................................................................Passed | 17:44 |
weshay|ruck | 2020-12-21 14:15:34.817644 | ubuntu-focal | linters run-test: commands[1] | bash -c tools/check_duplicate_jinja_blocks.sh | 17:44 |
weshay|ruck | 2020-12-21 14:15:34.818050 | ubuntu-focal | setting PATH=/home/zuul/src/opendev.org/openstack/tripleo-common/.tox/linters/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin | 17:44 |
weshay|ruck | 2020-12-21 14:15:34.821328 | ubuntu-focal | [2299] /home/zuul/src/opendev.org/openstack/tripleo-common$ /usr/bin/bash -c tools/check_duplicate_jinja_blocks.sh | 17:44 |
weshay|ruck | 2020-12-21 14:15:34.824561 | ubuntu-focal | grep: container-images/tripleo_kolla_template_overrides.j2: No such file or directory | 17:44 |
*** jpena has quit IRC | 17:45 | |
zbr | weshay|ruck: what is the problem? i see "passed" | 17:47 |
zbr | the other bits are unrelated to the change | 17:47 |
zbr | but none the less it is weird, usually we should not see such a message anyway. | 17:49 |
*** sanjayu_ has joined #oooq | 17:51 | |
*** amoralej|off has quit IRC | 17:52 | |
*** saneax has quit IRC | 17:54 | |
weshay|ruck | zbr, no problem.. just was poking at it :) | 17:57 |
weshay|ruck | zbr, thanks for doing it | 17:58 |
zbr | i wonder if it worth trying to backport this change | 17:58 |
zbr | as the original bug was on train. | 17:59 |
*** derekh has quit IRC | 18:00 | |
*** marios|out has quit IRC | 18:20 | |
*** dtantsur is now known as dtantsur|afk | 18:33 | |
rlandy | weshay|ruck: https://review.rdoproject.org/r/31422 Add script to compare repoquery lists within jobs | 18:53 |
rlandy | let me know what you think | 18:53 |
rlandy | added functionality to write table to file for logging | 18:53 |
rlandy | log collection | 18:53 |
* weshay|ruck looks | 19:15 | |
weshay|ruck | rlandy, linters :) | 19:15 |
weshay|ruck | tox -re linters :) | 19:15 |
rlandy | weshay|ruck: on it | 19:15 |
weshay|ruck | rlandy, biab.. have to grab a kid | 19:41 |
rlandy | weshay|ruck: np- still fighting linters | 19:42 |
rlandy | weshay|ruck: when you get back ... unsure how to fix this last error: | 20:01 |
rlandy | ************* Module diff_control_test | 20:01 |
rlandy | ci-scripts/infra-setup/roles/rrcockpit/files/compare_rpms/diff_control_test.py:131:4: E1120: No value for argument 'control_list' in function call (no-value-for-parameter) | 20:01 |
rlandy | ci-scripts/infra-setup/roles/rrcockpit/files/compare_rpms/diff_control_test.py:131:4: E1120: No value for argument 'test_list' in function call (no-value-for-parameter) | 20:01 |
rlandy | ci-scripts/infra-setup/roles/rrcockpit/files/compare_rpms/diff_control_test.py:131:4: E1120: No value for argument 'ignore_list' in function call (no-value-for-parameter) | 20:01 |
rlandy | ci-scripts/infra-setup/roles/rrcockpit/files/compare_rpms/diff_control_test.py:131:4: E1120: No value for argument 'table_location' in function call (no-value-for-parameter) | 20:01 |
rlandy | zbr: ^^ a little help pls | 20:32 |
*** jmasud has joined #oooq | 20:36 | |
*** jmasud has quit IRC | 21:20 | |
*** rfolco has quit IRC | 21:27 | |
*** jmasud has joined #oooq | 21:31 | |
weshay|ruck | rlandy, sorry that took so long | 22:14 |
weshay|ruck | what happens when you run it locally? | 22:14 |
weshay|ruck | rlandy, look up E1120 | 22:14 |
rlandy | weshay|ruck: np | 22:17 |
* weshay|ruck trying it | 22:17 | |
rlandy | I did | 22:17 |
*** rfolco has joined #oooq | 22:19 | |
weshay|ruck | rlandy, your arguments to main have no defaults | 22:19 |
weshay|ruck | rlandy, this is a weird thing w/ click | 22:19 |
rlandy | ok - I see you have defaults in yours | 22:20 |
rlandy | adding | 22:20 |
weshay|ruck | I think the linters will pass w/ empty values to.. | 22:21 |
weshay|ruck | def main(control_list, test_list, ignore_list, table_location): | 22:21 |
weshay|ruck | but it doesn't see anything set for the args there | 22:21 |
rlandy | didn't like that | 22:22 |
*** rfolco has quit IRC | 22:23 | |
rlandy | trying with default=false | 22:24 |
weshay|ruck | rlandy, /me needs a +2 on https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/768204 | 22:25 |
rlandy | done | 22:25 |
rlandy | ugh linters | 22:25 |
rlandy | what did I ever do to you???? | 22:25 |
weshay|ruck | lolz | 22:28 |
*** jmasud has quit IRC | 22:28 | |
*** jmasud has joined #oooq | 22:30 | |
rlandy | 4 more space - over-indented | 22:35 |
rlandy | 4 less under-indented | 22:35 |
rlandy | are you joking?? | 22:35 |
rlandy | # pylint: disable=no-value-for-parameter | 22:36 |
rlandy | weshay|ruck: ha ... | 22:36 |
rlandy | https://github.com/rdo-infra/ci-config/blob/master/ci-scripts/infra-setup/roles/rrcockpit/files/compare_rpms/diff_tripleo_builds/diff_builds.py#L818 | 22:36 |
rlandy | you also gave up | 22:36 |
weshay|ruck | oh.. how about that | 22:37 |
weshay|ruck | lolz.. ya.. /me takes another mental note | 22:37 |
weshay|ruck | that's a thing w/ click | 22:37 |
rlandy | linters: commands succeeded | 22:38 |
rlandy | congratulations :) | 22:38 |
rlandy | well, well, well | 22:38 |
rlandy | weshay|ruck: ok - hopefully this passes linters | 22:39 |
weshay|ruck | :) | 22:40 |
rlandy | testing calling this script on internal | 22:40 |
*** slaweq has quit IRC | 22:51 | |
*** jmasud has quit IRC | 23:49 | |
*** tosky has quit IRC | 23:57 | |
*** jmasud has joined #oooq | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!