Monday, 2020-03-16

openstackgerritIan Wienand proposed openstack/project-config master: Add pip-and-virtualenv to arm64 images  https://review.opendev.org/71315200:10
openstackgerritMerged openstack/project-config master: Add pip-and-virtualenv to arm64 images  https://review.opendev.org/71315200:31
openstackgerritMerged opendev/system-config master: nodepool-builder: add /opt/dib_cache  https://review.opendev.org/71282400:36
openstackgerritIan Wienand proposed openstack/project-config master: [dnm] Use diskimages-gloabls section  https://review.opendev.org/71315802:55
openstackgerritIan Wienand proposed openstack/project-config master: nodepool config : add ZUUL_USER_SSH_KEY  https://review.opendev.org/71316003:08
*** DSpider has joined #opendev05:41
*** DSpider has quit IRC05:42
*** DSpider has joined #opendev05:43
*** DSpider has quit IRC05:43
*** DSpider has joined #opendev06:15
openstackgerritDaniel Pawlik proposed opendev/system-config master: Added updates dir for Fedora 31 release  https://review.opendev.org/71316908:08
openstackgerritAndreas Jaeger proposed opendev/system-config master: Remove Fedora 29 mirroring  https://review.opendev.org/71317709:05
openstackgerritAndreas Jaeger proposed opendev/system-config master: Remove Fedora 29 mirroring  https://review.opendev.org/71317709:11
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Replace occurences of '/' in nodename to something more path friendly  https://review.opendev.org/71318210:08
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Replace occurences of '/' in nodename to something more path friendly  https://review.opendev.org/71318210:16
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Replace occurences of '/' in nodename to something more path friendly  https://review.opendev.org/71318210:18
openstackgerritDaniel Pawlik proposed zuul/zuul-jobs master: DNM - checking new images  https://review.opendev.org/71318310:22
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Replace occurences of '/' in nodename to something more path friendly  https://review.opendev.org/71318210:24
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Replace occurences of '/' in nodename to something more path friendly  https://review.opendev.org/71318210:28
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Replace occurences of '/' in nodename to something more path friendly  https://review.opendev.org/71318210:30
openstackgerritsebastian marcet proposed opendev/puppet-openstackid master: Fixed python packages installation  https://review.opendev.org/71322513:15
openstackgerritMerged opendev/puppet-openstackid master: Fixed python packages installation  https://review.opendev.org/71322513:57
mnaserhttps://review.opendev.org/#/c/713123/ -- just wondering how everyone feels about this :)15:16
AJaegermnaser, change LGTM but I like to have clarkb review a new tenant ^15:25
mordredclarkb: how does apply a reverse of https://salsa.debian.org/debian/openssl/-/blob/debian/unstable/debian/patches/Set-systemwide-default-settings-for-libssl-users.patch sound?15:53
clarkbI'll be able to answer if the patch ever loads :)15:54
clarkbmordred: ya that looks clean and is pretty easy to understand.15:56
openstackgerritMerged openstack/diskimage-builder master: bindep: remove lsb-release  https://review.opendev.org/71315015:59
openstackgerritMonty Taylor proposed opendev/system-config master: Undo debian changes to openssl.cnf for python-base  https://review.opendev.org/71327816:00
mordredclarkb: ^^16:01
clarkbmordred: so I understand you applied the patch to the .cnf file then vendored the result right? rather than apply the patch each build?16:03
mordredyeah. because python-base itself doesn't have patch installed16:03
clarkbwow16:04
mordredit's a base image :)16:04
Shrewsi suspect it might also be less error prone to do it ahead of time16:07
clarkbmnaser: AJaeger I don't have any objects, but am still trying to get on top of the fires since friday16:08
clarkbShrews: thats a good point (if the underlying config moves it could break our patch)16:08
AJaegerclarkb: want me to review mnaser's and +2A - or wait until the fires are out? either works for me...16:08
Shrewsmordred: i only +2'd in case someone else wants to review16:08
clarkbAJaeger: maybe just double check frickler's comments then approve? It should be safe to add a new tenant16:09
AJaegerclarkb: ok16:10
mordredcorvus: ^^ https://review.opendev.org/713278 if you have a sec16:12
clarkbthinking about the zuul ssh key thing, maybe we should just copy pasta it for each image in the env section while we sort out the best way to express it in nodepool conf for the future?16:22
clarkbmordred: I'm reviewing https://review.opendev.org/#/c/713101/ but won't approve it since it needs some review-dev attentin16:24
mordredclarkb: cool. if we wanna do it - I can emergency review-dev and clean it up - then we can land this and unemergency and things should just come back up16:25
clarkbI think I've come around to the idea of that consistency. Maybe we want to see what frickler Shrews fungi and corvus think? ianw already +2'd it16:27
mordredclarkb: agree16:28
AJaegerfrickler, mnaser, please have a look again at comments at https://review.opendev.org/#/c/71312316:29
corvusdocker +216:29
fungiclarkb: i still think putting the public keys we trust into our service configuration is preferable to relying on system configuration management, especially for the builder case where it really only uses the public key and only for baking into the node images16:30
corvuswin 1216:30
mnaserAJaeger, frickler: left a comment, dont think i would have been able to actually get a list of all the repos so my idea was to start with it and fixup afterwards16:31
fungiboxcars for a win!16:31
AJaegermnaser: works for me, let's wait for frickler to respond. Or do you need it directly?16:31
mnaserAJaeger: it's blocking some work i'm doing, and it'd be at least nice to see this land so i can do the round 2 of adding other projects so i can merge that today too (hopefully)16:32
AJaegermnaser: ok, let's give frickler an hour to review and then I'll +2A.16:33
clarkbmordred: you are probably the right person to doulble check my -1 on https://review.opendev.org/#/c/713148/2 (docker mounts thing)16:41
clarkband with that I think I've caught up on the changes that have been written so far16:41
clarkbfungi: re ssh keys, ya thats where we are heading based on ianw's change stack but they currently depend on new features in nodepool that are being discussed. I think we can do the early step of being extra verbose in our service configs then convert to the new nodepool configs if/when that happens16:42
fungiabsolutely16:44
mordredclarkb: your comment is correct16:51
openstackgerritClark Boylan proposed openstack/project-config master: [dnm] Use diskimages-gloabls section  https://review.opendev.org/71315816:57
openstackgerritClark Boylan proposed openstack/project-config master: nodepool config : add ZUUL_USER_SSH_KEY  https://review.opendev.org/71316016:57
openstackgerritClark Boylan proposed openstack/project-config master: Verbosely apply Zuul ssh key in nodepool config  https://review.opendev.org/71328916:57
clarkbfungi: mordred ianw ^ fyi I went ahead and stacked the verbose version under the cleanup version so that we don't have to wait on nodepool design stuff to make the functional change16:58
clarkbNext on the list is figuring out where we ended up with dnf installations being slow17:04
fungididn't ianw work out that it was lvm scanning during kernel package installation?17:06
clarkbya reading scrollback in -infra seems it doesn't do it on a fresh host but does repreoduce listing vgs on our existing nb01.opendev builder17:07
clarkbI guess we don't have changes for that yet, and probably debug that further after building nb04?17:07
fungiright, but also it may be something we run into over time. maybe there are a ton of orphaned cruft loop block devices it's trying and timing out on?17:10
clarkbdo loop block devices affect lvm vgs listing? I guess it scans the devices for lvm stuff?17:12
mnaserclarkb: i can abandon https://review.opendev.org/#/c/713136/ in favour of 713160 ?17:18
clarkbmnaser: yes, I think after debugging that we decided being explicit was desireable (to avoid similar confusion in the future)17:18
mnasercool, i'll abandon with a note17:19
fungiclarkb: vgscan checks all your block devices, i believe17:19
fungidepends on what exactly is happening, of course17:19
openstackgerritMerged opendev/system-config master: Undo debian changes to openssl.cnf for python-base  https://review.opendev.org/71327817:36
mnaserAJaeger: can I get the +2 now? :)17:48
AJaegermnaser: +2A ;)17:55
openstackgerritMerged openstack/project-config master: opendev: move vexxhost to seperate tenant  https://review.opendev.org/71312318:08
mnaserthanks!18:20
AJaegermnaser: have fun: http://zuul.opendev.org/t/vexxhost/config-errors18:53
mnaserAJaeger: nice.18:55
mordredmnaser: as you work on that a) it would be great to fix places where there's too tight of a coupling and b) it would be great to have a doc of "here's what you need to reconsume devstack"19:10
mnasermordred: it seems like its' mostly required-projects and im not sure how to decouple that19:12
mnaserso far i had to add openstack/requirements and https://github.com/openstack/devstack/blob/master/.zuul.yaml#L366-L37319:12
mordredmnaser: nod19:13
mnasermordred: having said that, the "bug" i think zuul has is19:13
mnaserit seems to fail after the first missing dependency19:13
mnaserso it only talks about openstack/cinder missing in all those, not the others19:14
mordrednod19:14
mnaserso there's probably a "return" in there when there shouldn't, but i don't have the time right now to look more into it19:14
mnaseri'll post in #zuul about it for now..19:14
openstackgerritMohammed Naser proposed openstack/project-config master: vexxhost: add repos needed for required-projects for devstack  https://review.opendev.org/71331719:18
corvuswe maybe should have talked about the vexxhost tenant a bit more19:18
mnasercorvus: happily can revert/discuss if it's an issue19:18
corvusi'm sorry i didn't have time earlier, it seems i'm swamped19:18
mnaseri was trying to not pollute the opendev namespace by adding more required-projects for required-projects19:19
corvusmnaser: yeah, it's reversible, and just to be clear, it's not upsetting or anything; just more of i don't think we totally worked out what that would mean :)19:19
mnasercorvus: yeah.  i mean to me it's not anything that wouldn't live under any other tenant, the only purpose was just not polluting the tenant with tons of extra projects which end up openstack-ifying the opendev tenant19:19
mnaserhappy to discuss though.  i just figured it's probably easier for these projects where we know other people might be contributing to live here rather than in our own gerrit (because i sure as hell not going to go through the pain of github)19:20
corvusagreed; we should have an answer for that, and i don't know what it is.  maybe this is the right answer.  but (aside from the interminable tedium of figuring out what the required projects are), other gotchas i can think of are multiple merge or config error reports, and we can't add a dedicated config project to this tenant (for security reasons)19:21
corvusmnaser: btw, if you do figure out what the appropriate set of required projects is, can you please document it somewhere?  because every third-party ci system goes through the exact same thing, and when they're done, they disappear and don't tell the next person what the config is supposed to be.19:22
mnasercorvus: happily.  i just don't know where is the best place, but i can gladly do that, i am thinking it might take one or two iterations19:23
corvuswell, i guess opendev's tenant config might be that documentation :)19:23
mnaserso hopefully y'all are a bit more patient with me taking a few patches to get it right as i did as much research as i could19:23
mnaseryeah, fwiw i have no interest in maintaining a config project or wanting to have one19:24
AJaegermnaser: we trade you some random reviews ;)19:24
corvusmnaser: anyway, about the config-project: hopefully you can live without one (i think probably so).  and about the multiple merge/config errors -- i'm not sure about how to address that.19:24
mnaseri'm totally ok with using the opendev ones, i dont need any custom pipelines or my own base jobs19:25
mordredthe multiple config errors one is the most troubling one19:25
mnaserAJaeger: i did my first attempt there ^ and then hopefully that's it, then maybe somewhere in openstack/devstack might be a good place to put it..19:26
mnaseri've topic'd them 'devstack-in-zuulv3' and if any follow ups come ill put them there19:26
mordredlargely because it can be confusing when you get a config error on an openstack repo fora. config issue in a different tenant - there is no error message - but that's maybe an experience we should improve19:26
mnaserso if i dont end up pushing a patch to document it, at least there will be a series of patches to look at :p19:27
mnaserAJaeger: i'll take a trade for one of those random reviews now :)19:36
AJaegermnaser: just pick something anytime - no urgency ;)19:37
AJaegermnaser: +2A19:37
openstackgerritMerged openstack/project-config master: vexxhost: add repos needed for required-projects for devstack  https://review.opendev.org/71331719:45
openstackgerritIan Wienand proposed opendev/system-config master: nodepool-builder: put container configs in /etc  https://review.opendev.org/71314820:37
ianwmordred/clarkb: ^ thanks, yes i forgot to map it in.  i can look at some "docker exec" type tests to ensure things in the container i guess; it doesn't map directly to testinfra's nice api20:38
mordredianw: lgtm20:38
mordredianw: related: https://review.opendev.org/#/c/713060/20:39
mordredianw: and we landed https://review.opendev.org/#/c/713278/20:39
mordredianw: so once we build a new nodepool-builder image the ssl thing should be taken care of too20:39
ianwmordred: yep, cool.  i don't know if we want to tell rax about it20:40
ianwi think it has something to do with SNI and webserver configs and sha120:40
ianwthat's my bug report :)20:40
ianwcorvus / mordred / clarkb : with https://review.opendev.org/#/c/713057/ do we no longer need to think about making a nb04.opendev.org for a redeploy?20:41
ianwi.e. we can keep nb01.opendev.org?  and the name won't conflict now?20:42
ianwor is there more to do?20:42
mordredianw: not sure - Shrews?20:42
ianwi wasn't clear on that bit from the other day; https://storyboard.openstack.org/#!/story/2007407 task #3906320:42
ianw<corvus> ianw: i think we're a little fuzzy on the contribution of the short-names -- the current system is using a unique short name but also completely duplicated file with all the images20:43
mordredianw: oh - so I'm going to clean up review-dev manually by doing a podman-compose down, apt-get remove podman, pip uninstall podman-compose and remove the podman ppa config - I think that should do it20:46
mordredI'm guessing when we're ready on nb01 we can do similar - or can just wait til we land the switch-to-docker patch before spinning up nb04 if we're gonna go that route20:47
clarkbianw: my understanding is we could use nb01 as the name but have to upgrade all builders forst20:48
ianwsounds good -- yeah i think we want to start the nb host again20:48
clarkbnb04 might be less confusing overall though20:48
ianwyeah, it also didn't seem to update what you see in "nodepool dib-image-list", or maybe it did20:49
ianwperhaps i should restart all the builders anyway today, but still move forward with nb04?20:49
ianwwhen the config change and the ssl change are fully merged, i think we have what we need to try again20:50
clarkbya I think lets do nb04 and restarting anyway sounds good20:50
Shrewsmordred: ianw: the nodepool fix would fix it, but we'd need to restart nodepool first. probably using nb04 is a good idea anyway?20:50
clarkbianw: we may need to build new nodepool.images20:50
clarkbthe dockerfile update went into the parent image20:50
clarkb(so we dont have to fix ssl for each child)20:51
ianwyeah, good point, do we actually need a release to upload them?20:51
clarkbno just a change to merge20:52
clarkbShrews: ^ know of any changes wemight be able to land in order to get new images?20:58
ianwi think there's mordred's dockerfile change in the queu?21:00
ianwhttps://review.opendev.org/#/c/713060/21:01
Shrewsfungi's py38 change might be easiest for now21:01
Shrewsi also have a cli change up that's pretty safe21:02
clarkbcorvus: can you rereview 713060 I think you understand that one best21:03
* fungi strives to make easy changes21:03
clarkbthough I think I'm ok to approve it21:03
openstackgerritMerged openstack/project-config master: Verbosely apply Zuul ssh key in nodepool config  https://review.opendev.org/71328921:04
Shrewshttps://review.opendev.org/712539 is straight forward21:04
clarkbactually https://review.opendev.org/#/c/713060/ seems to still remove the sudo stuff corvus asked for morded to add back in?21:08
clarkbmordred: ^21:08
corvusagreed, left comment21:09
ianwNPM is joining github ... top voted HN comment "this seems like a good outcome overall" ... we live in interesting times21:30
* fungi read the announcement as "npm is now a microsoft product"21:31
fungithey'll have some very useful additional insight into what'21:32
fungis deployed to a lot more servers on the internet21:32
ianwwell i guess i work for IBM, so stones and glass houses21:37
mnaserah damn22:17
mnaseri almost got everything right22:17
mnaserfor the devstack stuff22:17
openstackgerritMohammed Naser proposed openstack/project-config master: vexxhost: load openstack/tempest jobs  https://review.opendev.org/71333922:19
mnaserAJaeger, mordred: that might be the last one i hope ^22:20
mnaserwelcome other reviews as i go through my 1-2 hour timeouts to land and see if it works or not :P22:20
mordredianw: https://review.opendev.org/#/c/713101/ is good to go on my end now - I have stopped and uinstalled podman stuff on review-dev22:22
mordredianw: I think it should be safe to land on your end too, yes?22:22
openstackgerritMonty Taylor proposed opendev/system-config master: Remove the Rackspace Cloud repo  https://review.opendev.org/71334122:30
mordredclarkb: ^^ I found something while cleaning up review-dev22:31
clarkbcool my power is out so I'm gonna do something else for a bit22:31
mordredclarkb: great choice!22:31
clarkbpower company says I've got 3 hours of no power22:34
clarkbso that may be it for me today. I've not yet sent an agenda put but will try to if things are back before bed22:34
ianwmordred: yes, nb01.opendev in emergency so no issues there23:28
*** DSpider has quit IRC23:33
mordredianw: ok. I hit +A on it23:42
ianwi'll work on an nb04 a bit later23:42
ianwi am *really* hoping that the fedora LVM/udev/uevent/??? madness does not reappear :/23:43
fungimy money's on vgscan iterating over a bunch of dead loop devices23:49
ianwfungi: i think those it's getting some bad feedback -- the process of probing is somehow making some other even that starts a new probe or similar23:50
ianwevent23:50
fungiahh23:50
fungichain reaction23:51
ianwyeah, difficult to debug chain reactions seem to be the theme of 202023:58
fungimaybe if we keep the processes at least 2 meters apart23:58
ianw:)23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!