*** cloudnull has joined #opendev | 00:03 | |
clarkb | has anyone had a chance to read the opendev project update for the annual report yet? | 00:06 |
---|---|---|
clarkb | I'm about to pass the zuul one over to the foundation to get feedback before things are due next week and would be great to get the opendev side in a similar spot | 00:06 |
corvus | clarkb: looking now; btw, did i mention that my meetpad change was merged upstroam in jitsi? (but last i looked they hadn't updated docker images) | 00:07 |
clarkb | no I hadn't heard that | 00:07 |
corvus | hopefully soon we can drop our tiny fork (which is old) | 00:08 |
clarkb | we should be able to pull upstream for that component and still build our own image though? maybe its easiest to just switch to their image | 00:08 |
corvus | yeah, we should switch to theirs; ours is only for that patch | 00:08 |
*** cloudnull has quit IRC | 00:10 | |
corvus | clarkb: opendev lgtm; though we might be able to call out the zuul image build pipeline stuff a bit more; maybe something about how we made it available to all projects and they can use depends-on and whatever | 00:12 |
clarkb | that is a good idea | 00:12 |
clarkb | I'll try to work that in | 00:12 |
fungi | i briefly glimpsed at it but was hoping to take a closer look tomorrow | 00:13 |
corvus | i'm not sure if we need to say the words "intermediate registry" but we could if that helps | 00:13 |
clarkb | fungi: cool I can hold off on foundation feedback until you've had a chance to read it | 00:13 |
corvus | fungi is foundation feedback :) | 00:13 |
fungi | well, i can also just count as "foundation feedback" | 00:13 |
fungi | heh, indeed | 00:13 |
clarkb | ++ | 00:14 |
clarkb | corvus: paragraph starting at line 67 tries to capture the image build stuff with a bit more detail if you can take another look | 00:22 |
*** tosky has quit IRC | 00:23 | |
corvus | clarkb: minor suggestion on line 69, take it or leave it. otherwise, lgtm! | 00:35 |
clarkb | done and thanks | 00:36 |
*** DSpider has quit IRC | 01:13 | |
*** cloudnull has joined #opendev | 01:42 | |
*** diablo_rojo has quit IRC | 03:37 | |
*** ysandeep|away is now known as ysandeep | 03:47 | |
*** ykarel has joined #opendev | 04:53 | |
*** whoami-rajat__ has joined #opendev | 05:41 | |
*** slittle1 has quit IRC | 06:48 | |
*** slittle1 has joined #opendev | 06:49 | |
*** marios has joined #opendev | 06:57 | |
*** prometheanfire has quit IRC | 07:14 | |
*** sboyron has joined #opendev | 07:25 | |
*** prometheanfire has joined #opendev | 07:29 | |
*** rpittau|afk is now known as rpittau | 08:01 | |
*** andrewbonney has joined #opendev | 08:23 | |
*** hashar has joined #opendev | 08:42 | |
*** ysandeep is now known as ysandeep|lunch | 08:46 | |
*** elod_pto is now known as elod | 08:48 | |
*** DSpider has joined #opendev | 09:33 | |
*** ysandeep|lunch is now known as ysandeep | 09:40 | |
*** slaweq has joined #opendev | 09:55 | |
*** dtantsur|afk is now known as dtantsur | 10:35 | |
*** slaweq has quit IRC | 10:38 | |
*** hashar is now known as hasharLunch | 10:49 | |
*** Eighth_Doctor has quit IRC | 11:20 | |
*** mordred has quit IRC | 11:21 | |
*** mordred has joined #opendev | 11:29 | |
*** Eighth_Doctor has joined #opendev | 11:47 | |
*** tosky has joined #opendev | 12:15 | |
*** lpetrut has joined #opendev | 12:17 | |
*** slaweq has joined #opendev | 12:17 | |
*** ysandeep is now known as ysandeep|afk | 12:57 | |
*** brinzhang0 has quit IRC | 13:12 | |
*** slaweq has quit IRC | 13:15 | |
openstackgerrit | Sorin Sbârnea proposed opendev/system-config master: Recognize LP urls for footer bugs https://review.opendev.org/c/opendev/system-config/+/737960 | 13:21 |
*** ysandeep|afk is now known as ysandeep | 13:33 | |
dtantsur | hi folks! are there any docs on how to use search in storyboard? | 13:58 |
fungi | dtantsur: the api or the webui? | 14:42 |
fungi | the webui search widget is basically auto-completing what you type against a variety of different object types | 14:43 |
fungi | i don't know that it's particularly documented. the api has good docs though | 14:43 |
fungi | the search options in the api are object-type-scoped, for example https://docs.openstack.org/infra/storyboard/webapi/v1.html#get--v1-stories-search | 14:45 |
dtantsur | mm, okay, maybe I should use the API. the web UI doesn't seem usable (or I haven't figured it out) | 14:46 |
fungi | dtantsur: i click in the search field, my browser outlines it with a blue glow if it's active (i'm not sure what the significance of this is but i've noticed if i try to click in it while things are still loading i don't get that "blue glow" and then the typeahead searching doesn't seem to happen) and start typing some text. matches should (after a bit of a delay, could be a few seconds because the api can | 14:54 |
fungi | be slow/overloaded at times) start to appear and then i can click on which one i want | 14:54 |
fungi | there's a fix merged for a major api speedup but we haven't deployed it because we need to switch up how we're deploying the software and move to a newer distro with a version of python storyboard supports | 14:55 |
fungi | if i click in the search field and don't get a blue border or it appears and then immediately disappears again, clicking some dead space on the page and then clicking back into the search field seems to solve it. not sure what's going on there | 14:57 |
fungi | something to do with javascript focus detection i guess | 14:57 |
dtantsur | so, I tried inputting "ironic cleaning ramdisk". I got a "helpful" suggestion of "ironic cleaning ramdisk" :) I clicked on it and got everything in the world that has one of these words somewhere. | 14:57 |
dtantsur | try doing the same with google and site:storyboard.openstack.org and you'll get much more relevant results | 14:58 |
dtantsur | I also could not figure out how to limit the search to only stories with a task on openstack/ironic | 14:58 |
fungi | ahh, yeah, right now it's just keyword matching, there is no query language. there's been discussion of redoing all the query interfaces and implementing something like a lucene parser | 15:00 |
dtantsur | I see :( | 15:13 |
*** lpetrut has quit IRC | 15:27 | |
*** slittle1 has quit IRC | 15:40 | |
*** slittle1 has joined #opendev | 15:40 | |
*** spotz has quit IRC | 15:44 | |
*** mlavalle has joined #opendev | 16:01 | |
*** ykarel has quit IRC | 16:30 | |
openstackgerrit | Merged openstack/project-config master: Enable tripleo core members to change WIP flag https://review.opendev.org/c/openstack/project-config/+/765821 | 16:55 |
*** ysandeep is now known as ysandeep|away | 16:56 | |
*** marios is now known as marios|out | 16:57 | |
*** marios|out has quit IRC | 17:00 | |
*** hasharLunch is now known as hashar | 17:02 | |
clarkb | I don't see any new leaked ansible processes on bridge which implies we've cleaned up the holiday migration set | 17:05 |
clarkb | there are 4 processes that I must've missed yesterday though which I'll clean up momentarily | 17:05 |
*** stzsch has quit IRC | 17:13 | |
*** stzsch has joined #opendev | 17:18 | |
*** rpittau is now known as rpittau|afk | 17:43 | |
*** ttakenak has joined #opendev | 18:02 | |
*** ttakenak has quit IRC | 18:03 | |
openstackgerrit | Clark Boylan proposed opendev/system-config master: Force run-gitea job to fail for human verification https://review.opendev.org/c/opendev/system-config/+/769598 | 18:14 |
clarkb | infra-root I have set an autohold on ^ | 18:15 |
clarkb | that change is based on the gitea 1.13.1 change and it pushes in the local system-config into localhost then fails. This way we can hold the job then verify at least one repo has content and looks as expected | 18:16 |
clarkb | I'm not entirely sure the https push will work eitehr and if that fails thats fine too we'll just have to manually update a repo once we have the held node | 18:19 |
*** dtantsur is now known as dtantsur|afk | 18:27 | |
fungi | weird... https://grafana.opendev.org/d/9XCNuphGk/zuul-status?orgId=1&from=now-6h&to=now shows that we briefly had a 13th zuul executor between 17:18 and 17:32 | 18:40 |
fungi | statsd/graphite error i guess? | 18:40 |
fungi | you can also see the merger count jumped from 20 to 21 for the same timeframe | 18:41 |
clarkb | ya I'm gonna guess that is an averaging thing | 18:41 |
fungi | i don't see any corresponding dips, so it's not like increment/decrement arrived out of order or anything | 18:42 |
*** andrewbonney has quit IRC | 18:56 | |
clarkb | ok 769598 failed to do the push since ssl wasn't verified (we use a self signed cert) | 19:18 |
clarkb | Should be able to get on that host then do the push against with GIT_SSL_NO_VERIFY set. I'll look into that a bit later today after lunch | 19:19 |
*** DSpider has quit IRC | 20:13 | |
*** whoami-rajat__ has quit IRC | 20:21 | |
prometheanfire | can I get a second view on https://review.opendev.org/768785 (glean) and possibly a relase once merged, gentoo glean is broken and it'd be nice to get the linked review in as well | 20:42 |
* fungi checks | 20:44 | |
prometheanfire | lol | 20:45 |
fungi | ahh, yeah, i already reviewed that so not helping | 20:45 |
prometheanfire | was going to mention you already looked, but didn't want to ping you about something you can't help with :P | 20:45 |
* fungi apologizes for being helpfully unhelpful | 20:46 | |
prometheanfire | fungi: you haven't looked at https://review.opendev.org/762339 :P | 20:50 |
clarkb | prometheanfire: fungi I'm not sure the new code is correct either? /etc/hosts allows any whitespace delineation | 20:54 |
clarkb | this will only work if a single space is used | 20:54 |
clarkb | I'm not sure how big of aconcern that is but that may be a reason to use a regex? | 20:55 |
prometheanfire | /etc/hosts will be initialized via glean, so it'll be written out with a space, if modified after that it could be more of a concern, but not sure if that's in scope | 20:56 |
clarkb | prometheanfire: for the magic mock does it just return '' for every read while iterating? | 20:58 |
clarkb | or maybe returns one '' then eofs? | 20:58 |
clarkb | (want to make sure I understand the test change there) | 20:58 |
prometheanfire | that's the way I understand it (1 '' then eofs) | 20:58 |
fungi | like magic | 20:59 |
prometheanfire | I am not the expert on mock, or really python in general | 20:59 |
clarkb | ya that makes more sense otherwise it would never end the iteration | 20:59 |
fungi | yeah, honestly test mocks are black magic to me as well | 20:59 |
fungi | which is part of why i didn't just single-core approve that change | 20:59 |
clarkb | fungi: do you think the whitespace handling in the /etc/hosts line check is a problem or are we ok with matching what we write and if duplicates end up there due to user intervetion that is their problem? | 20:59 |
fungi | clarkb: i think it's fine until we find out it isn't, and then we can fix it | 21:00 |
clarkb | ok | 21:00 |
fungi | i honestly didn't think about it | 21:00 |
prometheanfire | right now it's writing a new set of host entries every reboot for me | 21:01 |
fungi | it's not hard to switch to a re.match() or something though if needed | 21:01 |
clarkb | I'm going to reboot to apply updates then dig up credentials and can approve it | 21:01 |
prometheanfire | thanks | 21:01 |
*** sboyron has quit IRC | 21:02 | |
clarkb | one last question (just thinking out loud) r+ is like r + a modes right? | 21:15 |
clarkb | it doesn't truncate and the write pointer is at eof? | 21:15 |
clarkb | the python docs don't really clarify that second bit, it does say it doesn't truncate which is probably good enough as order doesn't matter here I don't think | 21:15 |
clarkb | but I can test this really quickly | 21:15 |
clarkb | ya it does not append it prefixes | 21:16 |
clarkb | fungi: prometheanfire does that matter? | 21:16 |
prometheanfire | clarkb: I think r+ is more rw | 21:17 |
clarkb | ya I think you may want a+ ? | 21:18 |
clarkb | to append rather than prefix | 21:18 |
clarkb | testing a+ seems to do what I would expect | 21:18 |
prometheanfire | ok, I'll push that up | 21:19 |
clarkb | I don't think it truly matters but will help keep the glean stuff later in the file after any preexisting system stuff | 21:19 |
clarkb | which will be nice for users | 21:19 |
prometheanfire | yep | 21:20 |
openstackgerrit | Matthew Thode proposed opendev/glean master: add hosts entries and ssh keys only once https://review.opendev.org/c/opendev/glean/+/768785 | 21:20 |
clarkb | prometheanfire: hrm actually a+ reads don't work | 21:24 |
clarkb | ugh | 21:24 |
clarkb | they read at eof too I think | 21:24 |
prometheanfire | lol | 21:24 |
prometheanfire | so, r+ then? | 21:24 |
clarkb | no ithink you want a read handle and a write handle | 21:24 |
clarkb | read from from beginning to end of file and if not present then append | 21:24 |
clarkb | er then append using another file object opened with a | 21:25 |
prometheanfire | that's what it's currently doing, I was hoping to use just one file object | 21:25 |
clarkb | I don't think python's file objects do read and write pointers at different places? at least that seems to be the issue with a+ | 21:25 |
prometheanfire | right | 21:26 |
prometheanfire | how it's written now (with r+) is to do the writes at the end of file, I think | 21:27 |
fungi | clarkb: worth noting, the code there iterates over the entire file and then writes, so it's in essence a+ | 21:27 |
fungi | i did at least double-check that by hand | 21:27 |
clarkb | fungi: oh ok ya I was missing that | 21:27 |
fungi | is works as expected | 21:27 |
prometheanfire | so... r+ then? | 21:27 |
fungi | the file cursor is already at the eof when the write() call happens | 21:27 |
clarkb | prometheanfire: ya the iteration to the end makes it an apend and r+ doesn't truncate so ya sorry tht was correct | 21:27 |
prometheanfire | cool | 21:28 |
openstackgerrit | Matthew Thode proposed opendev/glean master: add hosts entries and ssh keys only once https://review.opendev.org/c/opendev/glean/+/768785 | 21:28 |
clarkb | ok +2'd sorry for that noise. fungi if you want to reapply your +2 then approve I'm happy with that | 21:30 |
fungi | sure | 21:34 |
*** hashar has quit IRC | 22:23 | |
*** tosky has quit IRC | 23:51 | |
openstackgerrit | Merged opendev/glean master: add hosts entries and ssh keys only once https://review.opendev.org/c/opendev/glean/+/768785 | 23:52 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!