Friday, 2021-03-19

*** mlavalle has quit IRC00:03
openstackgerritMerged opendev/system-config master: borg-backup-server: fix verification run
openstackgerritMerged opendev/system-config master: kerberos-kdc: add database backups
openstackgerritMerged opendev/system-config master: system-config-run-kerberos: run twice
*** tosky has quit IRC00:14
ianwopendev-prod-hourly has something seeminly stuck for 13 hr 23 min00:18
ianwit doesn't seem to have any jobs00:19
fungiso not blocking/blocked on a mutex00:19
ianwjust a sort of zombie entry00:21
openstackgerritMerged opendev/system-config master: Update nodepool launchers to focal in testing
ianw * ERROR: sys-block/open-iscsi-2.0.875::gentoo failed (compile phase):00:51
ianw2021-03-18 23:57:46.686 |  *   emake failed00:51
prometheanfireurl not all on one line, but I'll take a look00:53
prometheanfireopen-iscsi always seems to have problems and upstream tends to not care00:53
ianw is the job00:54
prometheanfirehmm, I'm guessing it's gcc-10 not liking open-iscsi00:57
prometheanfirewithout knowing00:57
fungisounds like a safe bet00:58
prometheanfire2021-03-18 23:57:46.686 | [01m[Kiscsiadm.c:859:56:[m[K [01;35m[Kwarning: [m[Karray subscript 2147483647 is outside the bounds of an interior zero-length array ‘[01m[Kstruct iscsi_stats_custom[0][m[K’ [[01;35m[K]8;;]8;;[m[K]00:59
prometheanfireheh, yep00:59
prometheanfiregonna build a image local to see if we can just use a newer version of open-iscsi01:01
prometheanfirehmm, built here01:15
prometheanfire2021-03-19 01:15:25.533 | >>> Installing (3 of 3) sys-block/open-iscsi-2.0.875::gentoo01:16
prometheanfireoh, binary01:16
prometheanfirelooks like I need to clean that up to match your fresh build :D01:16
*** hamalq has quit IRC01:39
*** lbragstad has quit IRC02:06
prometheanfireok, error reproduced02:24
prometheanfirelooks like the version we were using was remved from tree and it reverted to installing an earlier version02:27
prometheanfireso... it'll be a new release I think, I'll submit a review in a min02:28
*** hemanth_n has joined #opendev02:57
*** hemanth_n has quit IRC03:37
*** hemanth_n has joined #opendev03:38
ianwAnsibleUndefinedVariable: 'refstack_url' is undefined03:53
ianwfrom the refstack deploy job03:53
openstackgerritIan Wienand proposed opendev/system-config master: Rename refstack group variables
*** JayF has quit IRC04:00
*** JayF has joined #opendev04:01
openstackgerritMatthew Thode proposed openstack/diskimage-builder master: update gentoo keywords to support gcc-10
*** ykarel has joined #opendev04:59
openstackgerritIan Wienand proposed opendev/system-config master: Rename refstack group variables
ianwclarkb: if you could look at ... that's currently applied manually so good to get it merged05:10
openstackgerritMerged openstack/project-config master: Use nodejs8-publish-to-npm for monasca-grafana-datasource
openstackgerritMerged openstack/project-config master: Normalize projects.yaml
*** marios has joined #opendev06:02
*** ysandeep|away is now known as ysandeep06:15
*** elod is now known as elod_afk06:31
*** lpetrut has joined #opendev06:42
*** ykarel has quit IRC07:00
*** ykarel has joined #opendev07:02
*** sboyron has joined #opendev07:19
*** hashar has joined #opendev07:30
*** ysandeep is now known as ysandeep|lunch07:35
*** fressi has joined #opendev07:45
*** brinzhang0 has joined #opendev07:59
*** brinzhang_ has quit IRC08:01
*** rpittau|afk is now known as rpittau08:24
*** whoami-rajat_ has joined #opendev08:36
*** whoami-rajat_ is now known as whoami-rajat08:44
*** elod_afk is now known as elod08:48
*** andrewbonney has joined #opendev08:51
*** tosky has joined #opendev08:54
*** ykarel has quit IRC09:11
*** roman_g has joined #opendev09:23
*** ysandeep|lunch is now known as ysandee09:40
*** ysandee is now known as ysandeep09:56
*** ricolin has quit IRC10:01
*** hashar has quit IRC10:37
*** ykarel|lunch has joined #opendev10:45
openstackgerritLee Yarwood proposed opendev/elastic-recheck master: Add query for bug #1920136
openstackbug 1920136 in devstack "tempest-integrated-compute - c-sch/c-vol reporting insufficient free virtual space" [Undecided,In progress] - Assigned to Lee Yarwood (lyarwood)10:48
*** dtantsur|afk is now known as dtantsur10:52
*** ykarel|lunch is now known as ykarel11:06
dtantsurianw: hi! your patch does not work as it is, I think systemd-udev-settle is not triggered by default11:26
dtantsurI'm trying adding Wants on it11:26
dtantsuroh, hmm, and I think the path is wrong too11:34
dtantsurianw: will you object if I update your patch after my testing?11:35
openstackgerritMerged zuul/zuul-jobs master: Upgrade ansible-lint to 5.0
*** priteau has joined #opendev11:38
openstackgerritDmitry Tantsur proposed opendev/glean master: Override NetworkManager to wait for udev-settle
openstackgerritDmitry Tantsur proposed opendev/glean master: Allow disabling DHCP fallback
*** sboyron has quit IRC11:56
openstackgerritDmitry Tantsur proposed openstack/diskimage-builder master: simple-init: allow disabling DHCP fallback
*** hemanth_n has quit IRC11:59
*** roman_g has quit IRC12:03
*** roman_g has joined #opendev12:03
*** roman_g has quit IRC12:03
*** roman_g has joined #opendev12:04
*** roman_g has quit IRC12:04
*** roman_g has joined #opendev12:05
*** roman_g has quit IRC12:05
dtantsurianw, clarkb, I hope these three patches ^^^ solve my struggles finally12:06
*** ykarel has quit IRC12:06
*** ykarel has joined #opendev12:07
*** roman_g has joined #opendev12:07
*** roman_g has joined #opendev12:08
*** roman_g has quit IRC12:08
*** lbragstad has joined #opendev12:22
*** ysandeep is now known as ysandeep|afk12:27
*** zbr is now known as zbr|rover12:30
*** ykarel has quit IRC12:35
*** ykarel has joined #opendev12:35
openstackgerritDmitry Tantsur proposed opendev/glean master: Add Python 3.6 to supported versions
*** roman_g has joined #opendev13:00
*** lbragstad_ has joined #opendev13:25
*** fressi_ has joined #opendev13:26
*** ysandeep|afk is now known as ysandeep13:27
*** dhellmann_ has joined #opendev13:28
*** gothicserpent_ has joined #opendev13:30
*** brinzhang0 has quit IRC13:30
*** calcmandan_ has joined #opendev13:30
*** brinzhang0 has joined #opendev13:31
*** lbragstad has quit IRC13:33
*** fressi has quit IRC13:33
*** irclogbot_3 has quit IRC13:33
*** dhellmann has quit IRC13:33
*** gothicserpent has quit IRC13:33
*** openstackgerrit has quit IRC13:33
*** calcmandan has quit IRC13:34
*** fressi_ is now known as fressi13:34
*** dhellmann_ is now known as dhellmann13:34
*** irclogbot_1 has joined #opendev13:35
*** mlavalle has joined #opendev13:58
*** hashar has joined #opendev14:06
*** sboyron has joined #opendev14:18
dtantsurFolks, I see a very annoying (and likely new) behavior in Gerrit UI: when you click "Reply", the focus on the "Reviewers" field, not on the message14:26
fungithat's interesting14:46
fungiyou haven't noticed that before today?14:46
dtantsurNo. I wasn't paying attention, but given how annoying I find it now, I would have noticed.14:47
fungii'm wondering if a behavior change crept into their stable-3.2 branch. we continuously build and deploy images of that14:49
*** gothicserpent_ is now known as gothicserpent14:51
louroto/ I'm getting an openstack-zuul-jobs-linters failure that isn't caused by my review I think, what do you think?
*** ykarel has quit IRC14:53
iurygregorylourot, yeah I just noticed the same problem on my patch =)14:57
*** roman_g has quit IRC15:02
*** roman_g has joined #opendev15:03
*** roman_g has quit IRC15:03
clarkbfungi: dtantsur: note it isn't truly continuous, we have to land changes to our gerrit image files which causes rebuilds. I think it has been a few weeks since our last rebuild15:03
fungiokay, so if it's a new behavior in gerrit, it's been this way at least a few weeks15:03
dtantsurhmm, maybe I've just noticed.. I mostly use gertty15:04
fungiyeah, i use gertty almost exclusively15:04
clarkblourot: iurygregory: ../../zuul/zuul-jobs/roles/revoke-sudo/tasks/main.yaml:10: [E302] rm used in place of argument state=absent to file module <- I wonder why that job is linting the zuul-jobs content15:05
clarkbI suspect something changed in zuul-jobs causing those failures, but ozj shouldn't care about zuul-jobs content15:05
fungi Upgrade ansible-lint to 5.015:05
fungithat just merged15:05
clarkbfungi: this is running ansible-lint on ozj though and examining zuul-jobs files15:06
clarkber project-config I Guess15:06
clarkbwhich shouldn't try and lint zuul-jobs15:07
fungiyeah, just wondering if ansible-lint 5.0 changed how files are included/excluded15:08
*** ysandeep is now known as ysandeep|dinner15:08
clarkbbut if the job ran on project-config it shouldn't matter what version of ansile-lint zuul-jobs uses15:08
*** ykarel has joined #opendev15:08
*** rpittau is now known as rpittau|afk15:08
clarkbI think I see why it looks at zuul-jobs though. we set ANSIBLE_ROLES_PATH={env:ANSIBLE_ROLES_PATH:../zuul-jobs/roles:../openstack-zuul-jobs/roles:roles}15:09
clarkbI feel like this is a bug in ansible-lint15:09
clarkbthis would effectively force all of your third party roles to lint clean15:10
fungii'm wondering if it changed a default ansible-lint version in the job we're running15:10
clarkbwhich just isn't a sustainable approach15:10
clarkbproject-config seems to set ansible-lint>=4.2.0,<515:10
fungioh, yeah. and now i see what you're saying... why are we linting ../../zuul/zuul-jobs/roles/ in a project-config change?15:11
zbr|roveri can give some insights on v515:11
clarkbv5 is not relevant15:11
clarkbwe are using 4.3.715:11
*** lbragstad_ is now known as lbragstad15:11
clarkbthe problem is we set ANSIBLE_ROLES_PATH and ansible-lint lints the files in the roles path in addition to the specific files we have told it to lint. I don't think this is a viable approach ebcause you cannot expect third party roles to adhere to the same linter rules as your ansible15:12
clarkb(it is possible that ansible-lint is finding those roles through some other mechanism but the one that seems most likely is the ANSIBLE_ROLES_PATH var we set)15:13
clarkbif v5 fixes this behavior we could upgrade to it, but I don't think v5 is involved in causing the behavior we see15:14
zbr|roverlikely it does, but you can also add `../../zuul` to ignore path, it should work with older versions15:15
zbr|roveron v5, if you do not feed it any arguments, it will only lint what git ls-files reports, ignoring untracked stuff, one benefit being that the chance to need excludes is considerably lower.15:17
clarkbwe lost openstackgerrit but remote: Stop linting zuul-jobs from here15:21
clarkbI've restarted gerrit bot15:24
*** chkumar|ruck is now known as raukadah15:24
lourotthanks for the quick reaction!15:25
*** fressi has quit IRC15:26
fungiclarkb: so what's the theory on the regression? we've been linting the content of the zuul-jobs repo in our project config changes all along, but some of the content in zuul-jobs changed and the version of ansible-lint we're running no longer likes it?15:29
clarkbfungi: yes, I think zuul-jobs was following the project-config rules until recently and now linting on project-config complains15:31
clarkbI suspect something changed either in the linter or in zuul-jobs15:31
fungiprobably the changes made to zuul-jobs to satisfy ansible-lint 5 in that case, given the timing15:32
*** openstackgerrit has joined #opendev15:32
openstackgerritClark Boylan proposed opendev/system-config master: Upgrade gitea to 1.13.4
openstackgerritClark Boylan proposed opendev/system-config master: Force gitea to fail for human verification
zbr|roversomething is weird as zuul-jobs errors should have never ended up being reported and based on the existing config which already has ../../opendev but not zuul jobs.15:34
clarkbzbr|rover: zuul jobs are in ../../zuul/zuul-jobs not ../../opendev15:34
clarkbI suspect we ran into this with opendev/base-jobs as well15:35
clarkbfixed it there and moved on. And now we are seeing it for zuul-jobs too15:35
fungiyeah, that seems increasingly likely then15:35
clarkbI've set a hold on the gitea job for 78177615:36
clarkbwe can use that to check on gitea upgrade results15:36
clarkb(though it does a fresh install not an upgrade)15:36
zbr|roverif any of you want me to make CR to upgrade the linter on another repo, let me know. zuul-jobs was an interesting experience, but I endup migrating both custom rules to the linter, making much easier to maintain.15:39
clarkbif we think that v5 will fix this issue then upgrading is probably worth looking at15:42
*** sboyron has quit IRC15:42
clarkbfungi: is there a gerritbot change to ignore messages for commits that are too long?15:43
clarkb(also are people writing commit messages that are too long frequently because we aren't helping them learn to write better ones? I wonder if we shoudl also try to reach out to people doing that015:43
fungiclarkb: no, not yet, i wanted to take it as an opportunity to try to fix the reconnect behavior as well15:43
toomerclarkb: Do you know if it's posible to migrate Gerrit user from one externalId(OAuth) to another externalID(SAML)16:04
clarkbtoomer: yes, you create an externalid in All-Users:refs/external-ids with the right hashed path for the externalid value and ensure the accountId is set properly in that file. You need to reindex accounts if you do that change with gerrit offline16:05
clarkbtoomer: the docs are not good on this stuff and I've been trying to think of ways to improve them as I work through our gerrit account consistency cleanups (as its a similar process)16:06
clarkbif you are using pre notedb gerrit for accounts then you just update the account_external_ids db table16:06
toomerI'm using NoteDB and woneering if something like that is even posible16:07
toomerThere is not much documentation about this proccess on Internet16:07
toomerDo you have any notes that could help me here ?16:07
clarkbtoomer: ya there was a thread that andrew grimburg wrote on for account cleanups but the processes are similar. Let me find that for you16:08
toomerIs that mean I will need to create an externalID for existing user with right hash but without password16:10
openstackgerritMerged openstack/project-config master: Stop linting zuul-jobs from here
clarkbtoomer: yes, each openid/oath/saml/email/etc is a separate exteranl id16:11
clarkbthat externalid is located in a file named after a hashed value for the id itself16:11
clarkbthen in that file it has data like which account does this id belong to16:11
toomerEven when the same emial address is used16:11
toomerJust the authentication protocol change: OATH --> SML16:11
clarkbtoomer: that is my original thread, is Andrew's older info on how to address it16:12
clarkbtoomer: yes, since the files are keyed by the exteranlid value not their attributes (like email or account id)16:12
clarkbtoomer: also note that you can't have different accounts with the same emails in external ids. THis is the problem I am not cleaning up16:12
toomerclarkb: Thanks a LOT again !16:12
clarkbI have ~545 conflicts to address on that problem :(16:12
clarkbbut that is down from like 750 conflicts in total so slow progress16:13
*** ysandeep|dinner is now known as ysandeep16:13
toomerI will take a look on those note and see if I can make that worked16:13
fungitoomer: yeah, to reiterate, the main thing to keep in mind is that you need to know the new id you're migrating to ahead of time so you can pre-add it to the account16:14
*** brinzhang0 has quit IRC16:14
toomerWhat you mean by new ID ?16:14
clarkbdtantsur: fungi: I just rechecked the project-config changes above since their fix has landed. When I did so I copy pasted the recheck comment and it went straight into the message not the reviewers field. The issue is probably more subtle than the focus is always wrong16:14
fungibasically when the user logs in with the new id, you want gerrit to find there's already a record for that and use it, not rely on gerrit to create the id16:14
*** brinzhang0 has joined #opendev16:15
clarkbin your case sounds like the new ID would be the new SAML ID16:15
toomerfungi Exactly, this is what I need16:15
dtantsuryeeah.. I have 4 pages with Gerrit open, I see the issue on 2 of them16:15
openstackgerritAurelien Lourot proposed openstack/project-config master: Mirror new Magnum and Manila charms to GitHub
fungiright, that. basically know the saml ids of your users in advance, and then add those to gerrit manually associated with their accounts. gerrit will almost certainly not do the right thing if you rely on it to just notice the e-mail addresses are the same or something16:16
clarkblourot: note you didn't need to rebase. Zuul will do that for you16:16
dtantsuronly on one after refresh16:16
clarkbdtantsur: those are the best bugs16:16
*** ykarel has quit IRC16:16
dtantsurit is with can it be because it has no reviewers yet?16:16
*** ykarel has joined #opendev16:17
toomerLooks like you are Gerrit experts on this stage. I assume you have lots of diffrent kind of Gerrit issues in OpenDev16:17
clarkbdtantsur: if I reivew that one I get a cursor in the message box not reviewers list. I don't think that is it, but maybe it is a component of the issue?16:17
dtantsurclarkb: maybe it has to be your review?16:17
clarkbdtantsur: ya maybe that is it let me see if I have one I can check like that16:18
clarkbtoomer: I don't know that we are experts, we certainly try though :) the upstream mailing list is pretty responsive though a lot of issues around account management have been reported over time and not a ton of improvements have been made that I can see16:18
clarkbdtantsur: yup if I review my cursor goes to the reviewers16:19
clarkbnow let me add fungi and see if it fixes it (sorry fungi if that generates eamil noise for you)16:19
toomerclarkb: Yes, the user managment in Gerrit is none exsitent16:19
clarkbdtantsur: fungi  yup now my cursor goes to the message field. NEAT16:20
dtantsurheh, it may even make sense in some workflows16:20
fungii have lots of e-mail noise already. you're spitting into the ocean there16:20
dtantsurnext time I tag you on a review, I can claim that gerrit forced me :)16:20
*** ykarel is now known as ykarel|away16:29
*** hashar has quit IRC16:33
*** lpetrut has quit IRC16:47
*** ysandeep is now known as ysandeep|away16:50
openstackgerritJeremy Stanley proposed openstack/project-config master: Use Node 10 to release monasca-grafana-datasource
openstackgerritClark Boylan proposed opendev/system-config master: Force gitea to fail for human verification
*** marios is now known as marios|out17:17
*** dtantsur is now known as dtantsur|afk17:21
*** ykarel|away has quit IRC17:31
*** marios|out has quit IRC17:32
openstackgerritClark Boylan proposed opendev/system-config master: Set up gitea image provides and requires for gating
clarkbcorvus: fungi ^ can you double check the assertions in that change? but i think that may address some weirdness with testing of the new gitea version that I have noticed.17:35
clarkbI can also redo the stack for new gitea to exercise ^ if we land it17:35
corvusclarkb: any job ordering changes needed for that?17:37
corvus(i'm checking too right now; but just wondering if you'd gone through those already)17:38
corvuslooks like run-gitea depends on registry, build-image-gitea and build-image-haproxy-statsd; so i think that's all good17:39
clarkbya I think that was already in place so it worked fine at a buildset level17:39
clarkbbut not across changes17:39
fungiyeah, i think the prior behavior would have been to use the image from that same buildset if there was one, otherwise use the published image?17:41
clarkbyes I think that is what I was observing17:41
*** hamalq has joined #opendev17:41
fungiso this should let you consume an image built in a depended-on change17:41
clarkbor even a git parent child change17:41
fungier, yeah17:41
fungiexplicit or implicit change dependency, either one17:42
fungialso change ahead of it in a dependency queue17:42
fungiany of the above17:42
*** sboyron has joined #opendev17:43
*** andrewbonney has quit IRC17:50
clarkbhttps:// that was with the forced rebuild in the child job18:28
clarkblooks fine to me. I would like to redo it though with 781830 in place18:29
*** hamalq has quit IRC18:36
*** hamalq has joined #opendev18:36
openstackgerritMerged openstack/project-config master: Use Node 10 to release monasca-grafana-datasource
fungiclarkb: so i *think* i see the problem with
fungiwe should be calling
*** whoami-rajat has quit IRC19:00
fungithe factory in doesn't have a reconnect() method19:01
fungiwe're subclassing which doesn't expose that19:07
fungianyway, about to start driving again, so i'll pick this up again when i'm back at the house19:08
fungiahh, okay the method is actually defined at irc.client.ServerConnection.reconnect() and the irc.client.SimpleIRCClient we subclass has access to the irc.client.Reactor methods where SimpleIRCClient.connection is an instance of ServerConnection19:47
fungiso calling self.reconnect() from is legitimate, that method should exist, it just isn't properly reconnecting for some reason. i wonder if the sasl/ssl mix-in classes are involved19:50
fungilike maybe the saved connection context isn't actually including the auth or encryption19:50
fungioh, OR it could be that we're just failing to clear the joined_channels structure when we reconnect and so it assumes it's already in channels and doesn't bother rejoining them19:51
fungii wonder if simply inserting self.joined_channels = {} before the self.connection.reconnect() would fix this19:52
fungithis may turn out to be a regression from when we added the dynamic joining and unjoining19:54
openstackgerritGage Hugo proposed opendev/irc-meetings master: Update security sig frequency and chair
*** sboyron has quit IRC20:18
openstackgerritMerged opendev/irc-meetings master: Update security sig frequency and chair
clarkbfungi: oh neat21:05
clarkbfungi: also doing an explicit disconnect, cleanup, then connect seems reasonable if that reads better21:05
fungii think that's all reconnect does anyway, the connect method is supposed to replace the current connection, and i'm starting to think that's working fine. freenode logs that the client quit, the client doesn't log any errors21:10
clarkbdoes anyone know how and avoided merge conflicting?21:16
clarkbdoes (j)git see they both produce the same end state so doesn't consider it a conflict?21:16
clarkbI don't think this is wrong in this case, mostly just surprising and wanted to see if anyone knew how that happens in a (j)git context21:17
fungii think so. at least that's how (c)git works21:17
fungiif i cherry-pick a commit which makes some changes which are already present in my tree, those changes are skipped silently21:18
fungii rarely call git merge myself, but expect it uses the same conflict resolution mechanisms21:18
fungisame conflict resolution mechanisms as cherry-pick i mean21:19
clarkbI put those test update changes up separate to the actual flip over cahnges because the test only chagnes were useful to ensure there weren't any problems upfront21:20
clarkbbut then it was awkward to try and do the coordination of the changes in that context21:20
clarkbanyway shouldn't be a problem just thought it surprising21:20
*** openstackgerrit has quit IRC21:22
fungii'm fiddling with gerritbot btw, in case anyone notices exit messages. i'll keep it running21:24
*** openstackgerrit has joined #opendev21:35
openstackgerritJeremy Stanley proposed opendev/gerritbot master: DNM: Triggering a gerritbot event
*** openstackgerrit has quit IRC21:35
*** openstackgerrit has joined #opendev21:37
*** openstackgerrit has joined #opendev21:37
openstackgerritJeremy Stanley proposed opendev/gerritbot master: DNM: Triggering a gerritbot event
fungiclarkb: yep! that was precisely it. fix for that on the way, along with one to ignore that particular exception and not reconnect when it's seen21:38
openstackgerritJeremy Stanley proposed opendev/gerritbot master: Explicitly clear joined channels when reconnecting
openstackgerritJeremy Stanley proposed opendev/gerritbot master: Don't reconnect on MessageTooLong exceptions
fungigotta love tracking down bugs which result in nothing being logged as amiss, and discovering that's because nothing actually was as far as the script was concerned21:52
fungiinfra-root: ^ i think a lot of our mysterious "dunno netsplit maybe?" events where gerritbot never came back was that, it's been happening upwards of a few times a week21:53
fungihopefully that's time well-spent since it should save us time constantly restarting gerritbot21:53
clarkb++ any idea if there are users we need to help with commti writing suggestions (I would guess your log inspection would expose that maybe?)21:54
funginot really... it seems to be a mix of new users who don't realize commit messages need a separate subject, and users who just forget to add a blank line after the subject21:55
fungion projects where gerrit is enforcing a max commit message subject length this probably never comes up21:55
fungithe container on eavesdrop is currently running with 781919 hand patched in21:57
fungiand i exercised it with a couple of do-not-merge changes just to make sure it behaved as suspected21:57
openstackgerritJeremy Stanley proposed opendev/gerritbot master: Don't reconnect on MessageTooLong exceptions
fungiadded a log message22:05
clarkbfungi: do you know why testing failed on ps1?22:07
fungii do not, saw the py37 job failed but haven't checked the log yet22:08
fungicurious to see if it also fails on the other change22:08
fungiahh, nope, it passed on the first change22:08
*** dpawlik has quit IRC22:11
*** gothicserpent has quit IRC22:11
*** lbragstad has quit IRC22:11
*** akahat has quit IRC22:11
fungiaha, my mistake ;)22:12
fungiModuleNotFoundError: No module named 'irc.client.MessageTooLong'; 'irc.client' is not a package22:12
clarkboh you need from irc.client import MessageTooLong22:12
fungijftr, that's the change i didn't test ;)22:12
clarkbor just import irc.client22:12
*** brinzhang_ has joined #opendev22:12
fungii need to see if it has side effects first22:12
*** lbragstad_ has joined #opendev22:12
*** Dmitrii-Sh8 has joined #opendev22:12
*** dpawlik9 has joined #opendev22:12
fungilooks like it's all function defs and classes, so no side effects22:12
*** dpawlik9 is now known as dpawlik22:13
openstackgerritJeremy Stanley proposed opendev/gerritbot master: Don't reconnect on MessageTooLong exceptions
*** Dmitrii-Sh has quit IRC22:13
*** janders has quit IRC22:13
*** Dmitrii-Sh8 is now known as Dmitrii-Sh22:13
*** brinzhang0 has quit IRC22:13
*** tobiash has quit IRC22:13
*** tobiash has joined #opendev22:14
*** mgoddard has quit IRC22:16
*** jpena|off has quit IRC22:16
*** gothicserpent has joined #opendev22:16
*** jpena|off has joined #opendev22:18
*** akahat has joined #opendev22:19
*** sshnaidm|off has quit IRC22:54
*** hamalq has quit IRC23:05
*** tkajinam has quit IRC23:27
*** mlavalle has quit IRC23:37
*** stand has quit IRC23:47

Generated by 2.17.2 by Marius Gedminas - find it at!