*** mlavalle has quit IRC | 00:03 | |
*** DSpider has quit IRC | 00:24 | |
*** avass has quit IRC | 00:26 | |
*** hamalq has quit IRC | 01:53 | |
*** zul has quit IRC | 03:15 | |
*** diablo_rojo has quit IRC | 03:52 | |
*** ykarel has joined #opendev | 04:15 | |
*** vishalmanchanda has joined #opendev | 04:29 | |
*** whoami-rajat has joined #opendev | 04:57 | |
*** snapdeal has joined #opendev | 05:02 | |
*** marios has joined #opendev | 05:07 | |
*** snapdeal has quit IRC | 05:17 | |
*** ralonsoh has joined #opendev | 05:18 | |
*** ysandeep|away is now known as ysandeep | 05:29 | |
*** eolivare has joined #opendev | 06:24 | |
*** sboyron has joined #opendev | 06:25 | |
*** amoralej|off is now known as amoralej | 06:33 | |
*** kopecmartin has quit IRC | 06:34 | |
*** tinwood has quit IRC | 06:37 | |
*** tinwood has joined #opendev | 06:40 | |
*** lpetrut has joined #opendev | 06:40 | |
*** kopecmartin has joined #opendev | 06:46 | |
*** HeroicHitesh has joined #opendev | 06:55 | |
*** zbr has quit IRC | 06:56 | |
*** zbr has joined #opendev | 06:58 | |
*** avass has joined #opendev | 07:00 | |
*** ykarel_ has joined #opendev | 07:00 | |
*** ykarel has quit IRC | 07:02 | |
*** ykarel_ has quit IRC | 07:15 | |
*** andrewbonney has joined #opendev | 07:15 | |
*** ykarel has joined #opendev | 07:17 | |
*** jpena|off is now known as jpena | 07:30 | |
*** rpittau|afk is now known as rpittau | 07:32 | |
*** tosky has joined #opendev | 07:39 | |
*** HeroicHitesh has quit IRC | 08:05 | |
frickler | fungi: creating an ed25519 key should work using the "--expert" option, so given the change in default (which I hadn't seen yet), I think I'd be fine with just switching completely | 08:14 |
---|---|---|
*** ykarel is now known as ykarel|lunch | 08:44 | |
*** ykarel|lunch has quit IRC | 08:48 | |
openstackgerrit | Merged opendev/infra-manual master: Update branch creation for PolyGerrit https://review.opendev.org/c/opendev/infra-manual/+/786512 | 08:50 |
*** ykarel has joined #opendev | 09:38 | |
*** dtantsur|afk is now known as dtantsur | 10:04 | |
*** roman_g has joined #opendev | 10:41 | |
*** ysandeep is now known as ysandeep|afk | 10:53 | |
*** cloudnull has quit IRC | 11:09 | |
*** cloudnull7 has joined #opendev | 11:09 | |
*** jpena is now known as jpena|lunch | 11:32 | |
*** ysandeep|afk is now known as ysandeep | 11:44 | |
*** roman_g has quit IRC | 12:13 | |
*** jpena|lunch is now known as jpena | 12:30 | |
*** auristor has quit IRC | 12:38 | |
*** auristor has joined #opendev | 12:42 | |
*** amoralej is now known as amoralej|lunch | 13:18 | |
fungi | frickler: great, i'll work on that today. thanks for the suggestion! | 13:26 |
*** ysandeep is now known as ysandeep|away | 13:47 | |
*** bhagyashris is now known as bhagyashris|away | 13:49 | |
*** amoralej|lunch is now known as amoralej | 13:51 | |
*** hashar has joined #opendev | 14:01 | |
*** ykarel has quit IRC | 14:03 | |
*** brinzhang_ has quit IRC | 14:08 | |
*** brinzhang_ has joined #opendev | 14:09 | |
*** rpittau is now known as rpittau|afk | 14:18 | |
*** lpetrut has quit IRC | 14:26 | |
clarkb | catching up on the two things I wanted to get rolling today (zk replacements and gerrit 3.2.8 update) I'm not sure we're ready for either :/ Airship release is still ongoing aiui and the zuul plugin fix hasn't been responded to by luca | 14:41 |
*** HeroicHitesh has joined #opendev | 15:11 | |
*** HeroicHitesh has quit IRC | 15:22 | |
*** ykarel has joined #opendev | 15:35 | |
*** hashar has quit IRC | 15:41 | |
*** amoralej is now known as amoralej|off | 15:43 | |
clarkb | fungi: ok I can see in the jeepyb job log that gerrit set-project-parent is called but then later when listing the parent it says it is still All-Projects. We are running manage-projects multiple times and now I wonder if the project parent is going in the acl file and if so we're overwriting it | 15:51 |
clarkb | if that is the case then I think we may be able to just drop these changes and use the acl file directly to set this ifno | 15:51 |
fungi | yeah, that's an idea. we can try setting a parent and see what change that makes to the acl in git | 15:52 |
fungi | the docs didn't indicate that it was stored there, but i wouldn't be surprised if it actually is | 15:52 |
fungi | i'll give that a shot momentarily | 15:52 |
clarkb | fungi: ok | 15:52 |
fungi | clarkb: bingo! you're a genius | 15:59 |
fungi | [access] | 15:59 |
fungi | inheritFrom = openstack/meta-config | 15:59 |
fungi | change coming up | 15:59 |
clarkb | cool, I felt like I was going crazy yesterday when I couldn't get things to work :) | 16:00 |
clarkb | but then this morning it occurred to me that ^ may be happening | 16:00 |
fungi | that was exactly what was going on | 16:00 |
*** ykarel has quit IRC | 16:01 | |
*** ykarel has joined #opendev | 16:02 | |
clarkb | fungi: should I abandon the two chagnes I wrote related to this? | 16:06 |
clarkb | I don't expect they provide any value (and in fact would just cause confusion since we manage the acl files directly) | 16:06 |
fungi | clarkb: probably, we can always resurrect them again if they turn out to be needed | 16:06 |
clarkb | done | 16:07 |
fungi | yes | 16:08 |
fungi | heh, wrong terminal! | 16:08 |
openstackgerrit | Jeremy Stanley proposed openstack/project-config master: Allow inheritFrom in Gerrit configs https://review.opendev.org/c/openstack/project-config/+/786685 | 16:08 |
openstackgerrit | Jeremy Stanley proposed openstack/project-config master: OpenStack Release Team ACLs inherit meta-config https://review.opendev.org/c/openstack/project-config/+/786686 | 16:08 |
fungi | that's what i was trying to yes | 16:08 |
fungi | elod: ^ next steps | 16:11 |
clarkb | I +2'd both but left a comment on the second you may want to consider | 16:11 |
fungi | sure | 16:13 |
fungi | i asked in #openstack-release for feedback, but the idea was to test with openstack/release-test | 16:13 |
fungi | however it shares an acl with the rest of the release team deliverables | 16:14 |
fungi | we could use opendev/sandbox i suppose but it's not an openstack repo | 16:14 |
clarkb | fungi: oh in that case maybe split release-test out into its own acl for now? | 16:15 |
clarkb | then it can be folded back if/when all the other repos get the same treatment | 16:16 |
*** marios is now known as marios|out | 16:17 | |
fungi | clarkb: yeah, that was the alternative i suggested in #openstack-release | 16:20 |
*** dtantsur is now known as dtantsur|afk | 16:24 | |
*** hamalq has joined #opendev | 16:28 | |
*** Alex_Gaynor has left #opendev | 16:28 | |
*** hamalq has quit IRC | 16:28 | |
*** hamalq has joined #opendev | 16:29 | |
*** jpena is now known as jpena|off | 16:31 | |
*** marios|out has quit IRC | 16:34 | |
*** ykarel has quit IRC | 16:42 | |
*** ralonsoh has quit IRC | 16:53 | |
*** mlavalle has joined #opendev | 17:11 | |
*** roman_g has joined #opendev | 17:57 | |
*** fressi has left #opendev | 17:58 | |
*** vishalmanchanda has quit IRC | 18:04 | |
*** andrewbonney has quit IRC | 18:05 | |
elod | fungi: oh, thanks for the patch! yes, what clarkb says sounds reasonable, I mean do the test having separate acl for release-test | 18:12 |
elod | and sorry for the late response :S | 18:12 |
clarkb | anyone know if the original stackalytics account is used for anything? it pops up in my account cleanup list | 18:17 |
spotz | Hey all getting an ssl error on https://eavesdrop.openstack.org/ Error code: SSL_ERROR_RX_RECORD_TOO_LONG | 18:19 |
clarkb | spotz: I don't think we ever set up https there | 18:24 |
spotz | clarkb: And I can get there http, but I clicked on a link. Let me go look | 18:24 |
spotz | Ok let me put up a patch:) | 18:25 |
openstackgerrit | Amy Marrich (spotz) proposed opendev/irc-meetings master: Fixed eavesdrop link https://review.opendev.org/c/opendev/irc-meetings/+/786701 | 18:28 |
*** roman_g has quit IRC | 18:35 | |
openstackgerrit | Merged opendev/irc-meetings master: Fixed eavesdrop link https://review.opendev.org/c/opendev/irc-meetings/+/786701 | 18:37 |
openstackgerrit | Jeremy Stanley proposed openstack/project-config master: OpenStack release-test ACLs inherit meta-config https://review.opendev.org/c/openstack/project-config/+/786686 | 18:37 |
fungi | elod: ^ better? | 18:37 |
*** eolivare has quit IRC | 18:38 | |
*** jralbert has joined #opendev | 18:42 | |
clarkb | infra-root in review:~clarkb/gerrit_user_cleanups/notes/proposed-cleanups.20210416 I've put in just under 200 additional cleanups that I think we can make without contacting users. The bulk of these cleanups have been chosen beacuse the account usage was ancient, or the account never had usage then usage started at some point, or it was clear the user had created a number of accounts all at once | 18:47 |
clarkb | and orphaned one or more of them, etc | 18:47 |
clarkb | that said we're getting to where the judgement is more likely to be wrong :) | 18:48 |
clarkb | the audit-results.yaml.20210415 file in the same dir was what I used to make my decisions fwiw if you want to cross check. | 18:48 |
clarkb | I left out accounts where they seemed to be using one account for ssh and another for http. I also left out accounts where the conflicting accounts seemed recently active ~ 2018 was my gauge for that | 18:49 |
clarkb | there were also some cases where I could apply judgement based on what i knew about companies no longer existing etc | 18:50 |
*** whoami-rajat has quit IRC | 18:51 | |
elod | fungi: thanks, as far as I see it's good! :) | 18:55 |
openstackgerrit | Merged openstack/project-config master: Allow inheritFrom in Gerrit configs https://review.opendev.org/c/openstack/project-config/+/786685 | 19:11 |
openstackgerrit | Merged openstack/project-config master: OpenStack release-test ACLs inherit meta-config https://review.opendev.org/c/openstack/project-config/+/786686 | 19:11 |
*** ozzzo has quit IRC | 19:17 | |
*** ozzzo has joined #opendev | 19:27 | |
*** jralbert has quit IRC | 19:47 | |
elod | fungi: I'll try to add a stable/ocata branch to release-test repository. I guess I can do that directly and no need to do it through openstack/releases | 19:54 |
elod | and I'll try to delete that with the script afterwards | 19:54 |
*** smcginnis has quit IRC | 19:54 | |
clarkb | elod: yes you should be able to add the branch through the web ui | 19:55 |
clarkb | https://review.opendev.org/admin/repos/openstack/release-test,branches there | 19:55 |
elod | clarkb: thanks, that worked :] | 19:59 |
clarkb | the deletion too? | 20:01 |
elod | trying now to add a dummy patch and an ocata-eol tag afterwards | 20:03 |
elod | just to have the same things as we will have when running the scripts towards the "real" repos | 20:05 |
elod | clarkb: or do you think it worth to try a delete first on the web gui? | 20:05 |
clarkb | elod: that may be help isolate problems to the script if the script has trobule | 20:06 |
clarkb | not sure if fungi had a plan around testing or he was just going to let you at it :) | 20:06 |
elod | ok, so I've tested the branch deletion first through the web ui (created: stable/delete-me then deleted it) and it worked fine | 20:10 |
fungi | i was happy to let the release team test it | 20:11 |
elod | :] | 20:11 |
fungi | elod: so next steps are probably to update every openstack/ namespace acl with that same inheritFrom = openstack/meta-config | 20:12 |
elod | fungi: before that I'll try to test with the script as well. if I can manage that... | 20:12 |
fungi | oh, yep | 20:12 |
clarkb | fungi: elod: also lets do those updates in batches | 20:13 |
clarkb | I think there is a real risk the manage-projects script will timeout iof we do all the openstack repos at once | 20:13 |
fungi | also the release team should decide if they want any auditing around making sure that acl is inherited by projects the release team oversees (and whether it should just be every acl in that namespace other than meta-config itself, for simplicity) | 20:13 |
clarkb | we should keep project-config out too | 20:16 |
clarkb | it doesn't do releases and really needs to be split anyway | 20:16 |
*** slaweq has quit IRC | 20:29 | |
elod | ok, the script tools/delete_stable_branch.py worked, I was able to delete a dummy branch (stable/delete-elod) with it and couldn't delete (release-test/)stable/ocata from there as it has now an open patch (which I added as a trial patch) | 20:41 |
elod | (though I haven't tried the whole tools/list_eol_stale_branches.sh script) | 20:42 |
fungi | clarkb: right, good point wrt project-config. it's more opendev than openstack but hasn't been moved yet | 20:45 |
elod | ( http://paste.openstack.org/show/804574/ ) | 20:46 |
elod | so now I'll prepare the patches (in batches) for every openstack/* | 20:47 |
elod | there are 337 config under gerrit/acls/openstack/ | 20:52 |
elod | how many can be added in one patch to be on the safe side? | 20:52 |
clarkb | elod: hard to say off the top of my head. Maybe do 25 in a batch? | 20:57 |
clarkb | or maybe just do a single change of 25 and we can look at the timing for it | 20:58 |
clarkb | the cost per project should be fairly stable | 20:58 |
clarkb | since its pull refs/meta/config and update one file, verify things and push back | 20:58 |
clarkb | if you'd like to wait for more data we can inspect the logs and see what typical runtimes for an acl update are | 20:59 |
fungi | also keeping in mind the batches won't be exact. some of those acls are shared by a dozen or more projects | 21:00 |
fungi | so what might be one acl file will end up with a dozen+ project configs pulled and pushed by the script | 21:00 |
clarkb | oh good point | 21:00 |
elod | hmmm :S | 21:01 |
fungi | i don't think it's critical that the batches be of equivalent size, personally | 21:02 |
clarkb | our timeout is 30 minutes | 21:02 |
fungi | trying to make them exactly the same will just waste engineering time | 21:03 |
clarkb | we have had jobs timeout running manage-projects in recent history "neat" | 21:03 |
clarkb | thinking out loud here: we could temporarily bump the timeout up to 3 hours then do 2 batches? | 21:04 |
clarkb | we can also do the update out of band (though I'd like to make the uatomation work if possible) | 21:05 |
fungi | yeah, i'd rather we didn't have to babysit it | 21:05 |
fungi | we can do a few, see how long the deploy job takes, then do the next batch a bit larger/smaller | 21:06 |
clarkb | considering it has already timed out in the last month I think we should bump the timeout either way | 21:07 |
fungi | one tactic might be for elod to put together a list of which projects have requested branch deletions, and prioritize getting those updated in the earlier batches | 21:07 |
clarkb | ++ | 21:07 |
fungi | that way we can take the full conversion at a more measured pace without blocking the branch deletion requests which have been pending for ages | 21:07 |
*** sboyron has quit IRC | 21:08 | |
clarkb | looks like most of the time in the job when run typically is actually spent with gitea. And since we'll only be updating gerrit acls the gitea portion should go quickly | 21:08 |
elod | sounds good! I'll check which projects have ocata-eol tag and propose those in the first batch | 21:09 |
elod | 28 repositories (without puppet-*) | 21:11 |
fungi | you can always split that into two or three batches | 21:11 |
openstackgerrit | Clark Boylan proposed opendev/system-config master: Bump the infra-prod-manage-projects job timeout https://review.opendev.org/c/opendev/system-config/+/786728 | 21:11 |
fungi | we just put those batches first and then do the rest after | 21:11 |
clarkb | thats the timeout bump | 21:11 |
fungi | that's 1h20m | 21:13 |
fungi | what was the default? 30? | 21:13 |
fungi | 40 i guess | 21:13 |
fungi | minutes i mean | 21:13 |
clarkb | it is 30 | 21:13 |
fungi | got it | 21:13 |
openstackgerrit | Elod Illes proposed openstack/project-config master: Move projects under meta-config acl https://review.opendev.org/c/openstack/project-config/+/786735 | 21:22 |
elod | the 1st batch ^^^ | 21:23 |
elod | btw, should we wait for the audit from release team as fungi you suggested? | 21:23 |
fungi | elod: i would wait on doing the full set of all batches until we have a discussion with the rest of the release team, but adding the ones we know want branches deleted should be fine | 21:24 |
elod | fungi: ok | 21:25 |
fungi | the bigger question is whether all openstack/*.config files (minus the couple of exceptions we've moted) should inherit from meta-config, or just the ones which are release-managed | 21:25 |
fungi | but i'm inclined to push for all to keep it simple | 21:25 |
fungi | my point was more that they'll probably want to update whatever auditing scripts they've got to at least make sure the release-managed repos do have that inheritance, as it will become more critical for their release automation (we plan to remove it from the global all-projects acl once this work is done) | 21:26 |
clarkb | fungi: yes cleaning up all-projects is the main reason we should apply it to all the openstack repos I think | 21:28 |
clarkb | that way they don't loose and functionality | 21:28 |
openstackgerrit | Merged opendev/system-config master: Bump the infra-prod-manage-projects job timeout https://review.opendev.org/c/opendev/system-config/+/786728 | 21:39 |
openstackgerrit | Elod Illes proposed openstack/project-config master: Move projects under meta-config acl (2) https://review.opendev.org/c/openstack/project-config/+/786739 | 22:02 |
openstackgerrit | Elod Illes proposed openstack/project-config master: Move projects under meta-config acl (3) https://review.opendev.org/c/openstack/project-config/+/786740 | 22:04 |
elod | clarkb fungi : ^^^ these 3 patches covers the acls for the repositories where I've found ocata-eol tag | 22:07 |
elod | so now only 313 acl config left beyond these o:) (of course if we need all of them to inherit from meta-config... e.g. project-config.config, etc.) | 22:10 |
elod | anyway, sorry, I need to drop off now and call it a day | 22:12 |
elod | let me know if I need to change something | 22:12 |
elod | and thanks for the help so far! | 22:12 |
clarkb | enjoy your weekend | 22:13 |
elod | thanks :) same to you! | 22:13 |
openstackgerrit | Kostyantyn Kalynovskyi proposed openstack/project-config master: ACL, allow merge for airship-release group https://review.opendev.org/c/openstack/project-config/+/786741 | 22:32 |
openstackgerrit | Merged openstack/project-config master: ACL, allow merge for airship-release group https://review.opendev.org/c/openstack/project-config/+/786741 | 22:49 |
*** tosky has quit IRC | 23:38 | |
*** ysandeep|away is now known as ysandeep | 23:55 | |
*** mlavalle has quit IRC | 23:55 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!