*** rlandy is now known as rlandy|out | 00:07 | |
*** TheMaster is now known as Unit193 | 00:30 | |
*** ysandeep|sick is now known as ysandeep | 03:48 | |
*** ysandeep is now known as ysandeep|afk | 04:45 | |
*** ysandeep|afk is now known as ysandeep | 06:19 | |
*** jpena|off is now known as jpena | 06:51 | |
*** lbragstad8 is now known as lbragstad | 06:56 | |
amorin | hello | 07:30 |
---|---|---|
amorin | I did a patchset on mistral last day, but it's not checked by zuul: | 07:31 |
amorin | https://review.opendev.org/c/openstack/mistral/+/855674 | 07:31 |
amorin | I did a recheck this morning, the build appeared on zuul page but disappeared few sec after | 07:31 |
amorin | is there any issue with zuul at the moment? | 07:31 |
*** ysandeep is now known as ysandeep|lunch | 08:05 | |
mnasiadka | clarkb: seems it booted, thanks | 08:26 |
frickler | amorin: mistral needs to clean up their queue definitions https://zuul.opendev.org/t/openstack/config-errors | 08:32 |
frickler | similar to e.g. https://review.opendev.org/c/openstack/python-designateclient/+/842562 | 08:32 |
amorin | frickler: ack, should I do something? | 08:32 |
frickler | amorin: yes, you can propose a patch like ^^ | 08:33 |
amorin | perfect, will do | 08:33 |
frickler | seems a lot of projects have problems fixing this issue, maybe the TC should start to be more active in helping them | 08:33 |
frickler | we are still at 444 config errors for the openstack tenant | 08:34 |
amorin | https://review.opendev.org/c/openstack/mistral/+/859812 | 08:42 |
frickler | <ad> might be interesting for some people here, too: https://openinfra.dev/live/ Large Scale Ops Deep Dive: Schwarz Group, today 14 UTC </ad> | 09:37 |
*** ysandeep|lunch is now known as ysandeep | 09:44 | |
*** rlandy|out is now known as rlandy | 10:28 | |
*** dviroel|out is now known as dviroel | 11:17 | |
fungi | yep, thanks for the reminder! i always try to watch those | 11:29 |
*** ysandeep is now known as ysandeep|afk | 12:12 | |
fungi | played around with https://pypi.org/project/refurb/ a bit earlier today and it gives some pretty helpful suggestions. i was skeptical, but for the most part i agreed with most of its findings | 12:17 |
*** dviroel is now known as dviroel|doc_appt | 12:27 | |
*** dasm|off is now known as dasm | 12:48 | |
*** ysandeep|afk is now known as ysandeep | 12:49 | |
*** marios is now known as marios|call | 14:18 | |
*** ysandeep is now known as ysandeep|dinner | 14:28 | |
*** marios|call is now known as marios | 14:45 | |
*** dviroel|doc_appt is now known as dviroel|doc | 14:46 | |
*** dviroel|doc is now known as dviroel | 14:46 | |
opendevreview | Merged openstack/project-config master: charms: add new ceph subteam https://review.opendev.org/c/openstack/project-config/+/859219 | 15:03 |
*** marios is now known as marios|out | 15:37 | |
*** ysandeep|dinner is now known as ysandeep|out | 15:56 | |
*** jpena is now known as jpena|off | 16:05 | |
clarkb | fungi: some people were complaining that refurb suggest some far less readable code for file IO operations. Apparntly python has some pythonic apis for that that diverge from classic posix open/close/read/write and refurb will happily suggest you change from the classics | 16:10 |
clarkb | But its meant to give suggestions not provide a singular opinion that must be followed | 16:10 |
fungi | right, and in my case i'm going to add it to tox on one of my projects but set it to skip some of those rules | 16:37 |
fungi | a very old codebase i've been incrementally modernizing, and so has a lot of python 2.x and even ancient 1.x patterns (where those things continued working in py3k anyway) | 16:38 |
JayF | If you're not familiar with it, black is also a useful utility. Sorta like gofmt for python. | 16:45 |
fungi | yeah, i disagree with rather a lot of black's suggestions, but it's definitely gained a lot of popularity | 16:46 |
fungi | the codebase in question currently does lint with pycodestyle/pyflakes (via flake8+bugbear), bandit, and codespell | 16:47 |
fungi | and both its yaml inputs and outputs are checked with yamllint | 16:48 |
JayF | You can flip some of the opinionated stuff on/off. Honestly I'm not a person who cares about *what* style, so much as there is *consistent* style :D | 16:48 |
fungi | coercing pyyaml to write yaml which yamllint likes is no small feat, let me tell you | 16:49 |
clarkb | the thing I like about black is it is specifically built to make code review easier via cleaner diffs | 16:49 |
fungi | i end up shadowing some of pyyaml's writer methods to make indentation work | 16:49 |
clarkb | I can manage for weirdness if it makes code review easier | 16:49 |
JayF | The controversial/awkward thing about code formatting tools is how to run them. e.g.: automatically run in CI and commit back differences? Run in check mode in CI and make the dev do a round trip if they didn't run formatting? I even had someone suggest once to run a nightly job to make the main branch conform (NOPE) | 16:51 |
fungi | looking back over the code, i substitute my own yaml.emitter.Emitter.expect_block_sequence() method to get the block sequences indented in a yamllint-compatible way, and then override the yaml.SafeDumper class to call it | 16:52 |
fungi | apparently yamllint wants block sequences overindented | 16:52 |
fungi | and pyyaml's emitter lacks an option to do that | 16:53 |
opendevreview | Merged zuul/zuul-jobs master: Clarify that stage-output doesn't actually write to zuul_output_dir https://review.opendev.org/c/zuul/zuul-jobs/+/859333 | 17:05 |
*** chkumar|rover is now known as raukadah | 17:15 | |
clarkb | the mailman mailing list is quite active, but no response to my request for guidance on those issues yet | 17:18 |
opendevreview | Clark Boylan proposed opendev/system-config master: Update our Gerrit images https://review.opendev.org/c/opendev/system-config/+/859885 | 17:28 |
clarkb | infra-root ^ that change should run gerrit 3.5 + mina 2.8 + new jgit through our CI system. I don't think we should land that until after the openstack release out of an abundance of caution, but if somethign is horribly broken I want to be able to get that feedback upstream asap hence this change | 17:29 |
*** dviroel is now known as dviroel|afk | 19:42 | |
clarkb | our CI testing seems happy enough with updated gerrit 3.5. Thats good | 20:51 |
*** dviroel|afk is now known as dviroel | 20:52 | |
clarkb | arg I can't push to gerrit right now apparently I no longer have a valid CLA | 20:58 |
clarkb | but also it seems to think my account is deleted in some contexts. I really wish I understood what was going on here | 20:58 |
*** tosky_ is now known as tosky | 21:24 | |
*** dasm is now known as dasm|off | 21:24 | |
clarkb | Gerrit is asking for community help to test Gerrit 3.7 RCs: https://www.gerritcodereview.com/2022-09-29-gerrit-3.7-release-plan.html#gerrit-hackathon we can probably add 3.7 to our job list and run it through the testing we do | 21:56 |
*** rlandy is now known as rlandy|out | 22:10 | |
*** ysandeep|out is now known as ysandeep | 23:58 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!