| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: [wip] zuul-jobs-test-registry-buildset-registry-k8s-microk8s https://review.opendev.org/c/zuul/zuul-jobs/+/867063 | 00:17 |
|---|---|---|
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: [wip] zuul-jobs-test-registry-buildset-registry-k8s-microk8s https://review.opendev.org/c/zuul/zuul-jobs/+/867063 | 02:57 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: [wip] zuul-jobs-test-registry-buildset-registry-k8s-microk8s https://review.opendev.org/c/zuul/zuul-jobs/+/867063 | 03:20 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: [wip] zuul-jobs-test-registry-buildset-registry-k8s-microk8s https://review.opendev.org/c/zuul/zuul-jobs/+/867063 | 03:35 |
| *** yadnesh|away is now known as yadnesh | 04:34 | |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: [wip] zuul-jobs-test-registry-buildset-registry-k8s-microk8s https://review.opendev.org/c/zuul/zuul-jobs/+/867063 | 07:00 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: [wip] zuul-jobs-test-registry-buildset-registry-k8s-microk8s https://review.opendev.org/c/zuul/zuul-jobs/+/867063 | 08:15 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: [wip] zuul-jobs-test-registry-buildset-registry-k8s-microk8s https://review.opendev.org/c/zuul/zuul-jobs/+/867063 | 08:36 |
| *** jpena|off is now known as jpena | 08:43 | |
| opendevreview | Tim Beermann proposed zuul/zuul-jobs master: Add yamllint job. https://review.opendev.org/c/zuul/zuul-jobs/+/866679 | 10:24 |
| *** rlandy|out is now known as rlandy | 11:16 | |
| *** dviroel_ is now known as dviroel|rover | 11:20 | |
| *** anbanerj is now known as frenzy_friday | 11:35 | |
| *** pojadhav is now known as pojadhav|afk | 11:39 | |
| *** rlandy is now known as rlandy|brb | 13:17 | |
| *** rlandy|brb is now known as rlandy | 13:27 | |
| *** pojadhav|afk is now known as pojadhav | 13:40 | |
| jm1 | fungi: hello :) last year you wrote this patch: https://review.opendev.org/c/opendev/system-config/+/818787 today i tried to use this patch but the galaxy directory is missing on mirrors, e.g. https://mirror.bhs1.ovh.opendev.org | 13:43 |
| jm1 | fungi: has this galaxy mirroring been abandoned? | 13:44 |
| jm1 | fungi: or is it simply still-work-in-progress? | 13:44 |
| jm1 | fungi: this is what i tried to use opendev's mirror for ansible galaxy: https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867202/1 | 13:45 |
| jm1 | Tengu: ^ | 13:45 |
| Tengu | jm1: you're missing the port (as answered in #tripleo) | 13:47 |
| Tengu | jm1: I pushed a patch in order to correct the way galaxy was served - and it requires a dedicated vhost due to some sad redirect. | 13:48 |
| Tengu | jm1: namely: https://review.opendev.org/c/opendev/system-config/+/866175 | 13:48 |
| fungi | jm1: right, turns out that wasn't actually proxying/caching anything other than a redirect, but Tengu has replaced it with a fully functional caching proxy solution (required an alternate port number due to design choices of the galaxy site implementation) | 13:51 |
| fungi | for the benefit of anyone reading this channel's log, it's port 8085 for plain http or 4448 for https connections to the proxy | 13:52 |
| jm1 | Tengu, fungi: Oh ok, thank you very much! | 13:52 |
| jm1 | Tengu, fungi: so instead of https://galaxy.ansible.com/download/community-general-4.0.2.tar.gz one should be able to use e.g. https://mirror.bhs1.ovh.opendev.org:4448/download/community-general-4.0.2.tar.gz ? | 13:52 |
| Tengu | yep, something like that | 13:53 |
| Tengu | jm1: there's an example patch already up here: https://review.opendev.org/c/openstack/tripleo-ansible/+/866031 but I need to take some time to debug it (couldn't for now, had some other issues on some other topics) | 13:54 |
| jm1 | Tengu: does downloading the file from opendev's mirror above work for you? | 13:56 |
| fungi | that exact url does not work for me, no | 13:56 |
| Tengu | jm1: you mean on my local laptop? | 13:56 |
| fungi | looks like that doesn't work because the proxy expects to replace that url in responses | 13:58 |
| fungi | no, don't mind me i'm misreading the patch | 13:59 |
| *** Guest1665 is now known as dasm | 14:00 | |
| fungi | looks like that's ultimately redirected to https://mirror.bhs1.ovh.opendev.org:4448/galaxy-s3/artifact/bc/fe717cf4cb44357ed4ffcd47b4ef028c16f7b3e439d6bb15a87bc8e86b37f5?response-content-disposition=attachment%3B%20filename%3Dcommunity-general-4.0.2.tar.gz&AWSAccessKeyId=AKIAJZZ23S6M5JUH2EOA&Signature=5cDrxyth5VLIm1%2Bk3Wgk%2BjRWZ98%3D&Expires=1670857219 | 14:01 |
| jm1 | Tengu, fungi: i was expecting to be able to download from that mirror on my local system but it redirects me to ansible galaxy Page not found error instead. | 14:01 |
| *** dasm is now known as Guest1892 | 14:01 | |
| *** Guest1892 is now known as dasm | 14:01 | |
| jm1 | Tengu, fungi: both jobs that fail with RETRY_LIMIT on https://review.opendev.org/c/openstack/tripleo-ansible/+/866031 also fail when downloading from galaxy | 14:01 |
| fungi | whereas using the actual galaxy site ends up at https://ansible-galaxy.s3.amazonaws.com/artifact/bc/fe717cf4cb44357ed4ffcd47b4ef028c16f7b3e439d6bb15a87bc8e86b37f5?response-content-disposition=attachment%3B%20filename%3Dcommunity-general-4.0.2.tar.gz&AWSAccessKeyId=AKIAJZZ23S6M5JUH2EOA&Signature=QcADy3yCRCoV9k0S8crDwV0MqEY%3D&Expires=1670857278 | 14:02 |
| Tengu | (sorry, on a call) | 14:02 |
| fungi | looking at the apache config, it does appear that https://mirror.bhs1.ovh.opendev.org:4448/galaxy-s3/ gets forwarded to https://ansible-galaxy.s3.amazonaws.com/ and the rest of the url seems to match (aside from differing signatures coming from the redirect, it seems) | 14:08 |
| fungi | strangely, when i try to directly download the url the galaxy site redirects to, that also breaks | 14:12 |
| fungi | ahh, no i had to grab a fresh url, seems the expiration on those is very short and you get a new one each time | 14:15 |
| fungi | however, substituting the first part of the url with one of our mirrors still gives me an html response full of javascript links instead | 14:16 |
| fungi | with the same "page not found" if i try loading it in my browser | 14:17 |
| Tengu | hmmm... do they check some headers now... | 14:20 |
| opendevreview | Tim Beermann proposed zuul/zuul-jobs master: Add yamllint job. https://review.opendev.org/c/zuul/zuul-jobs/+/866679 | 14:25 |
| jm1 | Tengu, fungi: do we need a dedicated vhost for galaxy s3 as well? 🤨 | 14:26 |
| Tengu | maybe we can refrain re-writing the URI to galaxy-s3. still on a call. | 14:27 |
| jm1 | Tengu: take your time, its not urgent. great that you are actually pushing that galaxy mirror forward. Thank you :) | 14:27 |
| Tengu | I may work on that part during my off-time the 2 next weeks. depends on the load. | 14:28 |
| jm1 | Tengu: cool 😎 | 14:30 |
| jm1 | fungi: thank you too for testing that out. i wasnt sure if it was my local system only and whether we can actually use opendev's mirror outside of ci. | 14:31 |
| opendevreview | Tim Beermann proposed zuul/zuul-jobs master: Add yamllint job. https://review.opendev.org/c/zuul/zuul-jobs/+/866679 | 14:37 |
| opendevreview | Tim Beermann proposed zuul/zuul-jobs master: Add yamllint job. https://review.opendev.org/c/zuul/zuul-jobs/+/866679 | 14:48 |
| *** yadnesh is now known as yadnesh|away | 14:52 | |
| *** dviroel|rover is now known as dviroel|rover|lunch | 15:22 | |
| *** marios is now known as marios|out | 15:59 | |
| opendevreview | Clark Boylan proposed opendev/system-config master: Use docker-compose exec -T with ansible tasks https://review.opendev.org/c/opendev/system-config/+/867258 | 16:04 |
| clarkb | automated zuul updates broke on ^ | 16:05 |
| clarkb | I figure we can land that and run it manually at some point | 16:05 |
| clarkb | also jitsi meet just did a release we'll update to in about 12 hours | 16:05 |
| fungi | clarkb: all of the service-* mailing lists have pending moderator requests if you wanted to try out the interface. they're all spam of course | 16:07 |
| fungi | clarkb: was it the ansible upgrade with the new bridge which caused the regression 867258 is fixing? | 16:08 |
| fungi | i guess that's implied by the commit message | 16:08 |
| fungi | mainly just wondering if it broke longer ago than last week | 16:09 |
| fungi | and how far behind we are with zuul upgrades | 16:09 |
| fungi | (if you happen to know) | 16:10 |
| *** dviroel|rover|lunch is now known as dviroel|rover | 16:10 | |
| *** hjensas is now known as hjensas|out | 16:11 | |
| clarkb | fungi: the -T thing was caught in CI for db backups iirc and yes due to the recent bridge ansible update | 16:11 |
| clarkb | we didn'tcatch it for the reboot playbook because we don't run that in CI | 16:11 |
| clarkb | we are 9 days behind so just one cycle | 16:12 |
| fungi | ahh, cool | 16:12 |
| clarkb | I'm looking at service-discuss held messages now | 16:12 |
| clarkb | fungi: in this case I probably want "discard" and not "reject" to avoid sending an email back to them? | 16:13 |
| fungi | yes | 16:13 |
| clarkb | heh they send them with dates in the future to get better sorting? | 16:15 |
| clarkb | messages have been discarded for all three lists I currently have moderator rights on | 16:15 |
| fungi | yeah | 16:15 |
| clarkb | I've reminded the opesntack release team about the pending Gerrit upgrade | 16:16 |
| fungi | the thing to watch out for (somewhat prevalent on the openstack-discuss ml) is that they'll spoof a message from a list member address and sometimes even quote parts of subjects from message archives. sneaky, sneaky spammers | 16:16 |
| fungi | but after a while i've gotten to where i can spot them. those in particular tend to end up held because of large attachments | 16:17 |
| clarkb | spam is an efficient model trainer :{ | 16:17 |
| clarkb | er :P | 16:17 |
| opendevreview | Clark Boylan proposed openstack/project-config master: Scale iweb back to 25% of possible quota https://review.opendev.org/c/openstack/project-config/+/867261 | 16:44 |
| opendevreview | Clark Boylan proposed openstack/project-config master: Set iweb max-servers to 0 https://review.opendev.org/c/openstack/project-config/+/867262 | 16:44 |
| opendevreview | Clark Boylan proposed openstack/project-config master: Set iweb to empty labels and diskimages https://review.opendev.org/c/openstack/project-config/+/867263 | 16:44 |
| opendevreview | Clark Boylan proposed openstack/project-config master: Remove iweb nodepool configs https://review.opendev.org/c/openstack/project-config/+/867264 | 16:44 |
| clarkb | thats a series of changes to spin down iweb. I wanted to get those up and reviewed if not necessarily landed immediately just so that we can land them as things are quieter later this month | 16:44 |
| fungi | thanks! | 16:59 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Cleanup iweb/inap provider content https://review.opendev.org/c/opendev/system-config/+/867267 | 17:09 |
| clarkb | and that is the system-config side of cleanup | 17:09 |
| clarkb | I'm realizing we can't easily test project-config with tox v4 because it doesn't do speculative testing? | 17:25 |
| fungi | though most of its tox testenvs should be pretty straightforward to exercise locally | 17:27 |
| opendevreview | Clark Boylan proposed openstack/project-config master: Update tox.ini for tox v4 https://review.opendev.org/c/openstack/project-config/+/867268 | 17:28 |
| *** NeilHanlon_ is now known as NeilHanlon | 17:28 | |
| opendevreview | Clark Boylan proposed opendev/system-config master: Update tox.ini for tox v4 https://review.opendev.org/c/opendev/system-config/+/867269 | 17:31 |
| clarkb | we should do similar for bindep and git-review and so on but I expect project-config and system-config to be the most annoying if they break | 17:31 |
| *** jpena is now known as jpena|off | 17:32 | |
| fungi | agreed | 17:33 |
| clarkb | wow updating tox.ini or is it the project entry in zuul for system-config runs all the jobs. That might need pruning | 17:34 |
| fungi | good way to identify unstable jobs though ;) | 17:37 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Update tox.ini for tox v4 https://review.opendev.org/c/opendev/system-config/+/867269 | 18:17 |
| clarkb | reskimming the gerrit 3.6 release notes the project owner implies delete perm has been removed. I didn't notice that before but I'm happy with that change | 18:22 |
| clarkb | We should be on the look out for any unexpected fallout from that | 18:22 |
| clarkb | should be easy enough to modify acls if necessary | 18:22 |
| fungi | i don't expect to need to, we use explicit delete perm where we expect it | 18:26 |
| opendevreview | Clark Boylan proposed openstack/project-config master: Update tox.ini for tox v4 https://review.opendev.org/c/openstack/project-config/+/867268 | 18:29 |
| clarkb | 3.7 on the other hand... preparing for that upgrade will be fun | 18:29 |
| fungi | what's going to impact us with 3.7? | 18:38 |
| fungi | that we already know about, i mean | 18:38 |
| clarkb | fungi: we have to convert all of our voting rules to submit requirements | 18:38 |
| fungi | ohhhh | 18:38 |
| fungi | good thing we've normalized our acls long ago | 18:39 |
| clarkb | 3.6 adds support for submit requirements and claims to preserve the old behavior too so it will be the transitional release while we make those changes | 18:39 |
| fungi | should be a pretty straightforward transformation at least | 18:39 |
| clarkb | the priority labels might be hte most annoying as they aren't super consistent. But ya the others shouldn't be too bad | 18:39 |
| fungi | well, our enforced ordering for sections and options and lists within options should make the converted versions easy to compare | 18:44 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Update Gerrit to version 3.6 https://review.opendev.org/c/opendev/system-config/+/867277 | 18:49 |
| clarkb | There was a TODO to write that change on the ehterpad so I went ahead and did it | 18:49 |
| clarkb | https://etherpad.opendev.org/p/gerrit-upgrade-3.6 is the etherpad | 18:51 |
| ianw | o/ | 18:51 |
| ianw | thanks, yeah was about to send that one, forgot to do it yesterday | 18:52 |
| ianw | i had a look at the submit requirements, i think we can add +2 and a +2 verified, but really it seem informational in our situation with zuul submitting things? | 18:54 |
| ianw | it mostly seems to affect if the "submit" button will be not greyed out | 18:54 |
| clarkb | ianw: in 3.7 they drop compatibility with our configs that define the voting labels | 18:54 |
| clarkb | ianw: you have to redefine them using the new submit requirements. And ya in 3.6 it is supposed to support both so we should be fine for now | 18:55 |
| clarkb | upgrading to 3.6 so that we have compatibility with both is the first step in upgrading to 3.7. Then we can sort out configs under 3.6 to prep for 3.7 | 18:55 |
| ianw | ++ | 18:55 |
| ianw | i'm thinking we can mostly do in CI; we already update and push the config, but we don't set it up like we have in production | 18:56 |
| ianw | in terms of rules/groups etc. | 18:56 |
| clarkb | ya and we should be able to just bulk update project-config for all the one off project specific things | 18:57 |
| ianw | #status notice Gerrit will be unavailable for a short time as it is upgraded to the 3.6 release | 18:58 |
| clarkb | ianw: in an hour though right? | 18:58 |
| clarkb | I don't think the status bot is currently here | 18:58 |
| ianw | oh whoops! i've got my tz out, haha | 18:58 |
| ianw | nothing particularly interesting in the statusbot logs | 19:04 |
| ianw | i've restarted it | 19:06 |
| clarkb | and it has rejoined | 19:10 |
| fungi | i'll be in a meeting but around in case things go entirely sideways | 19:37 |
| clarkb | the system-config tox.ini update chagne actually passes after I fixed the allowlist | 19:47 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: ensure-kubernetes: add microk8s support https://review.opendev.org/c/zuul/zuul-jobs/+/866953 | 19:47 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: [wip] zuul-jobs-test-registry-buildset-registry-k8s-microk8s https://review.opendev.org/c/zuul/zuul-jobs/+/867063 | 19:47 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: use-buildset-registry: add URL to buildset_registry_namespaces https://review.opendev.org/c/zuul/zuul-jobs/+/867280 | 19:47 |
| clarkb | that is a good indicator that we don't have too much broken for toxv4 | 19:48 |
| opendevreview | Merged opendev/system-config master: Use docker-compose exec -T with ansible tasks https://review.opendev.org/c/opendev/system-config/+/867258 | 19:48 |
| opendevreview | Clark Boylan proposed openstack/project-config master: Update post-review zuul pipeline definiton https://review.opendev.org/c/openstack/project-config/+/867282 | 19:55 |
| ianw | #status notice Gerrit will be unavailable for a short time as it is upgraded to the 3.6 release | 19:57 |
| opendevstatus | ianw: sending notice | 19:57 |
| -opendevstatus- NOTICE: Gerrit will be unavailable for a short time as it is upgraded to the 3.6 release | 19:57 | |
| ianw | my clock is based on "when is the weekly meeting" which works fine generally, unless you think something is happening at that time and it isn't :) | 19:59 |
| clarkb | ha | 19:59 |
| ianw | it's in emergency, and a screen is up and logging | 19:59 |
| fungi | screen on review? | 19:59 |
| ianw | yep | 20:00 |
| opendevstatus | ianw: finished sending notice | 20:00 |
| fungi | thanks, attached | 20:00 |
| ianw | ok, will shutdown and backup | 20:00 |
| clarkb | I'm attached now as well | 20:00 |
| clarkb | did that do help text instead of actually downing the container? | 20:01 |
| fungi | as noted earlier, i'm only half watching so please ping me if i'm needed | 20:01 |
| clarkb | fungi: noted | 20:01 |
| ianw | yeah, added a note, i guess we need to down and then up just mariadb | 20:03 |
| ianw | backup done, looks good | 20:03 |
| clarkb | we should all get in the habit of only running docker-compose from the file dir since it ignores env files (I think onyl jitsi meet uses them currently?) when they are not present in he current dir | 20:06 |
| fungi | there is a command-line switch to point to the specific env files if you prefer to do it that way | 20:08 |
| fungi | i've used after realizing they were needed | 20:08 |
| clarkb | ianw: those two shas seem to match | 20:08 |
| clarkb | web ui loads for me | 20:11 |
| ianw | ok, i see us up @ 3.6.3-26-g80d6be44e2-dirty | 20:11 |
| ianw | i'm watching logs in separate window | 20:11 |
| fungi | woo! | 20:11 |
| ianw | we have another tight loop ssh failure from someone, but not seeing anything else | 20:12 |
| clarkb | we've got another one of those unhappy ssh clients but otherwise I haven't seen anything crazy go by (I didn't catch the startup process if there were any errors there, might be worth pulling those up explicitly if you haven't et ianw) | 20:12 |
| noonedeadpunk | wow | 20:13 |
| ianw | yeah i watch from start, nothing i could see | 20:13 |
| noonedeadpunk | my eyes started hurting badly :D | 20:13 |
| jm1 | gerrit looks so different but i like it XD | 20:13 |
| ianw | we've already got a few changes coming through | 20:14 |
| noonedeadpunk | Out of issues I don't see custom labels | 20:14 |
| noonedeadpunk | We had backport candidate in OSA at least - it's gone now | 20:14 |
| clarkb | noonedeadpunk: I'm not sure I parse that. Can you be more specific | 20:14 |
| ianw | https://review.opendev.org/c/openstack/manila-tempest-plugin/+/867119 went in, and has started zuul jobs | 20:15 |
| noonedeadpunk | clarkb: https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/openstack/openstack-ansible.config#L17-L19 | 20:16 |
| noonedeadpunk | Or well, better L6 | 20:16 |
| noonedeadpunk | And there's no such label anymore | 20:16 |
| noonedeadpunk | Ie https://review.opendev.org/c/openstack/openstack-ansible/+/867256 | 20:17 |
| clarkb | noonedeadpunk: do you see them when you click repoy? | 20:17 |
| clarkb | *reply | 20:17 |
| noonedeadpunk | Oh, well, I do.... | 20:17 |
| clarkb | I see them for review priority on devstack. Let me do a test vote and see how the UI renders it | 20:17 |
| noonedeadpunk | Ah. And it appears then | 20:17 |
| clarkb | Its possible that the online reindex is necessary to show these? or maybe they are not shown if not set | 20:17 |
| clarkb | ya ok | 20:17 |
| clarkb | its probably the case that they need to be set to be visible and that the online reindex that should be running (takes about 20 minutes iirc) may help? | 20:18 |
| noonedeadpunk | Actually I was quite sure they were not shown in reply as I checked that before I wrote... | 20:18 |
| noonedeadpunk | So yes, might be it's re-index that's happening now | 20:18 |
| clarkb | noonedeadpunk: but they are there now? and if you set the value you see it on the top level change page? | 20:18 |
| noonedeadpunk | On top level page don't see them yet | 20:19 |
| clarkb | well it looks like you unset it | 20:19 |
| noonedeadpunk | Or well | 20:19 |
| clarkb | if it is set is it visible? | 20:19 |
| noonedeadpunk | I don't see them on https://review.opendev.org/q/project:openstack%252Fopenstack-ansible | 20:19 |
| noonedeadpunk | (so depending on what mean undr op level | 20:19 |
| clarkb | ok you reapplied and if set then it is visible on the top level of the change | 20:19 |
| clarkb | I mean on the change page | 20:19 |
| noonedeadpunk | *under top level | 20:19 |
| noonedeadpunk | yep, on the change page it's visable | 20:20 |
| clarkb | I think the listing does rely on the index heavily so would't be surprised if that depends on the reindex | 20:20 |
| clarkb | Its also possible that Gerrit is using some criteria to determine which should be shown on the listing page by default | 20:20 |
| clarkb | Anyway this doesn't sound fatal. As we understand it better we can provide feedback upstream to make things less weird too | 20:21 |
| ianw | 1445 things left in the queue ... so yeah, let's let that drain ... | 20:21 |
| clarkb | I was just looking up how to examine that | 20:22 |
| clarkb | `gerrit show-queue` | 20:22 |
| noonedeadpunk | Also question - is there any way to display who's voted like in old good gerrit? | 20:22 |
| noonedeadpunk | Asking just in case it can be configured.... | 20:23 |
| clarkb | yes hover on the vote | 20:23 |
| clarkb | I don't know if it is configurable | 20:23 |
| noonedeadpunk | Well, hovering over vote for each change you open is quite.... time consuming? | 20:23 |
| noonedeadpunk | Ah | 20:23 |
| noonedeadpunk | I see workaround | 20:23 |
| noonedeadpunk | it's shown for the list of reviewers | 20:24 |
| clarkb | I'm not trying to judge the method just explaining how it can be done. After the gerrit 3.2 upgrade we were very explicit that the way the team is currently staffed we cannot maintain a Gerrit fork any longer and we need our users to engage upstream (through us is fine too) for problems | 20:24 |
| ianw | ok, from the upgrade POV, verified everything but replication. am just waiting for indexing to finish now before moving on | 20:25 |
| noonedeadpunk | nah, that's totally fair | 20:25 |
| clarkb | The best thing is if people can file issues upstream. I'm also happy to file those too if sufficient info is shared to me. But part of why we got stuck on ancient gerrit for so long is we ended up with all these little gadgets and widgets and customizations and we realized doing all that just wasn't going to scale if we wanted to be up to date. | 20:25 |
| clarkb | The good news is we've managed to engage upstream as a result and have a number of bug fixes pushed upstream through this process. The downside is we often live with issues for longer rather than holding up the entire upgrade process | 20:26 |
| clarkb | ianw: the very end of the replication log looks clean | 20:27 |
| noonedeadpunk | It's just small things that likely can be adjusted with config or smth, and I jsut lack knowledge a bit and asking as you're way more experienced and might already know how to fix that | 20:27 |
| clarkb | noonedeadpunk: there is very little about the UI that is configurable unfortunately | 20:27 |
| fungi | we also have a ci system which can deploy proposed config changes and obtain screenshots (and we can hold nodes from it for more interactive testing too) | 20:27 |
| clarkb | you can choose a theme and diff width and how diffs are rendered, But the actual change screen and serch screens are largely unconfigurable | 20:27 |
| fungi | except through plugins | 20:28 |
| noonedeadpunk | I wonder why gerrit now decided to flip +W and +V places... Because I thought it's alphabetical order... | 20:28 |
| clarkb | right if you write java or js and install that into gerrit you can make big changes | 20:28 |
| fungi | which can add things but not really remove/replace significant parts of the us | 20:28 |
| fungi | ui | 20:28 |
| ianw | (until the migration to the next javascript framework, anyway ;) | 20:29 |
| clarkb | ianw: I didn't see the config diffing was that clean (it should be due to our testing right?) | 20:29 |
| ianw | yep, that was empty | 20:29 |
| ianw | agree replication log looks clean, it has done some replication | 20:30 |
| clarkb | I think the new behavior on the change screen is to show you all labels that are required to be set to merge. For us that is Code-Review, Verified, Workflow. Additional lagels are only shown if they are set to a non 0 value | 20:30 |
| clarkb | It wouldn't surprise me if on the change listing screens they are also only showing you labels that must be set to merge. In order to simplify those listings | 20:31 |
| clarkb | https://review.opendev.org/c/openstack/devstack/+/865544 heres a change that had review priority set prior to the upgrade | 20:31 |
| noonedeadpunk | at least these labels still work on custom dashboards, so I guess that's fine | 20:32 |
| clarkb | the value shows up on the chagne screen properly but not in the listing page. I suspect we won't get these out of the listing pages | 20:32 |
| clarkb | noonedeadpunk: can you link to one of those just for me own collection of examples? It helps if we ever have to talk upstream about this | 20:32 |
| clarkb | those == custom dashboard | 20:32 |
| ianw | ok, indexing should be done | 20:34 |
| clarkb | I think CI results for https://review.opendev.org/c/openstack/project-config/+/867282 were not reported because gerrit was down. I've rechecked it and it has reenqueued | 20:35 |
| clarkb | (3.7 also broke/breaks rechecks and we need to followup oin the fix for that as part of the pre 3.7 upgrade prep) | 20:35 |
| ianw | i've approved https://review.opendev.org/c/opendev/system-config/+/867277 and will take out of emergency as that merges | 20:36 |
| ianw | we can fiddle the ui config to remove the "status" column, if we want. | 20:37 |
| clarkb | I don't think https://zuul.opendev.org/t/openstack/build/c478cbe8bb1d4a1eb8f356addd5650ac is related to the upgrade because i Think that is checking our projects.yaml? But calling it out incase that is cheking against gerrit | 20:38 |
| clarkb | fungi: ^ fyi | 20:38 |
| clarkb | ianw: I like it for the merge conflict info | 20:38 |
| ianw | yeah, i think we stick with it; just i did test turning it off on the held server :) | 20:39 |
| ianw | i'm going to afk for a brief toast break | 20:40 |
| clarkb | I shared that link with the openstack release team just in case | 20:40 |
| ianw | currently just waiting on gerrit config change to move through | 20:40 |
| clarkb | on further inspection of that openstack releases validation failure it seems to inspect project specific yaml and not the gerrit api. I think we're ok | 20:43 |
| fungi | sounds good. thanks for the upgrade! | 20:44 |
| fungi | i'll be around for a while still this evening in case there are any problems we haven't spotted yet | 20:44 |
| clarkb | https://review.opendev.org/c/openstack/project-config/+/867268 is a quick approval if we want to land that | 20:45 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: [wip] zuul-jobs-test-registry-buildset-registry-k8s-microk8s https://review.opendev.org/c/zuul/zuul-jobs/+/867063 | 20:57 |
| ianw | in our case, with the submit requirements, it seems more like we're "has a +2 and a +1 verified". that would seem to more correctly show the status column as the requirements being met. the +w is obviously required, but that's more an indication to zuul than a submit requirement, if that makes sense | 21:05 |
| opendevreview | Merged openstack/project-config master: Update tox.ini for tox v4 https://review.opendev.org/c/openstack/project-config/+/867268 | 21:06 |
| ianw | i'm going to take review out of emergency as the next thing to merge will be the config updates | 21:23 |
| clarkb | ok | 21:23 |
| clarkb | we don't auto restart anyway so thats really safe | 21:23 |
| fungi | sgtm | 21:24 |
| noonedeadpunk | clarkb: we use that http://bit.ly/osa-review-board-v4_1 But under "works" I meant - get filtered by that. | 21:25 |
| clarkb | noonedeadpunk: got it, the summary view still doesn't show the values but you can have queries that list them explicitly | 21:25 |
| noonedeadpunk | But labels still are not shown even though they've got filterred by it: https://review.opendev.org/q/parentproject:openstack/openstack-ansible++status:merged+label:Backport-Candidate%253E%253D1+NOT+is:cherrypick+ | 21:26 |
| clarkb | ya that might be a good piece of feedback. Basically if we are filtering by it then maybe show it? | 21:26 |
| noonedeadpunk | For me that does make sense. But in terms of implementing that I see how it might be a bit tricky | 21:27 |
| *** dviroel|rover is now known as dviroel|rover|out | 21:28 | |
| noonedeadpunk | But yeah, if query would be any value of label:Backport-Candidate (not only positive like we have), that it's really bad to understand what the result you get | 21:28 |
| noonedeadpunk | without renderring label values in a separate field | 21:29 |
| JayF | there is an [S] in emails from gerrit since the upgrade | 21:31 |
| JayF | e.g. Subject: [S] Change in ..... | 21:31 |
| Clark[m] | There are templates that control that and they are configurable but I'm pretty sure we don't override them. That must be a new piece of info they are trying to share via the template | 21:33 |
| *** dasm is now known as dasm|off | 21:34 | |
| JayF | ack; as long as it was expected | 21:35 |
| Clark[m] | https://gerrit.googlesource.com/gerrit/+/refs/tags/v3.6.3/resources/com/google/gerrit/server/mail/ChangeSubject.soy#34 seems to indicate the change size | 21:38 |
| opendevreview | Merged opendev/system-config master: Update Gerrit to version 3.6 https://review.opendev.org/c/opendev/system-config/+/867277 | 21:39 |
| Clark[m] | https://gerrit.googlesource.com/gerrit/+/refs/tags/v3.5.4/resources/com/google/gerrit/server/mail/ChangeSubject.soy#32 is what we were running so ya that's new | 21:41 |
| fungi | "s" for "small" i guess | 21:41 |
| clarkb | ya I expect those align with the size values you see in web ui listings | 21:46 |
| clarkb | ianw: I don't see any deployed jobs queued/running at this point implying that the jobs for 867277 ran (but I haven't double checked taht). The docker compose file on review02 still seems to show 3.6 so I think that applied as expected if the jobs ran | 22:01 |
| clarkb | I need to pop out for a school run but will be back after | 22:01 |
| ianw | yep both review update and manage projects ran | 22:10 |
| ianw | updated links in etherpad | 22:10 |
| ianw | that's it for the checklist | 22:11 |
| fungi | awesome, thanks again for getting it out of the way! | 22:19 |
| ianw | everything is much less scary thanks to ci! | 22:28 |
| opendevreview | Clark Boylan proposed openstack/project-config master: Flip jeepyb over to building Gerrit 3.6 https://review.opendev.org/c/openstack/project-config/+/867314 | 22:58 |
| clarkb | thats a bit that I remembered | 22:58 |
| clarkb | infra-root on https://review.opendev.org/c/opendev/system-config/+/867269 now that it seems towork with tox v4 should I drop the ensure_tox_version arg from the change and let the zuul-jobs update switch us later? I feel like that might be best to avoid carrying this config around? | 23:00 |
| clarkb | I've made some edits to the meeting agenda. I'll leave that open for another half hour or so before sending it out | 23:10 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: ensure-kubernetes: add microk8s support https://review.opendev.org/c/zuul/zuul-jobs/+/866953 | 23:57 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: [wip] zuul-jobs-test-registry-buildset-registry-k8s-microk8s https://review.opendev.org/c/zuul/zuul-jobs/+/867063 | 23:57 |
| ianw | clarkb: i think probably yes take the pin out and just use the default from zuul-jobs is best | 23:58 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!